[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499093#comment-14499093
]
Ewen Cheslack-Postava commented on KAFKA-2120:
--
[~sureshms] They're related,
[
https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499210#comment-14499210
]
Suresh Srinivas commented on KAFKA-2120:
[~ewencp], thanks for the explanation.
On Thu, Apr 16, 2015 at 6:13 PM, Jun Rao j...@confluent.io wrote:
Hi, Gwen,
What you suggested seems reasonable. I guess we will need the Principal,
Privilege pair and the Resource in grant() and revoke()?
I thought that Privilege is a Resource+Action, which is why grant and
revoke can take
On April 16, 2015, 5:34 a.m., Ewen Cheslack-Postava wrote:
clients/src/main/java/org/apache/kafka/clients/MetadataBookkeeper.java,
line 25
https://reviews.apache.org/r/32937/diff/3/?file=931249#file931249line25
This patch will definitely need a comment somewhere explaining the
KAFKA-2088 is ready for review, any one can help me review it? thanks.
JIRA : https://issues.apache.org/jira/browse/KAFKA-2088
review request : https://reviews.apache.org/r/33132/diff/
ransom
I've probably been a DBA for too long, but I imagined something like:
kafka-topic --topic t1 --grant user --action action
kafka-topic --topic t1 --revoke user --action action
(i.e. the commandline equivalent of grant select on table1 to
gwenshap and revoke select on table2 from gwenshap)
When you
[
https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500286#comment-14500286
]
Gwen Shapira commented on KAFKA-2088:
-
Awesome, thanks for checking :)
We could do this but I think its too simplistic plus now we are adding
authorization related options in CLI which I thought everyone wants to
avoid.
When I say its too simplistic I mean there are missing options like
—hosts, what happens when we start supporting group now we will probably
end up
* Yes, Acl pretty much captures everything. Originally I had resource as
part of Acls, we can go back to that.
* The describe can call getAcl and I plan to do so. addAcl is tricky
because the user will have to specify the acls through command lines,
which will probably be a location to some file.
[
https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500330#comment-14500330
]
Jun Rao commented on KAFKA-2088:
[~ransom], thanks for the patch. It may be reasonable to
[
https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500289#comment-14500289
]
Gwen Shapira commented on KAFKA-2088:
-
Pinging [~junrao] [~jjkoshy] [~nehanarkhede]
On Fri, Apr 17, 2015 at 9:31 AM, Parth Brahmbhatt
pbrahmbh...@hortonworks.com wrote:
I was following the storm model but I think this is a reasonable change. I
recommend changing the API names to addAcls, removeAcls and getAcls.
And they probably just need to get ListAcl instead of everything
[
https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500437#comment-14500437
]
Ashish K Singh edited comment on KAFKA-1994 at 4/17/15 6:56 PM:
[
https://issues.apache.org/jira/browse/KAFKA-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500437#comment-14500437
]
Ashish K Singh commented on KAFKA-1994:
---
[~junrao], [~gwenshap], does this look on
[
https://issues.apache.org/jira/browse/KAFKA-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500473#comment-14500473
]
Gwen Shapira commented on KAFKA-2088:
-
I think the main problem here is that someone
Hi, Parth,
How does this work in Hive? I thought authorization in Hive always goes
through it's SQL cli for any authorization plugin. When integrating with
Ranger(Argus), does Hive do authorization through a separate CLI?
Thanks,
Jun
On Fri, Apr 17, 2015 at 11:01 AM, Parth Brahmbhatt
I have copied Thejas from hive team in cc list. Here is what I learnt from
him
* Hive calls the authorizer plugin if you execute “grant/revoke Operation
to User on Table. They use this as hive provides the SQL layer and SQL
has standards for grant/revoke which they follow.
* If the plugin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31590/#review80526
---
Thanks for the patch. A few comments below.
Also, yes,
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500750#comment-14500750
]
Ashish K Singh commented on KAFKA-1982:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1982:
--
Status: Patch Available (was: In Progress)
change kafka.examples.Producer to use the new java
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1982:
--
Attachment: KAFKA-1982_2015-04-17_14:49:34.patch
change kafka.examples.Producer to use the new
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/
---
(Updated April 17, 2015, 9:49 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/
---
(Updated April 17, 2015, 10:09 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastien Zimmer updated KAFKA-2130:
Status: Patch Available (was: Open)
diff --git
[
https://issues.apache.org/jira/browse/KAFKA-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastien Zimmer updated KAFKA-2130:
Attachment: patch.diff
Resource leakage in AppInfo.scala during initialization
[
https://issues.apache.org/jira/browse/KAFKA-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastien Zimmer updated KAFKA-2130:
Comment: was deleted
(was: diff --git a/core/src/main/scala/kafka/common/AppInfo.scala
[
https://issues.apache.org/jira/browse/KAFKA-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1990:
---
Status: In Progress (was: Patch Available)
Add unlimited time-based log retention
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1982:
--
Attachment: KAFKA-1982_2015-04-17_15:08:54.patch
change kafka.examples.Producer to use the new
On April 7, 2015, 10:41 p.m., Jun Rao wrote:
Sorry for the late review. A few more comments below.
Done!
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/#review77523
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500783#comment-14500783
]
Ashish K Singh commented on KAFKA-1982:
---
Updated reviewboard
Sebastien Zimmer created KAFKA-2130:
---
Summary: Resource leakage in AppInfo.scala during initialization
Key: KAFKA-2130
URL: https://issues.apache.org/jira/browse/KAFKA-2130
Project: Kafka
On March 25, 2015, 4:48 p.m., Mayuresh Gharat wrote:
Thanks for the review. Addressed your comment.
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/#review77747
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33168/#review80543
---
Thanks for the patch. Great finding and very comprehensive tests!
[
https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2118:
---
Status: In Progress (was: Patch Available)
Cleaner cannot clean after shutdown during replaceSegments
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/#review80555
---
Thanks for the patch. A few more minor comments.
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1982:
---
Status: In Progress (was: Patch Available)
change kafka.examples.Producer to use the new java producer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review80130
---
Hi,
We will have a KIP hangout at 3pm PST on Apr 21. The following is the
tentative agenda. If you'd like to attend but haven't received an invite,
please let me know.
Agenda:
KIP-4 (admin commands): wrap up any remaining issues
KIP-11 (Authorization):
KIP-12 (SSL/Kerberos): See if there is any
[
https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501112#comment-14501112
]
Manikumar Reddy commented on KAFKA-1884:
[~guozhang] can you review this trivial
I looked into the consumer offset storage and it seems like for acl
storage we should not need something as complex. Consumer offset has
different throughput requirements which is why I think it made sense to
move away from zookeeper. Acls on the other hand seldom change and because
of the caching
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1982:
--
Status: Patch Available (was: In Progress)
change kafka.examples.Producer to use the new java
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500922#comment-14500922
]
Ashish K Singh commented on KAFKA-1982:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-1982:
--
Attachment: KAFKA-1982_2015-04-17_17:00:40.patch
change kafka.examples.Producer to use the new
[
https://issues.apache.org/jira/browse/KAFKA-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2119:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the patch. +1 and committed to
See https://builds.apache.org/job/Kafka-trunk/465/changes
Changes:
[junrao] kafka-2119; ConsumerRecord key() and value() methods should not have
throws Exception; patched by Ewen Cheslack-Postava; reviewed by Jun Rao
--
[...truncated 1249 lines...]
Agreed we also need to change in the code of Sender.java to indicate that
it resembles REPLICATION_TIMEOUT and not the request Timeout.
Thanks,
Mayuresh
On Thu, Apr 16, 2015 at 1:08 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
Hi Guozhang,
By implicit timeout for close() and flush(), I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31369/
---
(Updated April 18, 2015, midnight)
Review request for kafka.
Bugs:
On April 17, 2015, 11:05 p.m., Jun Rao wrote:
Thanks for the patch. A few more minor comments.
Jun thanks for the review again. Addressed your comments.
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33065/#review80557
---
Took a quick look. Overall, looks good. A few comments below.
[
https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1928:
---
Status: In Progress (was: Patch Available)
Move kafka.network over to using the network classes in
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1690:
---
Status: In Progress (was: Patch Available)
[~sriharsha], your original patch in KAFKA-1684 only added the
[
https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501020#comment-14501020
]
Sriharsha Chintalapani commented on KAFKA-1690:
---
[~junrao] I didn't send my
52 matches
Mail list logo
