Re: Review Request 33620: Patch for KAFKA-1690

2015-08-16 Thread Sriharsha Chintalapani
On Aug. 3, 2015, 4:50 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, line 417 https://reviews.apache.org/r/33620/diff/13/?file=1021979#file1021979line417 It's still not very clear to me how renegotiation can be supported in

[jira] [Work started] (KAFKA-2436) log.retention.hours should be honored by LogManager

2015-08-16 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2436 started by Dong Lin. --- log.retention.hours should be honored by LogManager

[jira] [Commented] (KAFKA-2435) More optimally balanced partition assignment strategy

2015-08-16 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698804#comment-14698804 ] Jiangjie Qin commented on KAFKA-2435: - [~noslowerdna] Thanks for the patch. I remember

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-16 Thread Sriharsha Chintalapani
On Aug. 3, 2015, 4:50 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, lines 306-320 https://reviews.apache.org/r/33620/diff/13/?file=1021979#file1021979line306 It seems that the logic here can be simpler. In handshake(), we call

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-16 Thread Sriharsha Chintalapani
On Aug. 3, 2015, 4:50 p.m., Jun Rao wrote: clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, lines 368-381 https://reviews.apache.org/r/33620/diff/13/?file=1021979#file1021979line368 If handshake status is BUFFER_OVERFLOW, we will return to the caller

[jira] [Commented] (KAFKA-2437) Controller lost /controller zookeeper watcher.

2015-08-16 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698910#comment-14698910 ] Jiangjie Qin commented on KAFKA-2437: - Possibly related to KAFKA-1155. I'm doing some

[jira] [Commented] (KAFKA-2436) log.retention.hours should be honored by LogManager

2015-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698882#comment-14698882 ] ASF GitHub Bot commented on KAFKA-2436: --- GitHub user lindong28 opened a pull

[GitHub] kafka pull request: KAFKA-2436; log.retention.hours should be hono...

2015-08-16 Thread lindong28
GitHub user lindong28 opened a pull request: https://github.com/apache/kafka/pull/142 KAFKA-2436; log.retention.hours should be honored by LogManager You can merge this pull request into a Git repository by running: $ git pull https://github.com/lindong28/kafka KAFKA-2436

[jira] [Created] (KAFKA-2437) Controller lost /controller zookeeper watcher.

2015-08-16 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-2437: --- Summary: Controller lost /controller zookeeper watcher. Key: KAFKA-2437 URL: https://issues.apache.org/jira/browse/KAFKA-2437 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2438) add maxParallelForks to build.gradle to speedup tests

2015-08-16 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698968#comment-14698968 ] Sriharsha Chintalapani commented on KAFKA-2438: --- PR posted here

[GitHub] kafka pull request: KAFKA-2438: add maxParallelForks to build.grad...

2015-08-16 Thread harshach
GitHub user harshach opened a pull request: https://github.com/apache/kafka/pull/143 KAFKA-2438: add maxParallelForks to build.gradle to speedup tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/harshach/kafka KAFKA-2438

[jira] [Commented] (KAFKA-2438) add maxParallelForks to build.gradle to speedup tests

2015-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698967#comment-14698967 ] ASF GitHub Bot commented on KAFKA-2438: --- GitHub user harshach opened a pull request:

[jira] [Commented] (KAFKA-2438) add maxParallelForks to build.gradle to speedup tests

2015-08-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698982#comment-14698982 ] ASF GitHub Bot commented on KAFKA-2438: --- Github user asfgit closed the pull request

[jira] [Resolved] (KAFKA-2438) add maxParallelForks to build.gradle to speedup tests

2015-08-16 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-2438. - Resolution: Fixed Fix Version/s: 0.8.3 Issue resolved by pull request 143

[GitHub] kafka pull request: KAFKA-2438: add maxParallelForks to build.grad...

2015-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-16 Thread Gwen Shapira
BTW. I think it will be great for Apache Kafka to have a 0.8.2 release manager who's role is to cherrypick low-risk bug-fixes into the 0.8.2 branch and once enough bug fixes happened (or if sufficiently critical fixes happened) to roll out a new maintenance release (with every 3 month as a

[jira] [Created] (KAFKA-2439) Add MirrorMakerService to ducktape system tests

2015-08-16 Thread Geoffrey Anderson (JIRA)
Geoffrey Anderson created KAFKA-2439: Summary: Add MirrorMakerService to ducktape system tests Key: KAFKA-2439 URL: https://issues.apache.org/jira/browse/KAFKA-2439 Project: Kafka Issue

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-16 Thread Jeff Holoman
+1 for the release and also including https://issues.apache.org/jira/browse/KAFKA-2114 Thanks Jeff On Sun, Aug 16, 2015 at 2:51 PM, Stevo Slavić ssla...@gmail.com wrote: +1 (non-binding) for 0.8.2.2 release Would be nice to include in that release new producer resiliency bug fixes

[jira] [Created] (KAFKA-2438) add maxParallelForks to build.gradle to speedup tests

2015-08-16 Thread Sriharsha Chintalapani (JIRA)
Sriharsha Chintalapani created KAFKA-2438: - Summary: add maxParallelForks to build.gradle to speedup tests Key: KAFKA-2438 URL: https://issues.apache.org/jira/browse/KAFKA-2438 Project: Kafka

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-16 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33620/ --- (Updated Aug. 17, 2015, 3:41 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-16 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698972#comment-14698972 ] Sriharsha Chintalapani commented on KAFKA-1690: --- Updated reviewboard

[jira] [Updated] (KAFKA-1690) new java producer needs ssl support as a client

2015-08-16 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1690: -- Attachment: KAFKA-1690_2015-08-16_20:41:02.patch new java producer needs ssl

[jira] [Updated] (KAFKA-2438) add maxParallelForks to build.gradle to speedup tests

2015-08-16 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-2438: -- Description: With current trunk unit tests on my machine takes 16+ mins and

Re: [DISCUSS] Client-side Assignment for New Consumer

2015-08-16 Thread Neha Narkhede
Hey Becket, These are all fair points. Regarding running Kafka as a service, it will be good for everyone to know some numbers around topic creation and changes around # of partitions. I don't think the test usage is a good one since no one should be creating and deleting topics in a loop on a

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-16 Thread Sriharsha Chintalapani
On July 27, 2015, 1:32 p.m., Ismael Juma wrote: core/src/main/scala/kafka/server/KafkaConfig.scala, line 867 https://reviews.apache.org/r/33620/diff/13/?file=1022000#file1022000line867 Why are we using a Java Map here? Is it used in Java code? If not, then why not use Scala's

Re: [DISCUSSION] Kafka 0.8.2.2 release?

2015-08-16 Thread Stevo Slavić
+1 (non-binding) for 0.8.2.2 release Would be nice to include in that release new producer resiliency bug fixes https://issues.apache.org/jira/browse/KAFKA-1788 and https://issues.apache.org/jira/browse/KAFKA-2120 On Fri, Aug 14, 2015 at 4:03 PM, Gwen Shapira g...@confluent.io wrote: Will be

Re: Review Request 33620: Patch for KAFKA-1690

2015-08-16 Thread Sriharsha Chintalapani
On July 31, 2015, 4:28 p.m., Ismael Juma wrote: clients/src/main/java/org/apache/kafka/common/network/SSLTransportLayer.java, line 319 https://reviews.apache.org/r/33620/diff/13/?file=1021979#file1021979line319 This message seems a bit unclear to me. Are we saying that