Re: [DISCUSS] KIP-1038: Add Custom Error Handler to Producer

2024-05-15 Thread Federico Valeri
Hello Alieh, thanks for this useful KIP. There is a typo in the motivation when you talk about the UnknownTopicOrPartitionException. It's delivery.timeout.ms, not deliver.timeout.ms. In the past, I did some work to improve and clean the official Kafka examples, which I think are useful for new

Re: [VOTE] KIP-1018: Introduce max remote fetch timeout config

2024-05-09 Thread Federico Valeri
+1 non binding Thanks On Thu, May 9, 2024 at 12:05 PM Luke Chen wrote: > > Hi Kamal, > > Thanks for the KIP! > +1 from me. > > Thanks. > Luke > > On Mon, May 6, 2024 at 5:03 PM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > Hi all, > > > > We would like to start a voting

Re: [VOTE] KIP-1041: Drop `offsets.commit.required.acks` config in 4.0 (deprecate in 3.8)

2024-05-08 Thread Federico Valeri
+1 non binding Thanks On Wed, May 8, 2024 at 5:27 PM Andrew Schofield wrote: > > Hi, > Thanks for the KIP. > > +1 (non-binding) > > Thanks, > Andrew > > > On 8 May 2024, at 15:48, David Jacot wrote: > > > > Hi folks, > > > > I'd like to start a voting thread for KIP-1041: Drop > >

Re: [DISCUSS] KIP-1041: Drop `offsets.commit.required.acks` config in 4.0 (deprecate in 3.8)

2024-05-03 Thread Federico Valeri
Hi David, I can't think about any valid use case where changing the default value would be useful, and your motivation is convincing. Thanks. On Fri, May 3, 2024 at 6:01 AM Andrew Schofield wrote: > > Hi David, > I think this KIP is a very good idea. It would be good to get rid of this > cruft.

Re: [VOTE] KIP-1036: Extend RecordDeserializationException exception

2024-05-03 Thread Federico Valeri
Hi Fred, this is a useful addition. +1 non binding Thanks On Fri, May 3, 2024 at 4:11 PM Andrew Schofield wrote: > > Hi Fred, > Thanks for the KIP. It’s turned out nice and elegant I think. Definitely a > worthwhile improvement. > > +1 (non-binding) > > Thanks, > Andrew > > > On 30 Apr 2024,

Re: [VOTE] KIP-909: DNS Resolution Fallures Should Not Fail the Client

2024-04-29 Thread Federico Valeri
+1 (non binding) Thanks On Mon, Apr 29, 2024 at 10:18 AM Rajini Sivaram wrote: > > Hi Philip, > > +1 (binding). Thanks for the KIP! > > Regards, > > Rajini > > > On Tue, Apr 25, 2023 at 8:52 PM Philip Nee wrote: > > > Thanks for the vote. We've decided to make a minor change to the default > >

Re: [DISCUSS] KIP-909: Allow clients to rebootstrap DNS lookup failure

2024-04-29 Thread Federico Valeri
Hi Philip, thanks for this KIP. As other mentioned, I think it is useful in dynamic environment like Kubernetes. I was wondering if we should also update the "examples" modules with this new non-retriable exception. Wdyt? On Fri, Apr 21, 2023 at 11:13 PM Philip Nee wrote: > > Hey Jason, > >

Re: [DISCUSS] KIP-1018: Introduce max remote fetch timeout config

2024-04-27 Thread Federico Valeri
Hi Kamal, it looks like all TS configurations starts with "remote." prefix, so I was wondering if we should name it "remote.fetch.max.wait.ms". On Fri, Apr 26, 2024 at 7:07 PM Kamal Chandraprakash wrote: > > Hi all, > > If there are no more comments, I'll start a vote thread by tomorrow. >

Re: the migration of command tools

2024-04-10 Thread Federico Valeri
Hi, if a tool already has a wrapper bash script in bin and bin/windows, then there is no need to create a redirection in Scala, as users are supposed to use the script. If there is any ST left which is using the tool directly, a bash script should be created, and the ST changed to use the script

Re: [ANNOUNCE] New committer: Christo Lolov

2024-03-26 Thread Federico Valeri
Congrats! On Tue, Mar 26, 2024 at 2:27 PM Mickael Maison wrote: > > Congratulations Christo! > > On Tue, Mar 26, 2024 at 2:26 PM Chia-Ping Tsai wrote: > > > > Congrats Christo! > > > > Chia-Ping

Re: [VOTE] 3.7.0 RC4

2024-02-16 Thread Federico Valeri
Hi Stanislav, it's +1 (non binding) for me. - Built from source using Java 17 and Scala 2.13. - Ran all unit and integration tests. - Used the staged Maven artifacts to test some client applications against ZK and KRaft based clusters. - Tested the Cluster-wide dynamic log adjustment for Kafka

[jira] [Created] (KAFKA-16228) Add --remote-log-metadata-decoder to kafka-dump-log.sh

2024-02-06 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-16228: --- Summary: Add --remote-log-metadata-decoder to kafka-dump-log.sh Key: KAFKA-16228 URL: https://issues.apache.org/jira/browse/KAFKA-16228 Project: Kafka

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-21 Thread Federico Valeri
+1 (non binding) Thanks. On Mon, Jan 22, 2024 at 7:03 AM Luke Chen wrote: > > Hi Ziming, > > +1(binding) from me. > > Thanks. > Luke > > On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > +1 (non-binding) > > > > On Mon, Jan 22, 2024 at 8:34 

[REVIEW REQUEST] Move StorageTool to tools

2024-01-15 Thread Federico Valeri
Hi folks, this PR has been open for some time now, can anyone have a look? https://github.com/apache/kafka/pull/14847 Thanks.

Re: [VOTE] KIP-1005: Expose EarliestLocalOffset and TieredOffset

2024-01-12 Thread Federico Valeri
+1 non binding Thanks On Fri, Jan 12, 2024 at 1:31 AM Boudjelda Mohamed Said wrote: > > +1 (binding) > > > On Fri, Jan 12, 2024 at 1:21 AM Satish Duggana > wrote: > > > +1 (binding) > > > > Thanks, > > Satish. > > > > On Thu, 11 Jan 2024 at 17:52, Divij Vaidya > > wrote: > > > > > > +1

Re: [DISCUSS] KIP-1014: Managing Unstable Metadata Versions in Apache Kafka

2024-01-12 Thread Federico Valeri
gt; > > would encourage waiting until the release before we decide an incomplete > > > feature is not ready and moving its MV into the future. (The > > > abandoning comment I made earlier -- that is consistent with Proven's > > > approach) > > > > > &g

Re: [DISCUSS] KIP-1014: Managing Unstable Metadata Versions in Apache Kafka

2024-01-10 Thread Federico Valeri
Hi folks, > If you use an unstable MV, you probably won't be able to upgrade your > software. Because whenever something changes, you'll probably get > serialization exceptions being thrown inside the controller. Fatal ones. Thanks for this clarification. I think this concrete risk should be

Re: [VOTE] KIP-1004: Enforce tasks.max property in Kafka Connect

2024-01-04 Thread Federico Valeri
Thanks! This will finally reconcile Javadoc and implementation. +1 (non binding) On Thu, Jan 4, 2024 at 6:49 AM Yash Mayya wrote: > > Hi Chris, > > +1 (binding), thanks for the KIP. > > Based on discussion in other threads, it looks like the community is > aligned with having a 3.8 release

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-04 Thread Federico Valeri
On Fri, Dec 29, 2023 at 8:49 AM ziming deng wrote: > > Hello all, > > We have 2 people prefer using "--enable-incremental" and it makes sense to > move the incompatible process to 4.X, I changed the default way to still use > `alterConfigs` and use `incrementalAlterConfigs` only when >

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-19 Thread Federico Valeri
HI Ziming, thanks for the KIP. Looks good to me. Just on question: given that alterConfig is deprecated, shouldn't we also introduce --disable-incremental as deprecated? That way we would get rid of both in Kafka 4.0. Also see: https://issues.apache.org/jira/browse/KAFKA-14705. On Tue, Dec 19,

Re: [VOTE] 3.6.1 RC0

2023-11-27 Thread Federico Valeri
Hi Mickael, - Build from source (Java 17, Scala 2.13) - Run unit and integration tests - Run custom client apps using staging artifacts +1 (non binding) Thanks Fede On Sun, Nov 26, 2023 at 11:34 AM Jakub Scholz wrote: > > +1 non-binding. I used the staged Scala 2.13 artifacts and the staged

Re: [VOTE] KIP-974: Docker Image for GraalVM based Native Kafka Broker

2023-11-22 Thread Federico Valeri
Hi, +1 (non binding) Thanks On Wed, Nov 22, 2023 at 3:16 PM Manikumar wrote: > > Hi Krishna, > > Thanks for KIP. +1 (binding). > > > Thanks, > Manikumar > > On Mon, Nov 20, 2023 at 11:57 AM Krishna Agarwal < > krishna0608agar...@gmail.com> wrote: > > > Hi, > > I'd like to call a vote on

Re: [VOTE] 3.5.2 RC1

2023-11-22 Thread Federico Valeri
Hi Luke, - Compiled from source (Java 17 and Scala 2.13) - Ran unit and integration tests - Ran custom client apps using staging artifacts +1 (non binding) Thanks Fede On Wed, Nov 22, 2023 at 2:44 PM Josep Prat wrote: > > Hi Luke, > > Thanks for running the release. > I did the following: > -

Re: [DISCUSS] KIP-974 Docker Image for GraalVM based Native Kafka Broker

2023-11-01 Thread Federico Valeri
wobkl59l4 > > > Regards, > Krishna > > On Wed, Oct 25, 2023 at 9:50 PM Federico Valeri > wrote: > > > Hi Krishna, thanks for updating the KIP and all the work you are > > putting into that. > > > > The release process LGTM. In the other KIP I se

Re: [DISCUSS] KIP-974 Docker Image for GraalVM based Native Kafka Broker

2023-10-25 Thread Federico Valeri
uded a section in the KIP on the release process. I would greatly > > appreciate your insights after reviewing it. > > > > Regards, > > Krishna > > > > On Fri, Sep 8, 2023 at 3:08 PM Federico Valeri > > wrote: > > > > > Hi Krishna

Re: [VOTE] KIP-978: Allow dynamic reloading of certificates with different DN / SANs

2023-10-25 Thread Federico Valeri
Hi Jakub, thanks for this KIP. +1 (non binding) Thanks Fede On Wed, Oct 25, 2023 at 4:45 PM Manikumar wrote: > > Hi, > > Thanks for the KIP. > > +1 (binding) > > > Thanks. > > On Wed, Oct 25, 2023 at 1:37 AM Jakub Scholz wrote: > > > Hi all, > > > > I would like to start a vote for the

Re: [VOTE] KIP-979 Allow independently stop KRaft processes

2023-10-23 Thread Federico Valeri
+1 (non binding) Thanks. On Mon, Oct 23, 2023 at 9:48 AM Kamal Chandraprakash wrote: > > +1 (non-binding). Thanks for the KIP! > > On Mon, Oct 23, 2023, 12:55 Hailey Ni wrote: > > > Hi all, > > > > I'd like to call a vote on KIP-979 that will allow users to independently > > stop KRaft

Re: [VOTE] KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-10-09 Thread Federico Valeri
Hi Chris, +1 (non binding) Thanks Fede On Sun, Oct 8, 2023 at 10:11 AM Yash Mayya wrote: > > Hi Chris, > > Thanks for the KIP! > +1 (binding) > > Yash > > On Fri, Oct 6, 2023 at 9:54 PM Greg Harris > wrote: > > > Hey Chris, > > > > Thanks for the KIP! > > I think that preserving the ephemeral

[jira] [Created] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-15537: --- Summary: Unsafe metadata.version downgrade is not supported Key: KAFKA-15537 URL: https://issues.apache.org/jira/browse/KAFKA-15537 Project: Kafka

Re: [DISCUSS] KIP-979: Allow independently stop KRaft controllers or brokers

2023-10-03 Thread Federico Valeri
Hi Hailey, thanks for the KIP. I also agree that the two mutually exclusive args are better. In order to be consistent with the other tools, I would suggest to use --process-role and --node-id (hyphen instead of dot). Can you also update the KIP? On Mon, Oct 2, 2023 at 10:18 PM Hailey Ni wrote:

Re: [VOTE] 3.6.0 RC2

2023-10-02 Thread Federico Valeri
Hi Satish, I did the following to verify the release: - Built from source with Java 17 and Scala 2.13 - Ran all unit and integration tests - Spot checked documentation - Ran custom client applications using staging artifacts on a 3-nodes cluster - Tested tiered storage with one of the available

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-24 Thread Federico Valeri
Hi Satish, I did the following to verify the release: - Verified signature and checksum - Built from source with Java 17 and Scala 2.13 - Ran all unit and integration tests - Spot checked release notes and documentation - Ran a custom client using staging artifacts on a 3-nodes cluster - Tested

Re: Apache Kafka 3.6.0 release

2023-09-13 Thread Federico Valeri
Hi Satish, this is a small documentation fix about ZK to KRaft migration, that we would like to backport to 3.5 and 3.6 branches. Are you ok with that? https://github.com/apache/kafka/pull/14366 On Wed, Sep 13, 2023 at 3:13 AM Satish Duggana wrote: > > Thanks David for the quick resolution. > >

Re: Complete Kafka replication protocol description

2023-09-12 Thread Federico Valeri
Hi Jack, thanks for providing this material. I'll spend some time digging into it. On Mon, Sep 11, 2023 at 6:56 PM Jack Vanlightly wrote: > > Hi all, > > I agree that we should have the protocol description and specification in > the Kafka repository. I have two other specifications to

Re: [DISCUSS] KIP-974 Docker Image for GraalVM based Native Kafka Broker

2023-09-08 Thread Federico Valeri
Hi Krishna, thanks for opening this discussion. I see you created two separate KIPs (974 and 975), but there are some common points (build system and test plan). Currently, the Docker image used for system tests is only supported in that limited scope, so the maintenance burden is minimal.

Re: KIP-976: Cluster-wide dynamic log adjustment for Kafka Connect

2023-09-04 Thread Federico Valeri
Hi Chris, thanks. This looks like a useful feature. Due to the idempotent nature of PUT, I guess that the last_modified timestamp won't change if the same request is repeated successively. Should we add a unit test for that? On Mon, Sep 4, 2023 at 6:17 AM Ashwin wrote: > > Hi Chris, > > Thanks

Re: [ANNOUNCE] Apache Kafka 3.5.1

2023-07-24 Thread Federico Valeri
Thanks Divij :) On Mon, Jul 24, 2023 at 2:28 PM Luke Chen wrote: > > Thanks for running the release! > > Luke > > On Mon, Jul 24, 2023 at 6:35 PM Manyanda Chitimbo < > manyanda.chiti...@gmail.com> wrote: > > > Thanks for running the release Divij. > > > > On Mon 24 Jul 2023 at 12:15, Kamal

Re: [VOTE] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-24 Thread Federico Valeri
+1 (non binding) Thanks Fede On Sun, Jul 23, 2023 at 6:30 PM Omnia Ibrahim wrote: > > Hi everyone, > I would like to open a vote for KIP-949. The proposal is here >

[jira] [Created] (KAFKA-15232) Move ToolsUtils to tools

2023-07-21 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-15232: --- Summary: Move ToolsUtils to tools Key: KAFKA-15232 URL: https://issues.apache.org/jira/browse/KAFKA-15232 Project: Kafka Issue Type: Sub-task

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-21 Thread Federico Valeri
> new class to implement a change in behavior this small. > > > > > > That said, I don't think this is worth blocking on and wouldn't be > > opposed > > > if others felt strongly that a new replication policy class is superior > > to > > &g

[jira] [Reopened] (KAFKA-14581) Move GetOffsetShell to tools

2023-07-21 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reopened KAFKA-14581: - > Move GetOffsetShell to tools > > >

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-19 Thread Federico Valeri
his policy instead of default and no impact will > > happen to users upgrading from 3.x to post-KIP-949. We can mark > > `LegacyReplicationPolicy` as deprecated later if we want (but not in 4.0 > as > > this is very soon) and we can drop it entirely at some point. > > > > If ther

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-19 Thread Federico Valeri
ut old MM2 migrating their internal > > topics to 4.0 with less impact. > > > > @Chris what do you think? > > > > Cheers > > Omnia > > > > On Fri, Jul 14, 2023 at 2:38 PM Federico Valeri > > wrote: > > > > > Hi O

Re: [VOTE] 3.5.1 RC1

2023-07-17 Thread Federico Valeri
Hi Divij, I did the following checks: - Checked signature, checksum, licenses - Spot checked documentation and javadoc - Built from source with Java 17 and Scala 2.13 - Ran full unit and integration test suites - Ran test Java app using staging Maven artifacts +1 (non binding) Cheers Fede On

Re: [DISCUSS] KIP-949: Add flag to enable the usage of topic separator in MM2 DefaultReplicationPolicy

2023-07-14 Thread Federico Valeri
Hi Omnia and Chris, I agree with setting "replication.policy.internal.topic.separator.enabled=true" by default, but I was wondering if we should also deprecate and remove in Kafka 4. If there is agreement in having the same behavior for internal and non-internal topics, then it should be fine, and

Re: [VOTE] 3.5.1 RC0

2023-07-13 Thread Federico Valeri
Hi Divij, thanks for running the release. I found a couple of issues with licenses. We include plexus-utils-3.3.1, but the LICENSE file has plexus-utils-3.3.0. The other issue is that we have classgraph-4.8.138, but we don't include this library for a few releases (this is non blocking but it

Re: [ANNOUNCE] New committer: Greg Harris

2023-07-11 Thread Federico Valeri
Congrats Greg! On Tue, Jul 11, 2023 at 3:55 AM Luke Chen wrote: > > Congrats Greg! > > Luke > > On Tue, Jul 11, 2023 at 8:19 AM Matthew de Detrich > wrote: > > > Congratulations, well deserved! > > > > On Mon, Jul 10, 2023 at 5:45 PM Chris Egerton wrote: > > > > > Hi all, > > > > > > The PMC

Re: [REVIEW REQUEST] KAFKA-14591 DeleteRecordsCommand moved to tools

2023-07-10 Thread Federico Valeri
HI Nikolay, I did the review. Thanks again for working on this. Br Fede On Mon, Jul 10, 2023 at 12:08 PM Николай Ижиков wrote: > > Hello. > > I prepared PR [1] for ticket [2]. > DeleteRecordsCommand rewritten in java and moved to tools module. > Currently, commands doesn’t have any tests so PR

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-14 Thread Federico Valeri
Congrats Divij! On Wed, Jun 14, 2023 at 10:02 AM Divij Vaidya wrote: > > Thank you everyone! I promise to shoulder this new responsibility to the > best of my abilities. > > -- > Divij Vaidya > > > > On Wed, Jun 14, 2023 at 4:13 AM ziming deng > wrote: > > > Congratulations, Divij! > > Well

Re: [ANNOUNCE] Apache Kafka 3.4.1

2023-06-06 Thread Federico Valeri
Thanks Luke! On Wed, Jun 7, 2023 at 5:56 AM Kamal Chandraprakash wrote: > > Thanks Luke for running this release! > > On Wed, Jun 7, 2023 at 8:08 AM Chia-Ping Tsai wrote: > > > Thank Luke for this hard work!!! > > > > > Chris Egerton 於 2023年6月7日 上午10:35 寫道: > > > > > > Thanks for running this

Re: [VOTE] 3.5.0 RC1

2023-06-06 Thread Federico Valeri
Hi Mickael, I did the following checks: - Signature, checksum, licenses - Build from source with Java 17 and Scala 2.13 - Full unit and integration test suites - Java app with staging Maven artifacts and multi-node cluster LGTM, apart from the already mentioned "classgraph" license that can be

Re: [VOTE] 3.4.1 RC3

2023-05-27 Thread Federico Valeri
Hi Luke, - Checked signature, checksum, libs, and license file - Build from source with Java 17 and Scala 2.13 - Ran full unit and integration test suites - Ran Java app with staging Maven artifacts against ZK and KRaft multi-node clusters +1 (non binding) Thanks Fede On Fri, May 26, 2023 at

Re: [VOTE] 3.4.1 RC2

2023-05-24 Thread Federico Valeri
Hi Luke, these are the things I checked: - Source signature, checksum and license file - Build from source with Java 17 and Scala 2.13 - Unit and integration test suites - Java app with staging Maven artifacts +1 (non binding) Thanks Fede On Wed, May 24, 2023 at 6:36 PM Chris Egerton wrote:

Re: [DISCUSS] Adding non-committers as Github collaborators

2023-05-24 Thread Federico Valeri
anges to asf.yaml, I received a > > notification that the list is limited to only 10 people, not 20 as the > > documentation states. > > > > Here is the list of folks who will now be able to triage PRs and trigger > > builds: Victoria Xia, Greg Harris, Divij Vaidya, Lucas Brutschy, Ya

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Federico Valeri
Hi Luke, - Source signature and checksum - Build from source with Java 17 and Scala 2.13 - Full unit and integration test suite - Java app with staging Maven artifacts +1 (non binding) Thanks Fede PS: Links still point to RC0, but I checked and RC1 artifacts are there, including Maven. The

Re: [VOTE] KIP-927: Improve the kafka-metadata-quorum output

2023-05-21 Thread Federico Valeri
>> > >> > >> > >> On Tue, May 16, 2023 at 4:35 AM ziming deng > >> wrote: > >> > >> > Thanks for this improvement, +1 from me(binging) > >> > > >> > — > >> > Best, > >> > Zim

Re: [VOTE] 3.4.1 RC0

2023-05-17 Thread Federico Valeri
Hi Luke, thanks for running the release. Looks like the Maven artifacts are not in staging: https://repository.apache.org/content/groups/staging/org/apache/kafka/kafka-clients/3.4.1/ Documentation still has 3.4.0, instead of 3.4.1 (not sure if this will be aligned later):

[VOTE] KIP-927: Improve the kafka-metadata-quorum output

2023-05-15 Thread Federico Valeri
Hi all, I'd like to start a vote on KIP-927: Improve the kafka-metadata-quorum output. https://cwiki.apache.org/confluence/display/KAFKA/KIP-927%3A+Improve+the+kafka-metadata-quorum+output Discussion thread: https://lists.apache.org/thread/pph59hxvz5jkk709x53p44xrpdqwv8qc Thanks Fede

Re: [DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-15 Thread Federico Valeri
mestamp), where "now" is in UTC (and not in your machine's > locale/timezone). Perhaps, it's worth clarifying in the KIP? > Other than that, no more comments from my side. The proposal looks good to > me. > > -- > Divij Vaidya > > > > On Thu, May 11, 2023 at 9

Re: [DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-11 Thread Federico Valeri
exact date. In that sense I think it is more readable. Happy to hear other opinions on this. > [1] https://en.wikipedia.org/wiki/ISO_8601 > > -- > Divij Vaidya > > > > On Wed, May 10, 2023 at 6:10 PM Federico Valeri > wrote: > > > Hi all, I'd like to start a new di

[DISCUSS] KIP-927: Improve the kafka-metadata-quorum output

2023-05-10 Thread Federico Valeri
Hi all, I'd like to start a new discussion thread on KIP-927: Improve the kafka-metadata-quorum output. https://cwiki.apache.org/confluence/display/KAFKA/KIP-927%3A+Improve+the+kafka-metadata-quorum+output This KIP is small and proposes to add a new optional flag to have a human-readable

[jira] [Resolved] (KAFKA-7735) StateChangeLogMerger tool can not work due to incorrect topic regular matches

2023-04-27 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri resolved KAFKA-7735. Resolution: Won't Fix > StateChangeLogMerger tool can not work due to incorrect to

Re: [ANNOUNCE] New PMC chair: Mickael Maison

2023-04-21 Thread Federico Valeri
Congrats Mickael, very well deserved, and thanks Jun for covering this role so far. On Fri, Apr 21, 2023 at 5:09 PM Jun Rao wrote: > > Hi, everyone, > > After more than 10 years, I am stepping down as the PMC chair of Apache > Kafka. We now have a new chair Mickael Maison, who has been a PMC

[jira] [Resolved] (KAFKA-14720) Tools migration guidelines

2023-04-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri resolved KAFKA-14720. - Resolution: Fixed > Tools migration guideli

Re: [VOTE] KIP-906 Tools migration guidelines

2023-04-04 Thread Federico Valeri
Hi, the KIP is accepted with 3 binding votes (Luke, John and Tom) and 1 non binding vote (Alexandre). Thanks everyone! Cheers Fede On Tue, Apr 4, 2023 at 1:58 PM Tom Bentley wrote: > > Hi Federico, > > Thanks for the KIP, +1 (binding). > > Tom > > On Tue, 4 Apr 2023 a

Re: [VOTE] KIP-906 Tools migration guidelines

2023-04-04 Thread Federico Valeri
Hi, we have 2 binding an 1 non binding votes. Thanks for tacking the time to review the KIP. Can I get one more binding vote? Cheers Fede On Fri, Mar 24, 2023 at 3:05 PM John Roesler wrote: > > Thanks Federico, > > I'm +1 (binding) > > -John > > On Fri, Mar 24, 2023, a

Re: [VOTE] KIP-906 Tools migration guidelines

2023-03-24 Thread Federico Valeri
om me. > > > > Luke > > > > On Wed, Mar 15, 2023 at 4:11 PM Federico Valeri > > wrote: > > > > > Hi everyone, > > > > > > I'd like to start the vote on KIP-906 Tools migration guidelines. > > > > > > > > >

[VOTE] KIP-906 Tools migration guidelines

2023-03-15 Thread Federico Valeri
Hi everyone, I'd like to start the vote on KIP-906 Tools migration guidelines. https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines Discussion thread: https://lists.apache.org/thread/o2ytmjj2tyc2xcy6xh5tco31yyjzvz8p Thanks Fede

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-03-15 Thread Federico Valeri
Bumping this thread as KIP-641 is now adopted. Thanks Fede On Thu, Feb 16, 2023 at 11:13 AM Federico Valeri wrote: > > On Thu, Feb 16, 2023 at 10:26 AM Luke Chen wrote: > > > > Hi Federico, > > > > 1. Sounds good. > > I think you should make it clear in th

Re: [VOTE] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-03-07 Thread Federico Valeri
+ 1 (non binding) for the latest revision of this KIP (RecordReader). Thanks Fede On Sat, Feb 25, 2023 at 7:04 AM Luke Chen wrote: > > +1 from me. > > Thank you > Luke > > On Sat, Feb 25, 2023 at 8:39 AM Chia-Ping Tsai wrote: > > > Dear all, > > > > All comments are addressed , and so please

Re: [VOTE] KIP-898: Modernize Connect plugin discovery

2023-02-28 Thread Federico Valeri
+1 (non binding) Thanks Fede On Tue, Feb 28, 2023 at 10:10 AM Mickael Maison wrote: > > +1 (binding) > > Thanks, > Mickael > > On Mon, Feb 27, 2023 at 7:42 PM Chris Egerton wrote: > > > > +1 (binding). Thanks for the KIP! > > > > On Mon, Feb 27, 2023 at 12:51 PM Greg Harris > > wrote: > > > >

Re: [VOTE] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-18 Thread Federico Valeri
+ 1 (non binding) Thanks On Sat, Feb 18, 2023 at 9:36 AM Chia-Ping Tsai wrote: > > Hi, > > I'd like to start the vote on KIP-614: An new java interface to replace > 'kafka.common.MessageReader' > > KIP-614: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158866569 > >

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-16 Thread Federico Valeri
Hi Chia-Ping, thanks for updating the KIP. I would only add that we plan to remove the old trait in the next major release. I think it's better to be explicit about this. On Thu, Feb 16, 2023 at 11:34 AM Chia-Ping Tsai wrote: > > Dear all, > > I have updated the KIP to address comments. PTAL >

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-02-16 Thread Federico Valeri
hink the first rejected alternative could also be used for the SPI argument issue. > Thank you. > Luke > > On Thu, Feb 16, 2023 at 4:56 PM Federico Valeri > wrote: > > > Hi Luke, thanks for the feedback. > > > > On Thu, Feb 16, 2023 at 9:33 AM Luke Chen wrote

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-02-16 Thread Federico Valeri
gt; If the above PR is accepted, we will have a deprecated but working version. The general orientation is to remove it in the next major release, because it was broker for a long time and nobody complained. > Thank you. > Luke > > On Thu, Feb 16, 2023 at 4:16 PM Federico Valeri >

Re: [DISCUSS] KIP-906 Tools migration guidelines

2023-02-16 Thread Federico Valeri
Sorry for the spam. I had some issue with my mail client. On Wed, Feb 15, 2023 at 3:42 PM Federico Valeri wrote: > > Hi everyone, > > I opened KIP-906 to have some guidelines around tools migration: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+mi

[DISCUSS] KIP-906 Tools migration guidelines

2023-02-15 Thread Federico Valeri
Hi everyone, I opened KIP-906 to have some guidelines around tools migration: https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines Let me know if you have any feedback or suggestions. Thanks Fede

[DISCUSS] KIP-906 Tools migration guidelines

2023-02-15 Thread Federico Valeri
Hi everyone, I opened KIP-906 to have some guidelines around tools migration: https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines Let me know if you have any feedback or suggestions. Thanks Fede

[DISCUSS] KIP-906 Tools migration guidelines

2023-02-15 Thread Federico Valeri
Hi everyone, I opened KIP-906 to have some guidelines around tools migration: https://cwiki.apache.org/confluence/display/KAFKA/KIP-906%3A+Tools+migration+guidelines Let me know if you have any feedback or suggestions. Thanks Fede

[jira] [Created] (KAFKA-14720) Tools migration guidelines

2023-02-15 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-14720: --- Summary: Tools migration guidelines Key: KAFKA-14720 URL: https://issues.apache.org/jira/browse/KAFKA-14720 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-14705) Delete kafka.tools.JmxTool redirection object

2023-02-10 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-14705: --- Summary: Delete kafka.tools.JmxTool redirection object Key: KAFKA-14705 URL: https://issues.apache.org/jira/browse/KAFKA-14705 Project: Kafka Issue

Re: [VOTE] 3.4.0 RC2

2023-02-03 Thread Federico Valeri
+1 (non binding) - Ran the unit and integration test suites with Java 17 and Scala 2.13 - Ran a series of basic examples and client configurations - Spot checked the docs and Javadocs Thanks Fede On Fri, Feb 3, 2023 at 5:29 PM Jakub Scholz wrote: > > +1 (non-binding). I run my tests with the

Re: [DISCUSS] KIP-888: Batch describe ACLs and describe client quotas

2023-02-02 Thread Federico Valeri
Hi Michael, thanks for the KIP. In addition to the deduplication logic, I wonder if we should also consider introducing a pagination mechanism. Talking about ACLs, there could be many rules for each user and we may have lots of users on big clusters. On Tue, Jan 31, 2023 at 3:58 PM Mickael

Re: [VOTE] KIP-894: Use incrementalAlterConfigs API for syncing topic configurations

2023-01-26 Thread Federico Valeri
+1 (non binding) Thanks. On Thu, Jan 26, 2023 at 2:30 PM Gantigmaa Selenge wrote: > > Hi > > I'd like to call for a vote on KIP-894, which updates MirrorMaker to use > IncrementalAlterConfigs API to sync topic configurations between clusters. > > The KIP: >

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-01-24 Thread Federico Valeri
ind a CLI flag) to find and remove > > manifests for nonexistent plugins? > > > > 5. What's the concrete plan for updating the plugins that ship OOTB with > > Connect? Will they be given a service loader manifest, a module info file, > > or both? > > > > 6.

Re: [DISCUSS] KIP-877: Mechanism for plugins and connectors to register metrics

2023-01-24 Thread Federico Valeri
Hi Michael, thanks for the KIP. Looks great. I noticed that there is a difference on how MetricName and Sensor are created and removed in PluginMetrics class: - In metricName() it is not clear what happens if the MetricName already exists, I guess it will be the same "get or create" behavior we

Re: [DISCUSS] KIP-898: Modernize Connect plugin discovery

2023-01-23 Thread Federico Valeri
Hi Greg, this looks like a useful change to me. I was just wondering if we should use a better script name like "connect-convert-to-service-provider.sh" or something like this, and maybe add a --dry-run option. On Tue, Jan 17, 2023 at 8:45 PM Greg Harris wrote: > > Hi all! > > I'd like to start

[jira] [Created] (KAFKA-14628) Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-18 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-14628: --- Summary: Move CommandLineUtils and CommandDefaultOptions shared classes Key: KAFKA-14628 URL: https://issues.apache.org/jira/browse/KAFKA-14628 Project: Kafka

Re: [DISCUSS] KIP-894: Use incrementalAlterConfigs API for syncing topic configurations

2023-01-15 Thread Federico Valeri
On Wed, Jan 11, 2023 at 12:03 PM Gantigmaa Selenge wrote: > > Thank you both for the feedback. > > > Have we considered using incremental alter configs by > default and fallback to the legacy one if the former is unavailable? > Initially having a flag with just on and off switches seemed simpler

[jira] [Created] (KAFKA-14568) Move FetchDataInfo and related to storage module

2023-01-04 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-14568: --- Summary: Move FetchDataInfo and related to storage module Key: KAFKA-14568 URL: https://issues.apache.org/jira/browse/KAFKA-14568 Project: Kafka Issue

[jira] [Resolved] (KAFKA-14554) Move ClassLoaderAwareRemoteStorageManagerTest to storage module

2022-12-28 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri resolved KAFKA-14554. - Resolution: Fixed > Move ClassLoaderAwareRemoteStorageManagerTest to storage mod

[jira] [Created] (KAFKA-14554) Move ClassLoaderAwareRemoteStorageManagerTest to storage module

2022-12-27 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-14554: --- Summary: Move ClassLoaderAwareRemoteStorageManagerTest to storage module Key: KAFKA-14554 URL: https://issues.apache.org/jira/browse/KAFKA-14554 Project: Kafka

Re: [ANNOUNCE] New committer: Satish Duggana

2022-12-23 Thread Federico Valeri
Hi Satish, congrats! On Fri, Dec 23, 2022, 8:46 PM Viktor Somogyi-Vass wrote: > Congrats Satish! > > On Fri, Dec 23, 2022, 19:38 Mickael Maison > wrote: > > > Congratulations Satish! > > > > On Fri, Dec 23, 2022 at 7:36 PM Divij Vaidya > > wrote: > > > > > > Congratulations Satish!  > > > >

[jira] [Resolved] (KAFKA-14549) Move LogDirFailureChannel to storage module

2022-12-23 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri resolved KAFKA-14549. - Resolution: Fixed > Move LogDirFailureChannel to storage mod

Re: [VOTE] 3.3.2 RC1

2022-12-23 Thread Federico Valeri
Hi, I did the following to validate the release: - Checksums and signatures ok - Build from source using Java 17 and Scala 2.13 ok - Unit and integration tests ok - Quickstart in both ZK and KRaft modes ok - Test app with staging Maven artifacts ok +1 (non binding) Thanks Fede On Wed, Dec 21,

[jira] [Created] (KAFKA-14549) Move LogDirFailureChannel to storage module

2022-12-22 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-14549: --- Summary: Move LogDirFailureChannel to storage module Key: KAFKA-14549 URL: https://issues.apache.org/jira/browse/KAFKA-14549 Project: Kafka Issue Type

Re: [VOTE] 3.3.2 RC0

2022-12-16 Thread Federico Valeri
Hi, I did the following to validate the release: - Checksums and signatures ok - Build from source using Java 17 and Scala 2.13 ok - Unit and integration tests ok - Quickstart in both ZK and KRaft modes ok - Test app with staging Maven artifacts ok Documentation still has 3.3.1 version

Re: [VOTE] KIP-678: New Kafka Connect SMT for plainText => struct with Regex

2022-10-10 Thread Federico Valeri
+1 (non binding) Thanks. On Fri, Sep 2, 2022 at 5:32 PM Chris Egerton wrote: > > +1 (binding) > > Thanks for the KIP! > > On Thu, Sep 1, 2022 at 9:52 PM gyejun choi wrote: > > > Hi all, > > I'd like to start a vote for KIP-678: New Kafka Connect SMT for plainText > > => struct with Regex > >

Re: [VOTE] 3.3.1 RC0

2022-10-03 Thread Federico Valeri
Hi, I did the following to validate the release: - Checksums and signatures ok - Build from source ok - Unit and integration tests ok - Quickstart in both ZK and KRaft modes ok - Test Java app with staging Maven artifacts ok +1 (non binding) Thanks Fede On Sun, Oct 2, 2022 at 7:47 PM José

Re: [VOTE] 3.2.1 RC3

2022-07-23 Thread Federico Valeri
gpg: Good signature from "David Arthur (CODE SIGNING KEY) " [unknown] /tmp/tmp.lRpAY/kafka-3.2.1-src.tgz.sha512: OK Build using Gradle 7.3.3, Java 11 and Scala 2.13.8 BUILD SUCCESSFUL in 5m 34s Unit and integration tests: BUILD SUCCESSFUL in 37m 47s I also used Scala 2.13 binaries and staged

  1   2   >