[
https://issues.apache.org/jira/browse/KAFKA-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2516:
---
Status: Patch Available (was: Open)
> Rename o.a.k.client.tools to o.a.k.to
[
https://issues.apache.org/jira/browse/KAFKA-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke reassigned KAFKA-2516:
--
Assignee: Grant Henke
> Rename o.a.k.client.tools to o.a.k.to
Grant Henke created KAFKA-2646:
--
Summary: Re-enable altering topic config in the topics command to
maintain backwards compatibility
Key: KAFKA-2646
URL: https://issues.apache.org/jira/browse/KAFKA-2646
[
https://issues.apache.org/jira/browse/KAFKA-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2620:
---
Status: Patch Available (was: Open)
> Introduce Scalarif
[
https://issues.apache.org/jira/browse/KAFKA-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke resolved KAFKA-2633.
Resolution: Fixed
> Default logging from tools to Std
Grant Henke created KAFKA-2645:
--
Summary: Document potentially breaking changes in the release
notes for 0.9.0
Key: KAFKA-2645
URL: https://issues.apache.org/jira/browse/KAFKA-2645
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955220#comment-14955220
]
Grant Henke commented on KAFKA-2633:
_Duplicating my comment here_
I am happy to send a docs patch
[
https://issues.apache.org/jira/browse/KAFKA-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955382#comment-14955382
]
Grant Henke commented on KAFKA-2620:
They should probably go in at a similar time, or at least
[
https://issues.apache.org/jira/browse/KAFKA-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke reassigned KAFKA-2536:
--
Assignee: Grant Henke
> topics tool should allow users to alter topic configurat
[
https://issues.apache.org/jira/browse/KAFKA-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke resolved KAFKA-2646.
Resolution: Duplicate
> Re-enable altering topic config in the topics command to maintain backwa
[
https://issues.apache.org/jira/browse/KAFKA-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955381#comment-14955381
]
Grant Henke commented on KAFKA-2536:
If we are deprecating it from the topic command, I can log
[
https://issues.apache.org/jira/browse/KAFKA-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2536:
---
Fix Version/s: 0.9.0.0
> topics tool should allow users to alter topic configurat
[
https://issues.apache.org/jira/browse/KAFKA-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2536:
---
Status: Patch Available (was: Open)
> topics tool should allow users to alter topic configurat
[
https://issues.apache.org/jira/browse/KAFKA-2536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2536:
---
Component/s: tools
> topics tool should allow users to alter topic configurat
[
https://issues.apache.org/jira/browse/KAFKA-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke reassigned KAFKA-2633:
--
Assignee: Grant Henke
> Default logging from tools to Std
Grant Henke created KAFKA-2633:
--
Summary: Default logging from tools to Stderr
Key: KAFKA-2633
URL: https://issues.apache.org/jira/browse/KAFKA-2633
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2633:
---
Status: Patch Available (was: Open)
> Default logging from tools to Std
ache
> Kafka? Or Changes made in Apache Kafka?
>
> Any one please Confirm this?
>
>
> Thanks,
> Dinesh
>
--
Grant Henke
Software Engineer | Cloudera
gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
[
https://issues.apache.org/jira/browse/KAFKA-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947464#comment-14947464
]
Grant Henke commented on KAFKA-2620:
[~ijuma] I agree we should use Scalastyle as well. These are two
Grant Henke created KAFKA-2620:
--
Summary: Introduce Scalariform
Key: KAFKA-2620
URL: https://issues.apache.org/jira/browse/KAFKA-2620
Project: Kafka
Issue Type: Bug
Components: build
[
https://issues.apache.org/jira/browse/KAFKA-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14937017#comment-14937017
]
Grant Henke commented on KAFKA-2580:
A few notes/questions from my initial look at the LogManager
gt; > specialized depending on different environments. This is a case
> where
> > > > > extensibility in the format is probably really useful.
> > > > > * Properties like supported.compression.codecs can presumably be
> > > > determined
> > > > > just via the broker version. Is there a good reason for including
> > them?
> > > > > Perhaps explicit info >> implicit info?
> > > > > * "All existing clients should be able to handle this gracefully
> > > without
> > > > > any alterations to the code" - which clients does this refer to?
> For
> > > > > example, will the Java clients continue to behave the same way they
> > do
> > > > > today? I'm curious because empty responses seem *very* different
> from
> > > > > closing connections.
> > > > >
> > > > >
> > > > > -Ewen
> > > > >
> > > > > On Fri, Sep 25, 2015 at 2:53 PM, Magnus Edenhill <
> mag...@edenhill.se
> > >
> > > > > wrote:
> > > > >
> > > > > > Good evening,
> > > > > >
> > > > > > KIP-35 was created to address current and future broker-client
> > > > > > compatibility.
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-35+-+Retrieving+protocol+version
> > > > > >
> > > > > > Summary:
> > > > > > * allow clients to retrieve the broker's protocol version
> > > > > > * make broker handle unknown protocol requests gracefully
> > > > > >
> > > > > > Feedback and comments welcome!
> > > > > >
> > > > > > Regards,
> > > > > > Magnus
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Thanks,
> > > > > Ewen
> > > > >
> > > >
> > >
> >
>
>
>
> --
> -Regards,
> Mayuresh R. Gharat
> (862) 250-7125
>
--
Grant Henke
Software Engineer | Cloudera
gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
[
https://issues.apache.org/jira/browse/KAFKA-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-1991:
---
Resolution: Not A Problem
Status: Resolved (was: Patch Available)
> Clean ControllerSt
Grant Henke created KAFKA-2588:
--
Summary: ReplicaManager partitionCount metric should actually be
replicaCount
Key: KAFKA-2588
URL: https://issues.apache.org/jira/browse/KAFKA-2588
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on KAFKA-2588 started by Grant Henke.
--
> ReplicaManager partitionCount metric should actually be replicaCo
[
https://issues.apache.org/jira/browse/KAFKA-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2588:
---
Status: Patch Available (was: In Progress)
> ReplicaManager partitionCount metric should actua
[
https://issues.apache.org/jira/browse/KAFKA-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908701#comment-14908701
]
Grant Henke commented on KAFKA-2583:
I agree that we should be consistent and even potentially
as contributed numerous patches to Kafka. The most significant
> > one is the SSL support.
> >
> > Please join me on welcoming and congratulating Sriharsha.
> >
> > I look forward to your continued contributions and much more to come!
> >
> > Jun
> >
>
--
Grant Henke
Software Engineer | Cloudera
gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
[
https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741299#comment-14741299
]
Grant Henke commented on KAFKA-1929:
[~hachikuji], feel free to pick this up
> Convert core ka
[
https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741307#comment-14741307
]
Grant Henke commented on KAFKA-2229:
[~abiletskyi] Are you still working on this? If not, perhaps I
[
https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-1929:
---
Assignee: (was: Grant Henke)
> Convert core kafka module to use the err
new consumer was pretty much scoped
> > for
> > > > 0.9.0, so it matches our original roadmap. I feel that so many
> awesome
> > > > features deserve a better release number.
> > > >
> > > > The downside is mainly some confusion (we re
[
https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14704220#comment-14704220
]
Grant Henke commented on KAFKA-873:
---
Hi [~fpj], I would be happy to help get this in, any
:17 AM, Grant Henke ghe...@cloudera.com wrote:
+dev
Adding dev list back in. Somehow it got dropped.
On Mon, Aug 17, 2015 at 10:16 AM, Grant Henke ghe...@cloudera.com
wrote:
Below is a list of candidate bug fix jiras marked fixed for 0.8.3. I
don't
suspect all
+dev
Adding dev list back in. Somehow it got dropped.
On Mon, Aug 17, 2015 at 10:16 AM, Grant Henke ghe...@cloudera.com wrote:
Below is a list of candidate bug fix jiras marked fixed for 0.8.3. I don't
suspect all of these will (or should) make it into the release but this
should
an 0.8.2.2 release
just
to
fix this issue. Any objections?
Thanks,
Jun
--
Grant Henke
Software Engineer | Cloudera
gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
://reviews.apache.org/r/34766/#comment150325
This logic is fairly complex and difficult to track. I am not sure the best
way to resolve it. Breaking it into smaller functions may help.
- Grant Henke
On June 30, 2015, 1:59 p.m., Andrii Biletskyi wrote
--
Grant Henke
Software Engineer | Cloudera
gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
[
https://issues.apache.org/jira/browse/KAFKA-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke reassigned KAFKA-2244:
--
Assignee: Grant Henke
Document Kafka metrics configuration properties
[
https://issues.apache.org/jira/browse/KAFKA-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692400#comment-14692400
]
Grant Henke commented on KAFKA-2410:
Great! Though I am concerned it overlaps
[
https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681958#comment-14681958
]
Grant Henke commented on KAFKA-2336:
Updated reviewboard https://reviews.apache.org/r
/OffsetManager.scala
47b6ce93da320a565435b4a7916a0c4371143b8a
Diff: https://reviews.apache.org/r/36548/diff/
Testing
---
Thanks,
Grant Henke
[
https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2336:
---
Attachment: KAFKA-2336_2015-08-11_10:37:41.patch
Changing offsets.topic.num.partitions after
.
-- Guozhang
--
Grant Henke
Software Engineer | Cloudera
gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
.
Best,
Ismael
--
Regards,
Ashish
--
Grant Henke
Software Engineer | Cloudera
gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
with CreateTopic, then DeleteTopic,
then AlterTopic may makes sense. If you disagree feel free to say so and I will
review this patch as is.
- Grant Henke
On June 30, 2015, 1:59 p.m., Andrii Biletskyi wrote:
---
This is an automatically
On Aug. 10, 2015, 3:47 p.m., Grant Henke wrote:
My apologies for not looking at this sooner, or suggesting this sooner.
Given that this code change and scope is fairly large, would it be too much
work to break out the patches reviews by each new protocol message? Then
reviews can
)
https://reviews.apache.org/r/34766/#comment149361
A lot of this code/functionality exists in kafka.admin.TopicCommand. Is
this duplicating a lot of code/functionality? Could they both be refactored to
use the same core code?
- Grant Henke
On June 30, 2015, 1:59 p.m., Andrii Biletskyi
/common/InvalidTopicConfigurationException.scala (line
22)
https://reviews.apache.org/r/34766/#comment149359
Is this needed? Should we always pass some message? (Same for the other
exceptions added?
- Grant Henke
On June 30, 2015, 1:59 p.m., Andrii Biletskyi wrote
try that out.
Thoughts?
--
-- Guozhang
--
Grant Henke
Software Engineer | Cloudera
gr...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
Grant Henke created KAFKA-2407:
--
Summary: Only create a log directory when it will be used
Key: KAFKA-2407
URL: https://issues.apache.org/jira/browse/KAFKA-2407
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2407:
---
Status: Patch Available (was: Open)
Only create a log directory when it will be used
on every
ConsumerMetadataRequest handling, so some kind of caching will be nice.
Grant Henke wrote:
We only talk to Zookeeper once at instance creation via the call to
`getOffsetsTopicPartitionCount` and setting the val
`offsetsTopicPartitionCount`. The static value is used from
[
https://issues.apache.org/jira/browse/KAFKA-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2393:
---
Fix Version/s: 0.8.3
Status: Patch Available (was: Open)
Correctly Handle
Grant Henke created KAFKA-2410:
--
Summary: Implement Auto Topic Creation client side and remove
support from Broker side
Key: KAFKA-2410
URL: https://issues.apache.org/jira/browse/KAFKA-2410
Project
[
https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653949#comment-14653949
]
Grant Henke commented on KAFKA-2285:
Thanks for all the related Jiras and input
[
https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke reassigned KAFKA-2285:
--
Assignee: Grant Henke
Logging trait obfuscates call site information
[
https://issues.apache.org/jira/browse/KAFKA-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649472#comment-14649472
]
Grant Henke commented on KAFKA-2111:
Should we consider also adding a --version option
[
https://issues.apache.org/jira/browse/KAFKA-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649438#comment-14649438
]
Grant Henke commented on KAFKA-2393:
Makes this scenario more likely to occur
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649427#comment-14649427
]
Grant Henke commented on KAFKA-2337:
Since this is already committed, lets create
Grant Henke created KAFKA-2393:
--
Summary: Correctly Handle InvalidTopicException in
KafkaApis.getTopicMetadata()
Key: KAFKA-2393
URL: https://issues.apache.org/jira/browse/KAFKA-2393
Project: Kafka
, 2015 at 1:22 PM, Grant Henke
ghe...@cloudera.com
wrote:
Found it was added here:
https://issues.apache.org/jira/browse/KAFKA-697
On Fri, Jul 10, 2015 at 3:18 PM, Todd Palino
tpal...@gmail.com
wrote:
This was definitely changed at some point after KAFKA-495.
The
question
like
setting the log.retention.ms = 1 and log.retention.hours = 1.
--
-Regards,
Mayuresh R. Gharat
(862) 250-7125
--
-Regards,
Mayuresh R. Gharat
(862) 250-7125
--
Grant Henke
Solutions Consultant | Cloudera
ghe...@cloudera.com | twitter.com/gchenke
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36670/#review92743
---
Ship it!
Ship It!
- Grant Henke
On July 23, 2015, 1:23 a.m
On July 22, 2015, 10:29 a.m., Ismael Juma wrote:
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala, line 269
https://reviews.apache.org/r/36670/diff/1/?file=1018343#file1018343line269
Should `verifyTopicDeletion` be inside `finally`? I don't think so
because you don't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35734/#review92416
---
Ship it!
Ship It!
- Grant Henke
On June 22, 2015, 5:35 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36341/#review92417
---
Ship it!
Ship It!
- Grant Henke
On July 9, 2015, 1:04 a.m., Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36565/#review92422
---
Ship it!
Ship It!
- Grant Henke
On July 17, 2015, 5:21 p.m
---
On July 16, 2015, 6:04 p.m., Grant Henke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36548
://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
--
Ashish h
--
Thanks,
Neha
--
Grant Henke
Solutions Consultant | Cloudera
ghe...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
)
https://reviews.apache.org/r/36652/#comment146669
What errors were seen that should be caught here? Can we catch a more
specific exception and provide a better message?
- Grant Henke
On July 21, 2015, 8:11 p.m., Mayuresh Gharat wrote
On July 21, 2015, 8:26 p.m., Grant Henke wrote:
core/src/main/scala/kafka/network/SocketServer.scala, line 266
https://reviews.apache.org/r/36652/diff/1/?file=1018073#file1018073line266
What errors were seen that should be caught here? Can we catch a more
specific exception
/scala/unit/kafka/common/TopicTest.scala
79532c89c41572ba953c4dc3319a05354927e961
Diff: https://reviews.apache.org/r/36570/diff/
Testing
---
Thanks,
Grant Henke
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Attachment: KAFKA-2337_2015-07-20_12:36:41.patch
Verify that metric names will not collide when
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633880#comment-14633880
]
Grant Henke commented on KAFKA-2337:
Updated reviewboard https://reviews.apache.org/r
in a way that would make it clear what the
issue is. That may be complicated, so we should at least document it as you
suggest.
I'll let you know if the issues goes away for me too with this change.
Best,
Ismael
On Sun, Jul 19, 2015 at 4:24 PM, Grant Henke ghe...@cloudera.com wrote:
When
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92327
---
Ship it!
Ship It!
- Grant Henke
On July 20, 2015, 9:48 p.m
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634136#comment-14634136
]
Grant Henke commented on KAFKA-2337:
Updated reviewboard https://reviews.apache.org/r
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Attachment: KAFKA-2337_2015-07-20_16:48:25.patch
Verify that metric names will not collide when
/scala/unit/kafka/common/TopicTest.scala
79532c89c41572ba953c4dc3319a05354927e961
Diff: https://reviews.apache.org/r/36570/diff/
Testing
---
Thanks,
Grant Henke
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available
When running all Kafka tests I had been getting failures most every time.
Usually in the SocketServerTest class. However, when I would run individual
tests, there were no failures. After a bit of digging I found this is due
to the small default open files limit in Mac Yosemite. I am positing how
to `partitionFor`.
- Grant
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36548/#review92020
---
On July 16, 2015, 6:04 p.m., Grant Henke wrote
--
Ashish h
--
Grant Henke
Solutions Consultant | Cloudera
ghe...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke
79532c89c41572ba953c4dc3319a05354927e961
Diff: https://reviews.apache.org/r/36570/diff/
Testing
---
Thanks,
Grant Henke
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631468#comment-14631468
]
Grant Henke commented on KAFKA-2337:
Created reviewboard https://reviews.apache.org/r
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Status: Patch Available (was: In Progress)
Verify that metric names will not collide when creating
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Attachment: KAFKA-2337.patch
Verify that metric names will not collide when creating new topics
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631474#comment-14631474
]
Grant Henke commented on KAFKA-2337:
This patch:
- Checks all topic creation including
/scala/unit/kafka/common/TopicTest.scala
79532c89c41572ba953c4dc3319a05354927e961
Diff: https://reviews.apache.org/r/36570/diff/
Testing
---
Thanks,
Grant Henke
of a sustantive.
Grant Henke wrote:
I had a hard time naming this. Collide, to me, sounded like an action
that should return a result. Like I was taking two topics and smashing them
together in order to get something new.
Edward Ribeiro wrote:
Yeah, totally agree with you. Maybe
generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/#review92089
---
On July 17, 2015, 3:27 p.m., Grant Henke wrote:
---
This is an automatically generated e-mail
on every
ConsumerMetadataRequest handling, so some kind of caching will be nice.
Grant Henke wrote:
We only talk to Zookeeper once at instance creation via the call to
`getOffsetsTopicPartitionCount` and setting the val
`offsetsTopicPartitionCount`. The static value is used from
p.m., Grant Henke wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36570/
---
(Updated July 17, 2015, 3:27 p.m.)
Review
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631525#comment-14631525
]
Grant Henke commented on KAFKA-2337:
Updated reviewboard https://reviews.apache.org/r
[
https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2337:
---
Attachment: KAFKA-2337_2015-07-17_11:17:30.patch
Verify that metric names will not collide when
open to alternatives but mention Gitter because:
- It's directly associated with the repository
- Strong Github integration
- Very accessible (No application install required)
- Nearly everyone already has a Github account
- ... I am sure there is more.
--
Grant Henke
Solutions
/browse/KAFKA-2336
Repository: kafka
Description
---
Fix whitespace
Diffs
-
core/src/main/scala/kafka/server/OffsetManager.scala
47b6ce93da320a565435b4a7916a0c4371143b8a
Diff: https://reviews.apache.org/r/36549/diff/
Testing
---
Thanks,
Grant Henke
[
https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630087#comment-14630087
]
Grant Henke commented on KAFKA-2336:
Created reviewboard https://reviews.apache.org/r
[
https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-2336:
---
Attachment: KAFKA-2336.patch
Changing offsets.topic.num.partitions after the offset topic is created
601 - 700 of 753 matches
Mail list logo
