Re: Review Request 36548: Patch for KAFKA-2336

2015-07-16 Thread Grant Henke
the former. For this reason, I think it would be nice to put a space between if and parenthesis, and maybe we should open a ticket to define and uniform the coding style of the project (if one doesn't exists already). Grant Henke wrote: There is a coding guide here: http://kafka.apache.org

[jira] [Updated] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

2015-07-16 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2336: --- Attachment: KAFKA-2336_2015-07-16_13:04:02.patch Changing offsets.topic.num.partitions after

[jira] [Updated] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

2015-07-16 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2336: --- Status: Patch Available (was: In Progress) Changing offsets.topic.num.partitions after the offset

[jira] [Commented] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

2015-07-16 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629815#comment-14629815 ] Grant Henke commented on KAFKA-2336: Created reviewboard https://reviews.apache.org/r

[jira] [Updated] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

2015-07-16 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2336: --- Attachment: KAFKA-2336.patch Changing offsets.topic.num.partitions after the offset topic is created

Review Request 36548: Patch for KAFKA-2336

2015-07-16 Thread Grant Henke
Diff: https://reviews.apache.org/r/36548/diff/ Testing --- Thanks, Grant Henke

Re: Review Request 36548: Patch for KAFKA-2336

2015-07-16 Thread Grant Henke
--- On July 16, 2015, 2:33 p.m., Grant Henke wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36548

Re: Review Request 36548: Patch for KAFKA-2336

2015-07-16 Thread Grant Henke
the former. For this reason, I think it would be nice to put a space between if and parenthesis, and maybe we should open a ticket to define and uniform the coding style of the project (if one doesn't exists already). Grant Henke wrote: There is a coding guide here: http://kafka.apache.org

[jira] [Commented] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

2015-07-16 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630094#comment-14630094 ] Grant Henke commented on KAFKA-2336: Updated reviewboard https://reviews.apache.org/r

Re: Review Request 36548: Patch for KAFKA-2336

2015-07-16 Thread Grant Henke
/ Testing --- Thanks, Grant Henke

[jira] [Work started] (KAFKA-2337) Verify that metric names will not collide when creating new topics

2015-07-16 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2337 started by Grant Henke. -- Verify that metric names will not collide when creating new topics

[jira] [Work started] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

2015-07-15 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2336 started by Grant Henke. -- Changing offsets.topic.num.partitions after the offset topic is created breaks

[jira] [Assigned] (KAFKA-2333) Add rename topic support

2015-07-15 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-2333: -- Assignee: Grant Henke Add rename topic support

[jira] [Commented] (KAFKA-2333) Add rename topic support

2015-07-15 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14628898#comment-14628898 ] Grant Henke commented on KAFKA-2333: I am thinking the expected behavior

[jira] [Created] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

2015-07-15 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-2336: -- Summary: Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment Key: KAFKA-2336 URL: https://issues.apache.org/jira

[jira] [Created] (KAFKA-2333) Add rename topic support

2015-07-13 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-2333: -- Summary: Add rename topic support Key: KAFKA-2333 URL: https://issues.apache.org/jira/browse/KAFKA-2333 Project: Kafka Issue Type: New Feature

Re: [Discussion] Limitations on topic names

2015-07-10 Thread Grant Henke
. With that said, I am sure they'd transition accordingly. If anyone has better backward-compatible solutions to this, I'm all ears :) Gwen -- Grant Henke Solutions Consultant | Cloudera ghe...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke

Re: [Discussion] Limitations on topic names

2015-07-10 Thread Grant Henke
if someone has a good idea for #3 it will be even better. Gwen On Fri, Jul 10, 2015 at 1:22 PM, Grant Henke ghe...@cloudera.com wrote: Found it was added here: https://issues.apache.org/jira/browse/KAFKA-697 On Fri, Jul 10, 2015 at 3:18 PM, Todd Palino tpal...@gmail.com

Re: [Discussion] Limitations on topic names

2015-07-10 Thread Grant Henke
On Fri, Jul 10, 2015 at 1:02 PM, Grant Henke ghe...@cloudera.com wrote: kafka.common.Topic shows that currently period is a valid character and I have verified I can use kafka-topics.sh to create a new topic with a period. AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK

Re: Dropping support for Scala 2.9.x

2015-07-08 Thread Grant Henke
think it would not be unreasonable to drop support for Scala 2.9.x in a future release, but I may be missing something. What do others think? Ismael -- Grant Henke Solutions Consultant | Cloudera ghe...@cloudera.com | twitter.com/gchenke | linkedin.com/in/granthenke

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-06-24 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-972: -- Attachment: BrokerMetadataTest.scala Sample Failing Tests: - testBrokerMetadataOnClusterWithNoTopics

[jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site information

2015-06-18 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14591990#comment-14591990 ] Grant Henke commented on KAFKA-2285: It looks like it's where the call to _logger

[jira] [Commented] (KAFKA-2285) Logging trait obfuscates call site information

2015-06-18 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14592415#comment-14592415 ] Grant Henke commented on KAFKA-2285: I agree. My suggestion was a way to move the call

Re: Kafka server validating incoming messages

2015-05-25 Thread Grant Henke
Bumping this message again to get some input before opening a Jira. On Thu, May 21, 2015 at 11:31 AM, Grant Henke ghe...@cloudera.com wrote: When working on my own implementation of the wire protocol, via a copy and paste error, I accidentally sent an OffsetCommit message

[jira] [Created] (KAFKA-2216) ConsumerMetadataRequest does not validate consumer group exists

2015-05-21 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-2216: -- Summary: ConsumerMetadataRequest does not validate consumer group exists Key: KAFKA-2216 URL: https://issues.apache.org/jira/browse/KAFKA-2216 Project: Kafka

Find all consumer groups without Zookeeper

2015-05-21 Thread Grant Henke
consumer group instead of joining an existing one. Note: I just made Jira KAFKA-2216 https://issues.apache.org/jira/browse/KAFKA-2216, which is somewhat related to this discussion. Thank you, Grant -- Grant Henke Solutions Consultant | Cloudera ghe...@cloudera.com | twitter.com/ghenke http

Kafka server validating incoming messages

2015-05-21 Thread Grant Henke
when parsing all messages? If so I can open a Jira. Thank you, Grant -- Grant Henke Solutions Consultant | Cloudera ghe...@cloudera.com | twitter.com/ghenke http://twitter.com/gchenke | linkedin.com/in/granthenke

[jira] [Commented] (KAFKA-2076) Add an API to new consumer to allow user get high watermark of partitions.

2015-03-31 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14388947#comment-14388947 ] Grant Henke commented on KAFKA-2076: This functionality and the edge cases

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-25 Thread Grant Henke
/apache/kafka/clients/producer/internals/SenderTest.java 24274a64885fadd0e9318de2beb232218ddd52cd Diff: https://reviews.apache.org/r/32440/diff/ Testing --- Thanks, Grant Henke

[jira] [Updated] (KAFKA-2043) CompressionType is passed in each RecordAccumulator append

2015-03-25 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2043: --- Attachment: KAFKA-2043_2015-03-25_13:28:52.patch CompressionType is passed in each RecordAccumulator

[jira] [Commented] (KAFKA-2043) CompressionType is passed in each RecordAccumulator append

2015-03-25 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380433#comment-14380433 ] Grant Henke commented on KAFKA-2043: Updated reviewboard https://reviews.apache.org/r

[jira] [Created] (KAFKA-2043) CompressionType is passed in each RecordAccumulator append

2015-03-24 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-2043: -- Summary: CompressionType is passed in each RecordAccumulator append Key: KAFKA-2043 URL: https://issues.apache.org/jira/browse/KAFKA-2043 Project: Kafka Issue

Review Request 32440: Patch for KAFKA-2043

2015-03-24 Thread Grant Henke
/SenderTest.java 24274a64885fadd0e9318de2beb232218ddd52cd Diff: https://reviews.apache.org/r/32440/diff/ Testing --- Thanks, Grant Henke

[jira] [Commented] (KAFKA-2043) CompressionType is passed in each RecordAccumulator append

2015-03-24 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378046#comment-14378046 ] Grant Henke commented on KAFKA-2043: Created reviewboard https://reviews.apache.org/r

[jira] [Updated] (KAFKA-2043) CompressionType is passed in each RecordAccumulator append

2015-03-24 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2043: --- Status: Patch Available (was: Open) CompressionType is passed in each RecordAccumulator append

[jira] [Updated] (KAFKA-2043) CompressionType is passed in each RecordAccumulator append

2015-03-24 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-2043: --- Attachment: KAFKA-2043.patch CompressionType is passed in each RecordAccumulator append

Re: New Producer Questions/Feedback

2015-03-24 Thread Grant Henke
/javadoc/index.html?org/apache/kafka/clients/producer/KafkaProducer.html Thanks, Jun On Mon, Mar 23, 2015 at 9:23 PM, Grant Henke ghe...@cloudera.com wrote: Thanks for validating that. I was thinking of solving it in the same fashion. Though I was unsure if there was/would be a use case

[DISCUSS] KIP-17 - Add HighwaterMarkOffset to OffsetFetchResponse

2015-03-24 Thread Grant Henke
-- Grant Henke Solutions Consultant | Cloudera ghe...@cloudera.com | 920-980-8979 twitter.com/ghenke http://twitter.com/gchenke | linkedin.com/in/granthenke

[jira] [Assigned] (KAFKA-1973) Remove the accidentally created LogCleanerManager.scala.orig

2015-03-24 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-1973: -- Assignee: Grant Henke Remove the accidentally created LogCleanerManager.scala.orig

[jira] [Assigned] (KAFKA-1991) Clean ControllerStats initialization

2015-03-24 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-1991: -- Assignee: Grant Henke Clean ControllerStats initialization

Re: Review Request 32440: Patch for KAFKA-2043

2015-03-24 Thread Grant Henke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32440/#review77593 --- On March 24, 2015, 3:51 p.m., Grant Henke wrote

New Producer Questions/Feedback

2015-03-23 Thread Grant Henke
byte[] serialize(String topic, T data); Thank you, Grant -- Grant Henke Solutions Consultant | Cloudera ghe...@cloudera.com | 920-980-8979 twitter.com/ghenke http://twitter.com/gchenke | linkedin.com/in/granthenke

Re: New Producer Questions/Feedback

2015-03-23 Thread Grant Henke
of passing it in for each append, we probably should just pass it in once during the creation RecordAccumulator. Could you file a jira to track this? Thanks, Jun On Mon, Mar 23, 2015 at 7:16 PM, Grant Henke ghe...@cloudera.com wrote: I am reading over the new producer code in an effort

[jira] [Commented] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-03-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375366#comment-14375366 ] Grant Henke commented on KAFKA-873: --- Is changing over to Curator something that still

[jira] [Assigned] (KAFKA-873) Consider replacing zkclient with curator (with zkclient-bridge)

2015-03-22 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke reassigned KAFKA-873: - Assignee: Grant Henke Consider replacing zkclient with curator (with zkclient-bridge

Re: Can I be added as a contributor?

2015-03-10 Thread Grant Henke
- - - - - - - - - - - - - - - - - http://www.stealth.ly - - - - - - - - - - - - - - - - - On Tue, Mar 10, 2015 at 12:54 AM, Grant Henke ghe...@cloudera.com wrote: I am also starting to work with the Kafka codebase with plans to contribute more significantly in the near future. Could I also

Re: Can I be added as a contributor?

2015-03-09 Thread Grant Henke
with a view to eventually making substantial contributions. Could you please add me as a contributor to the Kafka JIRA so that I can assign myself a newbie ticket? Thanks! Grayson -- Grayson Chao Data Infra Streaming SRE -- -- Guozhang -- Grant Henke Solutions Consultant

[jira] [Commented] (KAFKA-902) Randomize backoff on the clients for metadata requests

2015-03-02 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14344463#comment-14344463 ] Grant Henke commented on KAFKA-902: --- A few thoughts on the patch: Should the jitter

[jira] [Updated] (KAFKA-1973) Remove the accidentally created LogCleanerManager.scala.orig

2015-03-02 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1973: --- Attachment: KAFKA-1973.patch Remove the accidentally created LogCleanerManager.scala.orig

[jira] [Updated] (KAFKA-1973) Remove the accidentally created LogCleanerManager.scala.orig

2015-03-02 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1973: --- Status: Patch Available (was: Open) Removes core/src/main/scala/kafka/log

[jira] [Updated] (KAFKA-1991) Clean ControllerStats initialization

2015-02-28 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1991: --- Status: Patch Available (was: Open) Clean ControllerStats initialization

[jira] [Created] (KAFKA-1991) Clean ControllerStats initialization

2015-02-28 Thread Grant Henke (JIRA)
Grant Henke created KAFKA-1991: -- Summary: Clean ControllerStats initialization Key: KAFKA-1991 URL: https://issues.apache.org/jira/browse/KAFKA-1991 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-1991) Clean ControllerStats initialization

2015-02-28 Thread Grant Henke (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grant Henke updated KAFKA-1991: --- Attachment: KAFKA-1991.patch Clean ControllerStats initialization

<    3   4   5   6   7   8