Re: [DISCUSS] KIP-450: Sliding Window Aggregations in the DSL

2019-09-04 Thread Guozhang Wang
exactly, and why using this extractor would not > meet the requirements for processing-time sliding windows? > > > -Matthias > > > On 4/16/19 10:16 AM, Guozhang Wang wrote: > > Regarding 4): yes I agree with you that invertibility is not a common > > property for agg

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-09-04 Thread Guozhang Wang
on-logged > stateful tasks, as well as stateless tasks when it doesn't change the > balance at all to do so. It seems like this should accomplish the same > spiritual goal with no special cases. > > WDYT? > -John > > On Wed, Sep 4, 2019 at 2:26 PM Guozhang Wang wrote:

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-09-04 Thread Guozhang Wang
7;ll "try to" produce > > stable > > > assignments, so I've added a "should" clause to the assignment spec: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-441%3A+Smooth+Scaling+Out+for+Kafka+Streams#KIP-441:SmoothScaling

Re: [VOTE] KIP-401: TransformerSupplier/ProcessorSupplier StateStore connecting

2019-09-03 Thread Guozhang Wang
IP for clarity. > > > On Sep 3, 2019, at 5:04 PM, Matthias J. Sax > wrote: > > > > I am strongly in favor of "must be the same reference". > > > > > > -Matthias > > > >> On 9/3/19 2:09 PM, Guozhang Wang wrote: > >> Hi Paul,

Re: [VOTE] KIP-401: TransformerSupplier/ProcessorSupplier StateStore connecting

2019-09-03 Thread Guozhang Wang
Hi Paul, Thanks for the KIP! +1 (binding). One minor comment about the following: "In order to solve the problem of addStateStore potentially being called twice for the same store (because more than one Supplier specifies it), the check for duplicate stores in addStateStores will be relaxed to *

[jira] [Created] (KAFKA-8854) Optimize bulk loading of RocksDB during state restoration of Streams

2019-09-01 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-8854: Summary: Optimize bulk loading of RocksDB during state restoration of Streams Key: KAFKA-8854 URL: https://issues.apache.org/jira/browse/KAFKA-8854 Project: Kafka

Re: Permissions to create a KIP for KAFKA-8843

2019-08-29 Thread Guozhang Wang
Hello Pere, Thanks for you interest in contributing to Kafka, I've added you to the contributors list and you should be able to create wiki pages now. BTW there's an on-going KIP-500 which aims at removing ZK dependency of Kafka recently; depending when it would be voted and be adopted, I think i

Re: server-side message filter

2019-08-28 Thread Guozhang Wang
The reduction on network cost is a valid point: letting the consumer to do the filtering would waste the network bandwidth as many bytes would be dropped on the floor directly afterwards. But note that letting brokers to filter on fetch response means that we cannot use nio zero-copy as we need to

Re: [DISCUSS] KIP-360: Improve handling of unknown producer

2019-08-27 Thread Guozhang Wang
ror is when the producer has been > fenced by another instance. > > Thanks, > Jason > > On Mon, Aug 26, 2019 at 6:05 PM Guozhang Wang wrote: > > > Hi Jason, > > > > I've made another pass on the wiki page and it reads much better now. One > > more clari

Re: [DISCUSS] KIP-360: Improve handling of unknown producer

2019-08-26 Thread Guozhang Wang
rote: > >>> Hi Everyone, > >>> > >>> Sorry for the long delay on this KIP. I have updated it to include the > >>> handling of INVALID_PRODUCER_ID_MAPPING as suggested above. If there are > >> no > >>> further comments, I will plan

[jira] [Resolved] (KAFKA-8412) Still a nullpointer exception thrown on shutdown while flushing before closing producers

2019-08-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8412. -- Resolution: Fixed > Still a nullpointer exception thrown on shutdown while flushing bef

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-08-21 Thread Guozhang Wang
ross the cluster. > > > > It's worth noting that such an assignment would still not be considered > > "balanced", so the ultimately balanced final state of the assignment > (after > > task movements) would still have the desired property that eac

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-08-21 Thread Guozhang Wang
property that each stateful > and stateless task is evenly spread across the cluster. > > Does that seem reasonable? > > Thanks, > -John > > On Wed, Aug 21, 2019 at 11:22 AM Guozhang Wang wrote: > > > Hello John, > > > > I've made another pass on t

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-08-21 Thread Guozhang Wang
y, but > >> after working though some details, I think it causes some problems, > which > >> I've written up in the "rejected alternatives" part of the KIP: > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-441%3A+Smooth+Scaling+Out+for+Kafka+Streams#KIP

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-08-21 Thread Guozhang Wang
KA/KIP-441%3A+Smooth+Scaling+Out+for+Kafka+Streams#KIP-441:SmoothScalingOutforKafkaStreams-Addinganewkindoftask(%22moving%22,%22recovering%22,%22learner%22)fortaskmovements > > Please give it a read and let me know what you think. > > Thanks, > -John > > On Thu, Aug 8, 2019 at

[VOTE] KIP-444: Refactor and Augment Metrics for Kafka Streams

2019-08-20 Thread Guozhang Wang
Hello folks, I'd like to start a voting thread the following KIP to improve the Kafka Streams metrics mechanism to users. This includes 1) renaming changes in the public StreamsMetrics utils API, and 2) a major cleanup on the Streams' own built-in metrics hierarchy. Details can be found here: ht

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-08-20 Thread Guozhang Wang
ipped-records", and "expired-window-records-drop". 3. renamed the util functions of StreamsMetrics as `addLatencyRateTotal` and `addRateTotal` sensors. Since I feel it has incorporated all of your comments I'm going to start the vote thread for this KIP now. Guozhang On Tue, Au

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-08-20 Thread Guozhang Wang
rs to record invocations but none to > record amounts. Is that intentional? No need to add it to this KIP, I > am just curious. > > Best, > Bruno > > On Tue, Aug 20, 2019 at 1:13 AM Guozhang Wang wrote: > > > > Hi Bruno, > > > > Just realized that for `

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-08-19 Thread Guozhang Wang
Hi Bruno, Just realized that for `addRateSensor` and `addLatencyAndRateSensor` we've actually added the total invocation metric already. Guozhang On Mon, Aug 19, 2019 at 4:11 PM Guozhang Wang wrote: > Hi Bruno, > > > On Tue, Aug 6, 2019 at 1:51 AM Bruno Cadonna wrote:

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-08-19 Thread Guozhang Wang
Hi Bruno, On Tue, Aug 6, 2019 at 1:51 AM Bruno Cadonna wrote: > Hi Guozhang, > > I left my comments inline. > > On Thu, Jul 18, 2019 at 8:28 PM Guozhang Wang wrote: > > > > Hello Bruno, > > > > Thanks for the feedbacks, replied inline. > > >

Re: [VOTE] KIP-396: Add Commit/List Offsets Operations to AdminClient

2019-08-15 Thread Guozhang Wang
g the effort! > > > > > > > > 2019년 8월 14일 (수) 오후 8:49, Mickael Maison >님이 > > > 작성: > > > > > > > > Hi Guozhang, > > > > > > > > Thanks for taking a look. > > > > > > > > 1. Right, I updated the

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-08-14 Thread Guozhang Wang
listener is to consolidate the entry point of consumer internal > > states. Compared with letting consumer generate a deep-copy of metadata > > every time we call #sendOffsetsToTransactions, using a callback seems > > reducing unnecessary updates towards the metadata. WDY

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-08-13 Thread Guozhang Wang
but non-stream user has to code the callback by hand, do you think > > the > > > > > convenience we sacrifice here worth the simplification benefit? > > > > > > > > > > > > > > > > 3. Can you clarify the behavi

Re: [VOTE] KIP-497: Add inter-broker API to alter ISR

2019-08-13 Thread Guozhang Wang
+1 (binding). This is a great KIP, thanks Jason! Regarding the naming of the zkVersion, I'm actually fine to name it more generally and leave a note that at the moment its value is defined as the zk version. Guozhang On Mon, Aug 12, 2019 at 2:22 PM Jason Gustafson wrote: > Hi Viktor, > > I o

Re: [VOTE] KIP-396: Add Commit/List Offsets Operations to AdminClient

2019-08-13 Thread Guozhang Wang
Hi Mickael, Thanks for the KIP! Just some minor comments. 1. Java class names are stale, e.g. "CommitOffsetsOptions.java" should be "AlterOffsetsOptions". 2. I'd suggest we change the future structure of "AlterOffsetsResult" to *KafkaFuture>>* This is because we will have a hierarchy of two-l

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-12 Thread Guozhang Wang
+1 (binding). Thanks Jason! On Wed, Aug 7, 2019 at 11:18 AM Jason Gustafson wrote: > Hi All, > > I'd like to start a vote on KIP-496: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-496%3A+Administrative+API+to+delete+consumer+offsets > . > +1 > from me of course. > > -Jason > -- -

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-08-08 Thread Guozhang Wang
an for updating standbys, for example in how > > long we block on #poll. > > So in addition to giving them their own name -- let's go with restoring > > task for now -- they really > > do seem to deserve being their own distinct task. We can optimize them > for > > efficie

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-08-08 Thread Guozhang Wang
assigned to the same > instance they had run before the rebalance. As far as I can see this > special case is not handled in the algorithm. > > Best, > Bruno > > > > On Thu, Aug 8, 2019 at 8:24 AM Guozhang Wang wrote: > > > > 1. Sounds good, just wanted to c

[jira] [Resolved] (KAFKA-4600) Consumer proceeds on when ConsumerRebalanceListener fails

2019-08-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-4600. -- Resolution: Fixed > Consumer proceeds on when ConsumerRebalanceListener fa

[jira] [Resolved] (KAFKA-8493) Add PartitionsLost API in RebalanceListener (part 3)

2019-08-08 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8493. -- Resolution: Fixed Fix Version/s: 2.4.0 > Add PartitionsLost API in RebalanceListe

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-08-07 Thread Guozhang Wang
task lag. Hence, during the window > between when the instance reports a lag and the assignor makes a decision > about it, the instance should remain in REBALANCING state, right? If so, > then this should prevent the race condition. If not, then we do indeed need > to do something about

Re: [DISCUSS] KIP-441: Smooth Scaling Out for Kafka Streams

2019-08-06 Thread Guozhang Wang
Hello Sophie, Thanks for the proposed KIP. I left some comments on the wiki itself, and I think I'm still not very clear on a couple or those: 1. With this proposal, does that mean with num.standby.replicas == 0, we may sometimes still have some standby tasks which may violate the config? 2. I t

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-08-05 Thread Guozhang Wang
nstead > of passing in the consumer instance? > > Boyang > > On Fri, Aug 2, 2019 at 4:36 PM Guozhang Wang wrote: > > > Thanks Boyang, > > > > I've made another pass on KIP-447 as well as > > https://github.com/apache/kafka/pull/7078, and have some min

Re: [VOTE] KIP-429: Kafka Consumer Incremental Rebalance Protocol

2019-08-05 Thread Guozhang Wang
like to tack on some rebalance-related metrics as part of this > > KIP > > > as well. The details can be found in the sub-task JIRA: > > > https://issues.apache.org/jira/browse/KAFKA-8609 > > > > > > On Thu, May 30, 2019 at 5:09 PM Guozhang Wang > > wrot

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-08-02 Thread Guozhang Wang
in each release to > add a new accepted value? > > > -Matthias > > On 8/2/19 1:07 PM, Guozhang Wang wrote: > > Hello Matthias, > > > > That's a good question. Thinking about a bit more, I'd like to propose > that > > we just list all the version n

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-08-02 Thread Guozhang Wang
ing such information on the assignor anyways. Guozhang On Tue, Jul 30, 2019 at 1:55 PM Boyang Chen wrote: > Thank you Guozhang for the reply. We will consider the interface change > from 429 as a backup plan for 447. > > And bumping this thread for more discussion. > > On Mon,

Re: Add to the contributor list

2019-08-02 Thread Guozhang Wang
Hi Vinoth, You've been added to the list, cheers! Guozhang On Fri, Aug 2, 2019 at 2:50 PM Vinoth Chandar wrote: > I am interested in picking up KAFKA-7149 > Can I be added to the list? My jira id : vinoth > -- -- Guozhang

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-08-02 Thread Guozhang Wang
ce, we might want to rename it to "newest" / > "current" or something like this? > > Another alternative may be to rename it to "since-2.3" (or similar) -- > however, this may require to rename the config if we change metrics in a > future release (hence, it&#

Re: [VOTE] KIP-467: Augment ProduceResponse error messaging

2019-08-02 Thread Guozhang Wang
h the newly added metrics. Guozhang On Mon, Jul 29, 2019 at 9:31 AM Guozhang Wang wrote: > +1 from myself as well (binding). > > > I'm closing this vote thread with the following votes: > > binding +1s: 4 (Guozhang, Jun, Jason, Bill). > > > Thanks everyone

Re: Request to be added as a contributor

2019-07-31 Thread Guozhang Wang
Hello, I've added you as a contributor to Kafka. Cheers, Guozhang On Wed, Jul 31, 2019 at 5:31 PM Tharindu Amila < tharindu.am...@instaclustr.com> wrote: > Hi Team, > > Request you to add me to the contributor list. Jira username : tharindu > > Thanks and Regards, > > > *Tharindu Amila**Softwa

[jira] [Resolved] (KAFKA-8704) Add PartitionAssignor adapter for backwards compatibility

2019-07-31 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8704. -- Resolution: Fixed Fix Version/s: 2.4.0 > Add PartitionAssignor adapter for backwa

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

2019-07-31 Thread Guozhang Wang
display/KAFKA/KIP-221:+Enhance+DSL+with+Connecting+Topic+Creation+and+Repartition+Hint > > > Please let me know if you have any other questions and/or concerns. > > Regards, > Levani > > > On Jul 31, 2019, at 1:24 AM, Guozhang Wang wrote: > > > > Hello Levani, > &

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

2019-07-30 Thread Guozhang Wang
Hello Levani, Thanks for the KIP! Just got a quick question here about the scope: why do we only want this for `KStream`, not `KTable#groupBy` for example? Guozhang On Tue, Jul 30, 2019 at 1:27 PM Bill Bejeck wrote: > Thanks for the KIP Levani. > > +1 (binding) > > -Bill > > On Tue, Jul 30,

Re: [DISCUSS] KIP-496: Administrative API to delete consumer offsets

2019-07-29 Thread Guozhang Wang
her comments. > > Thanks, > Jason > > On Mon, Jul 29, 2019 at 9:10 AM Guozhang Wang wrote: > > > Thanks for the replies Jason! > > > > 2. No I do not see any problems, just trying to understand how restrict > we > > are applying this rule :) Piggy-backi

Re: [VOTE] KIP-479 Add Materialized to Join

2019-07-29 Thread Guozhang Wang
+1 (binding) On Thu, Jul 25, 2019 at 7:39 PM Matthias J. Sax wrote: > +1 (binding) > > On 7/25/19 1:05 PM, Bill Bejeck wrote: > > All, > > > > After a great discussion on KIP-479 ( > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-479%3A+Add+Materialized+to+Join > ) > > I'd > > like to

Re: [DISCUSS] KIP-497: Add inter-broker API to alter ISR

2019-07-29 Thread Guozhang Wang
ge which may no longer be relevant. This is the > approach that I modeled. That being said, if it's ok with you, I'd prefer > to leave this decision to the implementation. I think the main point is > that once the leader receives the latest update, it can discard any pending > s

[jira] [Created] (KAFKA-8729) Augment ProduceResponse error messaging for specific culprit records

2019-07-29 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-8729: Summary: Augment ProduceResponse error messaging for specific culprit records Key: KAFKA-8729 URL: https://issues.apache.org/jira/browse/KAFKA-8729 Project: Kafka

Re: [VOTE] KIP-467: Augment ProduceResponse error messaging

2019-07-29 Thread Guozhang Wang
+1 from myself as well (binding). I'm closing this vote thread with the following votes: binding +1s: 4 (Guozhang, Jun, Jason, Bill). Thanks everyone who've reviewed and voted on the KIP! Guozhang On Mon, Jul 29, 2019 at 9:30 AM Guozhang Wang wrote: > Yeah my thinking is that

Re: [VOTE] KIP-467: Augment ProduceResponse error messaging

2019-07-29 Thread Guozhang Wang
point that need not block the KIP. I'm +1 > overall. > > Thanks, > Jason > > On Fri, Jul 26, 2019 at 4:24 PM Guozhang Wang wrote: > > > Hi Jason, thanks for the comments. > > > > 1. Yes that's a good point. Will move it to `errors`. > > > &

Re: [DISCUSS] KIP-497: Add inter-broker API to alter ISR

2019-07-29 Thread Guozhang Wang
Hi Jason, Thanks for the KIP. It looks good to me overall. 1. Just clarifying the "CurrentVersion" field in the newly proposed protocol. Does it contains the same value as zkVersion that controller get from ZK? 2. As for the comment in the KIP: "We can either await the update or we can send a ne

Re: [DISCUSS] KIP-496: Administrative API to delete consumer offsets

2019-07-29 Thread Guozhang Wang
rspective, an empty group is just treated as a case where the > subscription is empty, which makes all offsets subject to expiration. > > > Thanks, > Jason > > On Thu, Jul 25, 2019 at 1:41 PM Guozhang Wang wrote: > > > Hi Jason, > > > > Thanks for the KIP!

Re: [VOTE] KIP-467: Augment ProduceResponse error messaging

2019-07-26 Thread Guozhang Wang
in the > compatibility section. Are you suggesting that we would use the new error > code even for old versions of the produce request? > > Thanks, > Jason > > > > > On Tue, Jul 16, 2019 at 3:46 PM Guozhang Wang wrote: > > > Hello folks, > > > > I&#x

Re: [DISCUSS] KIP-496: Administrative API to delete consumer offsets

2019-07-25 Thread Guozhang Wang
Hi Jason, Thanks for the KIP! I've made a pass on it and here are few comments: 1. " before the clients which ." --> incomplete sentence? 2. " Any committed offset for a partition which is not currently subscribed to is subject to expiration." --> this may be an implementation detail, but are we

Re: [VOTE] KIP-466: Add support for List serialization and deserialization

2019-07-24 Thread Guozhang Wang
+1 (binding). Thanks Daniyar! On Wed, Jul 24, 2019 at 12:04 PM John Roesler wrote: > Thanks, Daniyar, > > I'm +1 (nonbinding) > > -John > > On Tue, Jun 11, 2019 at 1:45 PM Development wrote: > > > Hello, > > > > I want to start a vote for KIP-466 < > > > https://cwiki.apache.org/confluence/dis

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2019-07-24 Thread Guozhang Wang
KIP, if > that's ok with you. > > -John > > On Tue, Jul 23, 2019 at 5:38 PM Guozhang Wang wrote: > > > Hi John, > > > > I left another question regarding Transformer in the DISCUSS thread. > Other > > than that I think this KIP is ready. Thanks! &g

Re: [DISCUSS] KIP-478 Strongly Typed Processor API

2019-07-24 Thread Guozhang Wang
> Of course, it's beyond the scope of this KIP, but this KIP is a > precondition for these further improvements. > > I'm copying your comment onto the ticket for posterity. > > Thanks! > -John > > On Tue, Jul 23, 2019 at 5:38 PM Guozhang Wang wrote: > > >

[jira] [Resolved] (KAFKA-8675) "Main" consumers are not unsubsribed on KafkaStreams.close()

2019-07-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8675. -- Resolution: Not A Problem > "Main" consumers are not unsubsribed on Kafka

Re: [VOTE] KIP-478 Strongly Typed Streams Processor API

2019-07-23 Thread Guozhang Wang
Hi John, I left another question regarding Transformer in the DISCUSS thread. Other than that I think this KIP is ready. Thanks! Guozhang On Tue, Jul 16, 2019 at 9:01 AM John Roesler wrote: > Hi Dev, > > After a good discussion, I'd like to start the vote for KIP-478 > (https://cwiki.apache.

Re: [DISCUSS] KIP-478 Strongly Typed Processor API

2019-07-23 Thread Guozhang Wang
ved process. > > > >> > > > >> For the end goal, if possible, here's what I propose. > > > >> > > > >>1. We keep the scope of the KIP the same, *but we only > implement* *it in > > > >>phases* &g

Re: Monitoring streams

2019-07-23 Thread Guozhang Wang
Hello Brian, I think your main question is to distinguish 1) broker is alive but there's no new data coming into the source topics to process, and 2) broker is not alive and hence nothing is readable, in your monitoring system. I agree that currently process-rate / last-record-timestamp cannot suc

Re: Jira Cleanup

2019-07-22 Thread Guozhang Wang
Thanks Sönke! I just made a quick pass on those tickets as well I think your assessments are right. Guozhang On Fri, Jul 19, 2019 at 4:09 AM Sönke Liebau wrote: > All, > > I left a few comments on some old but still open jiras in an attempt to > clean up a little bit. > > Since probably no on

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-07-22 Thread Guozhang Wang
Thanks everyone for your inputs, I've updated the wiki page accordingly. @Bruno: please let me know if you have any further thoughts per my replies above. Guozhang On Mon, Jul 22, 2019 at 6:30 PM Guozhang Wang wrote: > Thanks Boyang, > > I've thought about exposing

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-07-22 Thread Guozhang Wang
: > I mean the partition time. > > On Thu, Jul 18, 2019 at 11:29 AM Guozhang Wang wrote: > > > Hi Boyang, > > > > What do you mean by `per partition latency`? > > > > Guozhang > > > > On Mon, Jul 1, 2019 at 9:28 AM Boyang Chen > > wrote:

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-07-22 Thread Guozhang Wang
ut no semantical indications. > Boyang > > On Fri, Jul 19, 2019 at 3:57 PM Guozhang Wang wrote: > > > Boyang, thanks for the updated proposal! > > > > 3.a. As Jason mentioned, with EOS enabled we still need to augment the > > offset fetch request with a boolean

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-07-19 Thread Guozhang Wang
g/confluence/display/KAFKA/KIP-447%3A+Producer+scalability+for+exactly+once+semantics > > > > > > and > > > >> written a design doc > > > >> < > > > > > > https://docs.google.com/document/d/1LhzHGeX7_Lay4xvrEXxfciuDWATjpUXQhrEIk

[jira] [Resolved] (KAFKA-8392) Kafka broker leaks metric when partition leader moves to another node.

2019-07-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8392. -- Resolution: Fixed Fix Version/s: 2.4.0 > Kafka broker leaks metric when partit

Re: [VOTE] KIP-466: Add support for List serialization and deserialization

2019-07-18 Thread Guozhang Wang
+1 (binding). Thanks Daniyar! Guozhang On Tue, Jul 16, 2019 at 2:13 PM John Roesler wrote: > Thanks, Daniyar! > > I'm +1 (nonbinding) > > -John > > On Tue, Jul 16, 2019 at 3:14 PM Development wrote: > > > > Hi, > > > > I’d like to start a vote thread for KIP-466. > > > > This addition will in

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-07-18 Thread Guozhang Wang
that are processed after > > the retention period of the window. Is this correct? > > > > 4) Is there an actual difference between skipped and dropped records? > > If not, shall we unify the terminology? > > > > 5) What happens with removed metrics when the user sets

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-07-18 Thread Guozhang Wang
e latter is for records that are processed after > > > the retention period of the window. Is this correct? > > > > > > 4) Is there an actual difference between skipped and dropped records? > > > If not, shall we unify the terminology? > > > > > > 5

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-07-18 Thread Guozhang Wang
and "destroy-rate" we can still remove them with 2.2- as well; for other ones that are removed / replaced like thread-level skipped-records we should still maintain them. Best, > Bruno > > On Thu, Jun 27, 2019 at 6:11 PM Guozhang Wang wrote: > > > > Hello folks, >

Re: [DISCUSS] KIP-479: Add Materialized to Join

2019-07-17 Thread Guozhang Wang
re names and always use internal > > names > > > > as > > > > > well, which admittedly indeed leaves a hole of not being able to > > cover > > > > all > > > > > internal names here > > > > > > > > I thin

Re: [VOTE] KIP-488: Clean up Sum,Count,Total Metrics

2019-07-17 Thread Guozhang Wang
+1 (binging). This is a great cleanup, thanks John! Guozhang On Wed, Jul 17, 2019 at 11:26 AM Ryanne Dolan wrote: > +1 (non-binding) > > Thanks for the interesting discussion. > > Ryanne > > On Fri, Jul 12, 2019, 2:49 PM Ryanne Dolan wrote: > > > John, I'm glad to learn I'm not the only one w

[jira] [Resolved] (KAFKA-8218) IllegalStateException while accessing context in Transformer

2019-07-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8218. -- Resolution: Not A Problem > IllegalStateException while accessing context in Transfor

[jira] [Resolved] (KAFKA-7176) State store metrics for migrated tasks are not removed

2019-07-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-7176. -- Resolution: Fixed Fix Version/s: 2.3.0 > State store metrics for migrated tasks are

[jira] [Resolved] (KAFKA-7850) Remove deprecated KStreamTestDriver

2019-07-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-7850. -- Resolution: Fixed Fix Version/s: 2.3.0 KStreamTestDriver has been removed since 2.3.0

[VOTE] KIP-467: Augment ProduceResponse error messaging

2019-07-16 Thread Guozhang Wang
Hello folks, I'd like to start a voting thread on KIP-467 to improve error communication and handling for producer response: https://cwiki.apache.org/confluence/display/KAFKA/KIP-467 %3A+Augment+ProduceResponse+error+messaging+for+specific+culprit+records Thanks, -- Guozhang

Re: [DISCUSS] KIP-467: Augment ProduceResponse error messaging

2019-07-16 Thread Guozhang Wang
27;m going to start the voting thread soon. Guozhang On Thu, Jun 20, 2019 at 4:24 PM Guozhang Wang wrote: > Hi Jun, > > Thanks for your comments. > > 1. Yeah I think APIException would not make a distinct call here anymore, > and what really matters is the RetriableExcept

Bay area Kafka Meetup hosted by Confluent at Palo Alto, Tuesday 6:30pm, July 16, 2019

2019-07-15 Thread Guozhang Wang
Hello folks, This is just a kind reminder of the Bay Area Kafka® meetup tomorrow, Tuesday 6:30pm, at Confluent's Palo Alto HQ. *RSVP and Register* (if you intend to attend in person): https://www.meetup.com/KafkaBayArea/events/262715611/ please read instructions within the link to register for c

Re: [DISCUSS] KIP-479: Add Materialized to Join

2019-06-27 Thread Guozhang Wang
aterialized then also pollutes the interface for its _actual_ use > case of materializing a table view. Of course, to solve the immediate > problem, all we need is the store name, but we might feel better about > adding the store name to Joined if we _also_ feel like in the future, > we woul

Re: [DISCUSS] KIP-444: Augment Metrics for Kafka Streams

2019-06-27 Thread Guozhang Wang
Hello folks, As 2.3 is released now, I'd like to bump up this KIP discussion again for your reviews. Guozhang On Thu, May 23, 2019 at 4:44 PM Guozhang Wang wrote: > Hello Patrik, > > Since we are rolling out 2.3 and everyone is busy with the release now > this KIP d

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-06-26 Thread Guozhang Wang
ja...@confluent.io > > > > > > > > wrote: > > > > > > > > > >> > > > > > >> > I think co-locating does have some merits here, i.e. letting the > > > > >> > ConsumerCoordinator which has the source

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-06-25 Thread Guozhang Wang
t? > > > > Yes, this is not a requirement for this KIP, because it is inherently > impossible to > achieve co-locating topic partition of transaction log and consumed offset > topics. > > > > Thanks, > > Jason > > > On Mon, Jun 24, 2019 at 10:07 AM

Re: [DISCUSS] KIP-478 Strongly Typed Processor API

2019-06-24 Thread Guozhang Wang
gt; breaking source compatibility. > > If the others feel "kind of favorable" with this overall vision, maybe > we can make one or more Jira tickets to capture it, and then just > alter _this_ proposal to `processor.api.Processor` (etc). > > WDYT? > -John > > On

Re: [DISCUSS] KIP-479: Add Materialized to Join

2019-06-24 Thread Guozhang Wang
r the other side, that we get 5 new capabilities we > don't require, but are still pretty nice: > * configure the bytes store > * set a name for the store > * configure caching > * configure logging > * configure segment interval > > Not sure where this nets us out, b

Re: [DISCUSS] KIP-447: Producer scalability for exactly once semantics

2019-06-23 Thread Guozhang Wang
Hello Boyang, Thanks for the KIP, I have some comments below: 1. "Once transactions are complete, the call will return." This seems different from the existing behavior, in which we would return a retriable CONCURRENT_TRANSACTIONS and let the client to retry, is this intentional? 2. "an overload

Re: [DISCUSS] KIP-479: Add Materialized to Join

2019-06-23 Thread Guozhang Wang
m > a > > stream-stream join which is the only stateful operator that can result in > a > > stream, consider merging the join into multi-way joins (yes, this is a > very > > hand-wavy thought, but the point here is that we do not try to tackle it > > now but leave it for

Re: [DISCUSS] KIP-478 Strongly Typed Processor API

2019-06-23 Thread Guozhang Wang
#x27;ll update the KIP. > >>> > >>> Thanks again for all the feedback! > >>> -John > >>> > >>> On Thu, Jun 20, 2019 at 4:34 PM Matthias J. Sax wrote: > >>>> > >>>> Just want to second what Sophie said about the stores. The type of a

Re: Permissions for creating KIP

2019-06-23 Thread Guozhang Wang
Hello Levani, You should be able to create new wiki page now. Thanks, Guozhang On Sun, Jun 23, 2019 at 3:18 PM Levani Kokhreidze wrote: > Hi, > > Please give me permission for creating KIP < > https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals>. > You can find link t

Re: [VOTE] 2.3.0 RC3

2019-06-21 Thread Guozhang Wang
Hi Colin, Thanks for the new RC, +1 (binding). Verified the javadoc, maven repo, and ran unit tests on 2.12 binary. Guozhang On Fri, Jun 21, 2019 at 1:23 PM Colin McCabe wrote: > Hi Ismael, > > Good catch. This should be fixed now. > > It seems that if the previously staged Sonatype stagin

[jira] [Created] (KAFKA-8584) Allow "bytes" type to generated a ByteBuffer rather than byte arrays

2019-06-21 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-8584: Summary: Allow "bytes" type to generated a ByteBuffer rather than byte arrays Key: KAFKA-8584 URL: https://issues.apache.org/jira/browse/KAFKA-8584 Proj

[jira] [Created] (KAFKA-8581) Augment ProduceResponse error messaging for specific culprit records

2019-06-21 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-8581: Summary: Augment ProduceResponse error messaging for specific culprit records Key: KAFKA-8581 URL: https://issues.apache.org/jira/browse/KAFKA-8581 Project: Kafka

[jira] [Resolved] (KAFKA-8106) Reducing the allocation and copying of ByteBuffer when logValidator do validation.

2019-06-21 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8106. -- Resolution: Fixed Fix Version/s: 2.4.0 > Reducing the allocation and copying

Re: [DISCUSS] KIP-470: TopologyTestDriver test input and output usability improvements

2019-06-21 Thread Guozhang Wang
assertThat(outputTopic2.readKeyValue(), equalTo(new KeyValue<>("Hello", > 1L))); > inputTopic2.pipeInput(1L, "Hello"); > > > Jukka > > to 20. kesäk. 2019 klo 23.52 Guozhang Wang (wangg...@gmail.com) kirjoitti: > > > Hello Jukka, > >

Re: [DISCUSS] KIP-467: Augment ProduceResponse error messaging

2019-06-20 Thread Guozhang Wang
or different records, which error code and error message should the server > return to the client? > > Jun > > On Sat, May 11, 2019 at 12:44 PM Guozhang Wang wrote: > > > Hello everyone, > > > > I'd like to start a discussion thread on this newly created

Re: [DISCUSS] KIP-470: TopologyTestDriver test input and output usability improvements

2019-06-20 Thread Guozhang Wang
Hello Jukka, Thanks for writing the KIP, I have a couple of quick questions: 1) Is "TestRecord" an existing class that you propose to piggy-back on? Right now we have a scala TestRecord case class but I doubt that was your proposal, or are you proposing to add a new Java class? 2) Would the new

Re: [DISCUSS] KIP-478 Strongly Typed Processor API

2019-06-20 Thread Guozhang Wang
Hi John, Thanks for KIP! I've a few comments below: 1. So far the "Motivation" section is very general, and the only concrete example that I have in mind is `TransformValues#punctuate`. Do we have any other concrete issues that drive this KIP? If not then I feel better to narrow the scope of this

Re: [VOTE] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-20 Thread Guozhang Wang
+1 (binding) Thanks Bruno! Would also be interested to see how much overhead it may incur by enabling DEBUG metrics now, if it is huge we may consider doing finer-grained metrics enabling, but that would be another follow-up task. Guozhang On Wed, Jun 19, 2019 at 1:37 PM Patrik Kleindl wrote:

Re: [DISCUSS] KIP-479: Add Materialized to Join

2019-06-20 Thread Guozhang Wang
Hello Bill, Thanks for the KIP. Glad to see that we can likely shooting two birds with one stone. I have some concerns though about those "two birds" themselves: 1. About not breaking compatibility of stream-stream join materialized stores: I think this is a valid issue to tackle, but after think

Re: [DISCUSS] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-19 Thread Guozhang Wang
in RocksDB, but they are for debugging purposes > > > [2]. To get this data and publish it into a metric, one has to parse a > > > string. Since this data is for debugging purposes, I do not know how > > > stable the output format is. One thing, we could do, is to dump th

Re: [DISCUSS] KIP-471: Expose RocksDB Metrics in Kafka Streams

2019-06-18 Thread Guozhang Wang
Hello Bruno, I've read through the aggregation section and I think they look good to me. There are a few minor comments about the wiki page itself: 1) A state store might consist of multiple state stores -> You mean a `logical` state store be consistent of multiple `physical` store instances? 2)

<    5   6   7   8   9   10   11   12   13   14   >