Re: Development with Git Worktree

2023-10-23 Thread Ismael Juma
Greg, Thanks for making the change and sharing the benefit with the overall group. Ismael On Mon, Oct 23, 2023 at 10:03 AM Greg Harris wrote: > Hey Kafka Developers, > > This is a small announcement that the gradle build now supports the > git-worktree subcommand [1] on the 3.4, 3.5, 3.6, and

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-10-22 Thread Ismael Juma
easing a new version > of >Kafka for the affected branch in such a scenario is a much cleaner >approach. Added this as the accepted approach in the KIP. >2. EOL policy: Updated in the KIP. > > Thanks and regards, > Vedarth > > On Sun, Oct 22, 2023 at 11:20 PM Ismae

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-10-22 Thread Ismael Juma
serve as a basis > > for > > > > > >> development, but would it aim at production use cases too > > > > > (docker-compose, > > > > > >> Kubernetes, etc.)? > > > > > >> 2. How do you plan to forward configs to the bro

[jira] [Created] (KAFKA-15623) Migrate remaining tests in streams module to JUnit 5

2023-10-17 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15623: --- Summary: Migrate remaining tests in streams module to JUnit 5 Key: KAFKA-15623 URL: https://issues.apache.org/jira/browse/KAFKA-15623 Project: Kafka Issue

[jira] [Resolved] (KAFKA-12220) Replace PowerMock by Mockito

2023-10-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-12220. - Resolution: Fixed > Replace PowerMock by Mock

[jira] [Reopened] (KAFKA-12220) Replace PowerMock by Mockito

2023-10-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reopened KAFKA-12220: - > Replace PowerMock by Mockito > > > Key:

[jira] [Resolved] (KAFKA-12220) Replace PowerMock by Mockito

2023-10-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-12220. - Resolution: Duplicate The remaining connect tests that need to be migrated are being tracked

[jira] [Resolved] (KAFKA-13414) Replace Powermock/EasyMock by Mockito in connect.storage package

2023-10-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-13414. - Resolution: Fixed KafkaConfigBackingStoreTest is being tracked via KAFKA-14132, marking this as

[jira] [Resolved] (KAFKA-7686) Remove PowerMock from Connect Tests

2023-10-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-7686. Resolution: Duplicate > Remove PowerMock from Connect Te

[jira] [Created] (KAFKA-15610) Fix `CoreUtils.swallow()` test gaps

2023-10-16 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15610: --- Summary: Fix `CoreUtils.swallow()` test gaps Key: KAFKA-15610 URL: https://issues.apache.org/jira/browse/KAFKA-15610 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-15599) Move KafkaMetadataLog and RaftManager to metadata module

2023-10-12 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15599: --- Summary: Move KafkaMetadataLog and RaftManager to metadata module Key: KAFKA-15599 URL: https://issues.apache.org/jira/browse/KAFKA-15599 Project: Kafka Issue

Re: [ANNOUNCE] Apache Kafka 3.6.0

2023-10-12 Thread Ismael Juma
n, Erik van Oosten, ezio, Farooq Qaiser, > Federico Valeri, flashmouse, Florin Akermann, Gabriel Oliveira, > Gantigmaa Selenge, Gaurav Narula, GeunJae Jeon, Greg Harris, Guozhang > Wang, Hailey Ni, Hao Li, Hector Geraldino, hudeqi, hzh0425, Iblis Lin, > iit2009060, Ismael Juma, Ivan Yu

Re: [DISCUSS] Road to Kafka 4.0

2023-10-11 Thread Ismael Juma
Hi Luke, This is a good discussion. And there is a lot more to it than KRaft. With regards to KRaft, there are two separate items: 1. Bugs 2. Missing features when compared to ZK When it comes to bugs, I don't see why 4.0 is particularly relevant. KRaft has been considered production-ready for o

Re: Apache Kafka 3.7.0 Release

2023-10-09 Thread Ismael Juma
Thanks for volunteering Stanislav! Ismael On Mon, Oct 9, 2023 at 10:51 AM Stanislav Kozlovski wrote: > Hey all! > > I would like to volunteer to be the release manager driving the next > release - Apache Kafka *3.7.0*. > > If there are no objections, I will start and share a release plan soon >

Re: Apache Kafka 3.6.0 release

2023-10-05 Thread Ismael Juma
wait for 3.6.1. In the meantime, do we have > a way to indicate known significant issues in the release notes? Maybe just > a note in the blog? > > Thanks! > David > > On Fri, Sep 29, 2023 at 1:42 PM Ismael Juma wrote: > > > Thanks Satish! > > > > Is

Re: [DISCUSS] KIP-979: Allow independently stop KRaft controllers or brokers

2023-10-02 Thread Ismael Juma
eone else identifies still more options that people might want. > > Did I get that right, or were you proposing something different? > > Ron > > > On Sep 30, 2023, at 10:42 AM, Ismael Juma wrote: > > > > Hi, > > > > Thanks for the KIP. I think this

Re: [DISCUSS] KIP-979: Allow independently stop KRaft controllers or brokers

2023-09-30 Thread Ismael Juma
Hi, Thanks for the KIP. I think this approach based on configs is a bit too open ended and not very user friendly. Why don't we simply provide flags for the things a user may care about? So far, it seems like we have two good candidates (node id and process role). Are there any others? Ismael On

Re: Apache Kafka 3.6.0 release

2023-09-29 Thread Ismael Juma
x27;t impact log truncation and hence won't lead to data loss. I > > agree that it's not a blocker. > > > > (ref: https://github.com/apache/kafka/pull/14457) > > > > -- > > Divij Vaidya > > > > On Wed, Sep 27, 2023 at 8:50 PM Ismael Jum

Re: Apache Kafka 3.6.0 release

2023-09-27 Thread Ismael Juma
re from me on this release. > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > Justine > > > > > > > > > > > > > > > > >

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-09-25 Thread Ismael Juma
mparisons between our docker image and existing >ones, and incorporate the findings into the KIP. I'll keep you posted on >the same. > > Excellent, thanks! Ismael > On Wed, Sep 20, 2023 at 11:26 PM Ismael Juma wrote: > >> Hi Krishna, >> >> Thanks f

[jira] [Resolved] (KAFKA-15485) Support building with Java 21 (LTS release)

2023-09-25 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-15485. - Resolution: Fixed > Support building with Java 21 (LTS rele

[jira] [Created] (KAFKA-15493) Ensure system tests work with Java 21

2023-09-24 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15493: --- Summary: Ensure system tests work with Java 21 Key: KAFKA-15493 URL: https://issues.apache.org/jira/browse/KAFKA-15493 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-15492) Enable spotbugs when building with Java 21

2023-09-24 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15492: --- Summary: Enable spotbugs when building with Java 21 Key: KAFKA-15492 URL: https://issues.apache.org/jira/browse/KAFKA-15492 Project: Kafka Issue Type

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-23 Thread Ismael Juma
Given that this is not a regression and there have been no reports for over a year, I think it's ok for this to land in 3.6.1. Ismael On Sat, Sep 23, 2023 at 9:32 AM Satish Duggana wrote: > Thanks Luke for reporting KRaft issue[1]. > > I am not sure whether it is a release blocker for 3.6.0. Ne

Re: [DISCUSS] KIP-974 Docker Image for GraalVM based Native Kafka Broker

2023-09-20 Thread Ismael Juma
Hi Krishna, Thanks for the KIP. The results are impressive! A few quick comments: 1. I noticed that the graalvm-reachability-metadata project now includes kafka-clients[1]. Worth checking if the metadata over there matches what we've observed for our own attempt. 2. Can we please add peak memory

Re: [DISCUSS] KIP-974 Docker Image for GraalVM based Native Kafka Broker

2023-09-20 Thread Ismael Juma
Hi Federico, I suggest taking this conversation to KIP-975 and keeping this one to the graalvm specifics. Ismael On Fri, Sep 8, 2023 at 2:38 AM Federico Valeri wrote: > Hi Krishna, thanks for opening this discussion. > > I see you created two separate KIPs (974 and 975), but there are some > c

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-09-20 Thread Ismael Juma
Hi Krishna, Thanks for the KIP. A few quick questions: 1. Since this will only be available for Kafka 3.7 in the best case, I suggest we go with Java 21 instead of Java 17. Also, we should be clear about Java version expectations. Are we allowed to change the Java version whenever we want? Or can

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-09-20 Thread Ismael Juma
t; container on baremetal machines, it could allow us to create > > a sandbox/developer environment for new contributors and developers to > test > > and have a single agreed upon environment that kafka works in for future > > KIPs and would most likely spawn more contributio

Re: [DISCUSS] KIP-975 Docker Image for Apache Kafka

2023-09-14 Thread Ismael Juma
Hi Viktor, I disagree. Docker is a very popular deployment tool and it's not only used with Kubernetes. Ismael On Thu, Sep 14, 2023, 1:14 AM Viktor Somogyi-Vass wrote: > Hi Krishna, > > I think you should merge this KIP and KIP-974 as there are overlaps as > Federico pointed out on KIP-974. I

Re: Apache Kafka 3.6.0 release

2023-09-12 Thread Ismael Juma
11, 2023 at 12:29 PM David Arthur > > > wrote: > > > > > > > Another (small) ZK migration issue was identified. This one isn't a > > > > regression (it has existed since 3.4), but I think it's reasonable to > > > > include. It's a

Re: Apache Kafka 3.6.0 release

2023-09-10 Thread Ismael Juma
> Thanks, > Satish. > > On Fri, 8 Sept 2023 at 19:23, Ismael Juma wrote: > > > > Hi Satish, > > > > Do you have a sense of when we'll publish RC0? > > > > Thanks, > > Ismael > > > > On Fri, Sep 8, 2023 at 6:27 AM David Arthur

Re: Apache Kafka 3.6.0 release

2023-09-08 Thread Ismael Juma
Hi Satish, Do you have a sense of when we'll publish RC0? Thanks, Ismael On Fri, Sep 8, 2023 at 6:27 AM David Arthur wrote: > Quick update on my two blockers: KAFKA-15435 is merged to trunk and > cherry-picked to 3.6. I have a PR open for KAFKA-15441 and will hopefully > get it merged today. >

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-26 Thread Ismael Juma
hink the DTO style and the proposed additional argument style are > both reasonable. > > Thanks, > Greg > > On Sat, Aug 26, 2023 at 9:46 AM Ismael Juma wrote: > > > > Hi Greg, > > > > The mention of "runtime" is specific to Connect. When it comes to

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-26 Thread Ismael Juma
d? I'm not familiar with the > evolution of the Admin APIs. > > Thanks! > Greg > > On Sat, Aug 26, 2023 at 6:45 AM Ismael Juma wrote: > > > > Hi Greg, > > > > The point is that the approach proposed here introduces complexity > forever

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-26 Thread Ismael Juma
the community has any > > opinions on the same. > > > > Hey everyone, please share your thoughts on using a DTO instead of > separate > > params for the interface. > > > > Thanks. > > > > On Mon, Aug 21, 2023 at 8:06 PM Ismael Juma wrote: > &

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-21 Thread Ismael Juma
uggesting to pass a param like a DTO or you are suggesting to pass > the record object? > > I would also like to hear other devs' opinions on this as I personally > favour what is done currently. > > On Thu, Aug 17, 2023 at 9:34 AM Ismael Juma wrote: > > > Hi, > &g

Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well.

2023-08-16 Thread Ismael Juma
Hi, Thanks for the KIP. The problem outlined here is a great example why we should be using a record-like structure to pass the parameters to a method like this. Then we can add more parameters without having to introduce new methods. Have we considered this option? Ismael On Mon, Aug 7, 2023 at

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Ismael Juma
ber what works, so I would > > prefer to just use what I think works and then have it work. > > > > Ron > > > > On Thu, Jul 27, 2023 at 8:33 AM Ismael Juma wrote: > >> > >> I think singular was used because that's the common case for the cli >

Re: Apache Kafka 3.6.0 release

2023-07-27 Thread Ismael Juma
define what "early access" means in that case. Users may not be > aware that "early access" public APIs may change (unless I am missing > some documentation somewhere completely, in which case I apologize for > bringing this naive point). > > -- > Divij Vaidya

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-27 Thread Ismael Juma
I think singular was used because that's the common case for the cli tools. To be honest, it's actually a bit more confusing to have both singular and plural for the cli tools and you have to remember the exact version for each one. We should either support plural for both and the singular one is j

Re: Apache Kafka 3.6.0 release

2023-07-27 Thread Ismael Juma
Hi Divij, Some of these are launch checklist items (not really goals) and some are compatibility guarantees. More below. On Thu, Jul 27, 2023, 12:10 PM Divij Vaidya wrote: > Hey Satish > > Could we consider adding "launch goals" in the release plan. While > some of these may be implicit, it wou

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-07-25 Thread Ismael Juma
Thanks Igor. Are there unaddressed concerns or is this ready for a vote again? Ismael On Tue, Jul 25, 2023 at 6:14 PM Igor Soarez wrote: > Hi everyone, > > Following a face-to-face discussion with Ron and Colin, > I have just made further improvements to this KIP: > > > 1. Every log directory g

Re: Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-25 Thread Ismael Juma
Thanks Crispin! Ismael On Mon, Jul 24, 2023 at 8:16 PM Crispin Bernier wrote: > I updated the wiki to include both results along with their average. > > Thank you, > Crispin > > On Mon, Jul 24, 2023 at 10:58 AM Ismael Juma wrote: > > > Hi Crispin, > > >

Re: Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-24 Thread Ismael Juma
Hi Crispin, One additional question, the wiki says "The results are averaged over 2 runs.". Can you please provide some measure of variance in the distribution, i.e. were both results similar to each other for both cases? Ismael On Fri, Jul 21, 2023 at 11:31 AM Ismael Juma wrote: &g

Re: Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-24 Thread Ismael Juma
On Mon, Jul 24, 2023 at 3:32 PM David Jacot wrote: > 01. Hum... I understand your reasoning. I think that this is mainly > beneficial for clients lagging behind in terms of supported versions. > However, it is the opposite for the java client which is up to date. > Personally, I would rather pref

Re: Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-21 Thread Ismael Juma
Thanks for the update Crispin - very helpful to have actual performance data. 2-5% for the default configuration is a bit on the low side for this kind of proposal. Ismael On Thu, Jul 20, 2023 at 11:33 PM Crispin Bernier wrote: > Benchmark numbers have been posted on the KIP, please review. > >

Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-13 Thread Ismael Juma
Hi Mayank, See my answer below. On Thu, Jul 13, 2023 at 10:24 AM Mayank Shekhar Narula < mayanks.nar...@gmail.com> wrote: > re. 2 On some busy clusters a single metadata call has been observed to > take order of ~100 milliseconds(I think it's mentioned somewhere in this > motivation). So retryin

Re: [DISCUSS] KIP-951: Leader discovery optimisations for the client

2023-07-13 Thread Ismael Juma
Thanks for the KIP. A couple of high level points and a more specific one: 1. Given the motivation, the performance results are essential for proper evaluation, so I am looking forward to those. 2. The reasoning given for the rejected alternative seems weak to me. It would be useful to have number

Re: [DISCUSS] Release plan for Apache Kafka 3.5.1 release

2023-07-10 Thread Ismael Juma
Hi David, There is no reason to wait 3 months - we often would release 4-6 weeks after the .0 in the past. If someone is willing to volunteer to do the release and there are important bugs, it's actually better to release more often. Ismael On Mon, Jul 3, 2023 at 5:00 AM David Jacot wrote: > H

[jira] [Created] (KAFKA-15117) SslTransportLayerTest.testValidEndpointIdentificationCN fails with Java 20

2023-06-23 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-15117: --- Summary: SslTransportLayerTest.testValidEndpointIdentificationCN fails with Java 20 Key: KAFKA-15117 URL: https://issues.apache.org/jira/browse/KAFKA-15117 Project

Re: [DISCUSS] Conventional commits

2023-06-08 Thread Ismael Juma
for comitters to rewrite the message before > squash-merging? Or will we enforce PR authors to follow this convention? > > Best, > > On Thu, Jun 8, 2023 at 8:13 AM Ismael Juma wrote: > > > Hi, > > > > A number of open source projects have adopted the conventional

[DISCUSS] Conventional commits

2023-06-07 Thread Ismael Juma
Hi, A number of open source projects have adopted the conventional commits specification. What do people think about using this for Apache Kafka? https://www.conventionalcommits.org/en/v1.0.0/ Thanks, Ismael

Re: [DISCUSS] Regarding Old PRs

2023-06-01 Thread Ismael Juma
This is worthwhile, but can we use a bot for this? Many other projects do so already. Ismael On Thu, Jun 1, 2023 at 9:24 AM Josep Prat wrote: > Hi Kafka devs, > > Seeing that we have over a 1000 PRs and that we want to try to keep the > number low. I was thinking if it would make sense to go th

Re: [VOTE] 3.5.0 RC0

2023-05-24 Thread Ismael Juma
of 3.5.x. Just my 5cts. > > [1]: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-833:+Mark+KRaft+as+Production+Ready#KIP833:MarkKRaftasProductionReady-Kafka3.5 > Best, > > On Wed, May 24, 2023 at 8:51 PM Ismael Juma wrote: > > > Are all these blockers? For example, zk to kr

Re: [VOTE] 3.5.0 RC0

2023-05-24 Thread Ismael Juma
Are all these blockers? For example, zk to kraft migration are is still in preview - can we fix some of these in 3.5.1? Ismael On Wed, May 24, 2023, 10:22 AM Colin McCabe wrote: > Hi Mickael, > > Thanks for putting together this RC. Unfortunately, we've identified > several blocker issues in th

Re: [DISCUSS] Apache Kafka 3.5.0 release

2023-05-22 Thread Ismael Juma
we decide to include some of the > migration fixes, I'll make another RC. > > Thanks, > Mickael > > > > On Sat, May 20, 2023 at 5:53 PM Ismael Juma wrote: > > > > Hi Mickael, > > > > What's the plan for the first RC? In my opinion, we s

Re: [DISCUSS] Apache Kafka 3.5.0 release

2023-05-20 Thread Ismael Juma
Hi Mickael, What's the plan for the first RC? In my opinion, we should really tighten the criteria for what's considered a blocker and release RC0 soon (given where we are timeline wise). Ismael On Sat, May 20, 2023, 8:15 AM Mickael Maison wrote: > Hi Matthias, > > Yes feel free to backport to

Re: [DISCUSS] KIP-931: Flag to ignore unused message attribute field

2023-05-16 Thread Ismael Juma
s planned for message format v3. > I'll move this KIP into "discarded" state and add some reasons there. > Please remember to take this KIP (and Divij's proposal) into consideration > when we plan to propose a new message format. > > Thank you. > Luke > > &g

Re: [DISCUSS] KIP-931: Flag to ignore unused message attribute field

2023-05-15 Thread Ismael Juma
Hi Luke, Thanks for the KIP. A few things: 1. Record format changes are _extremely expensive_ for the ecosystem, so we need to have very strong motivation for them. There is a reason why we have had so few of them and the last one was in 0.11. 2. It was a conscious decision to make the record hea

Re: [DISCUSS] KIP-926: introducing acks=min.insync.replicas config

2023-05-09 Thread Ismael Juma
sages > beyond high watermark, which also has some discussion about how to achieve > that, and no conclusion > > Both of the above 2 concerns are out of the scope of my current KIP. > So, I think it's good to provide this `acks=quorum` or > `acks=min.insync.replicas` option to

Re: [DISCUSS] KIP-926: introducing acks=min.insync.replicas config

2023-05-09 Thread Ismael Juma
Hi Luke, Are you aware of https://cwiki.apache.org/confluence/display/KAFKA/KIP-250+Add+Support+for+Quorum-based+Producer+Acknowledgment ? Ismael On Tue, May 9, 2023 at 10:14 PM Luke Chen wrote: > Hi all, > > I'd like to start a discussion for the KIP-926: introducing > acks=min.insync.replica

Re: Test failures

2023-04-26 Thread Ismael Juma
smail, > > > > There is a PR to fix the failure in > > https://github.com/apache/kafka/pull/13634 > > > > On Tue, Apr 25, 2023 at 9:40 PM Ismael Juma wrote: > > > > > I was looking at the CI builds and I ca

Re: [DISCUSS] Apache Kafka 3.4.1 release

2023-04-26 Thread Ismael Juma
+1 Thanks for volunteering! Ismael On Wed, Apr 26, 2023 at 3:37 AM Luke Chen wrote: > Hi all, > > I'd like to volunteer as release manager for the Apache > Kafka 3.4.1 release. > If there are no objections, I'll start building a release plan in the > wiki in the next couple of days. > > Thank

Re: Test failures

2023-04-25 Thread Ismael Juma
> https://issues.apache.org/jira/browse/KAFKA-14929 > > Thanks Ismael for merging a fix for > > https://issues.apache.org/jira/browse/KAFKA-8115 but it appears that > there > > is still more investigation needed there, as the test is still failing > > occasionally. >

Re: Adding reviewers with Github actions

2023-04-19 Thread Ismael Juma
It's a lot more convenient to have it in the commit than having to follow links, etc. David Arthur also wrote a script to help with this step, I believe. Ismael On Tue, Apr 18, 2023, 9:29 AM Divij Vaidya wrote: > Do we even need a manual attribution for a reviewer in the commit message? > GitH

Re: Apache Kafka 3.6.0 release

2023-04-16 Thread Ismael Juma
Thanks for volunteering Satish. +1. Ismael On Sun, Apr 16, 2023 at 10:08 AM Satish Duggana wrote: > Hi, > I would like to volunteer as release manager for the next release, > which will be Apache Kafka 3.6.0. > > If there are no objections, I will start a release plan a week after > 3.5.0 relea

Re: Test failures

2023-04-14 Thread Ismael Juma
/kafka/pull/13543 which is on trunk now but > wasn't > at the time of the above run. > > Thanks, > Greg > > On Fri, Apr 14, 2023 at 10:25 AM Ismael Juma wrote: > > > Thanks Justine! > > > > Ismael > > > > On Fri, Apr 14, 2023 at 9:5

Re: Test failures

2023-04-14 Thread Ismael Juma
Fri, Apr 14, 2023 at 6:47 AM Ismael Juma wrote: > > > Hi team, > > > > It looks like there are a lot of test failures in the master branch. I > > don't know which commits introduced them, but can you please check if > > commit(s) you merged or contributed

Test failures

2023-04-14 Thread Ismael Juma
Hi team, It looks like there are a lot of test failures in the master branch. I don't know which commits introduced them, but can you please check if commit(s) you merged or contributed are the reason and fix it asap? If it's easy to fix the tests, let's do that - otherwise we should revert the fa

Re: [DISCUSS] Re-visit end of life policy

2023-04-13 Thread Ismael Juma
Clarification below. I did not understand your point about maintenance expense to ensure > compatibility. I am confused because, IMO, irrespective of our bug fix > support duration for minor versions, we should ensure that all prior minor > versions are compatible. Hence, increasing the support du

Re: [DISCUSS] Re-visit end of life policy

2023-04-13 Thread Ismael Juma
Hi, I think we're discussing two separate things and each has a very different cost and benefit: 1. Having a longer support period for the last minor release: major releases happen pretty rarely and have breaking changes. It seems reasonable to consider improving how this case is handled. And it

[jira] [Created] (KAFKA-14892) Harmonize package names in storage module

2023-04-11 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-14892: --- Summary: Harmonize package names in storage module Key: KAFKA-14892 URL: https://issues.apache.org/jira/browse/KAFKA-14892 Project: Kafka Issue Type

Re: [DISCUSS] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-04-09 Thread Ismael Juma
Hi, One interesting aspect is that the current `ByteBufferSerializer` avoids copies in the following case: if (data.hasArray()) { final byte[] arr = data.array(); if (data.arrayOffset() == 0 && arr.length == data.remaining()) { return arr; } } It would be good to clarify this aspect in the motiv

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-09 Thread Ismael Juma
Colin, See comment below. On Sun, Apr 9, 2023 at 4:53 PM Colin McCabe wrote: > > > > Until this is the case and unless we carry out a Zookeeper version > upgrade we leave users to run on an end-of-life version with unpatched CVEs > addressed in later versions. > > > > Some users have compliance

Re: [VOTE] KIP-902: Upgrade Zookeeper to 3.8.1

2023-04-06 Thread Ismael Juma
I'm +1 for this change, but we should do it early in the release cycle. Perhaps 3.6.0 is the right release target. That should buy us enough time for users to migrate to kraft mode. Ismael On Mon, Mar 20, 2023 at 10:12 AM Divij Vaidya wrote: > Hey Colin > > Thank you for your feedback. In addit

Re: [DISCUSS] KIP-915: Next Gen Group Coordinator Downgrade Path

2023-03-30 Thread Ismael Juma
Hi, I'm late to this conversation, but it's a bit odd to backport the flexible versions change to "3.0.3, 3.1.3, 3.2.4, 3.3.3, and 3.4.1" unless we intend to release an update for each of these. So, I suggest that either we commit to releasing an update for each of these versions or we reduce the

Re: [DISCUSS] KIP-897: Publish a single kafka (aka core) Maven artifact in Apache Kafka 4.0

2023-03-18 Thread Ismael Juma
Hi Matthew, Comments below. On Sat, Mar 18, 2023 at 2:27 PM Matthew Benedict de Detrich wrote: > >1. The kafka module does not expose a public api (unlike kafka-clients or > streams-scala) and the usage of Scala (including the version) is an > implementation detail. > > This is irrelevant, the

Re: [DISCUSS] KIP-897: Publish a single kafka (aka core) Maven artifact in Apache Kafka 4.0

2023-03-18 Thread Ismael Juma
the suffix > automatically for you during resolution. Similarly if we are talking about > a distribution of Kafka that needs to be run, it's just a list of jars that > need to be a classloader. > > > On Sat, Mar 18, 2023 at 4:16 PM Ismael Juma wrote: > > > Hi all

Re: [DISCUSS] KIP-896: Remove old client protocol API versions in Kafka 4.0

2023-03-18 Thread Ismael Juma
Hi Jun, I updated the KIP to include the inter-broker protocol version deprecation. Ismael On Mon, Jan 9, 2023 at 3:53 PM Jun Rao wrote: > Hi, Ismael, > > Thanks for the reply. > > 2. Yes, that makes sense. > > Jun > > On Mon, Jan 9, 2023 at 11:26 AM Ismae

[DISCUSS] KIP-897: Publish a single kafka (aka core) Maven artifact in Apache Kafka 4.0

2023-03-18 Thread Ismael Juma
Hi all, I would like to start a discussion regarding the removal of the scala suffix from the kafka (aka core) module. Please take a look at the proposal and provide feedback: https://cwiki.apache.org/confluence/display/KAFKA/KIP-897%3A+Publish+a+single+kafka+%28aka+core%29+Maven+artifact+in+Apac

[jira] [Created] (KAFKA-14819) Publish a single kafka (aka core) Maven artifact in Apache Kafka 4.0 (KIP-897)

2023-03-18 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-14819: --- Summary: Publish a single kafka (aka core) Maven artifact in Apache Kafka 4.0 (KIP-897) Key: KAFKA-14819 URL: https://issues.apache.org/jira/browse/KAFKA-14819 Project

Re: Failing ZkMigrationIntegrationTest

2023-03-17 Thread Ismael Juma
Thanks David. It may be worth temporarily disabling it unless we expect the fix to be available today. Ismael On Fri, Mar 17, 2023 at 6:58 AM David Arthur wrote: > Hey folks, I've noticed that ZkMigrationIntegrationTest#testDualWrite has > been failing a lot lately on trunk and PR builds. Earli

[jira] [Resolved] (KAFKA-13900) Support Java 9 direct ByteBuffer Checksum methods

2023-03-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-13900. - Resolution: Fixed > Support Java 9 direct ByteBuffer Checksum meth

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-03-14 Thread Ismael Juma
Hi Chia, Regarding `org.apache.kafka.clients.tool`, a few comments: 1. Why is it in `clients`? We don't generally consider tools to be a client. 2. Why is it `tool`? We have a package `org.apache.kafka.tools`, so it's a bit odd that this one uses singular instead of plural. 3. Also, should we fol

[jira] [Resolved] (KAFKA-14792) Race condition in LazyIndex.get()

2023-03-07 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14792. - Fix Version/s: 3.5.0 Resolution: Fixed > Race condition in LazyIndex.

[jira] [Created] (KAFKA-14792) Race condition in LazyIndex.get()

2023-03-07 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-14792: --- Summary: Race condition in LazyIndex.get() Key: KAFKA-14792 URL: https://issues.apache.org/jira/browse/KAFKA-14792 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-902: Upgrade Zookeeper to 3.8.1

2023-03-02 Thread Ismael Juma
Thanks for the KIP. I think the following is a little confusing since it doesn't make it clear the the ZooKeeper deployment is separate from Kafka, Kafka only includes the ZooKeeper libraries. I think it would be useful to explain the upgrade process for someone running Apache Kafka 2.3 and ZooKeep

[jira] [Resolved] (KAFKA-14680) Gradle version upgrade 7 -->> 8

2023-02-27 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14680. - Fix Version/s: 3.5.0 Resolution: Fixed > Gradle version upgrade 7 --&

[jira] [Resolved] (KAFKA-14749) Re-enable 'spotlessScalaCheck' task (in Jenkinsfile)

2023-02-27 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14749. - Assignee: Ismael Juma Resolution: Fixed We found a way to re-enable this when running

Re: [DISCUSS] KIP-909: Allow clients to rebootstrap DNS lookup failure

2023-02-23 Thread Ismael Juma
Thanks for the KIP. Not sure if I missed it, but how long will we retry for and when do we give up and propagate the failure to the user? Ismael On Thu, Feb 23, 2023 at 9:30 AM Philip Nee wrote: > Hi all! > > I want to start a discussion thread about how we can handle client > bootstrap failure

Re: [DISCUSS] KIP-641 An new java interface to replace 'kafka.common.MessageReader'

2023-02-15 Thread Ismael Juma
Hi. Is MessageReader the right name? The client apis tend to use the word `Record` instead. In fact, `readMessage` returns a `ProducerRecord`. Also, I wonder if we it would be useful for the interface to support the usage of Serializers. That is, the interface could return ProducerRecord as long

Re: [DISCUSS] Apache Kafka 3.5.0 release

2023-02-14 Thread Ismael Juma
Thanks! Ismael On Tue, Feb 14, 2023 at 1:07 PM Mickael Maison wrote: > Hi Ismael, > > Good call. I shifted all dates by 2 weeks and moved them to Wednesdays. > > Thanks, > Mickael > > On Tue, Feb 14, 2023 at 6:01 PM Ismael Juma wrote: > > > > Thanks Micka

Re: [DISCUSS] Zookeeper deprecation

2023-02-14 Thread Ismael Juma
Hi Divij, I think we'll make that call a bit later depending on the progress we make on things like zk to kraft migration. The deprecation notice is meant to indicate that we recommend customers use kraft mode for new clusters and that zk mode will be going away in 4.0. It doesn't change the suppo

Re: [DISCUSS] Apache Kafka 3.5.0 release

2023-02-14 Thread Ismael Juma
Thanks Mickael. A couple of notes: 1. We typically choose a Wednesday for the various freeze dates - there are often 1-2 day slips and it's better if that doesn't require people working through the weekend. 2. Looks like we're over a month later compared to the equivalent release last year ( https

[jira] [Resolved] (KAFKA-14688) Move org.apache.kafka.server.log.internals to org.apache.kafka.storage.internals.log

2023-02-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14688. - Resolution: Fixed > Move org.apache.kafka.server.log.internals

Re: [DISCUSS] Apache Kafka 3.5.0 release

2023-02-08 Thread Ismael Juma
Thanks Mickael! Ismael On Wed, Feb 8, 2023 at 7:06 AM Mickael Maison wrote: > Hi, > > I'd like to volunteer as release manager for the next release, Apache > Kafka 3.5.0. > If there are no objections, I'll start building a release plan in the > wiki in the next couple of weeks. > > Thanks, > Mi

Re: [VOTE] 3.4.0 RC2

2023-02-06 Thread Ismael Juma
Thanks David and Sophie! Ismael On Mon, Feb 6, 2023, 7:22 AM David Arthur wrote: > I'd like to go ahead and close out this vote. There were three binding > votes and one non-binding vote. > > Binding +1 PMC votes: > * David Jacot > * Bill Bejeck > * Mickael Maison > > Non-binding community vote

[jira] [Resolved] (KAFKA-13663) IllegalMonitorStateException in ProducerMetadata.awaitUpdate

2023-01-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-13663. - Resolution: Duplicate Marking as duplicate of KAFKA-10902 since that has a reference to the JDK

[jira] [Resolved] (KAFKA-10637) KafkaProducer: IllegalMonitorStateException

2023-01-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-10637. - Resolution: Duplicate Marking as duplicate of KAFKA-10902 since that has a reference to the JDK

Re: [ANNOUNCE] New committer: Stanislav Kozlovski

2023-01-17 Thread Ismael Juma
Congratulations Stanislav! Ismael On Tue, Jan 17, 2023 at 7:51 AM Jun Rao wrote: > Hi, Everyone, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Stanislav Kozlovski. > > Stan has been contributing to Apache Kafka since June 2018. He made various > contributions includ

<    1   2   3   4   5   6   7   8   9   10   >