Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

Guozhang, thanks for the comments, I've updated the KIP. Bill On Wed, Jul 5, 2017 at 10:10 PM, Guozhang Wang wrote: > Bill, > > Thanks for the updated KIP. From your WIP PR I think one piece of > information that still need to be included in the KIP is that the library >

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

Bill, Thanks for the updated KIP. From your WIP PR I think one piece of information that still need to be included in the KIP is that the library will check the type of the restoreCallback in runtime, and if it is extending StateRestoreListener it will also execute its functions at the runtime.

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

Hi Eno, Thanks for the comment. Depending on how users implement the `onBatchRestore` it could potentially slow down the restoration. However IMHO it shouldn't present an issue as in practice I suspect users simply want a status update of how far along the restoration process has progressed.

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

Thanks Bill, My only remaining question is whether we expect that calling `onBatchRestore` after each `poll` could slow down the restoration? Thanks Eno > On Jun 30, 2017, at 4:27 PM, Bill Bejeck wrote: > > Damian, > > Thanks for comments. I've updated the KIP with the

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

Damian, Thanks for comments. I've updated the KIP with the abstract classes. Thanks, Bill On Fri, Jun 30, 2017 at 9:57 AM, Damian Guy wrote: > Thanks for the updated KIP Bill. > > In the PR you have AbstractBatchingRestoreCallback and > AbstractNotifyingRestoreCallback

Re: [DISCUSS] KIP-167: Add interface for the state store restoration process

Thanks for the updated KIP Bill. In the PR you have AbstractBatchingRestoreCallback and AbstractNotifyingRestoreCallback which are both in public packages, so are part of the API. I think you need to add those to the KIP to round it off. Otherwise LGTM. Thanks, Damian On Fri, 30 Jun 2017 at

[DISCUSS] KIP-167: Add interface for the state store restoration process

Hi, I updated the KIP yesterday and reposted on the original thread, but I think it may get lost in the shuffle. I'd like to have one more round of discussion on the KIP found here:

[DISCUSS] KIP-167: Add interface for the state store restoration process

The KIP has been updated to incorporate support for users to receive notification of state store restore progress for either pre-existing or custom state stores. A PR has been submitted concurrently https://github.com/apache/kafka/pull/3325 Thanks, Bill