Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-06-14 Thread Boyang Chen
, June 14, 2019 8:42 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hi Boyang, Thanks for the update. To what extent will KIP-345 be available in 2.3.0? Mike On 6/13/19, 5:36 PM, "Boyang Chen" wrote: Hey al

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-06-14 Thread Mike Freyberger
, April 26, 2019 11:16 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey all, there is a minor change to the stream side logic for static membership<https://cwiki.apache.org/confluence/display/

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-06-13 Thread Boyang Chen
any concerns. Best, Boyang From: Boyang Chen Sent: Friday, April 26, 2019 11:16 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey all, there is a minor change to the stream side logic

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-05-15 Thread Boyang Chen
: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey all, there is a minor change to the stream side logic for static membership<https://cwiki.apache.org/confluence/display/KAFKA/KIP-345%3A+Introduce+static+membership+protocol+to+reduce+consumer+rebalan

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-04-25 Thread Boyang Chen
nsumer rebalances by specifying member id Hi Mike, Yes that's the plan! From: Mike Freyberger Sent: Saturday, March 9, 2019 10:04 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hi

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-03-08 Thread Boyang Chen
Hi Mike, Yes that's the plan! From: Mike Freyberger Sent: Saturday, March 9, 2019 10:04 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hi Boyang, Is this work targeted for Kafka 2.3? I

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-03-08 Thread Mike Freyberger
Hi Boyang, Is this work targeted for Kafka 2.3? I am eager to use this new feature. Thanks, Mike Freyberger On 12/21/18, 1:21 PM, "Mayuresh Gharat" wrote: Hi Boyang, Regarding "However, we shall still attempt to remove the member static info if the given `member.id` points

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-01-02 Thread Boyang Chen
Yep, that is correct! Get Outlook for iOS<https://aka.ms/o0ukef> From: Mayuresh Gharat Sent: Wednesday, January 2, 2019 8:30 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hi

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2019-01-02 Thread Mayuresh Gharat
gt; Sent: Saturday, December 22, 2018 2:21 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by > specifying member id > > Hi Boyang, > > Regarding "However, we shall still attempt to remove the member static info > if the given

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-12-28 Thread Boyang Chen
ent: Saturday, December 22, 2018 2:21 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hi Boyang, Regarding "However, we shall still attempt to remove the member static info if the given `member.id` points to an

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-12-21 Thread Mayuresh Gharat
Hi Boyang, Regarding "However, we shall still attempt to remove the member static info if the given `member.id` points to an existing `group.instance.id` upon LeaveGroupRequest, because I could think of the possibility that in long term we could want to add static membership leave group logic for

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-12-02 Thread Guozhang Wang
with the suggestion to make the leave group request change > generic. So this new Stream API > will be added on the rest layer to expose the necessary ids correct? > > Looking forward to your confirmation  > > Best, > Boyang > > -------------- > *From:

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-12-01 Thread Mayuresh Gharat
this new Stream API > will be added on the rest layer to expose the necessary ids correct? > > Looking forward to your confirmation  > > Best, > Boyang > > ____________ > From: Guozhang Wang > Sent: Saturday, December 1, 2018 7:00 AM > To: dev &

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-30 Thread Guozhang Wang
instanceid prefix, and list[instanceid] > > for clarity purpose. As you know, two options are equivalent since full > > name is subset of prefix. > > > > Let me know your thoughts! > > > > Boyang > > ____ > > From: Boyang Ch

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-30 Thread Mayuresh Gharat
t; From: Boyang Chen > Sent: Thursday, November 29, 2018 3:39 PM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by > specifying member id > > Thanks Guozhang for the new proposal here! > > So I'd like to propose a slightly

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-29 Thread Boyang Chen
: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Thanks Guozhang for the new proposal here! So I'd like to propose a slightly modified version of LeaveGroupRequest: instead of letting the static member consumer client themselves to send the request (which means we still

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-28 Thread Boyang Chen
management tooling. How does this workaround sound? Boyang From: Guozhang Wang Sent: Thursday, November 29, 2018 2:38 AM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hi Boyang, I was thinking that with the optional static members i

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-28 Thread Guozhang Wang
> > 3) personally I favor "ids" over "names" :) Since we already have some > "ids" and hence it sounds more consistent, plus on the producer side we > have a `transactional.id` whose semantics is a bit similar to this one, > i.e. for unique distinguishment of a client which may

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-28 Thread Boyang Chen
may comes and goes but need to be persist over multiple "instance life-times". Sure we have enough votes for ids I will finalize the name to `group.instance.id`, does that sound good? Best, Boyang From: Guozhang Wang Sent: Wednesday, November 28, 2018 4:51 AM To: dev Subject: R

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-27 Thread Guozhang Wang
ession timeout expiration. I am wondering how critical > > this piece is and whether we can leave it for future work. If not, then > it > > would be helpful to elaborate on its implementation. How would the > > coordinator know which members to kick out of the group? > > > > This API is ne

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-27 Thread Mayuresh Gharat
b0cbc94390f04b08d653fa2832%7C84df9e7fe9f640afb435%7C1%7C0%7C636788731208857126sdata=EDM7PmpOo2HenYhFHX2rxrszpkI7di401WhKh2Vjw5k%3Dreserved=0 > > >> > > > >> we will automatically fence all join requests with UNKNOWN_MEMBER_ID. > > >> > > >> 4)

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-26 Thread Boyang Chen
Yea, Dong and Stanislav also mentioned this naming. I personally buy in the namespace idea, and since we already use `member.name` in a lot of context, I decide to rename the config to `group.member.name` which should be sufficient for solving all the concerns we have now. Sounds good? Than

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-26 Thread Jason Gustafson
e%7C84df9e7fe9f640afb435%7C1%7C0%7C636786393153281080sdata=%2BNasMFlJf9rEJc9iDfndcyxA4%2BGWieS1azSKbtdGRW4%3Dreserved=0 > >> . > >> Added the script. > >> > >> 7) Would it be simpler to replace name "forceStaticRebalance" with > &

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-26 Thread Mayuresh Gharat
t; > > A and produces to Kafka cluster B. >> > > Depending on the data and the Kafka cluster configuration, Kafka >> service >> > > providers can set a mirroring group saying that it will take, for >> example >> > > 300 consumer hosts/members to

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-26 Thread Mayuresh Gharat
ethod through admin > client API. > > 8) It is not very clear how the newly added AdminClient API trigger > rebalance. For example, does it send request? Can this be explained in the > KIP? > > Sure, I will add more details to the API. > > > Thanks again for the help

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-26 Thread Boyang Chen
he API. Thanks again for the helpful suggestions! Best, Boyang From: Dong Lin Sent: Saturday, November 24, 2018 2:54 PM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey Boyang, Thanks for the update! Here are

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-23 Thread Dong Lin
coded > client ids to the group and replace the dead host, or as you proposed to > define spare host as > what I understood as hot backup. I will put both Jason and your > suggestions into a separate section > called "Future works". Note that this spare host ide

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-22 Thread Boyang Chen
through rebalance protocol IMO. Thank you again for the great feedback! Boyang ____________ From: Boyang Chen Sent: Thursday, November 22, 2018 3:39 PM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member i

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-21 Thread Boyang Chen
round Mayuresh ) Best, Boyang From: Mayuresh Gharat Sent: Wednesday, November 21, 2018 7:50 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hi Boyang, Thanks for updating the KIP. This is a

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-20 Thread Mayuresh Gharat
nce > > duplicate member.name issue could be handled by join group request. We > > shall reject join group with known member name but no member id (which > > means we already have an active member using this identity). > > 6. I agree to remove that internal config once we mo

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-20 Thread Boyang Chen
that internal config once we move forward with > static membership. And I already removed the entire section from the KIP. > > Let me know if you have other concerns. > > Best, > Boyang > > From: Guozhang Wang > Sent: Tuesday, November 20, 20

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-20 Thread Konstantine Karantasis
. > > Let me know if you have other concerns. > > Best, > Boyang > ____________ > From: Guozhang Wang > Sent: Tuesday, November 20, 2018 4:21 PM > To: dev > Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by > specifying m

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-20 Thread Boyang Chen
: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hello Boyang, Thanks a lot for the KIP! It is a great write-up and I appreciate your patience answering to the feedbacks from the community. I'd like to add my 2cents here: 1. By introducing another two timeout

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-20 Thread Guozhang Wang
Hello Boyang, Thanks a lot for the KIP! It is a great write-up and I appreciate your patience answering to the feedbacks from the community. I'd like to add my 2cents here: 1. By introducing another two timeout configs, registration_timeout and expansion_timeout, we are effectively having four

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-17 Thread Dong Lin
Hey Boyang, Thanks for the proposal! This is very useful. I have some comments below: 1) The motivation currently explicitly states that the goal is to improve performance for heavy state application. It seems that the motivation can be stronger with the following use-case. Currently for

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-16 Thread Boyang Chen
like I mentioned above for replication (auto healing during > > mid-night if one broker is never back), we could continue discussing the > > new approaches to have basic guarantee of consumer group liveness. > > > > > > The discussion so far is to make sure that all th

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-16 Thread Colin McCabe
is never back), we could continue discussing the > > new approaches to have basic guarantee of consumer group liveness. > > > > > > The discussion so far is to make sure that all the design approaches we > > have taken are pointing to real scenarios. Once we clarify the

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-16 Thread Jason Gustafson
. I hope these > discussions make sense. Thanks again for helping make the design solid! > > > Boyang > > > From: Jason Gustafson > Sent: Thursday, November 15, 2018 9:54 AM > To: dev > Subject: Re: [DISCUSS] KIP-345: Reduce multiple

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-14 Thread Boyang Chen
sions make sense. Thanks again for helping make the design solid! Boyang From: Jason Gustafson Sent: Thursday, November 15, 2018 9:54 AM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id > > I feel this would ma

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-14 Thread Jason Gustafson
yang > > ____________ > From: Jason Gustafson > Sent: Wednesday, November 14, 2018 9:31 AM > To: dev > Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by > specifying member id > > Hey Boyang, > > Thanks for the updates. From a h

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-14 Thread Boyang Chen
n correspondingly in the > follow-up KIPs. > > > Boyang > > > From: Mayuresh Gharat > Sent: Sunday, November 11, 2018 1:06 PM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by > specifying member id > >

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-13 Thread Jason Gustafson
> Boyang > > > From: Mayuresh Gharat > Sent: Sunday, November 11, 2018 1:06 PM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by > specifying member id > > Hi Boyang, > > Thanks

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-12 Thread Boyang Chen
ets topic. I will do more analysis and make a trade-off > comparison. Nice catch! > > > I hope the explanations make sense to you. I will keep polishing on the > edge cases and details. > > > Best, > > Boyang > > ____________ > From:

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-10 Thread Mayuresh Gharat
ore analysis and make a trade-off > comparison. Nice catch! > > > I hope the explanations make sense to you. I will keep polishing on the > edge cases and details. > > > Best, > > Boyang > > ____________ > From: Mayuresh Gharat > Sent: Sat

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-09 Thread Boyang Chen
g From: Mayuresh Gharat Sent: Saturday, November 10, 2018 10:25 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hi Boyang, Thanks for the KIP and sorry for being late to the party. This KIP

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-09 Thread Mayuresh Gharat
is great client proposal. This is great complementation to KIP 345. In a > high level, we are not having any collision on the path and both proposals > are making sense here. Just need better sync to avoid duplicate effort :) > > > Best, > > Boyang > > > ___

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-07 Thread Boyang Chen
cess of KIP-345. From: Matthias J. Sax Sent: Wednesday, November 7, 2018 7:02 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey, there was quite a pause on this KIP discussion and

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-06 Thread Boyang Chen
AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey, there was quite a pause on this KIP discussion and in the mean time, a new design for incremental cooporative rebalance was suggested: https://cwiki.apache.org/confluen

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-06 Thread Matthias J. Sax
uce admin API in this KIP or a separate one. > > > Thanks again for the proposed ideas! > > > Boyang > > ____________ > From: Mike Freyberger > Sent: Monday, November 5, 2018 6:13 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-05 Thread Boyang Chen
, but agree we could discuss whether we want to introduce admin API in this KIP or a separate one. Thanks again for the proposed ideas! Boyang From: Mike Freyberger Sent: Monday, November 5, 2018 6:13 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-3

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-11-05 Thread Mike Freyberger
gt; >> send a > >>>>>> leave group request (static membership mode). In static membership, > >>> we > >>>>> will > >>>>>> also define `change-group-timeout` to hold on rebalance provided by

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-10-29 Thread Boyang Chen
IP with our newly discussed items and details. Really excited to see the design has become more solid. Best, Boyang From: Jason Gustafson Sent: Saturday, August 25, 2018 6:04 AM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specif

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-10-28 Thread Boyang Chen
e design has become more solid. Best, Boyang From: Jason Gustafson Sent: Saturday, August 25, 2018 6:04 AM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey Mike, Yeah, that's a good point. A l

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-24 Thread Jason Gustafson
mber`. If not, this means there > >>> are > >>>>>> duplicate consumer members with same member name and the request > >> will > >>>> be > >>>>>> rejected to guarantee consumption uniqueness. > >>>>>> &g

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-24 Thread Mike Freyberger
>>>>>> So we will wait for all the members to rejoin the group and do >>> exactly >>>>> one >>>>>> rebalance since all members are expected to rejoin within timeout. >> If >>>>>> consumer crashes, t

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-24 Thread Jason Gustafson
etween dynamic to static membership. > > > > > > > > > > 1. Dynamic to static: the first joiner shall revise the > membership > > > to > > > > > static and wait for all the current members to restart, since their > > > > >

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-24 Thread Guozhang Wang
gt; > > > smooth: just erase the cached mapping, and wait for session timeout > to > > > > trigger rebalance should be sufficient. (Fallback to current > behavior) > > > > 3. Halfway switch: a corner case is like some clients keep dynamic > > > &

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-24 Thread Jason Gustafson
cause dynamic/static states are > > > bouncing each other. This could guarantee that we will not make the > > > consumer group work in a wrong state by having half static and half > > dynamic. > > > > > > To guarantee correctness, we will also pus

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-23 Thread Guozhang Wang
e KIP. > > > > > > Are there any concern for this high level proposal? Just want to > reiterate > > on the core idea of the KIP: "If the broker recognize this consumer as an > > existing member, it shouldn't trigger rebalance". > > > > Thanks a lot

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-21 Thread John Roesler
st want to reiterate > on the core idea of the KIP: "If the broker recognize this consumer as an > existing member, it shouldn't trigger rebalance". > > Thanks a lot for everyone's input! I feel this proposal is much more > robust than previous one! > > > Best, >

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-20 Thread Boyang Chen
ldn't trigger rebalance". Thanks a lot for everyone's input! I feel this proposal is much more robust than previous one! Best, Boyang From: Matthias J. Sax Sent: Friday, August 10, 2018 2:24 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduc

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-09 Thread Matthias J. Sax
Hi, thanks for the detailed discussion. I learned a lot about internals again :) I like the idea or a user config `member.name` and to keep `member.id` internal. Also agree with Guozhang, that reusing `client.id` might not be a good idea. To clarify the algorithm, each time we generate a new

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-07 Thread Guozhang Wang
@James What you described is true: the transition from dynamic to static memberships are not thought through yet. But I do not think it is an impossible problem: note that we indeed moved the offset commit from ZK to kafka coordinator in 0.8.2 :) The migration plan is to first to double-commits

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-07 Thread James Cheng
Guozhang, in a previous message, you proposed said this: > On Jul 30, 2018, at 3:56 PM, Guozhang Wang wrote: > > 1. We bump up the JoinGroupRequest with additional fields: > > 1.a) a flag indicating "static" or "dynamic" membership protocols. > 1.b) with "static" membership, we also add the

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-06 Thread Boyang Chen
From: Guozhang Wang Sent: Monday, August 6, 2018 8:46 AM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Re: reuse of "client.id": good question. Although client.id could be unique to guarantee fencing, by using it we are binding

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-05 Thread Guozhang Wang
o a minor comment is that our current codebase has two different > > classes: the GroupCoordinator and ConsumerCoordinator. When talking about > > term "coordinator", it would be great to distinguish between the two, or > > explicitly nominate broker coordinator as d

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-04 Thread Boyang Chen
! From: Guozhang Wang Sent: Saturday, August 4, 2018 5:25 AM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id @Boyang, * Yes registry id should be generated via a config, similar to what you proposed in the KIP currently for member

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-03 Thread Guozhang Wang
t;, it would be great to distinguish between the two, or > explicitly nominate broker coordinator as default "coordinator". > > > Best, > > Boyang > > ________ > From: Guozhang Wang > Sent: Thursday, August 2, 2018 1:59 AM > To: dev

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-03 Thread John Roesler
uld be great to distinguish between the two, or > explicitly nominate broker coordinator as default "coordinator". > > > Best, > > Boyang > > ____________ > From: Guozhang Wang > Sent: Thursday, August 2, 2018 1:59 AM > To: dev > Subj

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-03 Thread Boyang Chen
: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey Guozhang, thanks for this detailed proposal! Quickly I want to clarify, where this registry id is generated? My understanding is that the registry id is a unique id provided by user correct? This way even if multiple

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-01 Thread Boyang Chen
___ From: Guozhang Wang Sent: Thursday, August 2, 2018 1:59 AM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hello Boyang, Thanks for the great summary. Personally I think 1) is still doable as we are not necessarily have to rel

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-01 Thread Guozhang Wang
plex (no source of truth model). Hope we are on > the same page now. > > > Best, > > Boyang > > ____________ > From: John Roesler > Sent: Wednesday, August 1, 2018 5:28 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-345: Reduce multi

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-08-01 Thread Boyang Chen
ly complex (no source of truth model). Hope we are on the same page now. Best, Boyang From: John Roesler Sent: Wednesday, August 1, 2018 5:28 AM To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying mem

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-31 Thread John Roesler
> > > Sent: Saturday, July 28, 2018 6:50 AM > > > > > To: dev > > > > > Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer > > > rebalances > > > > by > >

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-30 Thread Guozhang Wang
> > > > instance, where each Stream thread will be using one > dedicated > > main > > > > consumer. So in a Stream use case, we could internally > generate > > > member id > > > > with USER_DEFINED_ID + STREAM_THRE

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-30 Thread Guozhang Wang
> > > understand the problem, and use the same set of initialization > logic > > cross > > > multiple consumers on the same instance. > > > > > > > > > I hope I have explained my understanding of the pros and co

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-30 Thread Jason Gustafson
; > advanced config, user may use member id config even before > they fully > > > understand the problem, and use the same set of initialization > logic > > cross > > > multiple consumers on the same instance. > > > > > &

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-30 Thread Mike Freyberger
oup be functional, but the > rebalancing be > > > non-optimal and require more round-trips/data-transfer? (similar > to the > > > current algorithm) > > > > > > I'm trying to assess the potential for u

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-30 Thread Guozhang Wang
motivation to leader-follower rebalance model, I feel that having > broker to > > create membership info and let client maintain would be less > appealing and > > fragile. Having client generate membership data could build up > > source-of-truth model and streamline the curr

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-30 Thread Mike Freyberger
server side. To simplify the first version, we do not plan > to > > enforce validation. A good comparison would be the EOS producer which is > in > > charge of generating unique transaction id sequence. IMO for broker > logic, > > the tolerance of cli

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-30 Thread Jason Gustafson
gt; > port) on the server side. To simplify the first version, we do not plan > to > > enforce validation. A good comparison would be the EOS producer which is > in > > charge of generating unique transaction id sequence. IMO for broker > logic, > > the tolerance

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-28 Thread Boyang Chen
t: Saturday, July 28, 2018 6:50 AM To: dev Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id Hey Boyang, Thanks for the KIP. I think my main question is in the same vein as James'. The problem is that the coordinator needs to be able to ide

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread Jason Gustafson
broker logic, > the tolerance of client side error is not unlimited. > > > > > > Thank you! > > > > > > ________________ > > From: James Cheng > > Sent: Saturday, July 28, 2018 1:26 AM > > To: dev@kafka.apache.org > > Subject: Re: [DISCUSS] K

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread James Cheng
c, the > tolerance of client side error is not unlimited. > > > Thank you! > > > > From: James Cheng > Sent: Saturday, July 28, 2018 1:26 AM > To: dev@kafka.apache.org > Subject: Re: [DISCUSS] KIP-345: Reduce multiple consumer re

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread Boyang Chen
-345: Reduce multiple consumer rebalances by specifying member id > On Jul 26, 2018, at 11:09 PM, Guozhang Wang wrote: > > Hi Boyang, > > Thanks for the proposed KIP. I made a pass over the wiki and here are some > comments / questions: > > 1. In order to preserve broke

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread James Cheng
> On Jul 26, 2018, at 11:09 PM, Guozhang Wang wrote: > > Hi Boyang, > > Thanks for the proposed KIP. I made a pass over the wiki and here are some > comments / questions: > > 1. In order to preserve broker compatibility, we need to make sure the > broker version discovery logic can be

Re: [DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-27 Thread Guozhang Wang
Hi Boyang, Thanks for the proposed KIP. I made a pass over the wiki and here are some comments / questions: 1. In order to preserve broker compatibility, we need to make sure the broker version discovery logic can be integrated with this new logic. I.e. if a newer versioned consumer is talking

[DISCUSS] KIP-345: Reduce multiple consumer rebalances by specifying member id

2018-07-26 Thread Boyang Chen
Hey friends, I would like to open a discussion thread on KIP-345: https://cwiki.apache.org/confluence/display/KAFKA/KIP-345%3A+Reduce+multiple+consumer+rebalances+by+specifying+member+id This KIP is trying to resolve multiple rebalances by maintaining the consumer member id across rebalance