Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

2019-09-18 Thread Randall Hauch
Thanks, Konstantine. I'm looking forward to a vote. On Wed, Sep 18, 2019 at 8:50 AM Konstantine Karantasis < konstant...@confluent.io> wrote: > Hi Randall. > > I'd also love to enable MDC by default. > However I agree with your concerns regarding compatibility. Runtime logs > are a form of

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

2019-09-18 Thread Konstantine Karantasis
Hi Randall. I'd also love to enable MDC by default. However I agree with your concerns regarding compatibility. Runtime logs are a form of public interface (as I believe has been discussed before) and therefore enabling MDC in the console requires a major version bump. Now, enabling it only for

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

2019-09-16 Thread Randall Hauch
Thanks for tackling this, Konstantine. The KIP looks great. My only question is about whether to enable the recent MDC variable in the file log format, but for backward compatibility reasons keep it as-is for the console. I suspect using the same format in the log files and the console would be

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

2019-09-11 Thread Konstantine Karantasis
Thanks Gwen! Indeed, it's a common setup and it's been missing for some time. I agree, it'll be nice to have this in place by default. I'm guessing previous attempts missed that such a change needs a KIP. Cheers, Konstantine On Wed, Sep 11, 2019 at 2:16 PM Gwen Shapira wrote: > Great idea.

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

2019-09-11 Thread Gwen Shapira
Great idea. It will greatly improve the ops experience. Can't believe we didn't do it before. On Wed, Sep 11, 2019 at 2:07 PM Konstantine Karantasis wrote: > > *** Missed the [DISCUSS] tag in the previous email. Reposting here, please > reply in this thread instead *** > > Hi all. > > While we

[DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

2019-09-11 Thread Konstantine Karantasis
*** Missed the [DISCUSS] tag in the previous email. Reposting here, please reply in this thread instead *** Hi all. While we are in the midst of some very interesting KIP discussions, I'd like to bring a brief and useful KIP on the table as well. It's about enabling redirection of log4j logging

KIP-521: Enable redirection of Connect's log4j messages to a file by default

2019-09-11 Thread Konstantine Karantasis
Hi all. While we are in the midst of some very interesting KIP discussions, I'd like to bring a brief and useful KIP on the table as well. It's about enabling redirection of log4j logging to a file for Kafka Connect by default, in a way similar to how this is done for Kafka brokers today. You