Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-09-19 Thread José Armando García Sancio
+1 from me. Thanks for your help David. Much appreciated. On Mon, Sep 19, 2022 at 10:29 AM David Arthur wrote: > > Hey folks, José has asked me to help push the release along this week while > he's out of the office. > > -David > > On Tue, Aug 30, 2022 at 12:01 PM José Armando García Sancio >

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-09-19 Thread David Arthur
Hey folks, José has asked me to help push the release along this week while he's out of the office. -David On Tue, Aug 30, 2022 at 12:01 PM José Armando García Sancio wrote: > Thanks Artem and Colin for identifying and fixing the issues > KAFKA-14156 and KAFKA-14187. I have marked both of them

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-30 Thread José Armando García Sancio
Thanks Artem and Colin for identifying and fixing the issues KAFKA-14156 and KAFKA-14187. I have marked both of them as blocker for this release. I also don't think that these issues should block testing other parts of the release. Thanks José

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-30 Thread Artem Livshits
Hi José , I found a potential regression in the new Sticky Partitioner logic, details are here https://issues.apache.org/jira/browse/KAFKA-14156. I've added a draft PR, will add unit tests soon. I think we should include the fix into 3.3.0. -Artem On Mon, Aug 29, 2022 at 1:17 PM Colin McCabe

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-29 Thread Colin McCabe
Hi José, Thanks for creating the first RC. I found an issue where kafka-feature.sh needs some work for KRaft. So, it looks like we will have to sink this RC. I opened a blocker JIRA, KAFKA-14187, and attached a PR. This should not block testing of other parts of the release, so hopefully we

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-29 Thread José Armando García Sancio
The documentation and protocol links are not working. Looking into it. https://kafka.apache.org/33/documentation.html https://kafka.apache.org/33/protocol.html Thanks, -José

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-29 Thread José Armando García Sancio
Hello Kafka users, developers and client-developers, This is the first candidate for release of Apache Kafka 3.3.0. Release notes for the 3.3.0 release: https://home.apache.org/~jsancio/kafka-3.3.0-rc1/RELEASE_NOTES.html Please download and test. Kafka's KEYS file containing PGP keys we use to

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-05 Thread José Armando García Sancio
Hi Apache Kafka Committers, I need some help reviewing PRs for 3.3. I created a GitHub label for 3.3 . I marked all of the PRs that were associated with a Jira that was targeting 3.3.0 . I also added components labels to some of the PRs. If you have some time to review and merge those PRs, it is

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
On Thu, Aug 4, 2022 at 2:33 PM Niket Goel wrote: > I would like to request adding KIP-859 [1] to the 3.3.0 release. The KIP > adds some important metrics to allow visibility into KRaft log processing > related errors. Thanks Niket. Adding these metrics to the 3.3.0 release should be okay since

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread Niket Goel
(hit send too soon) KIP -- https://cwiki.apache.org/confluence/display/KAFKA/KIP-859%3A+Add+Metadata+Log+Processing+Error+Related+Metrics JIRA -- https://issues.apache.org/jira/browse/KAFKA-14114 On Thu, Aug 4, 2022 at 2:33 PM Niket Goel wrote: > Hey Jose, > > I would like to request adding

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread Niket Goel
Hey Jose, I would like to request adding KIP-859 [1] to the 3.3.0 release. The KIP adds some important metrics to allow visibility into KRaft log processing related errors. The KIP was approved today and I have a PR ready for review, which I hope should get reviewed and merged within next week.

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
On Thu, Aug 4, 2022 at 8:37 AM Justine Olshan wrote: > > Hey Jose. > I found a gap in handling ISR changes in ZK mode. We just need to prevent > brokers that are offline from being added to ISR. Since KIP-841 is part of > this release and the fix should be small (a few lines), I propose adding >

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread Chris Egerton
> On Wed, Jul 13, 2022 at 10:01 AM Sagar wrote: > > Well actually I have 2 approved PRs from Kafka Connect: > > > > https://github.com/apache/kafka/pull/12321 > > https://github.com/apache/kafka/pull/12309 > > > > Not sure how to get these merged though but I think these can go into 3.3 > >

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
On Thu, Jul 28, 2022 at 2:16 PM Chris Egerton wrote: > Would it be okay to backport https://github.com/apache/kafka/pull/12451 to > the current 3.3 branch? It's a strictly cosmetic change that updates a > misleading comment about exactly-once support for source connectors. I'm > hoping it'll

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread Justine Olshan
Hey Jose. I found a gap in handling ISR changes in ZK mode. We just need to prevent brokers that are offline from being added to ISR. Since KIP-841 is part of this release and the fix should be small (a few lines), I propose adding https://issues.apache.org/jira/browse/KAFKA-14140 to the 3.3

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
On Mon, Aug 1, 2022 at 1:51 AM Matthew Benedict de Detrich wrote: > Due to time pressure from the release schedule does it make sense to merge > the PR as is since it already has the necessary approval from Luke or should > we wait for finale reviews from Mickael/Tom as well? Thanks for the

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
On Thu, Jul 21, 2022 at 8:10 PM Luke Chen wrote: > I just found the KIP-831 is not listed in the v3.3 planned KIPs. > It is completed and merged. > Please help add it. Thanks. It should now be in the 3.3.0 release page. -- -José

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
On Thu, Jul 21, 2022 at 1:56 PM Randall Hauch wrote: > Will you approve me merging the fix to the `3.3` branch for inclusion in > 3.3.0? Yes. I approved this fix for 3.3.0. Randall merged it to the 3.3.0 branch. -- -José

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
On Thu, Jul 14, 2022 at 4:55 PM Jason Gustafson wrote: > > Hey Jose, > > Thanks for volunteering to manage the release! KIP-833 is currently slotted > for 3.3. We've been getting some help from Jack Vanlighty to validate the > raft implementation in TLA+ and with frameworks like Jepsen. The >

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
On Wed, Jul 13, 2022 at 10:01 AM Sagar wrote: > Well actually I have 2 approved PRs from Kafka Connect: > > https://github.com/apache/kafka/pull/12321 > https://github.com/apache/kafka/pull/12309 > > Not sure how to get these merged though but I think these can go into 3.3 > release. Thank you

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-04 Thread José Armando García Sancio
Excuse the delay in the response. I was busy dealing with some potentially blocking issues for the 3.3.0 release. On Wed, Jul 13, 2022 at 4:33 AM Divij Vaidya wrote: > A few of my PRs are pending review for quite some which I was hoping to > merge into 3.3. I have already marked them with "Fix

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-01 Thread Matthew Benedict de Detrich
Just letting everyone know that in regards to KIP-797 (which was accepted in this release), the PR at https://github.com/apache/kafka/pull/11478 has received a binding approval from Luke Chen however we are still waiting for review from Mickael Maison/Tom Bently since they also reviewed the PR.

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-28 Thread Chris Egerton
Hi José, Would it be okay to backport https://github.com/apache/kafka/pull/12451 to the current 3.3 branch? It's a strictly cosmetic change that updates a misleading comment about exactly-once support for source connectors. I'm hoping it'll make life easier for anyone who has to debug this

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-21 Thread Luke Chen
Hi Jose, I just found the KIP-831 is not listed in the v3.3 planned KIPs. It is completed and merged. Please help add it. Thank you. Luke On Fri, Jul 22, 2022 at 4:56 AM Randall Hauch wrote: > Hi, Jose. > > Thanks for driving the 3.3.0 release. > > Chris E and Chris S both mentioned >

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-21 Thread Randall Hauch
Hi, Jose. Thanks for driving the 3.3.0 release. Chris E and Chris S both mentioned https://issues.apache.org/jira/browse/KAFKA-14079 in this thread a few days ago. This was deemed a critical bug fix for 3.2, and the PR for the `3.2` branch [1] has already been merged and is in the recently-cut

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-17 Thread Christopher Shannon
I submitted a tweaked PR for 3.3.0 based on the 3.2.1 fix here: https://github.com/apache/kafka/pull/12415 On Sun, Jul 17, 2022 at 1:52 PM Chris Egerton wrote: > Hi all, > > Although KAFKA-14079 is not a regression, it'd be nice if we could get it > into 3.3.0. As I mentioned on the 3.2.1

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-17 Thread Chris Egerton
Hi all, Although KAFKA-14079 is not a regression, it'd be nice if we could get it into 3.3.0. As I mentioned on the 3.2.1 release thread, the risk is fairly low (the functional changes are just two lines long), and the impact is high for users who have configured source connectors with

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-16 Thread Christopher Shannon
There is a bug I found that I think is worthwhile fixing in 3.3.0 (I also sent a note to 3.2.1 thread): https://issues.apache.org/jira/browse/KAFKA-14079 On Thu, Jul 14, 2022 at 7:56 PM Jason Gustafson wrote: > Hey Jose, > > Thanks for volunteering to manage the release! KIP-833 is currently

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-14 Thread Jason Gustafson
Hey Jose, Thanks for volunteering to manage the release! KIP-833 is currently slotted for 3.3. We've been getting some help from Jack Vanlighty to validate the raft implementation in TLA+ and with frameworks like Jepsen. The specification is written here if anyone is interested:

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-13 Thread Sagar
Hey Jose, Well actually I have 2 approved PRs from Kafka Connect: https://github.com/apache/kafka/pull/12321 https://github.com/apache/kafka/pull/12309 Not sure how to get these merged though but I think these can go into 3.3 release. Thanks! Sagar. On Wed, Jul 13, 2022 at 5:03 PM Divij

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-13 Thread Divij Vaidya
Hey Jose A few of my PRs are pending review for quite some which I was hoping to merge into 3.3. I have already marked them with "Fix version=3.3.0" so that you can track them using the JIRA filter you shared earlier

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-11 Thread José Armando García Sancio
Hi all, I created the branch for 3.3 (https://github.com/apache/kafka/tree/3.3). If you have bug fixes for the 3.3.0 release please make sure to cherry pick them to that branch. Thanks

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-08 Thread Rajini Sivaram
Thank you, Jose. Regards, Rajini On Fri, Jul 8, 2022 at 2:43 PM José Armando García Sancio wrote: > On Fri, Jul 8, 2022 at 6:37 AM Rajini Sivaram > wrote: > > We have a PR for batched offset fetch API, which is part of KIP-709 ( > > >

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-08 Thread José Armando García Sancio
On Fri, Jul 8, 2022 at 6:37 AM Rajini Sivaram wrote: > We have a PR for batched offset fetch API, which is part of KIP-709 ( > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=173084258) > that was opened a year ago, but didn't get merged because we didn't have > time to merge

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-08 Thread Rajini Sivaram
Hi Jose, We have a PR for batched offset fetch API, which is part of KIP-709 ( https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=173084258) that was opened a year ago, but didn't get merged because we didn't have time to merge into 3.0: https://github.com/apache/kafka/pull/10964.

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-07 Thread José Armando García Sancio
On Thu, Jul 7, 2022 at 7:20 AM Sagar wrote: > Pr for KIP-843 also got merged almost 24 days ago. There’s a follow up pr > open for documentation changes. Could this also be added plz? Thank you. Added KIP-843 to the list of KIPs for 3.3.0. I will create a release branch for 3.3 next Monday,

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-07 Thread Sagar
Hi Jose, Pr for KIP-843 also got merged almost 24 days ago. There’s a follow up pr open for documentation changes. Could this also be added plz? Sagar. On Thu, 7 Jul 2022 at 7:44 PM, José Armando García Sancio wrote: > Hi all, > > Friendly reminder that Feature Freeze was yesterday July 6th.

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-07-07 Thread José Armando García Sancio
Hi all, Friendly reminder that Feature Freeze was yesterday July 6th. The Code Freeze date is the 20th of July. On Wed, Jun 22, 2022 at 7:45 AM Viktor Somogyi-Vass wrote: > KIP-373 just went in yesterday (and likely add some docs too today), would > you please add it to the list? I added

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-22 Thread Viktor Somogyi-Vass
hi Jose, KIP-373 just went in yesterday (and likely add some docs too today), would you please add it to the list? Thanks, Viktor On Fri, Jun 17, 2022 at 11:45 AM Matthew Benedict de Detrich wrote: > Hi José, > > KIP-797 has been accepted and the associated PR is now ready, is it > possible

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-17 Thread Matthew Benedict de Detrich
Hi José, KIP-797 has been accepted and the associated PR is now ready, is it possible to add to the release? Regards On Thu, Jun 16, 2022 at 11:56 PM José Armando García Sancio wrote: > Hi Divij, > > On Thu, Jun 16, 2022 at 1:37 AM Divij Vaidya > wrote: > > *Question#1*: Do we only track the

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-16 Thread José Armando García Sancio
Hi Divij, On Thu, Jun 16, 2022 at 1:37 AM Divij Vaidya wrote: > *Question#1*: Do we only track the KIPs over here that are blockers for > release or do we track the non-KIP JIRA tickets as well? This page documents the KIPs and Jira issues I am tracking for the 3.3.0 release.

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-16 Thread Divij Vaidya
Hello *Question#1*: Do we only track the KIPs over here that are blockers for release or do we track the non-KIP JIRA tickets as well? If we don't track the JIRA tickets, please ignore the following, but if we do, I would like to propose that we fix/merge the following before release: 1.

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-15 Thread José Armando García Sancio
Hi all, This is a friendly reminder that the KIP freeze date is today, June 15th, 2022. The feature freeze date is July 6th, 2022. Thanks, -José

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-03 Thread José Armando García Sancio
Thanks for the updates everyone. I added KIP-618, KIP-841, KIP-827 and KIP-834 to the planned KIPs for 3.3.0. David Jacot, it looks like KIP-841 is not linked from the "Kafka Improvement Proposals" page: https://cwiki.apache.org/confluence/x/4QwIAw -- -José

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-03 Thread Jim Hughes
Hi José, Can we add KIP-834 as well? The vote has passed and I have PR in progress. Cheers, Jim On Fri, Jun 3, 2022 at 1:05 PM Mickael Maison wrote: > Hi José, > > Can we also add KIP-827? The vote has passed and I opened a PR today. > > Thanks, > Mickael > > On Fri, Jun 3, 2022 at 5:43 PM

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-03 Thread Mickael Maison
Hi José, Can we also add KIP-827? The vote has passed and I opened a PR today. Thanks, Mickael On Fri, Jun 3, 2022 at 5:43 PM David Jacot wrote: > > Hi José, > > KIP-841 has been accepted. Could we add it to the release plan? > > Thanks, > David > > On Wed, May 11, 2022 at 11:04 PM Chris

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-03 Thread David Jacot
Hi José, KIP-841 has been accepted. Could we add it to the release plan? Thanks, David On Wed, May 11, 2022 at 11:04 PM Chris Egerton wrote: > > Hi José, > > Could we add KIP-618 ( > https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors) > to

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-05-11 Thread Chris Egerton
Hi José, Could we add KIP-618 ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors) to the release plan? It's been blocked on review for almost a year now. If we can't make time to review it before the 3.3.0 release I'll probably close my PRs

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-05-11 Thread José Armando García Sancio
Great. I went ahead and created a release page for 3.3.0: https://cwiki.apache.org/confluence/x/-xahD The planned KIP content is based on the list of KIPs targeting 3.3.0 in https://cwiki.apache.org/confluence/x/4QwIAw. Please take a look at the list and let me know if I missed your KIP. The

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-05-11 Thread Bill Bejeck
Thanks for volunteering to run the release José! +1 -Bill On Wed, May 11, 2022 at 3:26 AM Bruno Cadonna wrote: > Thanks José! > > +1 > > Best, > Bruno > > On 11.05.22 04:38, John Roesler wrote: > > +1 from me! Thanks for volunteering, José. > > -John > > > > On Tue, May 10, 2022, at 17:53,

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-05-11 Thread Bruno Cadonna
Thanks José! +1 Best, Bruno On 11.05.22 04:38, John Roesler wrote: +1 from me! Thanks for volunteering, José. -John On Tue, May 10, 2022, at 17:53, José Armando García Sancio wrote: Hi all, I would like to volunteer for the release of Apache Kafka 3.3.0. If people agree, I'll start working

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-05-10 Thread John Roesler
+1 from me! Thanks for volunteering, José. -John On Tue, May 10, 2022, at 17:53, José Armando García Sancio wrote: > Hi all, > > I would like to volunteer for the release of Apache Kafka 3.3.0. If > people agree, I'll start working on the release plan and update this > thread. > > Thanks, >