[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150414_031627.patch > Improve consumer read performance for Windows > -

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493868#comment-14493868 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard against branch origin/0.8.

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150414_031627.patch) > Improve consumer read performance for Wind

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Updated reviewboard against branch origin/0.8.1) > Improve consumer rea

Review Request 33164: Patch for KAFKA-1646

2015-04-14 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33164/ --- Review request for kafka. Bugs: KAFKA-1646 https://issues.apache.org/jira/b

Re: Review Request 29091: Patch for KAFKA-1646

2015-04-14 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated April 14, 2015, 10:44 a.m.) Review request for kafka. Summary (updat

Re: Review Request 29091: Patch for KAFKA-1646

2015-04-14 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated April 14, 2015, 10:46 a.m.) Review request for kafka. Changes --

Re: Review Request 29091: Improve 1646 fix by add log.preallocate

2015-04-14 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated April 14, 2015, 10:54 a.m.) Review request for kafka. Summary (updat

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493899#comment-14493899 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150414_035415.patch > Improve consumer read performance for Windows > -

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493899#comment-14493899 ] Honghai Chen edited comment on KAFKA-1646 at 4/14/15 10:59 AM: -

[jira] [Commented] (KAFKA-1928) Move kafka.network over to using the network classes in org.apache.kafka.common.network

2015-04-14 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494177#comment-14494177 ] Sriharsha Chintalapani commented on KAFKA-1928: --- [~gwenshap] [~junrao] Are y

Review Request 33168: Fix recovery of swap files after broker crash

2015-04-14 Thread Rajini Sivaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33168/ --- Review request for kafka. Bugs: KAFKA-2118 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

2015-04-14 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494184#comment-14494184 ] Rajini Sivaram commented on KAFKA-2118: --- Created reviewboard https://reviews.apache.

[jira] [Updated] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

2015-04-14 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-2118: -- Assignee: Rajini Sivaram Status: Patch Available (was: Open) > Cleaner cannot clean after

[jira] [Updated] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

2015-04-14 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-2118: -- Attachment: KAFKA-2118.patch > Cleaner cannot clean after shutdown during replaceSegments >

[jira] [Commented] (KAFKA-2118) Cleaner cannot clean after shutdown during replaceSegments

2015-04-14 Thread Rajini Sivaram (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494214#comment-14494214 ] Rajini Sivaram commented on KAFKA-2118: --- Looking at the code, the sequence for repla

Re: Review Request 29091: Improve 1646 fix by add log.preallocate

2015-04-14 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/#review80031 --- This patch is looking really good. One minor issue but otherwise goo

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494314#comment-14494314 ] Jay Kreps commented on KAFKA-1646: -- Oh yes, also, we'll need a patch against trunk to be

[jira] [Updated] (KAFKA-2056) PartitionAssignorTest.testRangePartitionAssignor transient failure

2015-04-14 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated KAFKA-2056: -- Attachment: KAFKA-2056.patch > PartitionAssignorTest.testRangePartitionAssignor transient failure >

[jira] [Created] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-14 Thread Steven Zhen Wu (JIRA)
Steven Zhen Wu created KAFKA-2121: - Summary: error handling in KafkaProducer constructor Key: KAFKA-2121 URL: https://issues.apache.org/jira/browse/KAFKA-2121 Project: Kafka Issue Type: Bug

Re: [DISCUSS] error handling in java KafkaProducer

2015-04-14 Thread Steven Wu
Thanks, Ewen and Guozhang! I will go with the try-catch option then. here is the jira. feel free to assign it to me. I will try to submit a patch this week. https://issues.apache.org/jira/browse/KAFKA-2121 On Mon, Apr 13, 2015 at 7:17 PM, Guozhang Wang wrote: > It is a valid problem and we shou

PHP Kafka client

2015-04-14 Thread Elias Van Ootegem
Hello, I thought I'd send a quick mail to let you know that I'm currently working hard on a native PHP-Kafka client. Most of the heavy lifting is done by Magnus Edenhill's librdkafka C client, which you list as being robust and offering performance. I am going to keep working on this extension to

[jira] [Created] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-14 Thread Onur Karaman (JIRA)
Onur Karaman created KAFKA-2122: --- Summary: Remove controller.message.queue.size Config Key: KAFKA-2122 URL: https://issues.apache.org/jira/browse/KAFKA-2122 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-2046) Delete topic still doesn't work

2015-04-14 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494497#comment-14494497 ] Onur Karaman commented on KAFKA-2046: - I made a jira for this: https://issues.apache.o

[jira] [Commented] (KAFKA-1993) Enable topic deletion as default

2015-04-14 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494496#comment-14494496 ] Onur Karaman commented on KAFKA-1993: - I made the jira: https://issues.apache.org/jira

[jira] [Updated] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-14 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Status: Patch Available (was: Open) > error handling in KafkaProducer constructor > ---

[jira] [Updated] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-14 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121.patch.1 > error handling in KafkaProducer constructor > -

Re: [DISCUSS] error handling in java KafkaProducer

2015-04-14 Thread Steven Wu
I submitted a patch attempt in the jira. On Tue, Apr 14, 2015 at 10:16 AM, Steven Wu wrote: > Thanks, Ewen and Guozhang! > > I will go with the try-catch option then. here is the jira. feel free to > assign it to me. I will try to submit a patch this week. > https://issues.apache.org/jira/browse

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-14 Thread Mayuresh Gharat
I suppose adding this timeout will help. In cases were the broker is not completely down but stops responding to the produce request, tools like Mirror Makers will hang since they are waiting for responses. Adding this timeout enables it to fail the current request and retry with fresh metadata. T

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-04-14 Thread Jon Bringhurst (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494808#comment-14494808 ] Jon Bringhurst commented on KAFKA-1367: --- Hey [~jkreps], I can confirm that the metad

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-14 Thread Michael Herstine
Hi Parth, Sorry to chime in so late, but I’ve got a minor question on the KIP. Several methods take a parameter named “host” of type String. Is that intended to be a hostname, or an IP address? If the former, I’m curious as to how that’s found (in my experience, when accepting an incoming socket

Re: [DISCUSS] KIP-11- Authorization design for kafka security

2015-04-14 Thread Don Bosco Durai
I also feel, having just IP would be more appropriate. Host lookup will unnecessary slow things down and would be insecure as you pointed out. With IP, it will be also able to setup policies (in future if needed) with ranges or netmasks and it would be more scalable. Bosco On 4/14/15, 1:40 PM,

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-14 Thread Jiangjie Qin
Hi Ewen, thanks for the comments. Very good points! Please see replies inline. On 4/13/15, 11:19 PM, "Ewen Cheslack-Postava" wrote: >Jiangjie, > >Great start. I have a couple of comments. > >Under the motivation section, is it really true that the request will >never >be completed? Presumably i

[jira] [Commented] (KAFKA-1928) Move kafka.network over to using the network classes in org.apache.kafka.common.network

2015-04-14 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494861#comment-14494861 ] Gwen Shapira commented on KAFKA-1928: - This is still in-progress, but I'm working on a

[jira] [Updated] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-14 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: KAFKA-2121.patch.2 add a unit test file > error handling in KafkaProducer construct

Re: Review Request 31606: Patch for KAFKA-1416

2015-04-14 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31606/#review80122 --- Ship it! Ship It! - Guozhang Wang On April 11, 2015, 1:36 a.m.,

[jira] [Commented] (KAFKA-1416) Unify sendMessages/getMessages in unit tests

2015-04-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494967#comment-14494967 ] Guozhang Wang commented on KAFKA-1416: -- Thanks for the patch. +1 and pushed to trunk.

[jira] [Updated] (KAFKA-1416) Unify sendMessages/getMessages in unit tests

2015-04-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1416: - Resolution: Fixed Status: Resolved (was: Patch Available) > Unify sendMessages/getMessage

[jira] [Updated] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-14 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Zhen Wu updated KAFKA-2121: -- Attachment: (was: KAFKA-2121.patch.1) > error handling in KafkaProducer constructor > --

[jira] [Created] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-04-14 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-2123: Summary: Make new consumer offset commit API use callback + future Key: KAFKA-2123 URL: https://issues.apache.org/jira/browse/KAFKA-2123 Project: Kafka

Review Request 33196: Patch for KAFKA-2123

2015-04-14 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33196/ --- Review request for kafka. Bugs: KAFKA-2123 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-04-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2123: - Status: Patch Available (was: Open) > Make new consumer offset commit API use cal

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-04-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2123: - Attachment: KAFKA-2123.patch > Make new consumer offset commit API use callback +

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-04-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495012#comment-14495012 ] Ewen Cheslack-Postava commented on KAFKA-2123: -- Created reviewboard https://r

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-04-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2123: - Status: In Progress (was: Patch Available) Uploaded a patch to get some feedback,

Jenkins build is back to normal : Kafka-trunk #462

2015-04-14 Thread Apache Jenkins Server
See

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2015-04-14 Thread Jimmie Fulton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495043#comment-14495043 ] Jimmie Fulton commented on KAFKA-1490: -- This breaks the expected gradlew contract, an

Re: [DISCUSS] KIP-19 Add a request timeout to NetworkClient

2015-04-14 Thread Ewen Cheslack-Postava
On Tue, Apr 14, 2015 at 1:57 PM, Jiangjie Qin wrote: > Hi Ewen, thanks for the comments. Very good points! Please see replies > inline. > > > On 4/13/15, 11:19 PM, "Ewen Cheslack-Postava" wrote: > > >Jiangjie, > > > >Great start. I have a couple of comments. > > > >Under the motivation section,

Build failed in Jenkins: KafkaPreCommit #74

2015-04-14 Thread Apache Jenkins Server
See Changes: [wangguoz] KAFKA-1416; Unify sendMessages in TestUtils; reviewed by Guozhang Wang -- [...truncated 659 lines...] kafka.api.ProducerFailureHandlingTest > testWrongBrokerList PASSED kaf

Re: PHP Kafka client

2015-04-14 Thread Ewen Cheslack-Postava
This looks great Elias, thanks for working on this. I've added an entry (and a new section!) to the clients wiki page: https://cwiki.apache.org/confluence/display/KAFKA/Clients -Ewen On Tue, Apr 14, 2015 at 9:36 AM, Elias Van Ootegem wrote: > Hello, > > I thought I'd send a quick mail to let yo

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2015-04-14 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495079#comment-14495079 ] Jakob Homan commented on KAFKA-1490: bq. The current bootstrap workflow in kafka is so

[jira] [Created] (KAFKA-2124) gradlew is not working on a fresh checkout

2015-04-14 Thread Jakob Homan (JIRA)
Jakob Homan created KAFKA-2124: -- Summary: gradlew is not working on a fresh checkout Key: KAFKA-2124 URL: https://issues.apache.org/jira/browse/KAFKA-2124 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1490) remove gradlew initial setup output from source distribution

2015-04-14 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495084#comment-14495084 ] Jakob Homan commented on KAFKA-1490: Linking to issue to track current gradlew splat.

Re: PHP Kafka client

2015-04-14 Thread Gwen Shapira
There is a mailing list specific for Kafka clients: https://groups.google.com/forum/#!forum/kafka-clients You probably want to announce your client there. Gwen On Tue, Apr 14, 2015 at 9:36 AM, Elias Van Ootegem wrote: > Hello, > > I thought I'd send a quick mail to let you know that I'm current

[jira] [Commented] (KAFKA-2124) gradlew is not working on a fresh checkout

2015-04-14 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495104#comment-14495104 ] Gwen Shapira commented on KAFKA-2124: - Yep yep. Known issue and documented in the READ

[jira] [Comment Edited] (KAFKA-2124) gradlew is not working on a fresh checkout

2015-04-14 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495104#comment-14495104 ] Gwen Shapira edited comment on KAFKA-2124 at 4/14/15 11:09 PM: -

[jira] [Commented] (KAFKA-2124) gradlew is not working on a fresh checkout

2015-04-14 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495114#comment-14495114 ] Jakob Homan commented on KAFKA-2124: We can package the jar in the repo, we just need

[HALP] Kafka-1928 - connection ids, destinations and sources

2015-04-14 Thread Gwen Shapira
Hi, A lot of the client network code has the assumption that I know where I'm connecting to - specifically that a connection always has a specific broker ID. Sends have "dest", Recieves have "source" and Selector has an id for connections which is often referred to as source or dest... Server cod

Re: [HALP] Kafka-1928 - connection ids, destinations and sources

2015-04-14 Thread Gwen Shapira
Actually, a key will not exist when I register a connection with Selector - but the local port can be a a connection ID. On Tue, Apr 14, 2015 at 4:18 PM, Gwen Shapira wrote: > Hi, > > A lot of the client network code has the assumption that I know where > I'm connecting to - specifically that a c

[DISCUSS] New consumer offset commit API

2015-04-14 Thread Ewen Cheslack-Postava
I'd like to get some feedback on changing the offset commit API in the new consumer. Since this is user-facing API I wanted to make sure this gets better visibility than the JIRA ( https://issues.apache.org/jira/browse/KAFKA-2123) might. The motivation is to make it possible to do async commits bu

Re: [HALP] Kafka-1928 - connection ids, destinations and sources

2015-04-14 Thread Gwen Shapira
of course thats an even worse idea :) Never mind and I'll stop spamming the list while at a conference... On Tue, Apr 14, 2015 at 4:28 PM, Gwen Shapira wrote: > Actually, a key will not exist when I register a connection with > Selector - but the local port can be a a connection ID. > > On Tue, A

RE: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-14 Thread Aditya Auradkar
This is an implementation proposal for delaying requests in quotas using the current purgatory. I'll discuss the usage for produce and fetch requests separately. 1. Delayed Produce Requests - Here, the proposal is basically to reuse DelayedProduce objects and insert them into the purgatory with

[jira] [Commented] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495183#comment-14495183 ] Ewen Cheslack-Postava commented on KAFKA-2121: -- [~stevenz3wu] looks like a go

[jira] [Commented] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-14 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495206#comment-14495206 ] Steven Zhen Wu commented on KAFKA-2121: --- I will create a item on reviewboard. will t

[jira] [Comment Edited] (KAFKA-2121) error handling in KafkaProducer constructor

2015-04-14 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495206#comment-14495206 ] Steven Zhen Wu edited comment on KAFKA-2121 at 4/15/15 12:30 AM: ---

[jira] [Commented] (KAFKA-2056) PartitionAssignorTest.testRangePartitionAssignor transient failure

2015-04-14 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495463#comment-14495463 ] Fangmin Lv commented on KAFKA-2056: --- [~guozhang] I attached a patch, within which the co

[jira] [Created] (KAFKA-2125) Infinite loop after controlled shutdown succeeds

2015-04-14 Thread Jason Rosenberg (JIRA)
Jason Rosenberg created KAFKA-2125: -- Summary: Infinite loop after controlled shutdown succeeds Key: KAFKA-2125 URL: https://issues.apache.org/jira/browse/KAFKA-2125 Project: Kafka Issue Type

Re: Review Request 29091: Improve 1646 fix by add log.preallocate

2015-04-14 Thread Qianlin Xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated April 15, 2015, 1:45 a.m.) Review request for kafka. Bugs: KAFKA-164

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495541#comment-14495541 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150414_184503.patch > Improve consumer read performance for Windows > -

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495541#comment-14495541 ] Honghai Chen edited comment on KAFKA-1646 at 4/15/15 1:49 AM: --

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646.patch > Improve consumer read performance for Windows > -

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495592#comment-14495592 ] Honghai Chen commented on KAFKA-1646: - Created reviewboard against branch origin/trun

Review Request 33204: Patch for KAFKA-1646

2015-04-14 Thread Honghai Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33204/ --- Review request for kafka. Bugs: KAFKA-1646 https://issues.apache.org/jira/b

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-14 Thread Honghai Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495592#comment-14495592 ] Honghai Chen edited comment on KAFKA-1646 at 4/15/15 3:28 AM: --