Review Request 36474: Patch for KAFKA-2188

2015-07-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36474/ --- Review request for kafka. Bugs: KAFKA-2188

Re: Build failed in Jenkins: KafkaPreCommit #147

2015-07-14 Thread Gwen Shapira
Looks like ConsumerBounceTest is flaky. Anyone knows if there's a JIRA for it? It seemed to be failing more-or-less at random in the last few builds. On Mon, Jul 13, 2015 at 10:48 PM, Apache Jenkins Server jenk...@builds.apache.org wrote: See

Build failed in Jenkins: Kafka-trunk #541

2015-07-14 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/541/changes Changes: [cshapi] KAFKA-2198: kafka-topics.sh exits with 0 status on failures; patched by Manikumar Reddy reviewed by Gwen Shapira -- [...truncated 1443 lines...] kafka.log.LogTest

[jira] [Updated] (KAFKA-2198) kafka-topics.sh exits with 0 status on failures

2015-07-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2198: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch

[jira] [Commented] (KAFKA-2188) JBOD Support

2015-07-14 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14625910#comment-14625910 ] Timothy Chen commented on KAFKA-2188: - Created reviewboard

[jira] [Updated] (KAFKA-2188) JBOD Support

2015-07-14 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-2188: Attachment: KAFKA-2188.patch JBOD Support Key: KAFKA-2188

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-14 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated July 14, 2015, 10:03 a.m.) Review request for kafka. Bugs:

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-14 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/ --- (Updated July 14, 2015, 10:13 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2320) Configure GitHub pull request build in Jenkins

2015-07-14 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-2320: --- Description: The details are available in the following Apache Infra post:

Re: [DISCUSS] Using GitHub Pull Requests for contributions and code review

2015-07-14 Thread Ismael Juma
Hi Jun, On Tue, Jul 14, 2015 at 2:09 AM, Jun Rao j...@confluent.io wrote: Ismael, I followed the instructions in KAFKA-2320 and created a new Jenkins job ( https://builds.apache.org/job/kafka-trunk-git-pr/). Could you check if it works? Thanks! It seems to be building when trunk changes

Re: Review Request 34641: Patch for KAFKA-2214

2015-07-14 Thread Manikumar Reddy O
On May 26, 2015, 7:08 a.m., Michael Noll wrote: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala, line 81 https://reviews.apache.org/r/34641/diff/1/?file=971195#file971195line81 Should we also consider reassignments that are in-progress as errors? The

[GitHub] kafka pull request: KAFKA-1595; Remove deprecated and slower scala...

2015-07-14 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/74 KAFKA-1595; Remove deprecated and slower scala JSON parser A thin wrapper over Jackson's Tree Model API is used as the replacement. This wrapper increases safety while providing a simple, but

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Stefan Miklosovic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626122#comment-14626122 ] Stefan Miklosovic commented on KAFKA-1835: -- Awesome discussion guys! I love to

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626050#comment-14626050 ] ASF GitHub Bot commented on KAFKA-1595: --- GitHub user ijuma opened a pull request:

[jira] [Updated] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2214: --- Attachment: KAFKA-2214_2015-07-14_15:40:49.patch kafka-reassign-partitions.sh --verify

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626157#comment-14626157 ] Manikumar Reddy commented on KAFKA-2214: Updated reviewboard

[jira] [Commented] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626148#comment-14626148 ] Manikumar Reddy commented on KAFKA-2214: Updated reviewboard

[jira] [Updated] (KAFKA-2214) kafka-reassign-partitions.sh --verify should return non-zero exit codes when reassignment is not completed yet

2015-07-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2214: --- Attachment: KAFKA-2214_2015-07-14_15:31:12.patch kafka-reassign-partitions.sh --verify

[jira] [Updated] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

2015-07-14 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated KAFKA-2300: Attachment: KAFKA-2300.patch Attaching a preliminary patch in the case anyone is willing to

[jira] [Comment Edited] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

2015-07-14 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626247#comment-14626247 ] Flavio Junqueira edited comment on KAFKA-2300 at 7/14/15 1:13 PM:

Re: Review Request 35867: Patch for KAFKA-1901

2015-07-14 Thread Manikumar Reddy O
On July 14, 2015, 1:59 a.m., Joel Koshy wrote: core/src/main/scala/kafka/common/AppInfo.scala, line 27 https://reviews.apache.org/r/35867/diff/3/?file=1004947#file1004947line27 Per the comment in the previous diff, I think this can go now right? i.e., kafka server depends on

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-07-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1901: --- Attachment: KAFKA-1901_2015-07-14_17:59:56.patch Move Kafka version to be generated in code

Re: Review Request 35867: Patch for KAFKA-1901

2015-07-14 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/ --- (Updated July 14, 2015, 12:32 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

2015-07-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626292#comment-14626292 ] Manikumar Reddy commented on KAFKA-1901: Updated reviewboard

Re: Build failed in Jenkins: KafkaPreCommit #147

2015-07-14 Thread Guozhang Wang
I think there is no JIRA ticket created for ConsumerBounceTest yet. We can create a new one for it. On Tue, Jul 14, 2015 at 4:12 AM, Ismael Juma ism...@juma.me.uk wrote: On Tue, Jul 14, 2015 at 7:01 AM, Gwen Shapira csh...@gmail.com wrote: Looks like ConsumerBounceTest is flaky. Anyone knows

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626627#comment-14626627 ] Guozhang Wang commented on KAFKA-1835: -- [~becket_qin][~smiklosovic][~ewencp] I think

[jira] [Updated] (KAFKA-2188) JBOD Support

2015-07-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2188: --- Reviewer: Jun Rao (was: Jay Kreps) JBOD Support Key: KAFKA-2188

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

2015-07-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2210: --- Reviewer: Jun Rao KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

2015-07-14 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626663#comment-14626663 ] Parth Brahmbhatt commented on KAFKA-2210: - Updated reviewboard

Re: Build failed in Jenkins: KafkaPreCommit #147

2015-07-14 Thread Jason Gustafson
Looks like there is already KAFKA-2055 for the transient ConsumerBounceTest failure. I'll have a look at it. -Jason On Tue, Jul 14, 2015 at 9:02 AM, Guozhang Wang wangg...@gmail.com wrote: I think there is no JIRA ticket created for ConsumerBounceTest yet. We can create a new one for it. On

Re: Build failed in Jenkins: KafkaPreCommit #147

2015-07-14 Thread Guozhang Wang
Ohhh ... you are right, and I cannot believe it was created by myself, totally forgot about that. On Tue, Jul 14, 2015 at 9:30 AM, Jason Gustafson ja...@confluent.io wrote: Looks like there is already KAFKA-2055 for the transient ConsumerBounceTest failure. I'll have a look at it. -Jason

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-07-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2123: --- Reviewer: Guozhang Wang (was: Jay Kreps) Make new consumer offset commit API use callback + future

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

2015-07-14 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2210: Attachment: KAFKA-2210_2015-07-14_10:02:19.patch KafkaAuthorizer: Add all public entities,

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/ --- (Updated July 14, 2015, 5:02 p.m.) Review request for kafka. Bugs:

[jira] [Comment Edited] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-14 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626807#comment-14626807 ] Ashish K Singh edited comment on KAFKA-972 at 7/14/15 6:22 PM:

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-14 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626807#comment-14626807 ] Ashish K Singh commented on KAFKA-972: -- Thanks Jun! MetadataRequest returns stale

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-14 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626814#comment-14626814 ] Aditya Auradkar commented on KAFKA-2205: [~junrao] Thanks! I addressed your

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review91638 --- core/src/main/scala/kafka/security/auth/Acl.scala (line 24)

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

2015-07-14 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627049#comment-14627049 ] Parth Brahmbhatt commented on KAFKA-2210: - Updated reviewboard

[jira] [Updated] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

2015-07-14 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt updated KAFKA-2210: Attachment: KAFKA-2210_2015-07-14_14:13:19.patch KafkaAuthorizer: Add all public entities,

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Joe Stein
Fasterxml/Jackson +1 to that. The scala databinds to case classes are gr8. ~ Joestein On Jul 14, 2015 5:42 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Currently the clients/server mismatch wouldn't be an issue since there are no client-side uses of JSON, right? That said, if Copycat

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

2015-07-14 Thread Neha Narkhede
+1 (binding) Thanks Ewen for taking on something that the Kafka project has long waited for! On Tue, Jul 14, 2015 at 2:58 PM, Jay Kreps j...@confluent.io wrote: +1 Super excited! -Jay On Tue, Jul 14, 2015 at 2:09 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Hi all, Let's

[jira] [Commented] (KAFKA-1977) Make logEndOffset available in the Zookeeper consumer

2015-07-14 Thread James Cheng (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626900#comment-14626900 ] James Cheng commented on KAFKA-1977: Will maxEndOffset will be exposed in the new Java

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

2015-07-14 Thread Jay Kreps
+1 Super excited! -Jay On Tue, Jul 14, 2015 at 2:09 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Hi all, Let's start a vote on KIP-26: Add Copycat connector framework for data import/export For reference, here's the wiki:

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Joe Stein
Maybe after the existing scala clients are deprecated. ~ Joestein On Jul 14, 2015 6:04 PM, Jay Kreps j...@confluent.io wrote: Is this going to become a dependency for core and then transitively for the old clients? The current json library is definitely not great, but it does parse json and

[jira] [Commented] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

2015-07-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627041#comment-14627041 ] Guozhang Wang commented on KAFKA-2055: -- [~lvfangmin] Thanks for the patch, I agree

Re: Review Request 36333: Patch for KAFKA-2123

2015-07-14 Thread Jason Gustafson
On July 14, 2015, 6 p.m., Ewen Cheslack-Postava wrote: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java, line 274 https://reviews.apache.org/r/36333/diff/2-3/?file=1009096#file1009096line274 Seems like we're not handling this anymore?

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

2015-07-14 Thread Joe Stein
+1 (binding) ~ Joe Stein - - - - - - - - - - - - - - - - - - - [image: Logo-Black.jpg] http://www.elodina.net http://www.stealth.ly - - - - - - - - - - - - - - - - - - - On Tue, Jul 14, 2015 at 5:09 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Hi all, Let's start a vote on

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Parth Brahmbhatt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/ --- (Updated July 14, 2015, 9:13 p.m.) Review request for kafka. Bugs:

Re: Review Request 36333: Patch for KAFKA-2123

2015-07-14 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/#review91651 --- LGTM overall, just some minor comments below.

[jira] [Updated] (KAFKA-2300) Error in controller log when broker tries to rejoin cluster

2015-07-14 Thread Bob Cotton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bob Cotton updated KAFKA-2300: -- Attachment: KAFKA-2300-controller-logs.tar.gz Controller logs Error in controller log when broker

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-07-14 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626987#comment-14626987 ] Jason Gustafson commented on KAFKA-2123: Updated reviewboard

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-07-14 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2123: --- Attachment: KAFKA-2123_2015-07-14_13:20:25.patch Make new consumer offset commit API use

[jira] [Created] (KAFKA-2334) Prevent HW from going back during leader failover

2015-07-14 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-2334: Summary: Prevent HW from going back during leader failover Key: KAFKA-2334 URL: https://issues.apache.org/jira/browse/KAFKA-2334 Project: Kafka Issue Type:

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Ewen Cheslack-Postava
Currently the clients/server mismatch wouldn't be an issue since there are no client-side uses of JSON, right? That said, if Copycat ends up included in Kafka we'll need to provide at least one serializer which would be written in Java and I suspect some people would like JSON to be a candidate

[jira] [Updated] (KAFKA-2055) ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient failure

2015-07-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2055: - Reviewer: Jason Gustafson ConsumerBounceTest.testSeekAndCommitWithBrokerFailures transient

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Jay Kreps
Is this going to become a dependency for core and then transitively for the old clients? The current json library is definitely not great, but it does parse json and it's not used in any context where performance is a concern. Because the older clients aren't well modularized, adding core

Re: Review Request 36333: Patch for KAFKA-2123

2015-07-14 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/ --- (Updated July 14, 2015, 8:21 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-14 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627018#comment-14627018 ] Ewen Cheslack-Postava commented on KAFKA-2260: -- Hey [~bkirwi], this looks

[jira] [Commented] (KAFKA-2334) Prevent HW from going back during leader failover

2015-07-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627040#comment-14627040 ] Guozhang Wang commented on KAFKA-2334: -- One possible solution to this issue is to let

[VOTE] KIP-26 Add Copycat connector framework for data import/export

2015-07-14 Thread Ewen Cheslack-Postava
Hi all, Let's start a vote on KIP-26: Add Copycat connector framework for data import/export For reference, here's the wiki: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=58851767 And the mailing list thread (split across two months):

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627184#comment-14627184 ] Jiangjie Qin commented on KAFKA-1835: - We discussed this in today's KIP hangout. Just

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

2015-07-14 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627186#comment-14627186 ] Onur Karaman commented on KAFKA-2275: - Currently, the consumer has the following API:

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review91675 --- core/src/main/scala/kafka/security/auth/PermissionType.scala (line

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review91679 --- core/src/main/scala/kafka/security/auth/Acl.scala (line 110)

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627279#comment-14627279 ] Guozhang Wang commented on KAFKA-1835: -- Thanks [~becket_qin] for the summary. Some

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Geoffrey Anderson
Hi all, my pull request here: https://github.com/apache/kafka/pull/70/files#diff-59f3fe36571d1eee9f923df927a643eb would introduce a client-side dependency on the json-simple package. It is only used in a tool (VerifiableProducer.java), but it sounds like I should probably use Jackson instead?

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627190#comment-14627190 ] Joel Koshy commented on KAFKA-1835: --- bq. Similar proposal applies to KAFKA-2275

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Ismael Juma
On Tue, Jul 14, 2015 at 10:46 PM, Joe Stein joe.st...@stealth.ly wrote: Fasterxml/Jackson +1 to that. The scala databinds to case classes are gr8. To be clear, case classes support would require the Scala module for Jackson and the Scala versions headache that goes with it (2.9 support is

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Ismael Juma
Hi Jay, Comments inline. On Tue, Jul 14, 2015 at 11:04 PM, Jay Kreps j...@confluent.io wrote: Is this going to become a dependency for core and then transitively for the old clients? That's right. The current json library is definitely not great, but it does parse json and it's not used

[GitHub] kafka pull request: KAFKA-2145: Add a log config so users can defi...

2015-07-14 Thread Parth-Brahmbhatt
GitHub user Parth-Brahmbhatt opened a pull request: https://github.com/apache/kafka/pull/77 KAFKA-2145: Add a log config so users can define topic owners. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Parth-Brahmbhatt/kafka

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

2015-07-14 Thread Sriram Subramanian
+1. This was long due! On 7/14/15, 4:42 PM, Guozhang Wang wangg...@gmail.com wrote: +1. Thanks Ewen!! On Tue, Jul 14, 2015 at 3:01 PM, Neha Narkhede n...@confluent.io wrote: +1 (binding) Thanks Ewen for taking on something that the Kafka project has long waited for! On Tue, Jul 14, 2015

[GitHub] kafka pull request: KAFKA-1595; Remove deprecated and slower scala...

2015-07-14 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (KAFKA-1595) Remove deprecated and slower scala JSON parser from kafka.consumer.TopicCount

2015-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627269#comment-14627269 ] ASF GitHub Bot commented on KAFKA-1595: --- Github user ijuma closed the pull request

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review91682 --- core/src/main/scala/kafka/security/auth/ResourceType.scala (line

[jira] [Commented] (KAFKA-2092) New partitioning for better load balancing

2015-07-14 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627325#comment-14627325 ] Jason Gustafson commented on KAFKA-2092: [~azaroth], thanks for the update. I

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Jay Kreps
Yeah we really can't add any dependencies for that client jar. Maybe we could move the perf test to the tools jar though? -Jay On Tue, Jul 14, 2015 at 6:01 PM, Geoffrey Anderson ge...@confluent.io wrote: Hi all, my pull request here:

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627375#comment-14627375 ] Joel Koshy commented on KAFKA-1835: --- bq. I think case (3) is only for users who are

[jira] [Commented] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-07-14 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627383#comment-14627383 ] Jason Gustafson commented on KAFKA-2123: Updated reviewboard

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627395#comment-14627395 ] Jay Kreps commented on KAFKA-1835: -- Changing the return type of a method is a hard

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review91672 --- core/src/main/scala/kafka/security/auth/Acl.scala (line 24)

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627263#comment-14627263 ] Mayuresh Gharat commented on KAFKA-1835: Either way user will have to block or

Re: [DISCUSS] Json libraries for Kafka

2015-07-14 Thread Ismael Juma
Ewen, On Tue, Jul 14, 2015 at 10:41 PM, Ewen Cheslack-Postava e...@confluent.io wrote: Currently the clients/server mismatch wouldn't be an issue since there are no client-side uses of JSON, right? That said, if Copycat ends up included in Kafka we'll need to provide at least one serializer

Re: [CFP] Developer showcase at Strata NYC

2015-07-14 Thread Gwen Shapira
You (or someone working on them) should submit the projects :) On Tue, Jul 14, 2015 at 4:27 PM, Neha Narkhede n...@confluent.io wrote: All of the ones you've mentioned there sound great. I'd want to see copycat there. On Tue, Jul 14, 2015 at 4:22 PM, Gwen Shapira gshap...@cloudera.com wrote:

Re: [DISCUSS] Using GitHub Pull Requests for contributions and code review

2015-07-14 Thread Ismael Juma
On Tue, Jul 14, 2015 at 6:15 PM, Jun Rao j...@confluent.io wrote: I made a couple of changes to the new Jenkins job. Could you try again? It's still not working, unfortunately. It may or may not be related to: https://blogs.apache.org/infra/entry/mirroring_to_github_issues For b, if we can't

[jira] [Work started] (KAFKA-2145) An option to add topic owners.

2015-07-14 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-2145 started by Parth Brahmbhatt. --- An option to add topic owners. ---

[jira] [Updated] (KAFKA-2123) Make new consumer offset commit API use callback + future

2015-07-14 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-2123: --- Attachment: KAFKA-2123_2015-07-14_18:21:38.patch Make new consumer offset commit API use

Re: Review Request 36333: Patch for KAFKA-2123

2015-07-14 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36333/ --- (Updated July 15, 2015, 1:21 a.m.) Review request for kafka. Bugs:

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review91671 --- core/src/main/scala/kafka/security/auth/Operation.scala (line 35)

Re: Review Request 34492: Patch for KAFKA-2210

2015-07-14 Thread Edward Ribeiro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34492/#review91676 --- core/src/main/scala/kafka/security/auth/Resource.scala (line 25)

[CFP] Developer showcase at Strata NYC

2015-07-14 Thread Gwen Shapira
Hi Kafka fans, Strata NYC is looking for emerging, open source, big data projects to highlight in the developer showcase: http://strataconf.com/big-data-conference-ny-2015/public/cfp/409 Depending on how you look at it, it is either science faire for grownups or free conference booth for open

[jira] [Commented] (KAFKA-2145) An option to add topic owners.

2015-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627359#comment-14627359 ] ASF GitHub Bot commented on KAFKA-2145: --- GitHub user Parth-Brahmbhatt opened a pull

Re: Request to be added to the contributor list

2015-07-14 Thread Jun Rao
Added. Thanks, Jun On Tue, Jul 14, 2015 at 11:58 AM, Aravind Selvan aravind...@gmail.com wrote: Hi, Please add me to the contributor list. Thanks. ~Aravind Selvan

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627400#comment-14627400 ] Guozhang Wang commented on KAFKA-1835: -- Joel, I think you are referring to some

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-14 Thread Ben Kirwin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627460#comment-14627460 ] Ben Kirwin commented on KAFKA-2260: --- Hi [~ewencp] -- thanks for the interest! I'd be

[jira] [Commented] (KAFKA-2210) KafkaAuthorizer: Add all public entities, config changes and changes to KafkaAPI and kafkaServer to allow pluggable authorizer implementation.

2015-07-14 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627292#comment-14627292 ] Edward Ribeiro commented on KAFKA-2210: --- Hi [~parth.brahmbhatt], left some minor

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

2015-07-14 Thread Guozhang Wang
+1. Thanks Ewen!! On Tue, Jul 14, 2015 at 3:01 PM, Neha Narkhede n...@confluent.io wrote: +1 (binding) Thanks Ewen for taking on something that the Kafka project has long waited for! On Tue, Jul 14, 2015 at 2:58 PM, Jay Kreps j...@confluent.io wrote: +1 Super excited! -Jay

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627474#comment-14627474 ] Joel Koshy commented on KAFKA-1835: --- My earlier comment was more to clarify the

Re: Inquiry regarding unreviewed patch (KAFKA-1614)

2015-07-14 Thread Jiangjie Qin
Hi Kim, I took a quick look at the patch. It seems all the information you need are available in Kafka now. There are several mBeans you can take a look. They are in kafka.log. Including log start/end offsets, size and number of log segments. Thanks, Jiangjie (Becket) Qin On 7/13/15, 5:01 PM,

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

2015-07-14 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627485#comment-14627485 ] Jiangjie Qin commented on KAFKA-1835: - My example for use case (3) is probably a bad

  1   2   >