/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
---
On Aug. 14, 2015, 2:09 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049
/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
and Jun Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
and Jun Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
and Jun Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated Aug. 11, 2015, 4:58 a.m
/server/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
and Jun Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
/server/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
and Jun Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
/server/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
://reviews.apache.org/r/33049/#review95035
---
On Aug. 11, 2015, 4:58 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
Bump. Anyone else have an opinion?
Neha/Jay - You've made your thoughts clear. Any thoughts on how/if we make
any changes?
Thanks,
Aditya
On Fri, Jul 24, 2015 at 10:32 AM, Aditya Auradkar aaurad...@linkedin.com
wrote:
I'm with Neha on this one. I don't have a strong preference on 2 vs 4
/server/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
and Jun Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
at once after
KAFKA-2084 is committed because I will need to rebase after that.
- Aditya Auradkar
On July 13, 2015, 8:36 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
[
https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680409#comment-14680409
]
Aditya Auradkar commented on KAFKA-2084:
[~junrao][~jjkoshy] I think I've
, callback) {
// add to delay queue
// pass in the computed throttle time to the callback.
}
If I do that, I dont need to pass the throttleTime to the responseCallback
in ReplicaManager
- Aditya Auradkar
On July 13, 2015, 8:36 p.m., Aditya Auradkar wrote
/server/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
Aditya Auradkar created KAFKA-2419:
--
Summary: Allow certain Sensors to be garbage collected after
inactivity
Key: KAFKA-2419
URL: https://issues.apache.org/jira/browse/KAFKA-2419
Project: Kafka
---
On Aug. 10, 2015, 8:49 p.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049
[
https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-2419:
---
Description:
Currently, metrics cannot be removed once registered.
Implement a feature
.
Finally, it seems that delayTime only makes sense for rates and not for
anything else. Perhaps we can at least add a comment.
Aditya Auradkar wrote:
Hey Jun -
Can you elaborate a little? How would we use the current time exactly? It
is not clear to me how subtracting
Aditya Auradkar created KAFKA-2420:
--
Summary: Merge the Throttle time computation for Quotas and
Throttler
Key: KAFKA-2420
URL: https://issues.apache.org/jira/browse/KAFKA-2420
Project: Kafka
and Jun Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
/kafka/server/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review94333
---
On Aug. 5, 2015, 2:08 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply
.
- Aditya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review94412
---
On Aug. 5, 2015, 2:08 a.m., Aditya Auradkar wrote
Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
[
https://issues.apache.org/jira/browse/KAFKA-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659071#comment-14659071
]
Aditya Auradkar commented on KAFKA-1229:
Hey [~vamsi360],
We recently did
Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
/ThrottledResponseExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14654505#comment-14654505
]
Aditya Auradkar commented on KAFKA-2205:
Thanks Jun.
1. Filed https
Aditya Auradkar created KAFKA-2404:
--
Summary: Delete config znode when config values are empty
Key: KAFKA-2404
URL: https://issues.apache.org/jira/browse/KAFKA-2404
Project: Kafka
Issue
---
On June 30, 2015, 12:54 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049
/#review93965
---
On June 30, 2015, 12:54 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049
Personally, I prefer KafkaStreams just because it sounds nicer. For the
reasons identified above, KafkaProcessor or KProcessor is more apt but
sounds less catchy (IMO). I also think we should prefix with Kafka (rather
than K) because we will then have 3 clients: KafkaProducer, KafkaConsumer
and
[
https://issues.apache.org/jira/browse/KAFKA-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar reassigned KAFKA-2255:
--
Assignee: Aditya Auradkar
Missing documentation
[
https://issues.apache.org/jira/browse/KAFKA-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645166#comment-14645166
]
Aditya Auradkar commented on KAFKA-2255:
This was brought up during a mailing list
Great discussion everyone!
One general comment on the sync/async API's on the new consumer. I think
the producer tackles sync vs async API's well. For API's that can either be
sync or async, can we simply return a future? That seems more elegant for
the API's that make sense either in both
+1 on comparison with existing solutions. On a high level, it seems nice to
have a transform library inside Kafka.. a lot of the building blocks are
already there to build a stream processing framework. However the details
are tricky to get right I think this discussion will get a lot more
233)
https://reviews.apache.org/r/36871/#comment147535
consider closing this in a finally. A failing test can cause incorrect tear
down of the test
- Aditya Auradkar
On July 28, 2015, 12:56 a.m., Ashish Singh wrote
I'm with Neha on this one. I don't have a strong preference on 2 vs 4 but I
do think that consistency is more important. It makes writing code a bit
easier especially since patches are increasingly likely to touch both Java
and Scala code and it's nice to not think about formatting certain files
be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14641313#comment-14641313
]
Aditya Auradkar commented on KAFKA-2205:
[~junrao] One more time :). Addressed
Is there actually a use case where we need log.retention.ms? In most
cases, people would want to retain their logs for at least a few minutes
I'd think.
Aditya
On Fri, Jul 24, 2015 at 6:49 PM, Gwen Shapira gshap...@cloudera.com wrote:
Backward compatibility, I think.
At least the ms one is
Hey everyone,
I was wondering if it is possible to standardize indentation across clients
and core. As an example, all the java code uses 4 spaces and the scala code
2. As we increasingly share code between clients and core, I think
consistency would be super useful.
Thoughts?
Aditya
are adding in 2136 for the new
producer and consumer?
- Aditya Auradkar
On July 23, 2015, 7:12 a.m., Dong Lin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36722
Hi,
Why not simply have as many partitions as the set of consumers you want to
round robin across?
Aditya
On Wed, Jul 22, 2015 at 2:37 PM, Ashish Singh asi...@cloudera.com wrote:
Hey, don't you think that would be against the basic ordering guarantees
Kafka provides?
On Wed, Jul 22, 2015
Did you setup your jira.ini?
On Tue, Jul 21, 2015 at 11:52 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
Hi,
I had to clean up existing kafka repo on my linux box and start with a
fresh one.
I followed the instructions here :
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14631772#comment-14631772
]
Aditya Auradkar commented on KAFKA-2205:
[~junrao] Another patch ready
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/#review92008
---
On July 14, 2015, 5:37 p.m., Aditya Auradkar wrote
be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
a local cluster
Thanks,
Aditya Auradkar
by
starting a local cluster
Thanks,
Aditya Auradkar
be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14626814#comment-14626814
]
Aditya Auradkar commented on KAFKA-2205:
[~junrao] Thanks! I addressed your
:
https://reviews.apache.org/r/34554/#review91038
---
On July 8, 2015, 2:14 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
8a871cfaf6a534acd1def06a5ac95b5c985b024c
Diff: https://reviews.apache.org/r/34554/diff/
Testing
---
1. Added new testcases for new code.
2. Verified that both topic and client configs can be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
cluster
Thanks,
Aditya Auradkar
Gustafson
kafka-2248; Use Apache Rat to enforce copyright headers; patched by Ewen
Cheslack-Postava; reviewed by Gwen Shapira, Joel Joshy and Jun Rao
kafka-2132; Move Log4J appender to a separate module; patched by Ashish Singh;
reviewed by Gwen Shapira, Aditya Auradkar and Jun Rao
KAFKA-2314
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554/#review91038
---
On July 14, 2015, 5:37 p.m., Aditya Auradkar wrote:
---
This is an automatically
/#review91319
---
On July 1, 2015, 2:44 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378
,
Aditya Auradkar
do you think?
Aditya Auradkar wrote:
I think that sounds reasonable.. I initially decided against it in my
patch because I thought of this as an incentive to upgrade. Any concerns if I
submit a subsequent RB for this immediately after this is committed?
Joel Koshy wrote:
I think
Aditya Auradkar created KAFKA-2332:
--
Summary: Add quota metrics to old producer and consumer
Key: KAFKA-2332
URL: https://issues.apache.org/jira/browse/KAFKA-2332
Project: Kafka
Issue Type
5717165f2344823fabe8f7cfafae4bb8af2d949a
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
00d59337a99ac135e8689bd1ecd928f7b1423d79
Diff: https://reviews.apache.org/r/33378/diff/
Testing
---
New tests added
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-2332:
---
Issue Type: Sub-task (was: Improvement)
Parent: KAFKA-2083
Add quota metrics to old
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/#review91319
---
On July 13, 2015, 8:36 p.m., Aditya Auradkar wrote:
---
This is an automatically
8a871cfaf6a534acd1def06a5ac95b5c985b024c
Diff: https://reviews.apache.org/r/34554/diff/
Testing
---
1. Added new testcases for new code.
2. Verified that both topic and client configs can be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14617849#comment-14617849
]
Aditya Auradkar commented on KAFKA-2205:
[~junrao] - Addressed your comments. Can
/r/34554/#review90622
---
On July 2, 2015, 1:39 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34554
Thanks,
Aditya Auradkar
Congratulations Gwen!
Aditya
From: Ashish Singh [asi...@cloudera.com]
Sent: Monday, July 06, 2015 6:16 PM
To: dev@kafka.apache.org
Subject: Re: [ANNOUNCE] New Committer
Congrats Gwen!
On Monday, July 6, 2015, Joe Stein joe.st...@stealth.ly wrote:
I am
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611311#comment-14611311
]
Aditya Auradkar commented on KAFKA-2205:
[~junrao] - Addressed your comments. Can
/
Testing
---
1. Added new testcases for new code.
2. Verified that both topic and client configs can be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
/DynamicConfigChangeTest.scala
7877f6ca1845c2edbf96d4a9783a07a552db8f07
Diff: https://reviews.apache.org/r/34554/diff/
Testing
---
1. Added new testcases for new code.
2. Verified that both topic and client configs can be changed dynamically by
starting a local cluster
Thanks,
Aditya Auradkar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/#review89429
---
On July 1, 2015, 2:44 a.m., Aditya Auradkar wrote
/RequestResponseSerializationTest.scala
5717165f2344823fabe8f7cfafae4bb8af2d949a
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
00d59337a99ac135e8689bd1ecd928f7b1423d79
Diff: https://reviews.apache.org/r/33378/diff/
Testing
---
New tests added
Thanks,
Aditya Auradkar
/kafka/server/ReplicaManagerTest.scala
00d59337a99ac135e8689bd1ecd928f7b1423d79
Diff: https://reviews.apache.org/r/33378/diff/
Testing
---
New tests added
Thanks,
Aditya Auradkar
---
On June 30, 2015, 12:53 a.m., Aditya Auradkar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049
/server/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review88180
---
On June 30, 2015, 12:54 a.m., Aditya Auradkar wrote
Sent :)
From: Gwen Shapira [gshap...@cloudera.com]
Sent: Friday, June 26, 2015 11:53 AM
To: us...@kafka.apache.org
Cc: dev@kafka.apache.org
Subject: Re: Help Us Nominate Apache Kafka for a 2015 Bossie (Best of OSS)
Award - Due June 30th
Sent! Thanks for
Hey Ashish,
Last hangout, I think we discussed adding a num-iterations parameter to the
script. Do you plan to support that?
Aditya
From: Neha Narkhede [n...@confluent.io]
Sent: Tuesday, June 23, 2015 11:24 AM
To: dev@kafka.apache.org
Cc: Jun Rao
[
https://issues.apache.org/jira/browse/KAFKA-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596298#comment-14596298
]
Aditya Auradkar commented on KAFKA-2293:
[~junrao] Can you take a look
[
https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596965#comment-14596965
]
Aditya Auradkar commented on KAFKA-2205:
[~junrao] - Can you review this patch
[
https://issues.apache.org/jira/browse/KAFKA-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14594702#comment-14594702
]
Aditya Auradkar commented on KAFKA-2238:
[~junrao] - KafkaConfig seems
Aditya Auradkar created KAFKA-2287:
--
Summary: Add metric to track the number of clientId throttled
Key: KAFKA-2287
URL: https://issues.apache.org/jira/browse/KAFKA-2287
Project: Kafka
Issue
Congrats Guozhang!
From: Ashish Singh [asi...@cloudera.com]
Sent: Monday, June 15, 2015 10:53 PM
To: dev@kafka.apache.org
Cc: Jun Rao
Subject: Re: Guozhang Wang elected to Kafka PMC
Congrats Guozhang!
On Mon, Jun 15, 2015 at 10:20 PM, Sriharsha
/35437/#comment140291
can probably do this inline
case _: ConsumerEx = consumerTimeout.set(true)
- Aditya Auradkar
On June 14, 2015, 11:27 a.m., Manikumar Reddy O wrote:
---
This is an automatically generated e-mail
/ThrottledRequestExpirationTest.scala
PRE-CREATION
Diff: https://reviews.apache.org/r/33049/diff/
Testing
---
Thanks,
Aditya Auradkar
and Jun Rao.
Bugs: KAFKA-2084
https://issues.apache.org/jira/browse/KAFKA-2084
Repository: kafka
Description (updated)
---
Signed-off-by: Aditya Auradkar aaurad...@linkedin.com
Addressing Joel's comments
Minor imports changes
Added testcase to verify that replication traffic
On Thu, Jun 11, 2015 at 06:36:36PM +, Aditya Auradkar wrote:
Andrii,
Do we need a new voting thread for this KIP? The last round of votes had 3
binding +1's but there's been a fair amount of discussion since then.
Aditya
From: Aditya Auradkar
here?
- Aditya Auradkar
On April 30, 2015, 10:53 p.m., Ashish Singh wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33614
Hi Geoffrey,
Thanks for the writeup. Couple of questions:
- Is it possible to configure suites using ducktape? For example: assume all
the tests in system_tests have been migrated to ducktape. Can I run a subset of
all tests grouped by functional areas i.e. replication, broker failure etc.
-
[
https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Auradkar updated KAFKA-2136:
---
Labels: quotas (was: )
Client side protocol changes to return quota delays
101 - 200 of 429 matches
Mail list logo
