Re: Review Request 35820: Patch for KAFKA-1367

2015-07-07 Thread Ashish Singh
--- On July 7, 2015, 5:04 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820

Re: Review Request 36030: Patch for KAFKA-972

2015-07-07 Thread Ashish Singh
/scala/unit/kafka/integration/TopicMetadataTest.scala a95ee5e0849d29a5f95fdabed4f1988a308e9872 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-07 Thread Ashish Singh
/#review90734 --- On July 7, 2015, 5:04 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820

Review Request 36270: Patch for KAFKA-2317

2015-07-07 Thread Ashish Singh
/36270/diff/ Testing --- Thanks, Ashish Singh

Re: [ANNOUNCE] New Committer

2015-07-06 Thread Ashish Singh
Congrats Gwen! On Monday, July 6, 2015, Joe Stein joe.st...@stealth.ly wrote: I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen Shapira as a committer and Gwen has accepted. Please join me on welcoming and congratulating Gwen. Thanks for the contribution both in

Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-07-06 Thread Ashish Singh
Thanks for your comments and vote guys. KIP-23 passed retroactively with 2 binding +1s and 2 non-binding +1s. On Mon, Jun 29, 2015 at 3:25 PM, Jun Rao j...@confluent.io wrote: +1 Thanks, Jun On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh asi...@cloudera.com wrote: Hey Guys, We had

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-06 Thread Ashish Singh
--- On July 7, 2015, 5:04 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-06 Thread Ashish Singh
with 3 Kafka brokers Thanks, Ashish Singh

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-06 Thread Ashish Singh
42) https://reviews.apache.org/r/35820/#comment143754 Moved to method that uses it. - Ashish Singh On July 7, 2015, 5:04 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
. To reply, visit: https://reviews.apache.org/r/36030/#review90005 --- On July 1, 2015, 8:37 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
--- On July 1, 2015, 3:06 p.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030

Deprecation of ConsumerOffsetChecker

2015-07-01 Thread Ashish Singh
Hey Guys, In last KIP hangout, we decided on following path for deprecating ConsumerOffsetChecker. 1. Add deprecation warning to the tool for one release. In this case, the warning will be added in 0.9.0. 2. Drop it completely in next release, 0.9.1. I have updated the (KIP-23){

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-01 Thread Ashish Singh
with 3 Kafka brokers Thanks, Ashish Singh

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-01 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/#review89911 --- On July 2, 2015, 12:23 a.m., Ashish Singh wrote

Re: Review Request 35850: Patch for KAFKA-2301

2015-07-01 Thread Ashish Singh
://reviews.apache.org/r/35850/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 36030: Patch for KAFKA-972

2015-06-30 Thread Ashish Singh
--- On June 30, 2015, 12:46 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/ --- (Updated June 30, 2015

Re: Review Request 36030: Patch for KAFKA-972

2015-06-30 Thread Ashish Singh
/scala/unit/kafka/integration/TopicMetadataTest.scala 995b05901491bb0dbf0df210d44bd1d7f66fdc82 Diff: https://reviews.apache.org/r/36030/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-30 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review89919 --- On June 24, 2015, 5:25 p.m., Ashish Singh wrote: --- This is an automatically generated e

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-30 Thread Ashish Singh
: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Review Request 36030: Patch for KAFKA-972

2015-06-29 Thread Ashish Singh
--- Thanks, Ashish Singh

Re: Review Request 35850: Patch for KAFKA-2301

2015-06-29 Thread Ashish Singh
--- On June 24, 2015, 10:10 p.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850

Review Request 35822: Patch for KAFKA-2299

2015-06-24 Thread Ashish Singh
, Ashish Singh

Review Request 35850: Patch for KAFKA-2301

2015-06-24 Thread Ashish Singh
/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 3d52f62c88a509a655cf1df6232b738c25fa9b69 system_test/broker_failure/config/log4j.properties 23ece9bb5b3d521bb692870bc929865f68caabe0 Diff: https://reviews.apache.org/r/35850/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-24 Thread Ashish Singh
: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-24 Thread Ashish Singh
: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-24 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review88015 --- On June 24, 2015, 5:20 p.m., Ashish Singh wrote

[VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-06-23 Thread Ashish Singh
Hey Guys, We had some discussion over mail and in KIP hangout. I will update the RB with proposed changes. On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh asi...@cloudera.com wrote: Hi Neha, Answers inline. On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede n...@confluent.io wrote: Thanks

Review Request 35820: Patch for KAFKA-1367

2015-06-23 Thread Ashish Singh
/ReplicationUtilsTest.scala c96c0ffd958d63c09880d436b2e5ae96f51ead36 Diff: https://reviews.apache.org/r/35820/diff/ Testing --- Tested Thanks, Ashish Singh

Re: Review Request 35820: Patch for KAFKA-1367

2015-06-23 Thread Ashish Singh
/unit/kafka/utils/ReplicationUtilsTest.scala c96c0ffd958d63c09880d436b2e5ae96f51ead36 Diff: https://reviews.apache.org/r/35820/diff/ Testing (updated) --- Tested on a test cluster with 3 Kafka brokers Thanks, Ashish Singh

Re: Guozhang Wang elected to Kafka PMC

2015-06-15 Thread Ashish Singh
Congrats Guozhang! On Mon, Jun 15, 2015 at 10:20 PM, Sriharsha Chintalapani ka...@harsha.io wrote: Congrats Guozhang. -- Harsha On June 15, 2015 at 9:59:37 PM, Jun Rao (j...@confluent.io) wrote: Hi, Everyone, Guozhang Wang has been active in the Kafka community since he became a

Re: [DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-06-14 Thread Ashish Singh
a plan to phase out the old format? Probably not, but having it around will not hurt. Having three output formats is not that bad and I do not expect this list to grow in future. On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh asi...@cloudera.com wrote: Jun, Can we add this as part

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-13 Thread Ashish Singh
: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-13 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review87670 --- On June 14, 2015, 4:19 a.m., Ashish Singh wrote

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-13 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review87638 --- On June 14, 2015, 4:19 a.m., Ashish Singh wrote: --- This is an automatically

Re: [DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-06-11 Thread Ashish Singh
Hi Guys, This has been lying around for quite some time. Should I start a voting thread on this? On Thu, May 7, 2015 at 12:20 PM, Ashish Singh asi...@cloudera.com wrote: Had to change the title of the page and that surprisingly changed the link as well. KIP-23 is now available at here https

Pending review requests

2015-06-11 Thread Ashish Singh
Hey Guys, I have a few JIRAs in patch available state for some time. I will really appreciate if someone can review them. 1. https://issues.apache.org/jira/browse/KAFKA-2132 2. https://issues.apache.org/jira/browse/KAFKA-2005 3. https://issues.apache.org/jira/browse/KAFKA-1722 4.

Re: [DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-06-11 Thread Ashish Singh
Jun, Can we add this as part of next KIP's agenda? On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira gshap...@cloudera.com wrote: Maybe bring it up at the next KIP call, to make sure everyone is aware? On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh asi...@cloudera.com wrote: Hi Guys

Re: notes from Kafka KIP hangout Jun. 2

2015-06-02 Thread Ashish Singh
Jun, Thanks for the notes! @Jun/ Joel, An inline question on ISR info in TMR. On Tuesday, June 2, 2015, Jun Rao j...@confluent.io wrote: The following are my notes. 1. Security: Harsh will upload a new SSL patch in the next day or two. 2. KIP-21 (dynamic configuration): How to serve

Re: KIP Wiki

2015-06-01 Thread Ashish Singh
I like the idea! On Mon, Jun 1, 2015 at 9:51 AM, Aditya Auradkar aaurad...@linkedin.com.invalid wrote: Hey everyone, We have enough KIP's now (25) that it's a bit hard to tell which ones are adopted or under discussion by glancing at the wiki. Any concerns if I split it into 3 tables

Re: [DISCUSS] KIP-4 - Command line and centralized administrative operations (Thread 2)

2015-05-29 Thread Ashish Singh
+1 on discussing this on next KIP hangout. I will update KIP-24 before that. On Fri, May 29, 2015 at 3:40 AM, Andrii Biletskyi andrii.bilets...@stealth.ly wrote: Guys, I won't be able to attend next meeting. But in the latest patch for KIP-4 Phase 1 I didn't even evolve

Re: Kafka KIP hangout May 26

2015-05-26 Thread Ashish Singh
Below are my notes. Feel free to add/ modify the content. Kafka KIP discussion (May 26, 2015) KIP-12 (sasl/ssl authentication): status check Not much discussion this time. KIP-21 (configuration management) - Aditya will make changes to KIP-4 based on last time’s discussion. - Andrei is OK

Re: [DISCUSS] KIP-25 System test improvements

2015-05-21 Thread Ashish Singh
Geoffrey, This looks great! A few questions. 1. Will ducktape be maintained separately as a github repo? 2. How easy is viewing the test results and logs. The link in KIP, http://testing.confluent.io/confluent_platform/latest/, lists a bunch of files and dirs. Could you add to KIP how the result

Notes from KIP Hangout, May 19, 2015

2015-05-19 Thread Ashish Singh
Hey Guys, Below are my notes from today’s hangout. Feel free to add/modify the content. KIP Hangout (May 19, 2015) KIP-12 (sasl/ssl authentication): status check - Gwen has posted patch for KAFKA-1928, network refactoring. - Needed for sasl changes. - Pretty close to completion. -

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-11 Thread Ashish Singh
I agree with the Joel's suggestion on keeping broker's configs in config file and clients/topics config in ZK. Few other projects, Apache Solr for one, also does something similar for its configurations. On Monday, May 11, 2015, Gwen Shapira gshap...@cloudera.com wrote: I like this approach

Re: [DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-05-07 Thread Ashish Singh
Had to change the title of the page and that surprisingly changed the link as well. KIP-23 is now available at here https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556. On Thu, May 7, 2015 at 11:34 AM, Ashish Singh asi...@cloudera.com wrote: Hi Guys, I just added a KIP

[DISCUSS] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand

2015-05-07 Thread Ashish Singh
Hi Guys, I just added a KIP, KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand https://cwiki.apache.org/confluence/display/KAFKA/KIP-23, for KAFKA-313 https://issues.apache.org/jira/browse/KAFKA-313. The changes made as part of the JIRA can be found here

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-06 Thread Ashish Singh
, May 6, 2015 at 5:48 PM, Ashish Singh asi...@cloudera.com javascript:; wrote: I too would like to share some concerns that we came up with while discussing the effect of moving configs to zookeeper will have. 1. Kafka will start to become a configuration management tool to some degree

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-06 Thread Ashish Singh
I too would like to share some concerns that we came up with while discussing the effect of moving configs to zookeeper will have. 1. Kafka will start to become a configuration management tool to some degree, and be subject to all the things such tools are commonly asked to do. Kafka'll likely

Re: [DISCUSS] KIP-21 Configuration Management

2015-05-06 Thread Ashish Singh
, May 6, 2015, Ashish Singh asi...@cloudera.com wrote: Hey Jun, Where does the broker get the info, which zk it needs to talk to? On Wednesday, May 6, 2015, Jun Rao j...@confluent.io javascript:_e(%7B%7D,'cvml','j...@confluent.io'); wrote: Ashish, 3. Just want to clarify. Why can't you

Re: Kafka KIP hangout May 5

2015-05-05 Thread Ashish Singh
Below are my notes from today’s KIP hangout. Please feel free to add/ correct the content. Kafka KIP Discussion (May 5) KIP-4 (admin commands): any remaining issues - Only issue left is how to handle multiple instructions for one topic. Suggestion here was to silently ignore duplicate

Re: Adding multi-tenancy capabilities to Kafka

2015-05-05 Thread Ashish Singh
Adrian, Trying to follow up the discussion here. Is my understanding correct that if we have topic hierarchies then we can do without namespaces. To me namespace is an abstraction, it can be implemented with topic hierarchies as well, would you agree? If so I guess topic hierarchies is the way to

Re: Adding multi-tenancy capabilities to Kafka

2015-05-05 Thread Ashish Singh
than needing a new client instance that connects to that separate namespace (a la zookeeper). I think this will be a nice way to share config and acl defaults too. -Jay On Tue, May 5, 2015 at 10:36 AM, Ashish Singh asi...@cloudera.com javascript:; wrote: Adrian, Trying to follow up

Re: Request to add my confluent id to Apache Kafka

2015-05-04 Thread Ashish Singh
Thanks Jun! On Monday, May 4, 2015, Jun Rao j...@confluent.io wrote: Added. Thanks, Jun On Mon, May 4, 2015 at 2:17 PM, Ashish Singh asi...@cloudera.com javascript:; wrote: Thanks for extending help here. I do have a separate confluence wiki account, https://cwiki.apache.org

Re: Request to add my confluent id to Apache Kafka

2015-05-04 Thread Ashish Singh
Bummer... I meant *Confluence id* :) On Mon, May 4, 2015 at 1:48 PM, Ashish Singh asi...@cloudera.com wrote: Hello, While trying to create a KIP, I realized that I probably need to get my confluence id to be able to create a page under Apache Kafka. Either that or I am doing something wrong

Request to add my confluent id to Apache Kafka

2015-05-04 Thread Ashish Singh
Hello, While trying to create a KIP, I realized that I probably need to get my confluence id to be able to create a page under Apache Kafka. Either that or I am doing something wrong. Could someone with appropriate privileges/ knowledge help me out. My confluence account is registered with

Re: Request to add my confluent id to Apache Kafka

2015-05-04 Thread Ashish Singh
Thanks for extending help here. I do have a separate confluence wiki account, https://cwiki.apache.org/confluence/display/~asingh. Below are the details. username: asingh email: asi...@cloudera.com full name: Ashish Singh Let me know if you are still not able to find me. On Mon, May 4, 2015

Re: Review Request 33614: Patch for KAFKA-2132

2015-04-30 Thread Ashish Singh
Diff: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33645: Patch for KAFKA-2153

2015-04-29 Thread Ashish Singh
., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33645/ --- (Updated April 28, 2015, 11:04 p.m.) Review request

Review Request 33645: Patch for KAFKA-2153

2015-04-28 Thread Ashish Singh
://reviews.apache.org/r/33645/diff/ Testing --- Thanks, Ashish Singh

Review Request 33614: Patch for KAFKA-2132

2015-04-27 Thread Ashish Singh
/log4j/KafkaLog4jAppenderTest.java PRE-CREATION log4j/src/test/java/org/apache/kafka/log4j/MockKafkaLog4jAppender.java PRE-CREATION settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45 Diff: https://reviews.apache.org/r/33614/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

2015-04-27 Thread Ashish Singh
--- Thanks, Ashish Singh

Re: Review Request 33614: Patch for KAFKA-2132

2015-04-27 Thread Ashish Singh
--- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
--- On April 17, 2015, 10:09 p.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
--- On April 17, 2015, 10:09 p.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
://reviews.apache.org/r/31369/#review80555 --- On April 18, 2015, midnight, Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Chicken and egg problem when initializing SocketServer

2015-04-04 Thread Ashish Singh
Hi Gwen, Can we buffer the requests that arrive before acceptors are up. Once we have the acceptors, the buffer can be cleared. However, this adds on to the complexity. On Sunday, April 5, 2015, Gwen Shapira gshap...@cloudera.com wrote: Hi, I'm trying to rebase KAFKA-1809 after KAFKA-1501

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-25 Thread Ashish Singh
https://reviews.apache.org/r/30809/#comment125925 Probably, extract out in a upgrade method for reusability and readability. - Ashish Singh On March 23, 2015, 6:54 p.m., Abhishek Nigam wrote: --- This is an automatically generated e

Review Request 31765: Patch for KAFKA-2005

2015-03-05 Thread Ashish Singh
/browse/KAFKA-2005 Repository: kafka Description --- KAFKA-2005: Generate html report for system tests Diffs - system_test/system_test_runner.py 5078d4479fab71722751a28c3c8f5c0f61baadec Diff: https://reviews.apache.org/r/31765/diff/ Testing --- Thanks, Ashish Singh

Review Request 31711: Patch for KAFKA-1994

2015-03-03 Thread Ashish Singh
9897b2fa8f8261fe8ab6b62b45b9052adb07043f Diff: https://reviews.apache.org/r/31711/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-03 Thread Ashish Singh
examples/src/main/java/kafka/examples/SimpleConsumerDemo.java 0d66fe5f8819194c8624aed4a21105733c20cc8e Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31711: Patch for KAFKA-1994

2015-03-03 Thread Ashish Singh
--- On March 4, 2015, 12:45 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31711

Re: Review Request 31711: Patch for KAFKA-1994

2015-03-03 Thread Ashish Singh
a ConfigException if the namespace doesn't exist. Ashish Singh wrote: Not sure if that is a good idea. If we do that then there won't be an easy way to fix the situation. Even if someone creates that namespace on ZK, ZkPath will keep complaining about the missing namespace. With current

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-03 Thread Ashish Singh
--- On March 4, 2015, 1:51 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-03 Thread Ashish Singh
/#review74553 --- On March 4, 2015, 1:51 a.m., Ashish Singh wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369

Re: Review Request 31711: Patch for KAFKA-1994

2015-03-03 Thread Ashish Singh
/test/scala/unit/kafka/zk/ZKPathTest.scala 9897b2fa8f8261fe8ab6b62b45b9052adb07043f Diff: https://reviews.apache.org/r/31711/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-27 Thread Ashish Singh
: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-27 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74379 --- On Feb. 27, 2015, 7:08 p.m., Ashish Singh wrote

Re: ConsumerTest

2015-02-27 Thread Ashish Singh
+1 On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira gshap...@cloudera.com wrote: Actually, we will greatly appreciate :) On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede n...@confluent.io wrote: Would anyone object if I commented out the kafka.api.ConsumerTest out until it is fixed? It hangs

Re: Announcing the Confluent Platform built on Apache Kafka

2015-02-25 Thread Ashish Singh
Congrats guys! On Wed, Feb 25, 2015 at 11:47 AM, Jiangjie Qin j...@linkedin.com.invalid wrote: Congrats! On 2/25/15, 11:30 AM, Guozhang Wang wangg...@gmail.com wrote: +1, very nice! On Wed, Feb 25, 2015 at 11:20 AM, Sriram Subramanian srsubraman...@linkedin.com.invalid wrote:

[jira] [Updated] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-02-24 Thread Ashish Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singh updated KAFKA-1664: Attachment: KAFKA-1664_2015-02-24_11:02:23.patch Kafka does not properly parse multiple ZK nodes

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-02-24 Thread Ashish Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335248#comment-14335248 ] Ashish Singh commented on KAFKA-1664: - Updated reviewboard https://reviews.apache.org

Review Request 31369: Patch for KAFKA-1982

2015-02-24 Thread Ashish Singh
/ Testing --- Thanks, Ashish Singh

[jira] [Commented] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-02-24 Thread Ashish Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335198#comment-14335198 ] Ashish Singh commented on KAFKA-1982: - Created reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-02-24 Thread Ashish Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singh updated KAFKA-1982: Attachment: KAFKA-1982.patch change kafka.examples.Producer to use the new java producer

[jira] [Commented] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-02-24 Thread Ashish Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335203#comment-14335203 ] Ashish Singh commented on KAFKA-1982: - Updated reviewboard https://reviews.apache.org

[jira] [Updated] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-02-24 Thread Ashish Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singh updated KAFKA-1982: Status: Patch Available (was: Open) change kafka.examples.Producer to use the new java producer

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-24 Thread Ashish Singh
: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

[jira] [Updated] (KAFKA-1982) change kafka.examples.Producer to use the new java producer

2015-02-24 Thread Ashish Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singh updated KAFKA-1982: Attachment: KAFKA-1982_2015-02-24_10:34:51.patch change kafka.examples.Producer to use the new

Re: Review Request 28108: Patch for KAFKA-1664

2015-02-24 Thread Ashish Singh
core/src/test/scala/unit/kafka/zk/ZKPathTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/28108/diff/ Testing --- Tested with and without the fix. Thanks, Ashish Singh

[jira] [Commented] (KAFKA-1664) Kafka does not properly parse multiple ZK nodes with non-root chroot

2015-02-24 Thread Ashish Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335255#comment-14335255 ] Ashish Singh commented on KAFKA-1664: - [~nehanarkhede] addressed the warnings issue

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-24 Thread Ashish Singh
examples/src/main/java/kafka/examples/Producer.java 96e98933148d07564c1b30ba8e805e2433c2adc8 Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-24 Thread Ashish Singh
examples/src/main/java/kafka/examples/Producer.java 96e98933148d07564c1b30ba8e805e2433c2adc8 Diff: https://reviews.apache.org/r/31369/diff/ Testing --- Thanks, Ashish Singh

Re: Review Request 28096: Patch for KAFKA-313

2015-02-23 Thread Ashish Singh
) - core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala 89fa29a882ae1f2be512e1ae469631c02adeeddb Diff: https://reviews.apache.org/r/28096/diff/ Testing --- Ran ConsumerOffsetChecker with different combinations of --output.format and --loop options. Thanks, Ashish Singh

Re: Review Request 29893: Patch for KAFKA-1856

2015-02-09 Thread Ashish Singh
/#comment117568 *matches* is basically list of patches attached to a JIRA, in the order of dates they were attached. jira_get_attachment returns the latest patch attached to the JIRA. I have tested this with a few JIRAs, like KAFKA-1634, and it works fine. - Ashish Singh On Feb. 4, 2015, 11:44

<    1   2   3   4   >