[jira] [Updated] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1761: --- Assignee: Manikumar Reddy (was: Jay Kreps) Status: Patch Available (was: Open

[jira] [Updated] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1761: --- Attachment: KAFKA-1761.patch num.partitionsdocumented default is 1 while actual

[jira] [Commented] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282178#comment-14282178 ] Manikumar Reddy commented on KAFKA-1761: Created reviewboard https

[jira] [Commented] (KAFKA-1728) update 082 docs

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282166#comment-14282166 ] Manikumar Reddy commented on KAFKA-1728: we need to update the default values

Review Request 30022: Patch for KAFKA-1761

2015-01-18 Thread Manikumar Reddy O
: https://reviews.apache.org/r/30022/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1761) num.partitions documented default is 1 while actual default is 2

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282185#comment-14282185 ] Manikumar Reddy commented on KAFKA-1761: 1. we need to update the default values

[jira] [Updated] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-01-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1884: --- Assignee: (was: Jun Rao) New Producer blocks forever for Invalid topic names

[jira] [Resolved] (KAFKA-1434) kafka.admin.TopicCommand missing --delete topic command

2015-01-20 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1434. Resolution: Fixed Fix Version/s: 0.8.2 This issue is fixed in 0.8.2. Pl enable

[jira] [Created] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-01-19 Thread Manikumar Reddy (JIRA)
Manikumar Reddy created KAFKA-1884: -- Summary: New Producer blocks forever for Invalid topic names Key: KAFKA-1884 URL: https://issues.apache.org/jira/browse/KAFKA-1884 Project: Kafka Issue

[jira] [Assigned] (KAFKA-1877) Expose version via JMX for 'new' producer

2015-01-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1877: -- Assignee: Manikumar Reddy Expose version via JMX for 'new' producer

[jira] [Updated] (KAFKA-1239) New producer checklist

2015-01-20 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1239: --- Affects Version/s: (was: 0.9.0) 0.8.2 New producer checklist

[jira] [Updated] (KAFKA-1109) Need to fix GC log configuration code, not able to override KAFKA_GC_LOG_OPTS

2015-01-20 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1109: --- Attachment: KAFKA-1109.patch Need to fix GC log configuration code, not able to override

[jira] [Updated] (KAFKA-1109) Need to fix GC log configuration code, not able to override KAFKA_GC_LOG_OPTS

2015-01-20 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1109: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) Need to fix GC log

[jira] [Updated] (KAFKA-1000) Inbuilt consumer offset management feature for kakfa

2015-01-20 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1000: --- Fix Version/s: 0.8.2 Inbuilt consumer offset management feature for kakfa

Review Request 30073: Patch for KAFKA-1109

2015-01-20 Thread Manikumar Reddy O
--- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1109) Need to fix GC log configuration code, not able to override KAFKA_GC_LOG_OPTS

2015-01-20 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283755#comment-14283755 ] Manikumar Reddy commented on KAFKA-1109: Created reviewboard https

[jira] [Resolved] (KAFKA-1045) producer zk.connect config

2015-01-20 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1045. Resolution: Fixed Fix Version/s: 0.8.2 Zookeeper configs are not required for new

[jira] [Updated] (KAFKA-1861) Publishing kafka-client:test in order to utilize the helper utils in TestUtils

2015-01-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1861: --- Attachment: KAFKA-1861.patch Publishing kafka-client:test in order to utilize the helper

[jira] [Commented] (KAFKA-1861) Publishing kafka-client:test in order to utilize the helper utils in TestUtils

2015-01-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285995#comment-14285995 ] Manikumar Reddy commented on KAFKA-1861: Can we include this simple patch to 0.8.2

[jira] [Commented] (KAFKA-1861) Publishing kafka-client:test in order to utilize the helper utils in TestUtils

2015-01-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285990#comment-14285990 ] Manikumar Reddy commented on KAFKA-1861: Created reviewboard https

Review Request 30128: Patch for KAFKA-1861

2015-01-21 Thread Manikumar Reddy O
/browse/KAFKA-1861 Repository: kafka Description --- include clients test jar in maven artifacts Diffs - build.gradle 1cbab29ce83e20dae0561b51eed6fdb86d522f28 Diff: https://reviews.apache.org/r/30128/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1861) Publishing kafka-client:test in order to utilize the helper utils in TestUtils

2015-01-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1861: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) Publishing kafka

[jira] [Commented] (KAFKA-1869) Openning some random ports while running kafka service

2015-01-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282386#comment-14282386 ] Manikumar Reddy commented on KAFKA-1869: 1. -Dcom.sun.management.jmxremote.port

Re: Review Request 24214: Patch for KAFKA-1374

2015-01-17 Thread Manikumar Reddy O
produced, 1136608 rows of data consumed (88.6% reduction). De-duplicating and validating output files... Validated 899853 values, 0 mismatches. Thanks, Manikumar Reddy O

Re: Review Request 24214: Patch for KAFKA-1374

2015-01-17 Thread Manikumar Reddy O
/TestLogCleaning.scala af496f7c547a5ac7a4096a6af325dad0d8feec6f core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 07acd460b1259e0a3f4069b8b8dcd8123ef5810e Diff: https://reviews.apache.org/r/24214/diff/ Testing (updated) --- /safe/KAFKA/docs/TestLogCleaning.txt Thanks, Manikumar

[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2015-01-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281480#comment-14281480 ] Manikumar Reddy commented on KAFKA-1374: Updated reviewboard https

[jira] [Updated] (KAFKA-1728) update 082 docs

2015-01-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1728: --- Attachment: default-config-value-0.8.2.patch Uploaded patch to correct default config values

[jira] [Updated] (KAFKA-1729) add doc for Kafka-based offset management in 0.8.2

2015-01-19 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1729: --- Fix Version/s: 0.8.2 add doc for Kafka-based offset management in 0.8.2

[jira] [Updated] (KAFKA-1674) auto.create.topics.enable docs are misleading

2015-01-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1674: --- Fix Version/s: 0.8.2 This is simple documentation correction. we can push this to 0.8.2

[jira] [Resolved] (KAFKA-1869) Openning some random ports while running kafka service

2015-01-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1869. Resolution: Not a Problem Fix Version/s: 0.8.2 Assignee: Manikumar Reddy

[jira] [Commented] (KAFKA-1864) Revisit defaults for the internal offsets topic

2015-01-16 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281178#comment-14281178 ] Manikumar Reddy commented on KAFKA-1864: Will this also fixes KAFKA-1846

[jira] [Commented] (KAFKA-1874) missing import util.parsing.json.JSON

2015-01-17 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281431#comment-14281431 ] Manikumar Reddy commented on KAFKA-1874: I'm not sure if I understand your

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278303#comment-14278303 ] Manikumar Reddy commented on KAFKA-1499: Thanks for the review. Broker-side

[jira] [Commented] (KAFKA-1854) Allow the JIRA username and password to be prompted during patch submission

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278298#comment-14278298 ] Manikumar Reddy commented on KAFKA-1854: Yeah, I must be looking at the old page

[jira] [Commented] (KAFKA-595) Decouple producer side compression from server-side compression.

2015-01-15 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14278435#comment-14278435 ] Manikumar Reddy commented on KAFKA-595: --- [~nehanarkhede] We have given support

[jira] [Updated] (KAFKA-1728) update 082 docs

2015-01-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1728: --- Attachment: missing-config-props-0.8.2.patch Uploaded a patch to add missing config

[jira] [Commented] (KAFKA-1872) Update Developer Setup

2015-01-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281803#comment-14281803 ] Manikumar Reddy commented on KAFKA-1872: Thanks for the document. I was able

[jira] [Updated] (KAFKA-1938) [doc] Quick start example should reference appropriate Kafka version

2015-02-11 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1938: --- Attachment: remove-081-references.patch Attaching a patch which removes 0.8.1 references form

[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2015-02-11 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14316691#comment-14316691 ] Manikumar Reddy commented on KAFKA-1374: yes, we are using TestLogCleaning tool

[jira] [Commented] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-02-10 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14314518#comment-14314518 ] Manikumar Reddy commented on KAFKA-1884: looks like we are already returning error

[jira] [Updated] (KAFKA-1938) [doc] Quick start example should reference appropriate Kafka version

2015-02-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1938: --- Attachment: lz4-compression.patch forgot to add LZ4 compression to docs. Attaching a new

Re: Review Request 30078: Patch for KAFKA-1885

2015-01-23 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69532 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 24, 2015, 5:13

Re: Review Request 30078: Patch for KAFKA-1885

2015-01-23 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30078/#review69533 --- Ship it! Non-Binding +1 - Manikumar Reddy O On Jan. 24, 2015, 5

Re: Review Request 30321: Patch for kafka-1902

2015-01-27 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30321/#review69813 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 27, 2015, 4:16

[jira] [Commented] (KAFKA-1861) Publishing kafka-client:test in order to utilize the helper utils in TestUtils

2015-01-28 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295551#comment-14295551 ] Manikumar Reddy commented on KAFKA-1861: [~junrao] we can include this is 0.8.2

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2015-01-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264537#comment-14264537 ] Manikumar Reddy commented on KAFKA-1499: [~jjkoshy] Uploaded a new patch with some

Re: Review Request 29738: Patch for kafka-1797

2015-01-08 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29738/#review67374 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 9, 2015, 1:22 a.m

Re: Review Request 29724: Patch for KAFKA-1566

2015-01-08 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29724/#review67376 --- Ship it! Ship It! - Manikumar Reddy O On Jan. 8, 2015, 8:47 p.m

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270783#comment-14270783 ] Manikumar Reddy commented on KAFKA-1723: Updated reviewboard https

[jira] [Updated] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1723: --- Attachment: KAFKA-1723_2015-01-09_14:24:18.patch make the metrics name in new producer more

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-09 Thread Manikumar Reddy O
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Manikumar Reddy O
/#comment111418 Can we do authentication check at the beginning and fail-fast if the username/password is wrong. Currently it will update the review-board and fails at JIRA update. Is it possible to catch the exception/error, and show the message Invalid JIRA username/password - Manikumar

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-09 Thread Manikumar Reddy O
/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-09 Thread Manikumar Reddy O
/29523/diff/20/?file=813222#file813222line336 Should this be passed in? Or perhaps we can define this as a constant and reference it here. Sender is internal to producer.. So the group name is hard-coded. - Manikumar Reddy

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-09 Thread Manikumar Reddy O
... I have implemented toString() method in MetricName. So this will print complete info about the metric name (name , group, description , tags) - Manikumar Reddy --- This is an automatically generated e-mail. To reply, visit: https

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271663#comment-14271663 ] Manikumar Reddy commented on KAFKA-1723: 1. Submitted new patch with suggested

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Manikumar Reddy O
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: kafka-patch-review.py, line 96 https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96 Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-09 Thread Manikumar Reddy O
/SelectorTest.java 5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1723: --- Attachment: KAFKA-1723_2015-01-09_23:43:22.patch make the metrics name in new producer more

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271637#comment-14271637 ] Manikumar Reddy commented on KAFKA-1723: Updated reviewboard https

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-07 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267407#comment-14267407 ] Manikumar Reddy commented on KAFKA-1723: Thanks for the suggestion. will remove

[jira] [Commented] (KAFKA-1854) Allow the JIRA username and password to be prompted during patch submission

2015-01-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276551#comment-14276551 ] Manikumar Reddy commented on KAFKA-1854: [~jaikiran] Can you Pl update the wiki

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275651#comment-14275651 ] Manikumar Reddy commented on KAFKA-1723: While going through metrics related

[jira] [Comment Edited] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275651#comment-14275651 ] Manikumar Reddy edited comment on KAFKA-1723 at 1/13/15 6:22 PM

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-14 Thread Manikumar Reddy O
clients/src/main/java/org/apache/kafka/common/MetricName.java 4e810d56b753b7eeb662b99af5cdf36bcfba7ea7 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1723: --- Attachment: KAFKA-1723_2015-01-14_13:30:39.patch make the metrics name in new producer more

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14276629#comment-14276629 ] Manikumar Reddy commented on KAFKA-1723: Updated reviewboard https

[jira] [Resolved] (KAFKA-1022) Double quotes in Domain name Topic name

2015-01-14 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1022. Resolution: Not a Problem Fix Version/s: 0.8.2 Assignee: Manikumar Reddy O

[jira] [Commented] (KAFKA-1728) update 082 docs

2015-01-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275002#comment-14275002 ] Manikumar Reddy commented on KAFKA-1728: just want to update new producer JMX

[jira] [Issue Comment Deleted] (KAFKA-1728) update 082 docs

2015-01-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1728: --- Comment: was deleted (was: just want to update new producer JMX metrics . Not sure where

[jira] [Commented] (KAFKA-1730) add the doc for the new java producer in 0.8.2

2015-01-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275004#comment-14275004 ] Manikumar Reddy commented on KAFKA-1730: just want to update new producer JMX

[jira] [Commented] (KAFKA-1628) [New Java Producer] Topic which contains . does not correct corresponding metric name

2015-01-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275474#comment-14275474 ] Manikumar Reddy commented on KAFKA-1628: This has been fixed in KAFKA-1723. We can

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Manikumar Reddy O
/#comment111442 Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking jira.issue(). - Manikumar Reddy O On Jan. 9, 2015, 10:13 a.m., Jaikiran Pai wrote

Re: Review Request 29756: Patch for KAFKA-1854

2015-01-09 Thread Manikumar Reddy O
On Jan. 9, 2015, 11:07 a.m., Manikumar Reddy O wrote: kafka-patch-review.py, line 96 https://reviews.apache.org/r/29756/diff/3/?file=814216#file814216line96 Did you tested the failure senario? I did not get error message. I think we will get exception only after invoking

[jira] [Commented] (KAFKA-1758) corrupt recovery file prevents startup

2015-02-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312592#comment-14312592 ] Manikumar Reddy commented on KAFKA-1758: Created reviewboard https

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-02-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1758: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) corrupt recovery file

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-02-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1758: --- Attachment: KAFKA-1758.patch corrupt recovery file prevents startup

[jira] [Commented] (KAFKA-1758) corrupt recovery file prevents startup

2015-02-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312603#comment-14312603 ] Manikumar Reddy commented on KAFKA-1758: Attaching a patch which handles

[jira] [Resolved] (KAFKA-1377) transient unit test failure in LogOffsetTest

2015-02-11 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy resolved KAFKA-1377. Resolution: Fixed now i am not getting this exception..so closing the issue. transient

[jira] [Commented] (KAFKA-1945) MetaData Response - Broker hostname is wrong

2015-02-11 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14315841#comment-14315841 ] Manikumar Reddy commented on KAFKA-1945: You can set host.name

[jira] [Updated] (KAFKA-1938) [doc] Quick start example should reference appropriate Kafka version

2015-02-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1938: --- Attachment: remove-081-references-1.patch uploading new patch with small correction. [doc

Re: Review Request 29590: 1. Removed defaults for serializer/deserializer. 2. Converted type cast exception to serialization exception in the producer. 3. Added string ser/deser. 4. Moved the isKey fl

2015-01-08 Thread Manikumar Reddy O
/StringSerializer.java https://reviews.apache.org/r/29590/#comment111066 we should support null values right?. This is required for compaction.. - Manikumar Reddy O On Jan. 5, 2015, 7:47 p.m., Jun Rao wrote: --- This is an automatically

[jira] [Updated] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-08 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1723: --- Attachment: KAFKA-1723_2015-01-08_22:02:22.patch make the metrics name in new producer more

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-08 Thread Manikumar Reddy O
clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-08 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269513#comment-14269513 ] Manikumar Reddy commented on KAFKA-1723: Updated reviewboard https

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-08 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269585#comment-14269585 ] Manikumar Reddy commented on KAFKA-1723: 1. Added MetricName object and related

[jira] [Commented] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-08 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269489#comment-14269489 ] Manikumar Reddy commented on KAFKA-1723: Updated reviewboard https

[jira] [Updated] (KAFKA-1723) make the metrics name in new producer more standard

2015-01-08 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1723: --- Attachment: KAFKA-1723_2015-01-08_21:41:13.patch make the metrics name in new producer more

Re: Review Request 29523: Patch for KAFKA-1723

2015-01-08 Thread Manikumar Reddy O
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3 clients/src/test/java/org/apache/kafka/test/MetricsBench.java 9d98c1148255455fd801043b59b98fed9d0b76b3 Diff: https://reviews.apache.org/r/29523/diff/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-03-02 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1884: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) New Producer blocks

[jira] [Commented] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-03-02 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343294#comment-14343294 ] Manikumar Reddy commented on KAFKA-1884: Created reviewboard https

[jira] [Commented] (KAFKA-1877) Expose version via JMX for 'new' producer

2015-03-02 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343275#comment-14343275 ] Manikumar Reddy commented on KAFKA-1877: Yes, version info can be exposed as JMX

[jira] [Updated] (KAFKA-1884) New Producer blocks forever for Invalid topic names

2015-03-02 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1884: --- Attachment: KAFKA-1884.patch New Producer blocks forever for Invalid topic names

[jira] [Updated] (KAFKA-1884) Print metadata response errors

2015-03-05 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1884: --- Description: Print metadata response errors. producer logs: DEBUG [2015-01-20 12:46:13,406

[jira] [Commented] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

2015-02-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14332026#comment-14332026 ] Manikumar Reddy commented on KAFKA-1566: Also, it will be good , if we add all

Re: Review Request 30801: Patch for KAFKA-1758

2015-05-09 Thread Manikumar Reddy O
/ Testing --- Thanks, Manikumar Reddy O

[jira] [Updated] (KAFKA-1758) corrupt recovery file prevents startup

2015-05-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1758: --- Attachment: KAFKA-1758_2015-05-09_12:29:20.patch corrupt recovery file prevents startup

[jira] [Commented] (KAFKA-1758) corrupt recovery file prevents startup

2015-05-09 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536267#comment-14536267 ] Manikumar Reddy commented on KAFKA-1758: Updated reviewboard https

Re: Review Request 30801: Patch for KAFKA-1758

2015-05-09 Thread Manikumar Reddy O
to all errors. Also, worth changing the error message to a more generic statement about the problem and the fix (resetting the recovery checkpoint to 0). Yes, we can catch other exceptions also. updated the log message. - Manikumar Reddy

[jira] [Updated] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2015-05-18 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1374: --- Attachment: KAFKA-1374_2015-05-18_22:55:48.patch LogCleaner (compaction) does not support

<    9   10   11   12   13   14   15   16   17   18   >