/scala/kafka/tools/ReplicaVerificationTool.scala
af4783646803e58714770c21f8c3352370f26854
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
---
Thanks,
Mayuresh Gharat
)
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
/#review51793
---
On Aug. 28, 2014, 6:12 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25136
---
On Aug. 28, 2014, 6:12 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25136
and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
and the build succeeeded
Thanks,
Mayuresh Gharat
. To reply, visit:
https://reviews.apache.org/r/25136/#review51909
---
On Aug. 29, 2014, 5:04 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit
/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
, visit:
https://reviews.apache.org/r/25136/#review53391
---
On Sept. 3, 2014, 6:27 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
af4783646803e58714770c21f8c3352370f26854
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
,
Mayuresh Gharat
PRE-CREATION
Diff: https://reviews.apache.org/r/25942/diff/
Testing
---
Thanks,
Mayuresh Gharat
/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/SreOffsetTool.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/#comment94288
Please discard this
core/src/main/scala/kafka/tools/SreOffsetTool.scala
https://reviews.apache.org/r/25944/#comment94289
Please discard this!!
- Mayuresh Gharat
On Sept. 23, 2014, 5:18 p.m., Mayuresh Gharat wrote
core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/ExportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/#comment94290
Please discard this file for review
- Mayuresh Gharat
On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/#review54329
---
On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote
---
On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/#review54609
---
On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote
://reviews.apache.org/r/25136/diff/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
/unit/kafka/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
fbc680fde21b02f11285a4f4b442987356abd17b
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
/
Testing
---
Thanks,
Mayuresh Gharat
/
Testing
---
Thanks,
Mayuresh Gharat
8ea7368dc394a497164ea093ff8e9f2e6a94b1de
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
fbc680fde21b02f11285a4f4b442987356abd17b
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
://reviews.apache.org/r/26291/#review55456
---
On Oct. 9, 2014, 12:29 a.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26291
/PartitionAssignorTest.scala
9ceae222ca5bf63e8131de0db2a94126c8b57b59
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
/unit/kafka/consumer/PartitionAssignorTest.scala
9ceae222ca5bf63e8131de0db2a94126c8b57b59
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
://reviews.apache.org/r/27534/#comment101864
This causes many system tests (approx 98) to fail
- Mayuresh Gharat
On Nov. 3, 2014, 7:46 p.m., Ewen Cheslack-Postava wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote:
system_test/utils/kafka_system_test_utils.py, line 2403
https://reviews.apache.org/r/27534/diff/1/?file=747724#file747724line2403
This causes many system tests (approx 98) to fail
Ewen Cheslack-Postava wrote:
Can you give
On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote:
system_test/utils/kafka_system_test_utils.py, line 2403
https://reviews.apache.org/r/27534/diff/1/?file=747724#file747724line2403
This causes many system tests (approx 98) to fail
Ewen Cheslack-Postava wrote:
Can you give
/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28793/diff/
Testing
---
Thanks,
Mayuresh Gharat
/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28793/diff/
Testing
---
Thanks,
Mayuresh Gharat
/r/28793/#review64477
---
On Dec. 7, 2014, 7:43 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28793
On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote:
Can you add unit tests for this?
Mayuresh Gharat wrote:
Sure. I will try and add unit tests for this.
This part of the code was tested by Clark here, when had encountered an issue
where we had to fetch offsets from kafka
/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28793/diff/
Testing
---
Thanks,
Mayuresh Gharat
, your admin tool can just utilize the existing
APIst to expose commit/fetch through the tool. This class may be
unnecessary.
Mayuresh Gharat wrote:
I can pull out the code and use client utils as of now and once we get
the other patch with refactored code we can use this. Does
/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/TestOffsetManager.scala
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
, your admin tool can just utilize the existing
APIst to expose commit/fetch through the tool. This class may be
unnecessary.
Mayuresh Gharat wrote:
I can pull out the code and use client utils as of now and once we get
the other patch with refactored code we can use this. Does
/TestOffsetManager.scala
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/TestOffsetManager.scala
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/25944/#review65997
---
On Dec. 24, 2014, 12:41 a.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/#comment118893
Are you assuming that first argument will be some key?
core/src/main/scala/kafka/tools/ContinuousValidationTest.java
https://reviews.apache.org/r/30809/#comment118907
what do you mean by rebuild state later?
- Mayuresh Gharat
On Feb. 9, 2015, 11:53 p.m., Abhishek Nigam
41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala
4a3a5b264a021e55c39f4d7424ce04ee591503ef
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/OffsetCommitTest.scala
8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/
Testing
---
Thanks,
Mayuresh Gharat
I think the way reassignment works is asynchronous. Changes are made to
zookeeper but those changes get reflected only when controller watcher
fires for the respective zookeeper path. Is your watcher still alive?
Thanks,
Mayuresh
On Tue, Mar 17, 2015 at 1:29 PM, Allen Wang
...@netflix.com.invalid
wrote:
Yes, the watcher is still alive. The log in the controller indicates that
it observed the changes.
On Tue, Mar 17, 2015 at 2:05 PM, Mayuresh Gharat
gharatmayures...@gmail.com
wrote:
I think the way reassignment works is asynchronous. Changes are made to
zookeeper
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32199/#review77060
---
LGTM
- Mayuresh Gharat
On March 18, 2015, 11:12 a.m., Adrian
/KafkaProducer.java
https://reviews.apache.org/r/32440/#comment125718
Since its a Producer level config, is this change needed. We can keep it as
an instance variable. Also since the compression type does not change, the
private final makes it more clear. What do you think?
- Mayuresh Gharat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32440/#review77787
---
Ship it!
- Mayuresh Gharat
On March 25, 2015, 6:29 p.m., Grant
You can take a look at this :
https://issues.apache.org/jira/browse/KAFKA-1848
Thanks,
Mayuresh
On Sun, Mar 29, 2015 at 4:45 PM, Jiangjie Qin (JIRA) j...@apache.org
wrote:
[
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review74992
---
Ship it!
Ship It!
- Mayuresh Gharat
On Feb. 26, 2015, 6:54 p.m
://reviews.apache.org/r/31306/#comment121866
This will mean that if there are unkeyed messages we will neglect them and
not throw an exception right?
So we are aloowing unkeyed messages to go through comapction.
- Mayuresh Gharat
On Feb. 26, 2015, 6:54 p.m., Joel Koshy wrote
://reviews.apache.org/r/31306/#comment120016
We may also need to check this right:
sourceCodec != NoCompressionCodec
- Mayuresh Gharat
On Feb. 23, 2015, 2:43 p.m., Joel Koshy wrote:
---
This is an automatically generated e-mail
On March 24, 2015, 5 p.m., Mayuresh Gharat wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 134
https://reviews.apache.org/r/32440/diff/1/?file=904417#file904417line134
Since its a Producer level config, is this change needed. We can keep
://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
---
Thanks,
Mayuresh Gharat
Just a quick question, can we handle REQUEST TIMEOUT as disconnections and
do a fresh MetaDataRequest and retry instead of failing the request?
Thanks,
Mayuresh
On Mon, May 4, 2015 at 10:32 AM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
I incorporated Ewen and Guozhang’s comments in the
+1 Becket. That would give enough time for clients to move. We should make
this change very clear.
Thanks,
Mayuresh
On Tue, May 12, 2015 at 1:45 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
Hey Ewen,
Very good summary about the compatibility. What you proposed makes sense.
So
, hopefully metadata refresh will find the new
broker and we will not try to reconnect to the broker anymore.
Comments are welcome!
Thanks.
Jiangjie (Becket) Qin
On 5/12/15, 2:59 PM, Mayuresh Gharat gharatmayures...@gmail.com wrote:
+1 Becket. That would give enough time for clients to move
I suppose adding this timeout will help. In cases were the broker is not
completely down but stops responding to the produce request, tools like
Mirror Makers will hang since they are waiting for responses. Adding this
timeout enables it to fail the current request and retry with fresh
metadata.
Agreed we also need to change in the code of Sender.java to indicate that
it resembles REPLICATION_TIMEOUT and not the request Timeout.
Thanks,
Mayuresh
On Thu, Apr 16, 2015 at 1:08 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
Hi Guozhang,
By implicit timeout for close() and flush(), I
to something reasonable but maybe you
can override it if you want?
Thoughts?
-Jay
On Tue, May 19, 2015 at 11:34 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
So what I understand is that, we would have 3 time outs :
1) replication timeout
2) request timeout
3
) Qin
On 5/12/15, 2:59 PM, Mayuresh Gharat gharatmayures...@gmail.com
wrote:
+1 Becket. That would give enough time for clients to move. We should
make
this change very clear.
Thanks,
Mayuresh
On Tue, May 12, 2015 at 1:45 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote
On Tue, May 19, 2015 at 11:34 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
So what I understand is that, we would have 3 time outs :
1) replication timeout
2) request timeout
3) metadata timeout (existing)
The request timeout has to be greater than the replication timeout
+1 (non-binding). Thanks Jiangjie.
Thanks,
Mayuresh
On Tue, Jun 2, 2015 at 4:49 PM, Ewen Cheslack-Postava e...@confluent.io
wrote:
+1 non-binding. Thanks for all the work on this Jiangjie!
Aditya -- see discussion of partitionsFor() API, which needs to also use
one of those timeouts, and
TopicCreateRequest should be issued or not on UnknownTopicException. If
this is disabled and the topic doesn't exist, send will fail and the user
is expected to create the topic manually.
Thanks,
Jun
On Thu, May 21, 2015 at 5:27 PM, Mayuresh Gharat
gharatmayures...@gmail.com
wrote:
Hi
refresh will find the new
broker and we will not try to reconnect to the broker anymore.
Comments are welcome!
Thanks.
Jiangjie (Becket) Qin
On 5/12/15, 2:59 PM, Mayuresh Gharat gharatmayures...@gmail.com
wrote:
+1 Becket. That would give enough time for clients to move. We
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36858/#review94999
---
On Aug. 11, 2015, 2:55 a.m., Mayuresh Gharat wrote
The kafka review board returns a 500.
https://reviews.apache.org/r/36652
returns this :
Something broke! (Error 500) It appears something broke when you tried to
go to here. This is either a bug in Review Board or a server configuration
error. Please report this to your administrator
, visit:
https://reviews.apache.org/r/36652/#review95824
---
On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
)
https://reviews.apache.org/r/36652/#comment151020
I referred this :
https://www.sumologic.com/2014/05/05/why-you-should-never-catch-throwable-in-scala/
from the kafka 2353 patch.
http://www.tzavellas.com/techblog/2010/09/20/catching-throwable-in-scala/
- Mayuresh Gharat
On Aug. 13
+1 for this. Also we can put description of what changes might be required
to make in the current running release. But that might be cumbersome. Just
a thought.
Thanks,
Mayuresh
On Wed, Aug 19, 2015 at 2:29 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
I am thinking can we put some notes
---
Thanks,
Mayuresh Gharat
Hey Guozhang,
Can you forward the invite again?
Thanks,
Mayuresh
On Tue, Jul 28, 2015 at 11:04 AM, Guozhang Wang wangg...@gmail.com wrote:
Hi,
Just a reminder that today's KIP meeting is on GoToMeeting, not on Hangout.
Please find the link on the invite to join.
-- Guozhang
--
://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
/network/SocketServer.scala
dbe784b63817fd94e1593136926db17fac6fa3d7
Diff: https://reviews.apache.org/r/36652/diff/
Testing
---
Thanks,
Mayuresh Gharat
---
On Aug. 11, 2015, 2:55 a.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36858
core/src/test/scala/unit/kafka/utils/TestUtils.scala
eb169d8b33c27d598cc24e5a2e5f78b789fa38d3
Diff: https://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
missed it. +1 on rewriting Kafka in Java.
Thanks,
Mayuresh
On Tue, Aug 11, 2015 at 5:23 PM, Jason Gustafson ja...@confluent.io wrote:
Can the java code be indented without affecting the results of git blame?
If not, then I'd vote to leave it as it is.
(Also +1 on rewriting Kafka in Java)
+1 on consistency.
Thanks,
Mayuresh
On Tue, Aug 11, 2015 at 5:15 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Bump. Anyone else have an opinion?
Neha/Jay - You've made your thoughts clear. Any thoughts on how/if we make
any changes?
Thanks,
Aditya
On Fri, Jul 24, 2015
).
Even if we don't address the issue of sanity between the different timeouts
in this patch, it would be nice to have compatible defaults to keep the
consumer from breaking out of the box.
Mayuresh Gharat wrote:
Hi Jason,
I will upload a new patch with the sanity test
/ProducerFailureHandlingTest.scala
ee94011894b46864614b97bbd2a98375a7d3f20b
core/src/test/scala/unit/kafka/utils/TestUtils.scala
eb169d8b33c27d598cc24e5a2e5f78b789fa38d3
Diff: https://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
So basically this means that with acks = 0, their is no guarantee that the
message has been received by Kafka broker. I am just wondering, why would
anyone be using acks = 0, since anyone using kafka and doing
producer.send() would want that, their message got to kafka brokers. Also
as Jay said,
8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4
Diff: https://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
/clients/producer/internals/SenderTest.java
8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4
Diff: https://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
/RecordAccumulatorTest.java
5b2e4ffaeab7127648db608c179703b27b577414
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java
8b1805d3d2bcb9fe2bacb37d870c3236aa9532c4
Diff: https://reviews.apache.org/r/36858/diff/
Testing
---
Thanks,
Mayuresh Gharat
Try bouncing the host that appears in the stored data section.
Thanks,
Mayuresh
On Mon, Jul 27, 2015 at 3:41 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
This is due to the zookeeper path storing the previous owner info hasn't
been deleted at the moment. If the rebalance completes after
91319fa010b140cca632e5fa8050509bd2295fc9
Diff: https://reviews.apache.org/r/36652/diff/
Testing
---
Thanks,
Mayuresh Gharat
Hi,
I had to clean up existing kafka repo on my linux box and start with a
fresh one.
I followed the instructions here :
https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review
I am trying to upload a patch and I am getting these errors :
Configuring reviewboard url to
Yes.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 12:27 PM, Aditya Auradkar
aaurad...@linkedin.com.invalid wrote:
Did you setup your jira.ini?
On Tue, Jul 21, 2015 at 11:52 AM, Mayuresh Gharat
gharatmayures...@gmail.com wrote:
Hi,
I had to clean up existing kafka repo on my linux box
Not sure if you can do that with High level consumer.
Thanks,
Mayuresh
On Tue, Jul 21, 2015 at 10:53 AM, Pranay Agarwal agarwalpran...@gmail.com
wrote:
Any ideas?
On Mon, Jul 20, 2015 at 2:34 PM, Pranay Agarwal agarwalpran...@gmail.com
wrote:
Hi all,
Is there any way I can force
On July 21, 2015, 8:18 p.m., Mayuresh Gharat wrote:
T
Yes. Got it, I thought that we should be catching all exceptions and exit. But
doing the above will catch the exception and exit when its shutting down and
thats the only thing that this ticket considers.
- Mayuresh
1 - 100 of 593 matches
Mail list logo
