Re: [VOTE] KIP-864: Add End-To-End Latency Metrics to Connectors

2023-06-14 Thread Matthew Benedict de Detrich
Gets a +1 from me (non binding). Greatly helps debugging problematic connectors. On Thu, May 11, 2023 at 5:33 PM Hector Geraldino (BLOOMBERG/ 919 3RD A) < hgerald...@bloomberg.net> wrote: > This will help us greatly. +1 (non-binding) > > From: dev@kafka.apache.org At: 05/10/23 17:32:35

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Matthew Benedict de Detrich
+1 (non binding). Thanks for KIP On Tue, Jun 13, 2023 at 3:38 AM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > +1 (non-binding). Thanks for the KIP! > > On Mon, Jun 12, 2023, 21:23 Divij Vaidya wrote: > > > I have reviewed the proposal and feel that it would be beneficial to >

Re: [ANNOUNCE] New PMC chair: Mickael Maison

2023-04-21 Thread Matthew Benedict de Detrich
Congratulations Mickael and many thanks to Jun for the work over the years. On Fri, Apr 21, 2023 at 5:10 PM Jun Rao wrote: > Hi, everyone, > > After more than 10 years, I am stepping down as the PMC chair of Apache > Kafka. We now have a new chair Mickael Maison, who has been a PMC member >

Re: [DISCUSS] KIP-897: Publish a single kafka (aka core) Maven artifact in Apache Kafka 4.0

2023-03-18 Thread Matthew Benedict de Detrich
; On Sat, Mar 18, 2023 at 2:27 PM Matthew Benedict de Detrich > wrote: > > > >1. The kafka module does not expose a public api (unlike kafka-clients > or > > streams-scala) and the usage of Scala (including the version) is an > > implementation detail. >

Re: [DISCUSS] KIP-897: Publish a single kafka (aka core) Maven artifact in Apache Kafka 4.0

2023-03-18 Thread Matthew Benedict de Detrich
ively include > > kafka-core. > > > That's incorrect. kafka-clients is a pure Java library, does not include > the Scala suffix and does not depend on the kafka (aka core) jar. > > Ismael > > On Sat, Mar 18, 2023 at 9:31 AM Matthew Benedict de Detrich > wrote: >

Re: [DISCUSS] KIP-897: Publish a single kafka (aka core) Maven artifact in Apache Kafka 4.0

2023-03-18 Thread Matthew Benedict de Detrich
While I understand the motivation, such a change would break currently existing JVM build tools that work with Scala in subtle ways. More concretely it is expected that if a library is shipping the scala runtime scala-library.jar (i.e. it is a Scala library) it should use the suffix (i.e. _2.12 or

Re: [ANNOUNCE] New Kafka PMC Member: Chris Egerton

2023-03-10 Thread Matthew Benedict de Detrich
Congrats, well deserved! On Thu, 9 Mar 2023, 19:12 Jun Rao, wrote: > Hi, Everyone, > > Chris Egerton has been a Kafka committer since July 2022. He has been very > instrumental to the community since becoming a committer. It's my pleasure > to announce that Chris is now a member of Kafka PMC. >

Re: [ANNOUNCE] New Kafka PMC Member: Bruno Cadonna

2022-11-02 Thread Matthew Benedict de Detrich
Congratulations! On Wed, Nov 2, 2022 at 8:32 AM Josep Prat wrote: > Congrats Bruno! > > ——— > Josep Prat > > Aiven Deutschland GmbH > > Immanuelkirchstraße 26, 10405 Berlin > > Amtsgericht Charlottenburg, HRB 209739 B > > Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen > > m: +491715557497 >

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-10-17 Thread Matthew Benedict de Detrich
I realised that I mistook the KPI and didn't realize this wasn't part of the REST API so you can ignore what I previously wrote. On Mon, 17 Oct 2022, 12:18 Matthew Benedict de Detrich, < matthew.dedetr...@aiven.io> wrote: > So my only 2 cents on this KIP is mainly from a REST perspec

Re: [DISCUSS] KIP-875: First-class offsets support in Kafka Connect

2022-10-17 Thread Matthew Benedict de Detrich
So my only 2 cents on this KIP is mainly from a REST perspective, i.e. in the KIP you mention that you need to add a new field "state.v2": “STOPPED” due to maintaining backwards compatibility with older brokers. My main qualm here is that putting versioning into JSON field names isn’t typically

Re: [ANNOUNCE] New committer: Deng Ziming

2022-10-10 Thread Matthew Benedict de Detrich
Congratulations! On Mon, 10 Oct 2022, 11:30 Jason Gustafson, wrote: > Hi All > > The PMC for Apache Kafka has invited Deng Ziming to become a committer, > and we are excited to announce that he has accepted! > > Ziming has been contributing to Kafka for about three years. He has > authored >

Re: [DISCUSS] Apache Kafka 3.4.0 release

2022-10-10 Thread Matthew Benedict de Detrich
Thanks for volunteering! On Mon, 10 Oct 2022, 10:56 Bruno Cadonna, wrote: > +1 > > Thanks Sophie! > > Best, > Bruno > > On 06.10.22 00:01, Sophie Blee-Goldman wrote: > > Hey all, > > > > I'd like to volunteer as release manager for the next feature release, > > which will be Apache > > Kafka

Re: [VOTE] KIP-837 Allow MultiCasting a Result Record.

2022-08-24 Thread Matthew Benedict de Detrich
I also concur with this, having an Optional in the type makes it very clear what’s going on and better signifies an absence of value (or in this case the broadcast value). -- Matthew de Detrich Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B

Re: ARM/PowerPC builds

2022-08-23 Thread Matthew Benedict de Detrich
t; > On Thu, Aug 4, 2022, at 04:12, Matthew Benedict de Detrich wrote: > > Quite happy to have this change gone through since the ARM builds were > > constantly failing however I iterate what Divij Vaidya is saying. I > > just recently got a new MacBook M1 laptop that has

Re: Last sprint to finish line: Replace EasyMock/Powermock with Mockito

2022-08-04 Thread Matthew Benedict de Detrich
I will assign myself to 14132 and 14133, thanks for the detailed notes on gotchas for the migration. Regards -- Matthew de Detrich Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen m:

Re: ARM/PowerPC builds

2022-08-04 Thread Matthew Benedict de Detrich
Quite happy to have this change gone through since the ARM builds were constantly failing however I iterate what Divij Vaidya is saying. I just recently got a new MacBook M1 laptop that has ARM architecture and even locally the tests fail (these are the same tests that also failed in Jenkins).

Re: Recent commit causes Gradle to load significantly slowly?

2022-08-03 Thread Matthew Benedict de Detrich
t; Does this happen consistently? > > Ismael > > On Tue, Aug 2, 2022 at 4:00 AM Matthew Benedict de Detrich > wrote: > > > After syncing my fork with upstream Kafka at some point in time in the > > past I noticed that Gradle takes significantly longer to load, i.e. > &g

Re: [ANNOUNCE] New Kafka PMC Member: A. Sophie Blee-Goldman

2022-08-02 Thread Matthew Benedict de Detrich
Congratulations Sophie! -- Matthew de Detrich Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen m: +491603708037 w: aiven.io e: matthew.dedetr...@aiven.io On 2. Aug 2022, 01:42 +0200, Guozhang

Re: [ANNOUNCE] Apache Kafka 3.2.1

2022-08-02 Thread Matthew Benedict de Detrich
Thanks for organising the release! -- Matthew de Detrich Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen m: +491603708037 w: aiven.io e: matthew.dedetr...@aiven.io On 2. Aug 2022, 01:46 +0200,

Recent commit causes Gradle to load significantly slowly?

2022-08-02 Thread Matthew Benedict de Detrich
After syncing my fork with upstream Kafka at some point in time in the past I noticed that Gradle takes significantly longer to load, i.e. spending 5+ minutes in the configuration phase when the Gradle runner starts. Is anyone else experiencing this problem? -- Matthew de Detrich Aiven

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-08-01 Thread Matthew Benedict de Detrich
Just letting everyone know that in regards to KIP-797 (which was accepted in this release), the PR at https://github.com/apache/kafka/pull/11478 has received a binding approval from Luke Chen however we are still waiting for review from Mickael Maison/Tom Bently since they also reviewed the PR.

Re: [DISCUSS]: Including TLA+ in the repo

2022-07-28 Thread Matthew Benedict de Detrich
+1 from me as well, having the formal TLA+ proofs in the main repo is hugely beneficial not only from understanding the high level protocol but also in terms of awareness/making sure the proof is not outdated. -- Matthew de Detrich Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin

Re: [VOTE] 3.2.1 RC3

2022-07-26 Thread Matthew Benedict de Detrich
Thanks for the RC, I ran the full (unit + integration) tests using Scala 2.12 and 2.13 across OpenJDK (Linux) 11 and 17 and all tests passed apart from a single one which is documented at https://issues.apache.org/jira/browse/KAFKA-13514 +1 (non binding) On Fri, Jul 22, 2022 at 3:15 AM David

Re: [ANNOUNCE] New Committer: Chris Egerton

2022-07-25 Thread Matthew Benedict de Detrich
Congratulations! -- Matthew de Detrich Aiven Deutschland GmbH Immanuelkirchstraße 26, 10405 Berlin Amtsgericht Charlottenburg, HRB 209739 B Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen m: +491603708037 w: aiven.io e: matthew.dedetr...@aiven.io On 25. Jul 2022, 18:26 +0200, Mickael Maison ,

Details of Jenkins instance used for Kafka CI

2022-06-24 Thread Matthew Benedict de Detrich
I am trying to diagnose various flaky tests that are currently occurring on the official Apache Kafka Jenkins CI (i.e. https://ci-builds.apache.org/job/Kafka) and one of the theories I have behind the failing tests is that the load and/or concurrency of running the tests in Jenkins is sometimes

Re: [DISCUSS] Apache Kafka 3.3.0 Release

2022-06-17 Thread Matthew Benedict de Detrich
Hi José, KIP-797 has been accepted and the associated PR is now ready, is it possible to add to the release? Regards On Thu, Jun 16, 2022 at 11:56 PM José Armando García Sancio wrote: > Hi Divij, > > On Thu, Jun 16, 2022 at 1:37 AM Divij Vaidya > wrote: > > *Question#1*: Do we only track the

Re: [VOTE] KIP-797: Accept duplicate listener on port for IPv4/IPv6

2022-06-17 Thread Matthew Benedict de Detrich
Hi everyone, Thanks for participating in the discussion and voting. I'm closing this vote with three binding +1 and zero -1 votes. Binding +1 - Luke Chen - Tom Bently - Mickael Maison Non-Binding +1 - Ivan Yurchenko - Josep Prat - Igor Soarez I have rebased the PR against trunk at