Re: [ANNOUNCE] New committer: Igor Soarez

2024-04-30 Thread ziming deng
Congrats Igor! > On Apr 26, 2024, at 13:53, Christo Lolov wrote: > > Congratulations Igor :) ! > > On Thu, 25 Apr 2024 at 17:07, Igor Soarez wrote: > >> Thanks everyone, I'm very honoured to join! >> >> -- >> Igor >>

Re: [DISCUSS] KIP-996: Pre-Vote

2024-02-07 Thread ziming deng
Hi Alyssa, I have a minor question about the description in motivation section > Pre-Vote (as originally detailed in the Raft paper and in KIP-650) It seems Pre-vote is not mentioned in Raft paper, can you check out it again and rectify it? It would be helpful, thank you! - Thanks, Ziming

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-25 Thread ziming deng
Egerton написал(а): >> >> Thanks Ziming! +1 (binding) >> >> On Wed, Jan 24, 2024, 03:23 ziming deng wrote: >> >>> Thank you for reminding this, David, >>> >>> I have mentioned this in the [Compatibility] section as a following work. >>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-24 Thread ziming deng
tool. > It may be worth adding a note about it in the KIP to avoid the same > question in the future. > > Otherwise, I am +1 (binding). Thanks for driving this! > > Best, > David > > On Tue, Jan 23, 2024 at 6:07 AM ziming deng > wrote: > >> Hello David, >>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-23 Thread ziming deng
impacts append/subtract? The way I > read the JIRA is that the issue currently affects all operations for > plugins, but it can be fixed to only affect append/subtract (where it would > be harder to fix). It would be good to verify the current state. > > Ismael > > On Mon,

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-22 Thread ziming deng
at 7:03 AM Luke Chen wrote: >>>> >>>> Hi Ziming, >>>> >>>> +1(binding) from me. >>>> >>>> Thanks. >>>> Luke >>>> >>>> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash < >>&

[VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-21 Thread ziming deng
Hello everyone, I'd like to initiate a vote for KIP-1011. This KIP is about replacing alterConfigs with incrementalAlterConfigs when updating broker configs using kafka-configs.sh, this is similar to what we have done in KIP-894. KIP link:

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-14 Thread ziming deng
rovide any flag" after the discussion. We should > remove it. > > Thanks. > Luke > > On Fri, Jan 12, 2024 at 12:29 PM ziming deng <mailto:dengziming1...@gmail.com>> > wrote: > >> Thank you for your clarification, Chris, >> >> I have spent some time to re

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-11 Thread ziming deng
> don't appear to support appending/subtracting from list properties via the > CLI for any other entity type right now, and there's nothing in the KIP > that leads me to believe we'd be adding it for broker configs. > > Cheers, > > Chris > > On Thu, Jan 4, 2024 at 10:1

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2024-01-04 Thread ziming deng
all? Can we use incremental and fallback > automatically if it's not supported by the broker? At this point, the vast > majority of clusters should support it. > > Ismael > > On Mon, Dec 18, 2023 at 7:58 PM ziming deng <mailto:dengziming1...@gmail.com>> wrote: >> &g

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-28 Thread ziming deng
bility will be part of >> one amongst many changes that users will perform to upgrade to 4.x. This is >> unlike a major version change from 3.7 to 3.8 where users expect a simple >> upgrade without any code changes. >> >> Let's wait and hear what others think about thi

Re: [ANNOUNCE] New Kafka PMC Member: Divij Vaidya

2023-12-27 Thread ziming deng
Congrats Divij! > On Dec 28, 2023, at 10:59, Satish Duggana wrote: > > Congratulations Divij! > > On Thu, 28 Dec 2023 at 07:21, Kamal Chandraprakash > wrote: >> >> Congrats Divij! >> >> On Thu, Dec 28, 2023, 07:09 Kirk True wrote: >> >>> Congrats Divij!!! >>> >>> On Wed, Dec 27, 2023,

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-25 Thread ziming deng
Hello Divij Vaidya, You are right that users should update existing scripts to add ‘—disable-incremental’, and you mentioned another upgrade path which is similar, the summary of the 2 schemes are: we change existing scripts to use `incrementalAlterConfigs` and add "--disable-incremental"

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-21 Thread ziming deng
nice, it should be marked as deprecated and will >> be removed together with `AdminClient.alterConfigs()` > > Is it OK to introduce option that is deprecated from the beginning? > > >> 21 дек. 2023 г., в 06:03, ziming deng > <mailto:dengziming1...@gmail.com>>

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-20 Thread ziming deng
e KIP. Looks good to me. > > Just on question: given that alterConfig is deprecated, shouldn't we > also introduce --disable-incremental as deprecated? That way we would > get rid of both in Kafka 4.0. Also see: > https://issues.apache.org/jira/browse/KAFKA-14705. > > On Tue, De

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-20 Thread ziming deng
Also see: >> https://issues.apache.org/jira/browse/KAFKA-14705. >> >> On Tue, Dec 19, 2023 at 9:05 AM ziming deng wrote: >>> >>> Thank you for mention this Ismael, >>> >>> I added this to the motivation section, and I think we can still update

Re: DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-19 Thread ziming deng
. I think one of the main benefits of the change isn't > listed: sensitive configs make it impossible to make updates with the current > cli tool because sensitive config values are never returned. > > Ismael > > On Mon, Dec 18, 2023 at 7:58 PM ziming deng <mailto:de

DISCUSS KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

2023-12-18 Thread ziming deng
Hello, I want to start a discussion on KIP-1011, to make the broker config change path unified with that of user/topic/client-metrics and avoid some bugs. Here is the link:

Re: Remaining tests that need to support KRaft

2023-10-29 Thread ziming deng
Hello Sameer, I have created a PR for some test in `kafka.api` and `kafka.network`, you can take a review when you are free, thanks. https://github.com/apache/kafka/pull/14595 MINOR: Enable kraft test in kafka.api and kafka.network by dengziming · Pull Request #14595 · apache/kafka github.com

Re: [ANNOUNCE] New Kafka PMC Member: Satish Duggana

2023-10-27 Thread ziming deng
Congratulations Satish! > On Oct 27, 2023, at 23:03, Jun Rao wrote: > > Hi, Everyone, > > Satish Duggana has been a Kafka committer since 2022. He has been very > instrumental to the community since becoming a committer. It's my pleasure > to announce that Satish is now a member of Kafka PMC.

Re: [ANNOUNCE] New Kafka PMC Member: Justine Olshan

2023-09-24 Thread ziming deng
Congratulations Justine! > On Sep 25, 2023, at 00:01, Viktor Somogyi-Vass > wrote: > > Congrats Justine! > > On Sun, Sep 24, 2023, 17:45 Kirk True wrote: > >> Congratulations Justine! Thanks for all your great work! >> >>> On Sep 24, 2023, at 8:37 AM, John Roesler wrote: >>> >>>

Re: Unable to start the Kafka with Kraft in Windows 11

2023-09-05 Thread ziming deng
It seems this is related to KAFKA-14273, there is already a pr for this problem, but it’s not merged. https://github.com/apache/kafka/pull/12763 -- Ziming > On Sep 6, 2023, at 07:25, Greg Harris wrote: > > Hey Sumanshu, > > Thanks for trying out Kraft! I hope that you can get it working :)

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-09-05 Thread ziming deng
Hi, Igor I’m +1(binding) for this, looking forward the PR. -- Best, Ziming > On Jul 26, 2023, at 01:13, Igor Soarez wrote: > > Hi everyone, > > Following a face-to-face discussion with Ron and Colin, > I have just made further improvements to this KIP: > > > 1. Every log directory gets a

Re: What are the biggest issues with Apache Kafka?

2023-08-10 Thread ziming deng
Hi Liam, The Apache Kafka project has several modules, I think you should firstly select a module you are interested in. For example, we are currently working on KIP-500 related features, which includes 1. KIP-856: KRaft Disk Failure Recovery, 2. KIP-642: Dynamic quorum reassignment, 3.

Re: [VOTE] KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum and add Controller Registration

2023-07-26 Thread ziming deng
+1 (binding) from me. Thanks for the KIP! -- Ziming > On Jul 26, 2023, at 20:18, Luke Chen wrote: > > +1 (binding) from me. > > Thanks for the KIP! > > Luke > > On Tue, Jul 25, 2023 at 1:24 AM Colin McCabe wrote: > >> Hi all, >> >> I'd like to start the vote for KIP-919: Allow

Re: [ANNOUNCE] Apache Kafka 3.5.0

2023-06-15 Thread ziming deng
Thanks for this work, Mickael! -- Ziming > On Jun 15, 2023, at 16:35, Luke Chen wrote: > > Thanks for running this release, Mickael! > > > On Thu, Jun 15, 2023 at 4:27 PM Mickael Maison wrote: > >> The Apache Kafka community is pleased to announce the release for Apache >> Kafka 3.5.0. >>

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread ziming deng
Congratulations, Divij! Well deserved! -- Ziming > On Jun 14, 2023, at 09:41, Luke Chen wrote: > > Congratulations, Divij! > Well deserved! > > Luke > > On Wed, Jun 14, 2023 at 7:01 AM Viktor Somogyi-Vass > wrote: > >> Congrats Divij! >> >> On Tue, Jun 13, 2023, 20:27 Philip Nee wrote:

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-06-13 Thread ziming deng
Hi Igor, Thanks for this work. +1(binding) from me -- Best, Ziming > On Jun 12, 2023, at 18:07, Igor Soarez wrote: > > Hi everyone, > > We're getting closer to dropping ZooKeeper support, and JBOD > in KRaft mode is one of the outstanding big missing features. > > It's been a while since

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-30 Thread ziming deng
Hello ShunKang, +1(binding) from me -- Thanks, Ziming > On May 30, 2023, at 20:07, ShunKang Lin wrote: > > Hi all, > > Bump this thread again and see if we could get a few more votes. Currently > we have +2 non-binding and +1 binding. > Hoping we can get this approved, reviewed, and merged

Re: [VOTE] KIP-927: Improve the kafka-metadata-quorum output

2023-05-15 Thread ziming deng
Thanks for this improvement, +1 from me(binging) — Best, Ziming > On May 16, 2023, at 00:43, Federico Valeri wrote: > > Hi all, > > I'd like to start a vote on KIP-927: Improve the kafka-metadata-quorum output. > >

Re: Consumer offset value -Apache kafka 3.2.3

2023-04-27 Thread ziming deng
Hello, It seems kafka.tools.ConsumerOffsetChecker has been deprecated in 0.9.0, in the new version, please use kafka-consumer-groups.sh -- Best, Ziming > On Apr 26, 2023, at 18:21, Kafka Life wrote: > > Dear Kafka Experts > > How can we check for a particular offset number in Apache kafka

Re: [DISCUSS] KIP-858: Handle JBOD broker disk failure in KRaft

2023-04-24 Thread ziming deng
Thank you for the continuous work, I have some small problems related to the implementation details: 1. We have decided to add a new metadata.version, and you have said that "We should also avoid gating on metadata.version to include the `OnlineLogDirectories` field in the broker

Re: KIP-919: Allow AdminClient to Talk Directly with the KRaft Controller Quorum

2023-04-19 Thread ziming deng
Hello Colin, There is a mistake that we use `—bootstrap-server` instead of `—bootstrap-server(s)`, so should we also change the new argument `—bootstrap-controller` (no s). -- Ziming > On Apr 20, 2023, at 05:17, Colin McCabe wrote: > > Hi all, > > I wrote a short KIP about allowing

Re: kafka rebalancing problem

2023-04-04 Thread ziming deng
Thank you for reporting this, if you can stably reproduce it, you can create a JIRA ticket to track it. You are also welcomed if you can submit a PR to fix it. - - Best, Ziming. > On Apr 4, 2023, at 18:38, 大肉丸 <382650...@qq.com.INVALID> wrote: > > Excuse me, I would like to ask you a question:

Re: [ANNOUNCE] New Kafka PMC Member: David Arthur

2023-03-09 Thread ziming deng
Congrats David! Ziming > On Mar 10, 2023, at 10:02, Luke Chen wrote: > > Congratulations, David! > > On Fri, Mar 10, 2023 at 9:56 AM Yash Mayya wrote: > >> Congrats David! >> >> On Thu, Mar 9, 2023, 23:42 Jun Rao wrote: >> >>> Hi, Everyone, >>> >>> David Arthur has been a Kafka

Re: Entry point to start reading the code

2023-01-29 Thread ziming deng
Hello, I think you can start by reading `clients` module, starting from Producer and Consumer and AdminClient, there are many related blogs which can be found by google but may be outdated since Kafka are updating very quickly, a good new is that Kafka have very comprehensive test cases and you

Re: [ANNOUNCE] New committer: Justine Olshan

2022-12-29 Thread ziming deng
Congratulations Justine! — Best, Ziming > On Dec 30, 2022, at 10:06, Luke Chen wrote: > > Congratulations, Justine! > Well deserved! > > Luke > > On Fri, Dec 30, 2022 at 9:15 AM Ron Dagostino wrote: > >> Congratulations, Justine!Well-deserved., and I’m very happy for you. >> >> Ron >>

Re: [ANNOUNCE] New committer: Ron Dagostino

2022-12-14 Thread ziming deng
Congratulations, Ron! Well deserved! -- Ziming > On Dec 15, 2022, at 09:16, Luke Chen wrote: > > Congratulations, Ron! > Well deserved! > > Luke

Re: [DISCUSS] KIP-879: Multi-level Rack Awareness

2022-12-08 Thread ziming deng
Hi Viktor, As far as I know, we haven't make ReplicaPlacer a public interface, and we have no plan to make it public. I think you can submit a discussion or create a JIRA ticket directly without KIP if you have ideas on improving it, right? -- Best, Ziming > On Nov 29, 2022, at 21:52, Viktor