[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992063#comment-14992063
]
ASF GitHub Bot commented on KAFKA-2702:
---
Github user granthenke closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992064#comment-14992064
]
ASF GitHub Bot commented on KAFKA-2702:
---
GitHub user granthenke reopened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992387#comment-14992387
]
Grant Henke commented on KAFKA-2702:
I have updated the pull request based on all discussion above.
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992957#comment-14992957
]
ASF GitHub Bot commented on KAFKA-2702:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988504#comment-14988504
]
Grant Henke commented on KAFKA-2702:
Thanks for all the input
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988635#comment-14988635
]
Jason Gustafson commented on KAFKA-2702:
I think it's only required if the user is using group
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988628#comment-14988628
]
Gwen Shapira commented on KAFKA-2702:
-
Not 100% related to this patch, but I thought group.id is
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989036#comment-14989036
]
Grant Henke commented on KAFKA-2702:
[~gwenshap] There was no default for group.id in KAFKA-1328. It
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986744#comment-14986744
]
Jun Rao commented on KAFKA-2702:
[~granthenke], we can probably do the following.
1. Remove the required
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986371#comment-14986371
]
Grant Henke commented on KAFKA-2702:
[~ijuma] I agree. This would be fairly simple in Scala, as Option
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982679#comment-14982679
]
Andrii Biletskyi commented on KAFKA-2702:
-
It's been a while, but, yes, as far as I remember I
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982636#comment-14982636
]
Grant Henke commented on KAFKA-2702:
[~gwenshap] Yeah, there is definitely some config cleanup needed.
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983248#comment-14983248
]
Ismael Juma commented on KAFKA-2702:
For SSL and SASL configs, a default of null can be used for all
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983215#comment-14983215
]
Gwen Shapira commented on KAFKA-2702:
-
I'd prefer B, and I think that both Jay and you mentioned the
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980817#comment-14980817
]
Grant Henke commented on KAFKA-2702:
[~jkreps] You are right, that _required_ was added in
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981631#comment-14981631
]
Gwen Shapira commented on KAFKA-2702:
-
This needs some cleanup - because required=true is the default,
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979782#comment-14979782
]
Jay Kreps commented on KAFKA-2702:
--
Originally the presence or absence of a default indicated whether
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979786#comment-14979786
]
Jay Kreps commented on KAFKA-2702:
--
Also note that the check against NO_DEFAULT_VALUE isn't a check
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979754#comment-14979754
]
ASF GitHub Bot commented on KAFKA-2702:
---
GitHub user granthenke opened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979753#comment-14979753
]
Grant Henke commented on KAFKA-2702:
Looking into this a bit more...
{quote}
Try printing
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979802#comment-14979802
]
Grant Henke commented on KAFKA-2702:
[~jkreps] Good point. I was in Scala mode. I reverted the
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979461#comment-14979461
]
Grant Henke commented on KAFKA-2702:
I can take this one if you are not planning to work on it Gwen.
[
https://issues.apache.org/jira/browse/KAFKA-2702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979554#comment-14979554
]
Jay Kreps commented on KAFKA-2702:
--
Aren't things without default required? That rationale for that order
23 matches
Mail list logo
