[GitHub] [knox] lmccay merged pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response

2021-06-21 Thread GitBox
lmccay merged pull request #459: URL: https://github.com/apache/knox/pull/459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] xuzikun2003 opened a new pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response

2021-06-18 Thread GitBox
xuzikun2003 opened a new pull request #459: URL: https://github.com/apache/knox/pull/459 ## What changes were proposed in this pull request? Currently, Knox only supports the Content-Encoding "gzip" and the Content-Encoding "deflate" is not supported. When the upstream server (such

[GitHub] [knox] lmccay commented on pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response

2021-06-18 Thread GitBox
lmccay commented on pull request #459: URL: https://github.com/apache/knox/pull/459#issuecomment-864198747 @xuzikun2003 - it seems you have some checkstyle issues that need to be resolved. Please see https://travis-ci.com/github/apache/knox/jobs/515699869 for the issues towards the

[GitHub] [knox] xuzikun2003 commented on pull request #459: [KNOX-2622] Support Deflate Encoding for the Inbound Response

2021-06-18 Thread GitBox
xuzikun2003 commented on pull request #459: URL: https://github.com/apache/knox/pull/459#issuecomment-864207198 @lmccay , the style issue is already fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [knox] smolnar82 merged pull request #458: KNOX-2621 - Consolidated some HTTP error codes upon JWT/Passcode validation

2021-06-14 Thread GitBox
smolnar82 merged pull request #458: URL: https://github.com/apache/knox/pull/458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 opened a new pull request #458: KNOX-2621 - Consolidated some HTTP error codes upon JWT/Passcode validation

2021-06-14 Thread GitBox
smolnar82 opened a new pull request #458: URL: https://github.com/apache/knox/pull/458 ## What changes were proposed in this pull request? In some cases, it's better to return `401/UNAUTHORIZED` than `400/BAD_REQUEST`. ## How was this patch tested? Ran JUnit tests and

[GitHub] [knox] pzampino merged pull request #456: KNOX-2619 - HA dispatch should failover regardless of noFallback conf…

2021-06-10 Thread GitBox
pzampino merged pull request #456: URL: https://github.com/apache/knox/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 merged pull request #457: KNOX-2620 - Using the proper signature algorithm name in JWKS endpoint

2021-06-10 Thread GitBox
smolnar82 merged pull request #457: URL: https://github.com/apache/knox/pull/457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 opened a new pull request #457: KNOX-2620 - Using the proper signature algorithm name in JWKS endpoint

2021-06-09 Thread GitBox
smolnar82 opened a new pull request #457: URL: https://github.com/apache/knox/pull/457 ## What changes were proposed in this pull request? Populating and returning the appropriate signature algorithm in the response of Knox's JWKS endpoint. ## How was this patch tested?

[GitHub] [knox] pzampino commented on a change in pull request #456: KNOX-2619 - HA dispatch should failover regardless of noFallback conf…

2021-06-09 Thread GitBox
pzampino commented on a change in pull request #456: URL: https://github.com/apache/knox/pull/456#discussion_r648643626 ## File path: gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/ConfigurableHADispatch.java ## @@ -224,7 +224,7 @@ private void

[GitHub] [knox] moresandeep commented on a change in pull request #456: KNOX-2619 - HA dispatch should failover regardless of noFallback conf…

2021-06-09 Thread GitBox
moresandeep commented on a change in pull request #456: URL: https://github.com/apache/knox/pull/456#discussion_r648517128 ## File path: gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/ConfigurableHADispatch.java ## @@ -224,7 +224,7 @@ private void

[GitHub] [knox] lmccay commented on a change in pull request #456: KNOX-2619 - HA dispatch should failover regardless of noFallback conf…

2021-06-09 Thread GitBox
lmccay commented on a change in pull request #456: URL: https://github.com/apache/knox/pull/456#discussion_r648502609 ## File path: gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/ConfigurableHADispatch.java ## @@ -224,7 +224,7 @@ private void

[GitHub] [knox] pzampino opened a new pull request #456: KNOX-2619 - HA dispatch should failover regardless of noFallback conf…

2021-06-09 Thread GitBox
pzampino opened a new pull request #456: URL: https://github.com/apache/knox/pull/456 …ig until session is established ## What changes were proposed in this pull request? Modified ConfigurableHaDispatch behavior wrt to failover when sticky sessions are enabled, but fallback

[GitHub] [knox] smolnar82 merged pull request #455: KNOX-2618 - INFO level logging added about removing expired tokens from the DB

2021-06-08 Thread GitBox
smolnar82 merged pull request #455: URL: https://github.com/apache/knox/pull/455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 opened a new pull request #455: KNOX-2618 - INFO level logging added about removing expired tokens from the DB

2021-06-08 Thread GitBox
smolnar82 opened a new pull request #455: URL: https://github.com/apache/knox/pull/455 ## What changes were proposed in this pull request? Instead of logging the number of expired tokens removed from the DB at `DEBUG` level, Knox logs the ## How was this patch tested?

[GitHub] [knox] smolnar82 merged pull request #454: KNOX-2617 - Minor style changes and copy-to-clipboard functionality added for JWT/Passcode tokens and base target UL fields on the Token Generation

2021-06-04 Thread GitBox
smolnar82 merged pull request #454: URL: https://github.com/apache/knox/pull/454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 opened a new pull request #454: KNOX-2617 - Minor style changes and copy-to-clipboard functionality added for JWT/Passcode tokens and base target UL fields on the Token Gener

2021-06-04 Thread GitBox
smolnar82 opened a new pull request #454: URL: https://github.com/apache/knox/pull/454 ## What changes were proposed in this pull request? Improvements on Token Generation UI: - more refined DIV elements - copy-to-clipboard function is invoked when end-users click on `JWT

[GitHub] [knox] smolnar82 merged pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-04 Thread GitBox
smolnar82 merged pull request #452: URL: https://github.com/apache/knox/pull/452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 removed a comment on pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-04 Thread GitBox
smolnar82 removed a comment on pull request #452: URL: https://github.com/apache/knox/pull/452#issuecomment-853625828 Thanks, @stoty for your comment. I did a smoke test in a local cluster with all the service UIs available and found the following services need the trailing slash: Oozie,

[GitHub] [knox] smolnar82 merged pull request #453: KNOX-2613 - Limiting and validating the comment's length on Token Generation UI

2021-06-04 Thread GitBox
smolnar82 merged pull request #453: URL: https://github.com/apache/knox/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 commented on pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-04 Thread GitBox
smolnar82 commented on pull request #452: URL: https://github.com/apache/knox/pull/452#issuecomment-853625828 Thanks, @stoty for your comment. I did a smoke test in a local cluster with all the service UIs available and found the following services need the trailing slash: Oozie, Ranger,

[GitHub] [knox] smolnar82 merged pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-04 Thread GitBox
smolnar82 merged pull request #452: URL: https://github.com/apache/knox/pull/452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 merged pull request #453: KNOX-2613 - Limiting and validating the comment's length on Token Generation UI

2021-06-03 Thread GitBox
smolnar82 merged pull request #453: URL: https://github.com/apache/knox/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 opened a new pull request #453: KNOX-2613 - Limiting and validating the comment's length on Token Generation UI

2021-06-03 Thread GitBox
smolnar82 opened a new pull request #453: URL: https://github.com/apache/knox/pull/453 ## What changes were proposed in this pull request? Limiting the comment field length to 255 characters. I also added validation on that field in case the limit does not take place for any reason.

[GitHub] [knox] smolnar82 removed a comment on pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-03 Thread GitBox
smolnar82 removed a comment on pull request #452: URL: https://github.com/apache/knox/pull/452#issuecomment-853625828 Thanks, @stoty for your comment. I did a smoke test in a local cluster with all the service UIs available and found the following services need the trailing slash: Oozie,

[GitHub] [knox] smolnar82 commented on pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-03 Thread GitBox
smolnar82 commented on pull request #452: URL: https://github.com/apache/knox/pull/452#issuecomment-853625828 Thanks, @stoty for your comment. I did a smoke test in a local cluster with all the service UIs available and found the following services need the trailing slash: Oozie, Ranger,

[GitHub] [knox] stoty edited a comment on pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-02 Thread GitBox
stoty edited a comment on pull request #452: URL: https://github.com/apache/knox/pull/452#issuecomment-853019011 When I tested, the UI pages for some services, like the Oozie UI, didn't load without the trailing slash. As it is kind of hopeless to test every single service, the most

[GitHub] [knox] stoty edited a comment on pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-02 Thread GitBox
stoty edited a comment on pull request #452: URL: https://github.com/apache/knox/pull/452#issuecomment-853019011 When I tested, the UI pages for some services, like the Oozie UI, didn't load without the trailing slash. As it is kind of hopeless to test every single service, the most

[GitHub] [knox] stoty commented on pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-02 Thread GitBox
stoty commented on pull request #452: URL: https://github.com/apache/knox/pull/452#issuecomment-853019011 When I tested, the UI pages for some services, look the Oozie UI, didn't load without the trailing slash. As it is kind of hopeless to test every single service, the most

[GitHub] [knox] smolnar82 opened a new pull request #452: KNOX-2616 - Removed trailing slashes service context generation

2021-06-02 Thread GitBox
smolnar82 opened a new pull request #452: URL: https://github.com/apache/knox/pull/452 ## What changes were proposed in this pull request? Extra trailing slash in the generated service context caused problems. ## How was this patch tested? Updated JUnit tests and tested

[GitHub] [knox] moresandeep merged pull request #451: KNOX-2608 - JWT tokens issues by Knox should have 'kid' and 'jku' as part of JOSE Headers

2021-05-24 Thread GitBox
moresandeep merged pull request #451: URL: https://github.com/apache/knox/pull/451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] moresandeep opened a new pull request #451: KNOX-2608 - JWT tokens issues by Knox should have 'kid' and 'jku' as part of JOSE Headers

2021-05-24 Thread GitBox
moresandeep opened a new pull request #451: URL: https://github.com/apache/knox/pull/451 ## What changes were proposed in this pull request? Adding 'kid' and 'jku' claims as part of JOSE Headers for tokens issued by Knox ## How was this patch tested? This patch was tested

[GitHub] [knox] smolnar82 merged pull request #450: KNOX-2606 - Indicate configured token TTL on UI and ask for confirmation when end-users try to generate a token above the configured limit

2021-05-20 Thread GitBox
smolnar82 merged pull request #450: URL: https://github.com/apache/knox/pull/450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 opened a new pull request #450: KNOX-2606 - Indicate configured token TTL on UI and ask for confirmation when end-users try to generate a token above the configured limit

2021-05-20 Thread GitBox
smolnar82 opened a new pull request #450: URL: https://github.com/apache/knox/pull/450 ## What changes were proposed in this pull request? In order to avoid misunderstandings and customer escalations, the token generation UI now indicates what is the configured maximum lifetime

[GitHub] [knox] smolnar82 merged pull request #449: KNOX-2605 - Better validation of the supplied token lifespan fields

2021-05-19 Thread GitBox
smolnar82 merged pull request #449: URL: https://github.com/apache/knox/pull/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 opened a new pull request #449: KNOX-2605 - Better validation of the supplied token lifespan fields

2021-05-19 Thread GitBox
smolnar82 opened a new pull request #449: URL: https://github.com/apache/knox/pull/449 ## What changes were proposed in this pull request? Added more refined validation on each token lifespan field to make sure we do not allow: - negative values - floating numbers -

[GitHub] [knox] smolnar82 merged pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
smolnar82 merged pull request #448: URL: https://github.com/apache/knox/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 commented on a change in pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
smolnar82 commented on a change in pull request #448: URL: https://github.com/apache/knox/pull/448#discussion_r633569862 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@

[GitHub] [knox] pzampino commented on a change in pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
pzampino commented on a change in pull request #448: URL: https://github.com/apache/knox/pull/448#discussion_r633550033 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -30,8

[GitHub] [knox] smolnar82 merged pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
smolnar82 merged pull request #448: URL: https://github.com/apache/knox/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 commented on a change in pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
smolnar82 commented on a change in pull request #448: URL: https://github.com/apache/knox/pull/448#discussion_r633646832 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@

[GitHub] [knox] pzampino commented on a change in pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
pzampino commented on a change in pull request #448: URL: https://github.com/apache/knox/pull/448#discussion_r633584944 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -30,8

[GitHub] [knox] pzampino commented on a change in pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
pzampino commented on a change in pull request #448: URL: https://github.com/apache/knox/pull/448#discussion_r633584139 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -30,8

[GitHub] [knox] smolnar82 commented on a change in pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
smolnar82 commented on a change in pull request #448: URL: https://github.com/apache/knox/pull/448#discussion_r633569862 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@

[GitHub] [knox] pzampino commented on a change in pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-17 Thread GitBox
pzampino commented on a change in pull request #448: URL: https://github.com/apache/knox/pull/448#discussion_r633550033 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -30,8

[GitHub] [knox] smolnar82 opened a new pull request #448: KNOX-2603 - Caching passcode token verifications

2021-05-14 Thread GitBox
smolnar82 opened a new pull request #448: URL: https://github.com/apache/knox/pull/448 ## What changes were proposed in this pull request? In order to avoid expensive MAC calculation at request verification time, previous successful passcode token verifications are cached and

[GitHub] [knox] moresandeep merged pull request #423: KNOX-2559: Added functionality to append headers in request in Config…

2021-05-13 Thread GitBox
moresandeep merged pull request #423: URL: https://github.com/apache/knox/pull/423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 merged pull request #437: KNOX-2579 - Saving token.id claim in a hashed from in the DB

2021-05-11 Thread GitBox
smolnar82 merged pull request #437: URL: https://github.com/apache/knox/pull/437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] pzampino commented on a change in pull request #437: KNOX-2579 - Saving token.id claim in a hashed from in the DB

2021-05-11 Thread GitBox
pzampino commented on a change in pull request #437: URL: https://github.com/apache/knox/pull/437#discussion_r630379211 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java ## @@ -141,9

[GitHub] [knox] smolnar82 merged pull request #447: KNOX-2602 - Added the enabled flag and related token service API into the tokens' metadata.

2021-05-05 Thread GitBox
smolnar82 merged pull request #447: URL: https://github.com/apache/knox/pull/447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 commented on a change in pull request #447: KNOX-2602 - Added the enabled flag and related token service API into the tokens' metadata.

2021-05-05 Thread GitBox
smolnar82 commented on a change in pull request #447: URL: https://github.com/apache/knox/pull/447#discussion_r626278725 ## File path: gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/JDBCTokenStateService.java ## @@ -193,8 +194,17 @@ protected void

[GitHub] [knox] moresandeep merged pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep merged pull request #445: URL: https://github.com/apache/knox/pull/445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] moresandeep commented on a change in pull request #447: KNOX-2602 - Added the enabled flag and related token service API into the tokens' metadata.

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #447: URL: https://github.com/apache/knox/pull/447#discussion_r626109820 ## File path: gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/JDBCTokenStateService.java ## @@ -193,8 +194,17 @@ protected void

[GitHub] [knox] smolnar82 opened a new pull request #447: KNOX-2602 - Added the enabled flag and related token service API into the tokens' metadata.

2021-05-04 Thread GitBox
smolnar82 opened a new pull request #447: URL: https://github.com/apache/knox/pull/447 ## What changes were proposed in this pull request? There is a new `KNOXTOKEN` service API to enable/disable a Knox-generated token. Instead of adding another column in KNOX_TABLES, a brand new

[GitHub] [knox] moresandeep merged pull request #446: KNOX-2601: ZeppelinUI creates multiple sessions when going via Knox

2021-05-04 Thread GitBox
moresandeep merged pull request #446: URL: https://github.com/apache/knox/pull/446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r626000702 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java ## @@ -31,15

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625904268 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SSOCookieFederationFilter.java ## @@

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625902703 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SSOCookieFederationFilter.java ## @@

[GitHub] [knox] smolnar82 merged pull request #443: KNOX-2599 - Improve tokengen UI

2021-05-04 Thread GitBox
smolnar82 merged pull request #443: URL: https://github.com/apache/knox/pull/443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] vedantlodha opened a new pull request #446: KNOX-2601: ZeppelinUI created multiple sessions when going via Knox

2021-05-04 Thread GitBox
vedantlodha opened a new pull request #446: URL: https://github.com/apache/knox/pull/446 ## What changes were proposed in this pull request? Zeppelin uses JSESSIONID to identify a session. Zeppelin UI service definition uses DefaultDispatch which prevents "SET-COOKIE" response

[GitHub] [knox] pzampino commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
pzampino commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625827897 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java ## @@ -31,15

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625822042 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java ## @@ -186,4

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625821690 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java ## @@ -90,6

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625819010 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java ## @@ -31,15

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625815547 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/JWTMessages.java ## @@ -59,8 +59,11 @@

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625814216 ## File path: gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java ## @@ -201,6 +246,86 @@

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625812360 ## File path: gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java ## @@ -201,6 +246,86 @@

[GitHub] [knox] moresandeep commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
moresandeep commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625805715 ## File path: gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java ## @@ -129,10 +152,27 @@

[GitHub] [knox] pzampino commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
pzampino commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625797509 ## File path: gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java ## @@ -201,6 +246,86 @@

[GitHub] [knox] pzampino commented on a change in pull request #445: Knox 2582

2021-05-04 Thread GitBox
pzampino commented on a change in pull request #445: URL: https://github.com/apache/knox/pull/445#discussion_r625756920 ## File path: gateway-provider-security-hadoopauth/src/main/java/org/apache/knox/gateway/hadoopauth/filter/HadoopAuthFilter.java ## @@ -129,10 +152,27 @@

[GitHub] [knox] mudit-97 commented on a change in pull request #423: KNOX-2559: Added functionality to append headers in request in Config…

2021-05-04 Thread GitBox
mudit-97 commented on a change in pull request #423: URL: https://github.com/apache/knox/pull/423#discussion_r625633724 ## File path: gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/ConfigurableDispatch.java ## @@ -41,13 +47,26 @@ public class ConfigurableDispatch

[GitHub] [knox] moresandeep opened a new pull request #445: Knox 2582

2021-05-03 Thread GitBox
moresandeep opened a new pull request #445: URL: https://github.com/apache/knox/pull/445 ## What changes were proposed in this pull request? This change adds unauthenticated path list support for the following two authentication providers (along with SSOCookieProvider) -

[GitHub] [knox] smolnar82 commented on a change in pull request #443: KNOX-2599 - Improve tokengen UI

2021-05-03 Thread GitBox
smolnar82 commented on a change in pull request #443: URL: https://github.com/apache/knox/pull/443#discussion_r625323200 ## File path: gateway-applications/src/main/resources/applications/tokengen/app/js/tokengen.js ## @@ -53,20 +53,23 @@ function b64DecodeUnicode(str) { }

[GitHub] [knox] smolnar82 merged pull request #444: KNOX-2600 - It's now possible to setup a PostgreSQL connection using a JDBC URL

2021-05-03 Thread GitBox
smolnar82 merged pull request #444: URL: https://github.com/apache/knox/pull/444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 merged pull request #441: KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues

2021-05-03 Thread GitBox
smolnar82 merged pull request #441: URL: https://github.com/apache/knox/pull/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] pzampino merged pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-05-03 Thread GitBox
pzampino merged pull request #440: URL: https://github.com/apache/knox/pull/440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 commented on pull request #444: KNOX-2600 - It's now possible to setup a PostgreSQL connection using a JDBC URL

2021-05-03 Thread GitBox
smolnar82 commented on pull request #444: URL: https://github.com/apache/knox/pull/444#issuecomment-831204421 > It would be nice if we can validate JDBC url syntax and let users know that the configured URL was wrong in the logs. Thanks, @moresandeep for your review. This is

[GitHub] [knox] smolnar82 opened a new pull request #444: KNOX-2600 - It's now possible to setup a PostgreSQL connection using a JDBC URL

2021-05-02 Thread GitBox
smolnar82 opened a new pull request #444: URL: https://github.com/apache/knox/pull/444 ## What changes were proposed in this pull request? Instead of declaring connection properties one-by-one in `gateway-site.xml` a simple `connection URL` is enough to create connections to

[GitHub] [knox] smolnar82 commented on a change in pull request #443: KNOX-2599 - Improve tokengen UI

2021-05-02 Thread GitBox
smolnar82 commented on a change in pull request #443: URL: https://github.com/apache/knox/pull/443#discussion_r624738363 ## File path: gateway-applications/src/main/resources/applications/tokengen/app/js/tokengen.js ## @@ -53,20 +53,23 @@ function b64DecodeUnicode(str) { }

[GitHub] [knox] smolnar82 merged pull request #442: KNOX-2598 - Added SSL connection support for PostgreSQL database type in JDBC token state management

2021-05-02 Thread GitBox
smolnar82 merged pull request #442: URL: https://github.com/apache/knox/pull/442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [knox] smolnar82 commented on a change in pull request #442: KNOX-2598 - Added SSL connection support for PostgreSQL database type in JDBC token state management

2021-05-02 Thread GitBox
smolnar82 commented on a change in pull request #442: URL: https://github.com/apache/knox/pull/442#discussion_r624737344 ## File path: gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java ## @@ -1258,4 +1261,20 @@ public int

[GitHub] [knox] smolnar82 commented on a change in pull request #441: KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues

2021-05-02 Thread GitBox
smolnar82 commented on a change in pull request #441: URL: https://github.com/apache/knox/pull/441#discussion_r624737130 ## File path: gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java ## @@ -207,6 +211,42 @@ public void

[GitHub] [knox] smolnar82 commented on a change in pull request #441: KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues

2021-05-02 Thread GitBox
smolnar82 commented on a change in pull request #441: URL: https://github.com/apache/knox/pull/441#discussion_r624735877 ## File path: gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java ## @@ -207,6 +211,42 @@ public void

[GitHub] [knox] smolnar82 commented on a change in pull request #441: KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues

2021-05-02 Thread GitBox
smolnar82 commented on a change in pull request #441: URL: https://github.com/apache/knox/pull/441#discussion_r624735857 ## File path: gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java ## @@ -207,6 +211,42 @@ public void

[GitHub] [knox] smolnar82 commented on a change in pull request #441: KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues

2021-05-02 Thread GitBox
smolnar82 commented on a change in pull request #441: URL: https://github.com/apache/knox/pull/441#discussion_r624735568 ## File path: gateway-server/src/main/java/org/apache/knox/gateway/services/factory/TokenStateServiceFactory.java ## @@ -51,8 +55,15 @@ protected Service

[GitHub] [knox] lmccay commented on a change in pull request #443: KNOX-2599 - Improve tokengen UI

2021-04-30 Thread GitBox
lmccay commented on a change in pull request #443: URL: https://github.com/apache/knox/pull/443#discussion_r623873998 ## File path: gateway-applications/src/main/resources/applications/tokengen/app/js/tokengen.js ## @@ -53,20 +53,23 @@ function b64DecodeUnicode(str) { }

[GitHub] [knox] lmccay commented on a change in pull request #441: KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues

2021-04-30 Thread GitBox
lmccay commented on a change in pull request #441: URL: https://github.com/apache/knox/pull/441#discussion_r623857140 ## File path: gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java ## @@ -207,6 +211,42 @@ public void init()

[GitHub] [knox] pzampino commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
pzampino commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623523680 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -0,0

[GitHub] [knox] smolnar82 opened a new pull request #443: KNOX-2599 - Improve tokengen UI

2021-04-29 Thread GitBox
smolnar82 opened a new pull request #443: URL: https://github.com/apache/knox/pull/443 ## What changes were proposed in this pull request? - let end-users declare a more refined lifespan - let end-users add a comment to the generated ## How was this patch tested?

[GitHub] [knox] pzampino commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
pzampino commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623374691 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -0,0

[GitHub] [knox] pzampino commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
pzampino commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623373552 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -0,0

[GitHub] [knox] pzampino commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
pzampino commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623373356 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -0,0

[GitHub] [knox] smolnar82 opened a new pull request #442: KNOX-2598 - Added SSL connection support for PostgreSQL database type in JDBC token state management

2021-04-29 Thread GitBox
smolnar82 opened a new pull request #442: URL: https://github.com/apache/knox/pull/442 ## What changes were proposed in this pull request? Made it possible to connect to an SSL-enabled PostgreSQL server using an SSL connection. To be able to achieve our goals here I needed to

[GitHub] [knox] pzampino commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
pzampino commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623364195 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/AbstractJWTFilter.java ## @@ -444,41

[GitHub] [knox] pzampino commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
pzampino commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623362873 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/SignatureVerificationCache.java ## @@ -0,0

[GitHub] [knox] pzampino commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
pzampino commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623361585 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/AbstractJWTFilter.java ## @@ -444,41

[GitHub] [knox] pzampino commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
pzampino commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623360938 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/AbstractJWTFilter.java ## @@ -96,7 +92,7 @@

[GitHub] [knox] smolnar82 commented on a change in pull request #440: KNOX-2544 - Token-based providers should cache successful (including …

2021-04-29 Thread GitBox
smolnar82 commented on a change in pull request #440: URL: https://github.com/apache/knox/pull/440#discussion_r623334551 ## File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/AbstractJWTFilter.java ## @@ -444,41

[GitHub] [knox] smolnar82 opened a new pull request #441: KNOX-2597 - Falling back to AliasBasedTokenStateService in case of DB configuration issues

2021-04-29 Thread GitBox
smolnar82 opened a new pull request #441: URL: https://github.com/apache/knox/pull/441 ## What changes were proposed in this pull request? The following features are implemented by this change: - if there is a misconfiguration in JDBCTokenState service, the

[GitHub] [knox] smolnar82 merged pull request #439: KNOX-2596 - Changed gateway-site config value to support PostgeSQL as token state backend

2021-04-27 Thread GitBox
smolnar82 merged pull request #439: URL: https://github.com/apache/knox/pull/439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

<    8   9   10   11   12   13   14   15   16   17   >