[GitHub] [knox] zeroflag commented on a diff in pull request #602: KNOX-2771 - Log HTTP client config parameters such as socket timeouts with info level

2022-07-06 Thread GitBox
zeroflag commented on code in PR #602: URL: https://github.com/apache/knox/pull/602#discussion_r914550322 ## gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java: ## @@ -91,10 +91,10 @@ public interface SpiGatewayMessages { text = "The dispatch

[GitHub] [knox] zeroflag commented on a diff in pull request #602: KNOX-2771 - Log HTTP client config parameters such as socket timeouts with info level

2022-07-06 Thread GitBox
zeroflag commented on code in PR #602: URL: https://github.com/apache/knox/pull/602#discussion_r914550322 ## gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java: ## @@ -91,10 +91,10 @@ public interface SpiGatewayMessages { text = "The dispatch

[GitHub] [knox] MrtnBalazs commented on pull request #602: KNOX-2771 - Log HTTP client config parameters such as socket timeouts with info level

2022-07-06 Thread GitBox
MrtnBalazs commented on PR #602: URL: https://github.com/apache/knox/pull/602#issuecomment-1175868604 @smolnar82 @zeroflag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [knox] MrtnBalazs opened a new pull request, #602: KNOX-2771 - Log HTTP client config parameters such as socket timeouts with info level

2022-07-06 Thread GitBox
MrtnBalazs opened a new pull request, #602: URL: https://github.com/apache/knox/pull/602 ## What changes were proposed in this pull request? Changed log level of http connection timeout and socket timeout to from DEBUG to INFO and added INFO level log for retry count and retry non

[GitHub] [knox] harshiljhaveri commented on pull request #600: KNOX-2763 Fix for NPE arising due to missing CompositeAuthz provider names

2022-07-05 Thread GitBox
harshiljhaveri commented on PR #600: URL: https://github.com/apache/knox/pull/600#issuecomment-1175343502 > @harshiljhaveri - is this the same PR as #597? Yes, PR 597 had conditions to handle null cases as well. Started a new PR to address a different JIRA ticket #. -- This is an

[GitHub] [knox] smolnar82 commented on pull request #600: KNOX-2763 Fix for NPE arising due to missing CompositeAuthz provider names

2022-07-05 Thread GitBox
smolnar82 commented on PR #600: URL: https://github.com/apache/knox/pull/600#issuecomment-1174704905 @harshiljhaveri - is this the same PR as #597? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [knox] smolnar82 commented on pull request #601: KNOX-123 - Test commit

2022-07-04 Thread GitBox
smolnar82 commented on PR #601: URL: https://github.com/apache/knox/pull/601#issuecomment-1173832383 This was a test PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [knox] smolnar82 closed pull request #601: KNOX-123 - Test commit

2022-07-04 Thread GitBox
smolnar82 closed pull request #601: KNOX-123 - Test commit URL: https://github.com/apache/knox/pull/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [knox] harshiljhaveri commented on pull request #600: KNOX-2763 Fix for NPE arising due to missing CompositeAuthz provider names

2022-06-29 Thread GitBox
harshiljhaveri commented on PR #600: URL: https://github.com/apache/knox/pull/600#issuecomment-1170223049 @moresandeep @smolnar82 @zeroflag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [knox] moresandeep commented on pull request #601: KNOX-123 - Test commit

2022-06-28 Thread GitBox
moresandeep commented on PR #601: URL: https://github.com/apache/knox/pull/601#issuecomment-1168732872 Looks good :) ![Looks good](https://media.giphy.com/media/mlvseq9yvZhba/giphy.gif) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [knox] smolnar82 commented on pull request #601: KNOX-123 - Test commit

2022-06-28 Thread GitBox
smolnar82 commented on PR #601: URL: https://github.com/apache/knox/pull/601#issuecomment-1168652832 @moresandeep Inviting you to review this very important change! It's critical! Please make it first today!! :) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [knox] MrtnBalazs commented on a diff in pull request #601: KNOX-123 - Test commit

2022-06-28 Thread GitBox
MrtnBalazs commented on code in PR #601: URL: https://github.com/apache/knox/pull/601#discussion_r908279687 ## gateway-util-common/src/test/java/org/apache/knox/gateway/audit/AuditLayoutTest.java: ## @@ -115,6 +115,7 @@ public void testFullyFilledAuditEvent() {

[GitHub] [knox] zeroflag commented on a diff in pull request #601: KNOX-123 - Test commit

2022-06-28 Thread GitBox
zeroflag commented on code in PR #601: URL: https://github.com/apache/knox/pull/601#discussion_r908275157 ## gateway-util-common/src/test/java/org/apache/knox/gateway/audit/AuditLayoutTest.java: ## @@ -115,6 +115,7 @@ public void testFullyFilledAuditEvent() {

[GitHub] [knox] MrtnBalazs opened a new pull request, #601: KNOX-123 - Test commit

2022-06-28 Thread GitBox
MrtnBalazs opened a new pull request, #601: URL: https://github.com/apache/knox/pull/601 This is a test, do not merge!! ## What changes were proposed in this pull request? Added a comment with test purpuses ## How was this patch tested? TODO Not tested yet

[GitHub] [knox] moresandeep merged pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-26 Thread GitBox
moresandeep merged PR #597: URL: https://github.com/apache/knox/pull/597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [knox] harshiljhaveri opened a new pull request, #600: KNOX-2763 Fix for NPE arising due to missing CompositeAuthz provider names

2022-06-24 Thread GitBox
harshiljhaveri opened a new pull request, #600: URL: https://github.com/apache/knox/pull/600 ## What changes were proposed in this pull request? The Provider Names Parse Method handles the case where no provider names or blank or empty provider names are provided. ## How was this

[GitHub] [knox] smolnar82 commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-24 Thread GitBox
smolnar82 commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r905831775 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -58,7 +59,7 @@ public void

[GitHub] [knox] zeroflag commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-24 Thread GitBox
zeroflag commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r905828331 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -58,7 +59,7 @@ public void

[GitHub] [knox] smolnar82 merged pull request #565: Bump async from 2.6.3 to 2.6.4 in /knox-token-management-ui

2022-06-24 Thread GitBox
smolnar82 merged PR #565: URL: https://github.com/apache/knox/pull/565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] zeroflag commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-23 Thread GitBox
zeroflag commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r905386669 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -71,7 +71,7 @@ public void

[GitHub] [knox] zeroflag commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-23 Thread GitBox
zeroflag commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r905386669 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -71,7 +71,7 @@ public void

[GitHub] [knox] smolnar82 commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-23 Thread GitBox
smolnar82 commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r905328537 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -71,7 +71,7 @@ public void

[GitHub] [knox] smolnar82 commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-23 Thread GitBox
smolnar82 commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r905326309 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -71,7 +71,7 @@ public void

[GitHub] [knox] smolnar82 merged pull request #564: Bump async from 2.6.3 to 2.6.4 in /gateway-admin-ui

2022-06-23 Thread GitBox
smolnar82 merged PR #564: URL: https://github.com/apache/knox/pull/564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] smolnar82 merged pull request #556: Bump minimist from 1.2.5 to 1.2.6 in /knox-token-management-ui

2022-06-23 Thread GitBox
smolnar82 merged PR #556: URL: https://github.com/apache/knox/pull/556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] moresandeep merged pull request #599: KNOX-2766 - Make sure disableLoadBalancingForUserAgents is picked up from HA configs

2022-06-23 Thread GitBox
moresandeep merged PR #599: URL: https://github.com/apache/knox/pull/599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [knox] smolnar82 closed pull request #477: [WIP] KNOX-2631

2022-06-23 Thread GitBox
smolnar82 closed pull request #477: [WIP] KNOX-2631 URL: https://github.com/apache/knox/pull/477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [knox] smolnar82 commented on pull request #477: [WIP] KNOX-2631

2022-06-23 Thread GitBox
smolnar82 commented on PR #477: URL: https://github.com/apache/knox/pull/477#issuecomment-1164307170 All the Knox WebShell changes are available here: https://github.com/apache/knox/tree/webshell -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [knox] smolnar82 merged pull request #598: Bump mysql-connector-java from 8.0.25 to 8.0.28

2022-06-23 Thread GitBox
smolnar82 merged PR #598: URL: https://github.com/apache/knox/pull/598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] dependabot[bot] commented on pull request #588: Bump @angular/core from 5.2.11 to 11.0.5 in /gateway-admin-ui

2022-06-23 Thread GitBox
dependabot[bot] commented on PR #588: URL: https://github.com/apache/knox/pull/588#issuecomment-1164177664 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [knox] smolnar82 closed pull request #588: Bump @angular/core from 5.2.11 to 11.0.5 in /gateway-admin-ui

2022-06-23 Thread GitBox
smolnar82 closed pull request #588: Bump @angular/core from 5.2.11 to 11.0.5 in /gateway-admin-ui URL: https://github.com/apache/knox/pull/588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [knox] smolnar82 commented on pull request #588: Bump @angular/core from 5.2.11 to 11.0.5 in /gateway-admin-ui

2022-06-23 Thread GitBox
smolnar82 commented on PR #588: URL: https://github.com/apache/knox/pull/588#issuecomment-1164177625 See https://issues.apache.org/jira/browse/KNOX-2767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [knox] smolnar82 closed pull request #591: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-homepage-ui

2022-06-23 Thread GitBox
smolnar82 closed pull request #591: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-homepage-ui URL: https://github.com/apache/knox/pull/591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [knox] dependabot[bot] commented on pull request #591: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-homepage-ui

2022-06-23 Thread GitBox
dependabot[bot] commented on PR #591: URL: https://github.com/apache/knox/pull/591#issuecomment-1164177470 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [knox] smolnar82 commented on pull request #591: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-homepage-ui

2022-06-23 Thread GitBox
smolnar82 commented on PR #591: URL: https://github.com/apache/knox/pull/591#issuecomment-1164177415 See https://issues.apache.org/jira/browse/KNOX-2767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [knox] smolnar82 commented on pull request #592: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-token-management-ui

2022-06-23 Thread GitBox
smolnar82 commented on PR #592: URL: https://github.com/apache/knox/pull/592#issuecomment-1164177109 See https://issues.apache.org/jira/browse/KNOX-2767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [knox] smolnar82 closed pull request #592: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-token-management-ui

2022-06-23 Thread GitBox
smolnar82 closed pull request #592: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-token-management-ui URL: https://github.com/apache/knox/pull/592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [knox] dependabot[bot] commented on pull request #592: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-token-management-ui

2022-06-23 Thread GitBox
dependabot[bot] commented on PR #592: URL: https://github.com/apache/knox/pull/592#issuecomment-1164176969 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [knox] smolnar82 merged pull request #587: KNOX-2721: upgrade jetty to 9.4.45 due to cves

2022-06-23 Thread GitBox
smolnar82 merged PR #587: URL: https://github.com/apache/knox/pull/587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] dependabot[bot] commented on pull request #557: Bump hadoop-common from 3.2.2 to 3.2.3

2022-06-23 Thread GitBox
dependabot[bot] commented on PR #557: URL: https://github.com/apache/knox/pull/557#issuecomment-1164168469 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [knox] smolnar82 closed pull request #557: Bump hadoop-common from 3.2.2 to 3.2.3

2022-06-23 Thread GitBox
smolnar82 closed pull request #557: Bump hadoop-common from 3.2.2 to 3.2.3 URL: https://github.com/apache/knox/pull/557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [knox] smolnar82 commented on pull request #557: Bump hadoop-common from 3.2.2 to 3.2.3

2022-06-23 Thread GitBox
smolnar82 commented on PR #557: URL: https://github.com/apache/knox/pull/557#issuecomment-1164168435 Merged #586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [knox] smolnar82 merged pull request #586: KNOX-2754: upgrade hadoop-common due to cve

2022-06-23 Thread GitBox
smolnar82 merged PR #586: URL: https://github.com/apache/knox/pull/586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] smolnar82 merged pull request #584: KNOX-2718: upgrade xmlsec due to security issue

2022-06-23 Thread GitBox
smolnar82 merged PR #584: URL: https://github.com/apache/knox/pull/584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] smolnar82 closed pull request #585: KNOX-2753: upgrade mina due to security issue

2022-06-23 Thread GitBox
smolnar82 closed pull request #585: KNOX-2753: upgrade mina due to security issue URL: https://github.com/apache/knox/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [knox] smolnar82 commented on pull request #585: KNOX-2753: upgrade mina due to security issue

2022-06-23 Thread GitBox
smolnar82 commented on PR #585: URL: https://github.com/apache/knox/pull/585#issuecomment-1164164319 #574 was merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [knox] smolnar82 merged pull request #574: Bump mina-core from 2.0.21 to 2.0.22

2022-06-23 Thread GitBox
smolnar82 merged PR #574: URL: https://github.com/apache/knox/pull/574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] smolnar82 merged pull request #566: Bump async from 2.6.3 to 2.6.4 in /knox-homepage-ui

2022-06-23 Thread GitBox
smolnar82 merged PR #566: URL: https://github.com/apache/knox/pull/566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] smolnar82 merged pull request #555: Bump minimist from 1.2.5 to 1.2.6 in /knox-homepage-ui

2022-06-23 Thread GitBox
smolnar82 merged PR #555: URL: https://github.com/apache/knox/pull/555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] smolnar82 commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-23 Thread GitBox
smolnar82 commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r904699792 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -56,23 +59,24 @@ public void

[GitHub] [knox] moresandeep opened a new pull request, #599: KNOX-2766 - Make sure disableLoadBalancingForUserAgents is picked up from HA configs

2022-06-22 Thread GitBox
moresandeep opened a new pull request, #599: URL: https://github.com/apache/knox/pull/599 ## What changes were proposed in this pull request? Fix case where `disableLoadBalancingForUserAgents` property defined in HA provider in a topology was not getting picked up. ## How was this

[GitHub] [knox] smolnar82 commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-21 Thread GitBox
smolnar82 commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r902944796 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -57,22 +59,23 @@ public void

[GitHub] [knox] smolnar82 commented on a diff in pull request #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-21 Thread GitBox
smolnar82 commented on code in PR #597: URL: https://github.com/apache/knox/pull/597#discussion_r902941720 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -57,22 +59,23 @@ public void

[GitHub] [knox] dependabot[bot] opened a new pull request, #598: Bump mysql-connector-java from 8.0.25 to 8.0.28

2022-06-20 Thread GitBox
dependabot[bot] opened a new pull request, #598: URL: https://github.com/apache/knox/pull/598 Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 8.0.25 to 8.0.28. Changelog Sourced from

[GitHub] [knox] harshiljhaveri opened a new pull request, #597: KNOX-2762 Bug fixes for spaces around delimiters with all reviewed comments addressed

2022-06-20 Thread GitBox
harshiljhaveri opened a new pull request, #597: URL: https://github.com/apache/knox/pull/597 ## What changes were proposed in this pull request? Fix for NullPointer Exception arising due to whitespaces around delimiters in Composite Auth Provider Names. All review comments addressed.

[GitHub] [knox] smolnar82 commented on a diff in pull request #596: KNOX-2762 Bug fixes for spaces around delimiters with reviewed commen…

2022-06-19 Thread GitBox
smolnar82 commented on code in PR #596: URL: https://github.com/apache/knox/pull/596#discussion_r901147476 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -57,22 +58,23 @@ public void

[GitHub] [knox] moresandeep commented on a diff in pull request #596: KNOX-2762 Bug fixes for spaces around delimiters with reviewed commen…

2022-06-18 Thread GitBox
moresandeep commented on code in PR #596: URL: https://github.com/apache/knox/pull/596#discussion_r900832669 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -57,22 +58,23 @@ public

[GitHub] [knox] harshiljhaveri opened a new pull request, #596: KNOX-2762 Bug fixes for spaces around delimiters with reviewed commen…

2022-06-17 Thread GitBox
harshiljhaveri opened a new pull request, #596: URL: https://github.com/apache/knox/pull/596 ## What changes were proposed in this pull request? Issue arising from NPE due to whitespaces around delimiters in Composite Authz names fixed with review comments addressed. ## How

[GitHub] [knox] harshiljhaveri closed pull request #595: KNOX-2762 Bug fixes for spaces around delimiters with reviewed commen…

2022-06-16 Thread GitBox
harshiljhaveri closed pull request #595: KNOX-2762 Bug fixes for spaces around delimiters with reviewed commen… URL: https://github.com/apache/knox/pull/595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [knox] harshiljhaveri opened a new pull request, #595: KNOX-2762 Bug fixes for spaces around delimiters with reviewed commen…

2022-06-16 Thread GitBox
harshiljhaveri opened a new pull request, #595: URL: https://github.com/apache/knox/pull/595 ## What changes were proposed in this pull request? Fix for Null Pointer Exception arising due to whitespaces. Changes suggested in previous PR have all been incorporated. ## How was

[GitHub] [knox] smolnar82 merged pull request #593: KNOX-2761 - Knox Token renew/revoke operations are now PUT/DELETE HTTP methods in KnoxShell too

2022-06-16 Thread GitBox
smolnar82 merged PR #593: URL: https://github.com/apache/knox/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] moresandeep commented on pull request #594: KNOX-2762

2022-06-15 Thread GitBox
moresandeep commented on PR #594: URL: https://github.com/apache/knox/pull/594#issuecomment-1156857449 @harshiljhaveri can you post a followup PR with suggested changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [knox] moresandeep commented on pull request #594: KNOX-2762

2022-06-15 Thread GitBox
moresandeep commented on PR #594: URL: https://github.com/apache/knox/pull/594#issuecomment-1156856334 Sure, thanks for the comments @smolnar82! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [knox] smolnar82 commented on pull request #594: KNOX-2762

2022-06-15 Thread GitBox
smolnar82 commented on PR #594: URL: https://github.com/apache/knox/pull/594#issuecomment-1156845298 @harshiljhaveri @moresandeep - I'd like to ask you to re-open this one and address my review comments. Sorry, I did not add them before, I just haven't had time today morning. Thanks for

[GitHub] [knox] smolnar82 commented on a diff in pull request #594: KNOX-2762

2022-06-15 Thread GitBox
smolnar82 commented on code in PR #594: URL: https://github.com/apache/knox/pull/594#discussion_r898334503 ## gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java: ## @@ -56,17 +56,23 @@ public void

[GitHub] [knox] moresandeep merged pull request #594: KNOX-2762

2022-06-15 Thread GitBox
moresandeep merged PR #594: URL: https://github.com/apache/knox/pull/594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [knox] harshiljhaveri opened a new pull request, #594: KNOX-2762

2022-06-14 Thread GitBox
harshiljhaveri opened a new pull request, #594: URL: https://github.com/apache/knox/pull/594 ## What changes were proposed in this pull request? Whitespaces around delimiters were causing problems while specifying composite auth provider names. The parseProviderNames function has

[GitHub] [knox] smolnar82 opened a new pull request, #593: KNOX-2761 - Knox Token renew/revoke operations are now PUT/DELETE HTTP methods in KnoxShell too

2022-06-14 Thread GitBox
smolnar82 opened a new pull request, #593: URL: https://github.com/apache/knox/pull/593 ## What changes were proposed in this pull request? As the corresponding JIRA states, #494 changed some of the HTTP methods in `TokenResource` that the KnosShell classes were missing to implement.

[GitHub] [knox] zeroflag merged pull request #583: KNOX-2752 knoxcli should support batch alias creation

2022-06-09 Thread GitBox
zeroflag merged PR #583: URL: https://github.com/apache/knox/pull/583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] smolnar82 commented on a diff in pull request #583: KNOX-2752 knoxcli should support batch alias creation

2022-06-09 Thread GitBox
smolnar82 commented on code in PR #583: URL: https://github.com/apache/knox/pull/583#discussion_r893495981 ## gateway-server/src/main/java/org/apache/knox/gateway/util/KnoxCLI.java: ## @@ -977,6 +995,104 @@ public String getUsage() { } + public class

[GitHub] [knox] dependabot[bot] opened a new pull request, #591: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-homepage-ui

2022-06-09 Thread GitBox
dependabot[bot] opened a new pull request, #591: URL: https://github.com/apache/knox/pull/591 Bumps [@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core) from 5.2.11 to 11.0.5. Changelog Sourced from

[GitHub] [knox] dependabot[bot] opened a new pull request, #592: Bump @angular/core from 5.2.11 to 11.0.5 in /knox-token-management-ui

2022-06-09 Thread GitBox
dependabot[bot] opened a new pull request, #592: URL: https://github.com/apache/knox/pull/592 Bumps [@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core) from 5.2.11 to 11.0.5. Changelog Sourced from

[GitHub] [knox] smolnar82 merged pull request #590: KNOX-2757 - HadoopGroupProvider parameters should be added to the filter even there is a gateway level property with CENTRAL_GROUP_CONFIG_PREFIX

2022-06-09 Thread GitBox
smolnar82 merged PR #590: URL: https://github.com/apache/knox/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] smolnar82 commented on a diff in pull request #590: KNOX-2757 - HadoopGroupProvider parameters should be added to the filter even there is a gateway level property with CENTRAL_GROUP_C

2022-06-08 Thread GitBox
smolnar82 commented on code in PR #590: URL: https://github.com/apache/knox/pull/590#discussion_r892644197 ## gateway-provider-identity-assertion-hadoop-groups/src/main/java/org/apache/knox/gateway/identityasserter/hadoop/groups/filter/HadoopGroupProviderDeploymentContributor.java:

[GitHub] [knox] smolnar82 merged pull request #576: KNOX-2746 - Add presto/presto ui support in service definition

2022-06-07 Thread GitBox
smolnar82 merged PR #576: URL: https://github.com/apache/knox/pull/576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] Bhargavi-Sagi commented on pull request #576: KNOX-2746 - Add presto/presto ui support in service definition

2022-06-06 Thread GitBox
Bhargavi-Sagi commented on PR #576: URL: https://github.com/apache/knox/pull/576#issuecomment-1148212095 Presto and Trino are different projects. Trino was initially forked from presto but then they have diverged quite a lot over time. There are apis in Trino which are not present in

[GitHub] [knox] smolnar82 commented on a diff in pull request #590: KNOX-2757 - HadoopGroupProvider parameters should be added to the filter even there is a gateway level property with CENTRAL_GROUP_C

2022-06-03 Thread GitBox
smolnar82 commented on code in PR #590: URL: https://github.com/apache/knox/pull/590#discussion_r889275387 ## gateway-provider-identity-assertion-hadoop-groups/src/main/java/org/apache/knox/gateway/identityasserter/hadoop/groups/filter/HadoopGroupProviderDeploymentContributor.java:

[GitHub] [knox] zeroflag commented on a diff in pull request #590: KNOX-2757 - HadoopGroupProvider parameters should be added to the filter even there is a gateway level property with CENTRAL_GROUP_CO

2022-06-03 Thread GitBox
zeroflag commented on code in PR #590: URL: https://github.com/apache/knox/pull/590#discussion_r889018034 ## gateway-provider-identity-assertion-hadoop-groups/src/main/java/org/apache/knox/gateway/identityasserter/hadoop/groups/filter/HadoopGroupProviderDeploymentContributor.java:

[GitHub] [knox] smolnar82 opened a new pull request, #590: KNOX-2757 - HadoopGroupProvider parameters should be added to the filter even there is a gateway level property with CENTRAL_GROUP_CONFIG_PRE

2022-06-03 Thread GitBox
smolnar82 opened a new pull request, #590: URL: https://github.com/apache/knox/pull/590 ## What changes were proposed in this pull request? From now on, in Knox's HadoopGroupProvider, the gateway-level `CENTRAL_GROUP_CONFIG_PREFIX` prefixed parameters are added together with any

[GitHub] [knox] smolnar82 merged pull request #589: KNOX-2756 - Fixing NPE caused by null GatewayConfig

2022-06-03 Thread GitBox
smolnar82 merged PR #589: URL: https://github.com/apache/knox/pull/589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] dependabot[bot] opened a new pull request, #588: Bump @angular/core from 5.2.11 to 11.0.5 in /gateway-admin-ui

2022-06-02 Thread GitBox
dependabot[bot] opened a new pull request, #588: URL: https://github.com/apache/knox/pull/588 Bumps [@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core) from 5.2.11 to 11.0.5. Changelog Sourced from

[GitHub] [knox] pjfanning opened a new pull request, #587: KNOX-2721: upgrade jetty to 9.4.45 due to cves

2022-06-02 Thread GitBox
pjfanning opened a new pull request, #587: URL: https://github.com/apache/knox/pull/587 (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!) ## What changes were proposed in this pull

[GitHub] [knox] pjfanning opened a new pull request, #586: KNOX-2754: upgrade hadoop-common due to cve

2022-06-01 Thread GitBox
pjfanning opened a new pull request, #586: URL: https://github.com/apache/knox/pull/586 (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!) ## What changes were proposed in this pull

[GitHub] [knox] pjfanning opened a new pull request, #585: KNOX-2753: upgrade mina due to security issue

2022-06-01 Thread GitBox
pjfanning opened a new pull request, #585: URL: https://github.com/apache/knox/pull/585 (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!) ## What changes were proposed in this pull

[GitHub] [knox] smolnar82 commented on pull request #576: KNOX-2746 - Add presto/presto ui support in service definition

2022-06-01 Thread GitBox
smolnar82 commented on PR #576: URL: https://github.com/apache/knox/pull/576#issuecomment-1143746741 @Bhargavi-Sagi - this looks great! There was another PR recently that added [Trino](https://trino.io/docs/current/) as a new service to Knox. Checking Trino's and Presto's pages I found

[GitHub] [knox] pjfanning opened a new pull request, #584: KNOX-2718: upgrade xmlsec due to security issue

2022-06-01 Thread GitBox
pjfanning opened a new pull request, #584: URL: https://github.com/apache/knox/pull/584 (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!) ## What changes were proposed in this pull

[GitHub] [knox] dependabot[bot] commented on pull request #580: Bump gson from 2.8.6 to 2.8.9

2022-06-01 Thread GitBox
dependabot[bot] commented on PR #580: URL: https://github.com/apache/knox/pull/580#issuecomment-1143735583 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

[GitHub] [knox] smolnar82 commented on pull request #580: Bump gson from 2.8.6 to 2.8.9

2022-06-01 Thread GitBox
smolnar82 commented on PR #580: URL: https://github.com/apache/knox/pull/580#issuecomment-1143735515 Fixed in https://issues.apache.org/jira/browse/KNOX-2750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [knox] smolnar82 closed pull request #580: Bump gson from 2.8.6 to 2.8.9

2022-06-01 Thread GitBox
smolnar82 closed pull request #580: Bump gson from 2.8.6 to 2.8.9 URL: https://github.com/apache/knox/pull/580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [knox] smolnar82 merged pull request #582: KNOX-2750: upgrade gson due to security issue

2022-06-01 Thread GitBox
smolnar82 merged PR #582: URL: https://github.com/apache/knox/pull/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] zeroflag opened a new pull request, #583: KNOX-2752 knoxcli should support batch alias creation

2022-06-01 Thread GitBox
zeroflag opened a new pull request, #583: URL: https://github.com/apache/knox/pull/583 ## What changes were proposed in this pull request? KnoxCLI only allow creating one alias at a time which can be really slow if we want to create lots of aliases. This patch introduces batch

[GitHub] [knox] smolnar82 merged pull request #548: KNOX-2720 upgrade postgresql due to security issue

2022-06-01 Thread GitBox
smolnar82 merged PR #548: URL: https://github.com/apache/knox/pull/548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] pjfanning opened a new pull request, #582: KNOX-2750: upgrade gson due to security issue

2022-05-30 Thread GitBox
pjfanning opened a new pull request, #582: URL: https://github.com/apache/knox/pull/582 (It is very **important** that you created an Apache Knox JIRA for this change and that the PR title/commit message includes the Apache Knox JIRA ID!) ## What changes were proposed in this pull

[GitHub] [knox] zeroflag merged pull request #581: KNOX-2747 RemoteAliasService generates password without checking if it already exists

2022-05-27 Thread GitBox
zeroflag merged PR #581: URL: https://github.com/apache/knox/pull/581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] zeroflag commented on a diff in pull request #581: KNOX-2747 RemoteAliasService generates password without checking if it already exists

2022-05-26 Thread GitBox
zeroflag commented on code in PR #581: URL: https://github.com/apache/knox/pull/581#discussion_r883106816 ## gateway-server/src/test/java/org/apache/knox/gateway/services/security/impl/RemoteAliasServiceTestProvider.java: ## @@ -88,7 +88,8 @@ public void

[GitHub] [knox] pzampino commented on a diff in pull request #581: KNOX-2747 RemoteAliasService generates password without checking if it already exists

2022-05-26 Thread GitBox
pzampino commented on code in PR #581: URL: https://github.com/apache/knox/pull/581#discussion_r882870933 ## gateway-server/src/test/java/org/apache/knox/gateway/services/security/impl/RemoteAliasServiceTestProvider.java: ## @@ -88,7 +88,8 @@ public void

[GitHub] [knox] zeroflag opened a new pull request, #581: KNOX-2747 RemoteAliasService generates password without checking if it already exists

2022-05-24 Thread GitBox
zeroflag opened a new pull request, #581: URL: https://github.com/apache/knox/pull/581 ## What changes were proposed in this pull request? RemoteAliasService always regenerates the password if generates=true, unlike the other implementation. This causes problems with HA deployments

[GitHub] [knox] moresandeep merged pull request #579: KNOX-2726 - Impersonation Params should be configurable

2022-05-23 Thread GitBox
moresandeep merged PR #579: URL: https://github.com/apache/knox/pull/579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [knox] zeroflag merged pull request #560: KNOX-2732 Issuer claim in Knox JWTs should be configurable

2022-05-23 Thread GitBox
zeroflag merged PR #560: URL: https://github.com/apache/knox/pull/560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

[GitHub] [knox] zeroflag merged pull request #578: KNOX-2736 Knox clients should support retry/failover - addendum

2022-05-23 Thread GitBox
zeroflag merged PR #578: URL: https://github.com/apache/knox/pull/578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

<    1   2   3   4   5   6   7   8   9   10   >