zeroflag merged PR #686:
URL: https://github.com/apache/knox/pull/686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
smolnar82 commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1035551478
##
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##
@@ -720,19 +705,21 @@ private Response
pzampino commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1035343473
##
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##
@@ -720,19 +705,21 @@ private Response getAuthenticationToken()
lmccay commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1035199113
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##
@@ -187,21 +219,46
smolnar82 commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1034908229
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##
@@ -84,57 +98,86
smolnar82 commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1034907903
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java:
##
@@ -50,4 +51,16 @@ public interface
pzampino commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1034795153
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##
@@ -84,57 +98,86
smolnar82 commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1034635599
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/IdentityAsserterMessages.java:
##
@@ -50,4 +51,16 @@ public interface
zeroflag opened a new pull request, #686:
URL: https://github.com/apache/knox/pull/686
## What changes were proposed in this pull request?
Originally was named incorretly
## How was this patch tested?
--
This is an automated message from the Apache Git Service.
To
zeroflag merged PR #680:
URL: https://github.com/apache/knox/pull/680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
pzampino commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1034240821
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##
@@ -84,57 +98,86
pzampino commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1033944407
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##
@@ -187,21
pzampino commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1033944407
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##
@@ -187,21
pzampino commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1033944407
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##
@@ -187,21
zeroflag merged PR #685:
URL: https://github.com/apache/knox/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
zeroflag commented on PR #685:
URL: https://github.com/apache/knox/pull/685#issuecomment-1329135599
I'm rerunning one more time to see how stable it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zeroflag commented on PR #685:
URL: https://github.com/apache/knox/pull/685#issuecomment-1329127634
> @zeroflag - Could you please explain why those ignore declarations help
here? Thanks!
My understanding is that some of those classes are included in the jdk's
rt.jar as well as
smolnar82 commented on PR #685:
URL: https://github.com/apache/knox/pull/685#issuecomment-1329102484
@zeroflag - Could you please explain why those ignore declarations help
here? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
smolnar82 merged PR #684:
URL: https://github.com/apache/knox/pull/684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
zeroflag opened a new pull request, #685:
URL: https://github.com/apache/knox/pull/685
## What changes were proposed in this pull request?
Let's see if it fixes the test this:
```
2022-11-28T05:34:23.3732998Z [ERROR]
smolnar82 opened a new pull request, #684:
URL: https://github.com/apache/knox/pull/684
## What changes were proposed in this pull request?
Disabled `GatewayWebsocketHandlerTest.testValidWebShellRequest()`
temporarily.
## How was this patch tested?
Let the build run
smolnar82 commented on PR #683:
URL: https://github.com/apache/knox/pull/683#issuecomment-1326797269
Excellent work @MrtnBalazs ! I'll take a look soon. Thanks, again, for your
hard work and contribution to Apache Knox!
--
This is an automated message from the Apache Git Service.
To
MrtnBalazs commented on PR #683:
URL: https://github.com/apache/knox/pull/683#issuecomment-1326647172
@smolnar82 @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
MrtnBalazs opened a new pull request, #683:
URL: https://github.com/apache/knox/pull/683
## What changes were proposed in this pull request?
The `angular/cli` dependency of all angular applications have been upgraded
to `14.2.8`. Since the projects have been on `1.7.4` (except
zeroflag commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1031406217
##
gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.java:
##
@@ -187,21
dependabot[bot] closed pull request #635: Bump postgresql from 42.3.3 to 42.3.7
URL: https://github.com/apache/knox/pull/635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] commented on PR #635:
URL: https://github.com/apache/knox/pull/635#issuecomment-1325729849
Superseded by #682.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #682:
URL: https://github.com/apache/knox/pull/682
Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.3.3 to 42.3.8.
Changelog
Sourced from https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md;>postgresql's
changelog.
smolnar82 opened a new pull request, #681:
URL: https://github.com/apache/knox/pull/681
## What changes were proposed in this pull request?
//TODO
## How was this patch tested?
Manual test cases executed on the token generation page:
1. Impersonation thru
smolnar82 merged PR #672:
URL: https://github.com/apache/knox/pull/672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
zeroflag opened a new pull request, #680:
URL: https://github.com/apache/knox/pull/680
## What changes were proposed in this pull request?
This is a draft PR.
## How was this patch tested?
```xml
gateway.service.remoteconfigurationmonitor.impl
smolnar82 commented on PR #672:
URL: https://github.com/apache/knox/pull/672#issuecomment-1318701408
@debiswal - please fix the build failure and submit a new PS. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
debiswal commented on PR #672:
URL: https://github.com/apache/knox/pull/672#issuecomment-1318650215
Hi @smolnar82 Thank you for review would like to inform SSL_ENABLED is
defined at the role level in CM, so it should be defined on the role level in
the model generator as well & earlier
smolnar82 commented on PR #672:
URL: https://github.com/apache/knox/pull/672#issuecomment-1316588587
Thanks, @debiswal for the unit test classes. I also see you changed the
following too:
- SSL_ENABLED is registered on the role level (before it was on the service
level) in the
dependabot[bot] closed pull request #671: Bump loader-utils from 1.4.0 to 1.4.1
in /knox-webshell-ui
URL: https://github.com/apache/knox/pull/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #671:
URL: https://github.com/apache/knox/pull/671#issuecomment-1315939711
Superseded by #679.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #679:
URL: https://github.com/apache/knox/pull/679
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to
1.4.2.
Release notes
Sourced from https://github.com/webpack/loader-utils/releases;>loader-utils's
releases.
dependabot[bot] opened a new pull request, #678:
URL: https://github.com/apache/knox/pull/678
Removes [loader-utils](https://github.com/webpack/loader-utils). It's no
longer used after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies
dependabot[bot] opened a new pull request, #677:
URL: https://github.com/apache/knox/pull/677
Removes [loader-utils](https://github.com/webpack/loader-utils). It's no
longer used after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies
dependabot[bot] opened a new pull request, #676:
URL: https://github.com/apache/knox/pull/676
Removes [loader-utils](https://github.com/webpack/loader-utils). It's no
longer used after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies
pzampino merged PR #673:
URL: https://github.com/apache/knox/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
zeroflag merged PR #670:
URL: https://github.com/apache/knox/pull/670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
smolnar82 merged PR #675:
URL: https://github.com/apache/knox/pull/675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
debiswal commented on PR #672:
URL: https://github.com/apache/knox/pull/672#issuecomment-1314954439
> Thanks, @debiswal for addressing my direct review comments. There is one
more I mentioned above:
>
> > Before we merge your changes, I'd like to ask you to write separate unit
test
smolnar82 opened a new pull request, #675:
URL: https://github.com/apache/knox/pull/675
## What changes were proposed in this pull request?
Renamed `.travis.yml` to `.travis.yml.disabled` so that Travis CI won't
trigger Knox builds in the future. I did not remove this file to
smolnar82 commented on PR #672:
URL: https://github.com/apache/knox/pull/672#issuecomment-1314920268
Thanks, @debiswal for addressing my direct review comments. There is one
more I mentioned above:
> Before we merge your changes, I'd like to ask you to write separate unit
test
smolnar82 commented on PR #673:
URL: https://github.com/apache/knox/pull/673#issuecomment-1314906426
The ARM64 build error is a known issue with Knox/Travis CI integration and
can be ignored for now.
--
This is an automated message from the Apache Git Service.
To respond to the message,
moresandeep merged PR #674:
URL: https://github.com/apache/knox/pull/674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dionusos opened a new pull request, #674:
URL: https://github.com/apache/knox/pull/674
(It is very **important** that you created an Apache Knox JIRA for this
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
## What changes were proposed in this pull
pzampino opened a new pull request, #673:
URL: https://github.com/apache/knox/pull/673
## What changes were proposed in this pull request?
SecureKnoxShellTest was broken due to a NoClassDefFound error. It seems
miniDFS now requires mockito, which needed to be added to Knox test
zeroflag commented on code in PR #672:
URL: https://github.com/apache/knox/pull/672#discussion_r1020279099
##
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/ozone/OzoneServiceModelGenerator.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to
smolnar82 commented on code in PR #672:
URL: https://github.com/apache/knox/pull/672#discussion_r1020240901
##
gateway-service-definitions/src/main/resources/services/ozone-recon/1.2.0/service.xml:
##
@@ -0,0 +1,30 @@
+
+
+
Review Comment:
Please use indentation here.
debiswal opened a new pull request, #672:
URL: https://github.com/apache/knox/pull/672
Apache JIRA ID: [https://issues.apache.org/jira/browse/KNOX-2833]
## changes proposed in this PR:
1. integration of Ozone Manager (OM) in KNOX UI
2. integration of Recon in KNOX UI
3.
dependabot[bot] opened a new pull request, #671:
URL: https://github.com/apache/knox/pull/671
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to
1.4.1.
Release notes
Sourced from https://github.com/webpack/loader-utils/releases;>loader-utils's
releases.
smolnar82 commented on code in PR #670:
URL: https://github.com/apache/knox/pull/670#discussion_r1017963443
##
gateway-server/src/main/java/org/apache/knox/gateway/topology/monitor/DefaultConfigurationMonitorProvider.java:
##
@@ -16,16 +16,60 @@
*/
package
zeroflag opened a new pull request, #670:
URL: https://github.com/apache/knox/pull/670
## What changes were proposed in this pull request?
This is a similar implementation as the existing zookeeper based monitor,
but it uses the SQL DB. Zookeeper is not always available and the DB is
dependabot[bot] opened a new pull request, #669:
URL: https://github.com/apache/knox/pull/669
Removes [loader-utils](https://github.com/webpack/loader-utils). It's no
longer used after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies
smolnar82 merged PR #668:
URL: https://github.com/apache/knox/pull/668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
smolnar82 commented on code in PR #668:
URL: https://github.com/apache/knox/pull/668#discussion_r1013657425
##
gateway-provider-security-webappsec/src/main/java/org/apache/knox/gateway/webappsec/deploy/WebAppSecContributor.java:
##
@@ -150,12 +165,24 @@ public void
lmccay commented on code in PR #668:
URL: https://github.com/apache/knox/pull/668#discussion_r1013604525
##
gateway-provider-security-webappsec/src/main/java/org/apache/knox/gateway/webappsec/deploy/WebAppSecContributor.java:
##
@@ -150,12 +165,24 @@ public void
MrtnBalazs opened a new pull request, #668:
URL: https://github.com/apache/knox/pull/668
## What changes were proposed in this pull request?
The DoS security provider have been removed, and it's functionality have
been moved in the Web App Security provider.
This provider is now
dependabot[bot] opened a new pull request, #667:
URL: https://github.com/apache/knox/pull/667
Removes [node-forge](https://github.com/digitalbazaar/forge). It's no longer
used after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies need
dependabot[bot] opened a new pull request, #665:
URL: https://github.com/apache/knox/pull/665
Removes [ejs](https://github.com/mde/ejs). It's no longer used after
updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies need
to be updated
dependabot[bot] opened a new pull request, #666:
URL: https://github.com/apache/knox/pull/666
Removes [postcss](https://github.com/postcss/postcss). It's no longer used
after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies need
to be
dependabot[bot] opened a new pull request, #664:
URL: https://github.com/apache/knox/pull/664
Removes [scss-tokenizer](https://github.com/sasstools/scss-tokenizer). It's
no longer used after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These
dependabot[bot] opened a new pull request, #663:
URL: https://github.com/apache/knox/pull/663
Removes [ansi-html](https://github.com/Tjatse/ansi-html). It's no longer
used after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies need
to
dependabot[bot] opened a new pull request, #662:
URL: https://github.com/apache/knox/pull/662
Removes [eventsource](https://github.com/EventSource/eventsource). It's no
longer used after updating ancestor dependency
[@angular/cli](https://github.com/angular/angular-cli). These dependencies
dependabot[bot] opened a new pull request, #661:
URL: https://github.com/apache/knox/pull/661
Bumps
[@angular/core](https://github.com/angular/angular/tree/HEAD/packages/core)
from 5.2.11 to 11.0.5.
Changelog
Sourced from
smolnar82 merged PR #656:
URL: https://github.com/apache/knox/pull/656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
smolnar82 merged PR #660:
URL: https://github.com/apache/knox/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
smolnar82 opened a new pull request, #660:
URL: https://github.com/apache/knox/pull/660
## What changes were proposed in this pull request?
TODO
## How was this patch tested?
TODO
--
This is an automated message from the Apache Git Service.
To respond to the
MrtnBalazs commented on PR #656:
URL: https://github.com/apache/knox/pull/656#issuecomment-1293277832
@smolnar82 @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zeroflag merged PR #650:
URL: https://github.com/apache/knox/pull/650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
anyorey opened a new pull request, #659:
URL: https://github.com/apache/knox/pull/659
## What changes were proposed in this pull request?
In some cases getPID will return 0 even if the process started. e.g. pid
file is deleted or file is modified and we can not get
correct pid
dependabot[bot] opened a new pull request, #658:
URL: https://github.com/apache/knox/pull/658
Bumps [woodstox-core](https://github.com/FasterXML/woodstox) from 6.1.1 to
6.4.0.
Commits
smolnar82 merged PR #657:
URL: https://github.com/apache/knox/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
smolnar82 opened a new pull request, #657:
URL: https://github.com/apache/knox/pull/657
## What changes were proposed in this pull request?
Changed the default value of `knox.token.impersonation.enabled` and added
some helpful DEBUG-level log messages.
## How was this patch
zeroflag commented on code in PR #650:
URL: https://github.com/apache/knox/pull/650#discussion_r1002972633
##
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/GatewayDispatchFilter.java:
##
@@ -145,14 +147,21 @@ private boolean isDispatchAllowed(HttpServletRequest
MrtnBalazs opened a new pull request, #656:
URL: https://github.com/apache/knox/pull/656
## What changes were proposed in this pull request?
A new maven module was added which contains the angular version of the
javascript token generation web application.
The angular version
dependabot[bot] opened a new pull request, #655:
URL: https://github.com/apache/knox/pull/655
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
Changelog
Sourced from https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md;>async's
changelog.
v2.6.4
dependabot[bot] opened a new pull request, #654:
URL: https://github.com/apache/knox/pull/654
Bumps [ejs](https://github.com/mde/ejs) from 3.1.6 to 3.1.8.
Release notes
Sourced from https://github.com/mde/ejs/releases;>ejs's
releases.
v3.1.8
Version 3.1.8
v3.1.7
dependabot[bot] opened a new pull request, #652:
URL: https://github.com/apache/knox/pull/652
Bumps
[follow-redirects](https://github.com/follow-redirects/follow-redirects) from
1.14.5 to 1.15.2.
Commits
dependabot[bot] opened a new pull request, #653:
URL: https://github.com/apache/knox/pull/653
Bumps [nanoid](https://github.com/ai/nanoid) from 3.1.30 to 3.3.4.
Changelog
Sourced from https://github.com/ai/nanoid/blob/main/CHANGELOG.md;>nanoid's
changelog.
3.3.4
dependabot[bot] opened a new pull request, #651:
URL: https://github.com/apache/knox/pull/651
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.7.
Changelog
Sourced from https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md;>minimist's
changelog.
moresandeep merged PR #639:
URL: https://github.com/apache/knox/pull/639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep commented on code in PR #650:
URL: https://github.com/apache/knox/pull/650#discussion_r1001661250
##
gateway-spi/src/main/java/org/apache/knox/gateway/dispatch/GatewayDispatchFilter.java:
##
@@ -145,14 +147,21 @@ private boolean isDispatchAllowed(HttpServletRequest
zeroflag opened a new pull request, #650:
URL: https://github.com/apache/knox/pull/650
## What changes were proposed in this pull request?
pending
## How was this patch tested?
pending
--
This is an automated message from the Apache Git Service.
To respond to the
moresandeep commented on code in PR #639:
URL: https://github.com/apache/knox/pull/639#discussion_r999585337
##
gateway-server/src/main/java/org/apache/knox/gateway/websockets/JWTValidator.java:
##
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
smolnar82 commented on code in PR #638:
URL: https://github.com/apache/knox/pull/638#discussion_r999028813
##
gateway-service-webhdfs/src/main/java/org/apache/knox/gateway/hdfs/dispatch/HdfsUIHaDispatch.java:
##
@@ -26,6 +30,26 @@ public HdfsUIHaDispatch() throws
Flamingo93 commented on PR #638:
URL: https://github.com/apache/knox/pull/638#issuecomment-1283370329
Hi @risdenk @lmccay @moresandeep @pzampino @smolnar82 Could you please take
a look? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Flamingo93 commented on PR #644:
URL: https://github.com/apache/knox/pull/644#issuecomment-1283368846
Hi @moresandeep Could you please take a look? :）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
moresandeep commented on code in PR #639:
URL: https://github.com/apache/knox/pull/639#discussion_r997510777
##
gateway-server/src/main/java/org/apache/knox/gateway/deploy/DeploymentFactory.java:
##
@@ -260,7 +260,13 @@ private static void addMissingDefaultProviders(Topology
moresandeep merged PR #649:
URL: https://github.com/apache/knox/pull/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
moresandeep opened a new pull request, #649:
URL: https://github.com/apache/knox/pull/649
## What changes were proposed in this pull request?
Only add "Default" provider iff it is found in the provider contributor map.
There could be cases where service loader might find other
dependabot[bot] commented on PR #603:
URL: https://github.com/apache/knox/pull/603#issuecomment-1276723853
Superseded by #648.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] closed pull request #603: Bump shiro-core from 1.8.0 to 1.9.1
URL: https://github.com/apache/knox/pull/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #648:
URL: https://github.com/apache/knox/pull/648
Bumps [shiro-core](https://github.com/apache/shiro) from 1.8.0 to 1.10.0.
Commits
https://github.com/apache/shiro/commit/7141f41137f058a3c756ea13ed4e0fef9a3abb66;>7141f41
lmccay commented on PR #647:
URL: https://github.com/apache/knox/pull/647#issuecomment-1276482671
> This introduces breaking change, changing to `strict` from `none`. it
would be difficult to figure out what went wrong given the errors are thrown on
the UI so debugging this would be
lmccay merged PR #647:
URL: https://github.com/apache/knox/pull/647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
lmccay opened a new pull request, #647:
URL: https://github.com/apache/knox/pull/647
## What changes were proposed in this pull request?
The attribute for KnoxSSO cookie is currently hardocded.
This improvement will make its value configurable to better accommodate
various
201 - 300 of 3972 matches
Mail list logo
