[GitHub] yiming187 commented on issue #102: KYLIN-2960, modify the default LDAP admin group config.
yiming187 commented on issue #102: KYLIN-2960, modify the default LDAP admin group config. URL: https://github.com/apache/kylin/pull/102#issuecomment-365153978 merged This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #102: KYLIN-2960, modify the default LDAP admin group config.
yiming187 closed pull request #102: KYLIN-2960, modify the default LDAP admin group config. URL: https://github.com/apache/kylin/pull/102 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core-common/src/main/resources/kylin-defaults.properties b/core-common/src/main/resources/kylin-defaults.properties index a79728a78f..37520ef899 100644 --- a/core-common/src/main/resources/kylin-defaults.properties +++ b/core-common/src/main/resources/kylin-defaults.properties @@ -243,7 +243,7 @@ kylin.query.transformers=org.apache.kylin.query.util.DefaultQueryTransformer,org kylin.security.profile=testing # Admin roles in LDAP, for ldap and saml -kylin.security.acl.admin-role=ROLE_ADMIN +kylin.security.acl.admin-role=admin # LDAP authentication configuration kylin.security.ldap.connection-server=ldap://ldap_server:389 diff --git a/examples/test_case_data/localmeta/kylin.properties b/examples/test_case_data/localmeta/kylin.properties index 1e3f2ff72c..b9dfc387fa 100644 --- a/examples/test_case_data/localmeta/kylin.properties +++ b/examples/test_case_data/localmeta/kylin.properties @@ -93,7 +93,7 @@ kylin.query.transformers=org.apache.kylin.query.util.DefaultQueryTransformer,org kylin.security.profile=testing # Admin roles in LDAP, for ldap and saml -kylin.security.acl.admin-role=ROLE_ADMIN +kylin.security.acl.admin-role=admin # LDAP authentication configuration kylin.security.ldap.connection-server=ldap://ldap_server:389 diff --git a/examples/test_case_data/sandbox/kylin.properties b/examples/test_case_data/sandbox/kylin.properties index b5f8657cce..ae9dad24b3 100644 --- a/examples/test_case_data/sandbox/kylin.properties +++ b/examples/test_case_data/sandbox/kylin.properties @@ -141,7 +141,7 @@ kylin.query.security-enabled=true kylin.security.profile=testing # Admin roles in LDAP, for ldap and saml -kylin.security.acl.admin-role=ROLE_ADMIN +kylin.security.acl.admin-role=admin ### MAIL ### This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #99: Yang21 hbase102
yiming187 closed pull request #99: Yang21 hbase102 URL: https://github.com/apache/kylin/pull/99 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #67: Fix the double carets bug in sample.sh for old bash version
yiming187 closed pull request #67: Fix the double carets bug in sample.sh for old bash version URL: https://github.com/apache/kylin/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 commented on issue #67: Fix the double carets bug in sample.sh for old bash version
yiming187 commented on issue #67: Fix the double carets bug in sample.sh for old bash version URL: https://github.com/apache/kylin/pull/67#issuecomment-365154160 merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #58: kylin sso????cas?????
yiming187 closed pull request #58: kylin ssocas? URL: https://github.com/apache/kylin/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #33: ????
yiming187 closed pull request #33: URL: https://github.com/apache/kylin/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #40: 1.3.x
yiming187 closed pull request #40: 1.3.x URL: https://github.com/apache/kylin/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #42: Update pom.xml
yiming187 closed pull request #42: Update pom.xml URL: https://github.com/apache/kylin/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #60: support jdbc source
yiming187 closed pull request #60: support jdbc source URL: https://github.com/apache/kylin/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #61: Fix for KYLIN-2668
yiming187 closed pull request #61: Fix for KYLIN-2668
URL: https://github.com/apache/kylin/pull/61
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/jdbc/src/main/java/org/apache/kylin/jdbc/KylinConnection.java
b/jdbc/src/main/java/org/apache/kylin/jdbc/KylinConnection.java
index 6852998961..61d13b9abd 100644
--- a/jdbc/src/main/java/org/apache/kylin/jdbc/KylinConnection.java
+++ b/jdbc/src/main/java/org/apache/kylin/jdbc/KylinConnection.java
@@ -51,7 +51,7 @@ protected KylinConnection(UnregisteredDriver driver,
KylinJdbcFactory factory, S
super(driver, factory, url, info);
String odbcUrl = url;
-odbcUrl = odbcUrl.replace(Driver.CONNECT_STRING_PREFIX + "//", "");
+odbcUrl = odbcUrl.replaceAll((Driver.CONNECT_STRING_PREFIX +
"[[A-Za-z0-9]*=[A-Za-z0-9]*;]*//").toString(), "");
String[] temps = odbcUrl.split("/");
assert temps.length == 2;
diff --git a/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
b/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
index 08876349cb..255cb76bee 100644
--- a/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
+++ b/jdbc/src/test/java/org/apache/kylin/jdbc/DriverTest.java
@@ -189,6 +189,14 @@ public void testPreparedStatementWithCubeData() throws
SQLException {
conn.close();
}
+ @Test
+public void testSSLFromURL() throws SQLException{
+Driver driver = new DummyDriver();
+Connection conn =
driver.connect("jdbc:kylin:ssl=True;//test_url/test_db", null);
+assertEquals("test_url", ((KylinConnection)conn).getBaseUrl());
+assertEquals("test_db", ((KylinConnection)conn).getProject());
+}
+
private void printResultSet(ResultSet rs) throws SQLException {
ResultSetMetaData meta = rs.getMetaData();
System.out.println("Data:");
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yiming187 closed pull request #64: JIRA_ID:KYLIN-2819
yiming187 closed pull request #64: JIRA_ID:KYLIN-2819
URL: https://github.com/apache/kylin/pull/64
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
index 0e990df52f..0a62f3d31f 100644
--- a/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
+++ b/core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
@@ -226,6 +226,10 @@ public String getHdfsWorkingDirectory() {
return cachedHdfsWorkingDirectory;
}
+public String getZkBasePath() {
+return getOptional("kylin.zk.base.path", "/kylin");
+}
+
/**
* A comma separated list of host:port pairs, each corresponding to a
ZooKeeper server
*/
diff --git a/core-common/src/main/resources/kylin-defaults.properties
b/core-common/src/main/resources/kylin-defaults.properties
index 7c421f9fa0..0cd9b9c248 100644
--- a/core-common/src/main/resources/kylin-defaults.properties
+++ b/core-common/src/main/resources/kylin-defaults.properties
@@ -26,6 +26,8 @@ kylin.env.hdfs-working-dir=/kylin
# DEV|QA|PROD. DEV will turn on some dev features, QA and PROD has no
difference in terms of functions.
kylin.env=QA
+# kylin zk base path
+kylin.zk.base.path=/kylin
### SERVER | WEB ###
diff --git
a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
index e3a5836b97..9902618143 100644
---
a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
+++
b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
@@ -82,7 +82,7 @@
private String serverName;
private final static String SEGMENT_ID = "segmentId";
-public static final String ZOOKEEPER_LOCK_PATH = "/job_engine/lock"; //
note ZookeeperDistributedLock will ensure zk path prefix: /kylin/metadata
+public static final String ZOOKEEPER_LOCK_PATH = "/job_engine/lock"; //
note ZookeeperDistributedLock will ensure zk path prefix:
/${kylin.zk.base.path}/metadata
//only for it test
public static DistributedScheduler getInstance(KylinConfig config) {
diff --git
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperDistributedLock.java
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperDistributedLock.java
index 63ffda0a25..27278ffdee 100644
---
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperDistributedLock.java
+++
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/util/ZookeeperDistributedLock.java
@@ -102,7 +102,7 @@ public Factory() {
public Factory(KylinConfig config) {
this.curator = getZKClient(config);
-this.zkPathBase = fixSlash("/kylin/" +
KylinConfig.getInstanceFromEnv().getMetadataUrlPrefix());
+this.zkPathBase = fixSlash(config.getZkBasePath() +
KylinConfig.getInstanceFromEnv().getMetadataUrlPrefix());
}
@Override
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yiming187 closed pull request #94: 2.2.x
yiming187 closed pull request #94: 2.2.x URL: https://github.com/apache/kylin/pull/94 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #44: change the style of return that make it read easy
yiming187 closed pull request #44: change the style of return that make it read
easy
URL: https://github.com/apache/kylin/pull/44
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRequest.java
b/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRequest.java
index dc90ed66af..1f07f849ce 100644
--- a/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRequest.java
+++ b/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRequest.java
@@ -381,11 +381,22 @@ public GTScanRequest deserialize(ByteBuffer in) {
long timeout = BytesUtil.readVLong(in);
String storageBehavior = BytesUtil.readUTFString(in);
-return new
GTScanRequestBuilder().setInfo(sInfo).setRanges(sRanges).setDimensions(sColumns).//
-
setAggrGroupBy(sAggGroupBy).setAggrMetrics(sAggrMetrics).setAggrMetricsFuncs(sAggrMetricFuncs).//
-
setFilterPushDown(sGTFilter).setAllowStorageAggregation(sAllowPreAggr).setAggCacheMemThreshold(sAggrCacheGB).//
-
setStorageScanRowNumThreshold(storageScanRowNumThreshold).setStoragePushDownLimit(storagePushDownLimit).//
-
setStartTime(startTime).setTimeout(timeout).setStorageBehavior(storageBehavior).createGTScanRequest();
+return new GTScanRequestBuilder()
+.setInfo(sInfo)
+.setRanges(sRanges)
+.setDimensions(sColumns)
+.setAggrGroupBy(sAggGroupBy)
+.setAggrMetrics(sAggrMetrics)
+.setAggrMetricsFuncs(sAggrMetricFuncs)
+.setFilterPushDown(sGTFilter)
+.setAllowStorageAggregation(sAllowPreAggr)
+.setAggCacheMemThreshold(sAggrCacheGB)
+.setStorageScanRowNumThreshold(storageScanRowNumThreshold)
+.setStoragePushDownLimit(storagePushDownLimit)
+.setStartTime(startTime)
+.setTimeout(timeout)
+.setStorageBehavior(storageBehavior)
+.createGTScanRequest();
}
private void serializeGTRecord(GTRecord gtRecord, ByteBuffer out) {
diff --git
a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeScanRangePlanner.java
b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeScanRangePlanner.java
index b05a629db9..548e355302 100644
---
a/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeScanRangePlanner.java
+++
b/core-storage/src/main/java/org/apache/kylin/storage/gtrecord/CubeScanRangePlanner.java
@@ -148,10 +148,19 @@ public GTScanRequest planScanRequest() {
GTScanRequest scanRequest;
List scanRanges = this.planScanRanges();
if (scanRanges != null && scanRanges.size() != 0) {
-scanRequest = new
GTScanRequestBuilder().setInfo(gtInfo).setRanges(scanRanges).setDimensions(gtDimensions).//
-
setAggrGroupBy(gtAggrGroups).setAggrMetrics(gtAggrMetrics).setAggrMetricsFuncs(gtAggrFuncs).setFilterPushDown(gtFilter).//
-
setAllowStorageAggregation(context.isNeedStorageAggregation()).setAggCacheMemThreshold(cubeSegment.getCubeInstance().getConfig().getQueryCoprocessorMemGB()).//
-
setStoragePushDownLimit(context.getFinalPushDownLimit()).setStorageScanRowNumThreshold(context.getThreshold()).createGTScanRequest();
+scanRequest = new GTScanRequestBuilder()
+.setInfo(gtInfo)
+.setRanges(scanRanges)
+.setDimensions(gtDimensions)
+.setAggrGroupBy(gtAggrGroups)
+.setAggrMetrics(gtAggrMetrics)
+.setAggrMetricsFuncs(gtAggrFuncs)
+.setFilterPushDown(gtFilter)
+.setAllowStorageAggregation(context.isNeedStorageAggregation())
+
.setAggCacheMemThreshold(cubeSegment.getCubeInstance().getConfig().getQueryCoprocessorMemGB())
+.setStoragePushDownLimit(context.getFinalPushDownLimit())
+.setStorageScanRowNumThreshold(context.getThreshold())
+.createGTScanRequest();
} else {
scanRequest = null;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] yiming187 opened a new pull request #103: enable coveralls
yiming187 opened a new pull request #103: enable coveralls URL: https://github.com/apache/kylin/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #103: enable coveralls
asfgit commented on issue #103: enable coveralls URL: https://github.com/apache/kylin/pull/103#issuecomment-365270991 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #103: enable coveralls
yiming187 closed pull request #103: enable coveralls URL: https://github.com/apache/kylin/pull/103 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #103: enable coveralls
asfgit commented on issue #103: enable coveralls URL: https://github.com/apache/kylin/pull/103#issuecomment-365884277 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 opened a new pull request #103: enable coveralls
yiming187 opened a new pull request #103: enable coveralls URL: https://github.com/apache/kylin/pull/103 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #103: enable coveralls
yiming187 closed pull request #103: enable coveralls
URL: https://github.com/apache/kylin/pull/103
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index ce76775c83..38dc93c62c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -26,8 +26,11 @@ addons:
jdk:
- oraclejdk8
+before_script:
+ - echo "MAVEN_OPTS='-Xms1024m -Xmx3072m -XX:MetaspaceSize=128m
-XX:MaxMetaspaceSize=384m'" > ~/.mavenrc
+
script:
- - mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent test
+ - mvn clean org.jacoco:jacoco-maven-plugin:prepare-agent test
coveralls:report
- if [[ -n "${TRAVIS_PULL_REQUEST_SLUG}" && "${TRAVIS_PULL_REQUEST_SLUG}" !=
"${TRAVIS_REPO_SLUG}" ]]; then
echo "The pull request from ${TRAVIS_PULL_REQUEST_SLUG} is an EXTERNAL
pull request. Skip sonar analysis.";
else
diff --git a/pom.xml b/pom.xml
index 43e96bb0b6..8c52f9cd89 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1022,7 +1022,7 @@
org.jacoco
jacoco-maven-plugin
-0.7.8
+0.8.0
org.apache.maven.plugins
@@ -1257,12 +1257,6 @@
org.jacoco
jacoco-maven-plugin
-
-true
-
-${sonar.jacoco.reportPath}
-
-
pre-test
@@ -1270,6 +1264,8 @@
prepare-agent
+true
+
${sonar.jacoco.reportPath}
surefireArgLine
@@ -1279,6 +1275,9 @@
report
+
+
${sonar.jacoco.reportPath}
+
@@ -1310,6 +1309,11 @@
+
+org.eluder.coveralls
+coveralls-maven-plugin
+4.2.0
+
@@ -1388,7 +1392,6 @@
-
org.apache.maven.plugins
maven-surefire-plugin
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's retry.
codecov-io commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's retry. URL: https://github.com/apache/kylin/pull/104#issuecomment-367982611 # [Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr&el=h1) Report > Merging [#104](https://codecov.io/gh/apache/kylin/pull/104?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/21ef4d6e4bb62eb3f5209b14daaa8ab404d0f4c5?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `80%`. [](https://codecov.io/gh/apache/kylin/pull/104?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #104 +/- ## - Coverage 21.45% 21.45% -0.01% - Complexity 3815 3819 +4 Files 992 992 Lines 5974159734 -7 Branches 8639 8638 -1 - Hits 1281912813 -6 + Misses4574045734 -6 - Partials 1182 1187 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/104?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | `51.69% <80%> (+3.55%)` | `46 <6> (+5)` | :arrow_up: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `66.56% <0%> (-3.65%)` | `7% <0%> (?)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `65.35% <0%> (+0.78%)` | `0% <0%> (?)` | :arrow_down: | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/104/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `55.72% <0%> (+0.99%)` | `21% <0%> (?)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/104?src=pr&el=footer). Last update [21ef4d6...74dff9f](https://codecov.io/gh/apache/kylin/pull/104?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's retry.
coveralls commented on issue #104: KYLIN-3263, bugfix with AbstractExecutable's retry. URL: https://github.com/apache/kylin/pull/104#issuecomment-367983164 ## Pull Request Test Coverage Report for [Build 2991](https://coveralls.io/builds/15663717) * **5** of **5** **(100.0%)** changed or added relevant lines in **1** file are covered. * **7** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.001%**) to **23.441%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15663717/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193) | 7 | 76.29% | | Totals | [](https://coveralls.io/builds/15663717) | | :-- | --: | | Change from base [Build 2978](https://coveralls.io/builds/15605811): | 0.001% | | Covered Lines: | 14002 | | Relevant Lines: | 59734 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #104: KYLIN-3263, bugfix with AbstractExecutable's retry.
yiming187 closed pull request #104: KYLIN-3263, bugfix with
AbstractExecutable's retry.
URL: https://github.com/apache/kylin/pull/104
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
index 91283f0f2d..dbe11c2ea3 100644
---
a/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
+++
b/core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java
@@ -165,7 +165,7 @@ public final ExecuteResult execute(ExecutableContext
executableContext) throws E
exception = e;
}
retry++;
-} while (needRetry(result, exception));
+} while (needRetry(this.retry, exception)); //exception in
ExecuteResult should handle by user itself.
if (exception != null) {
onExecuteError(exception, executableContext);
@@ -221,13 +221,6 @@ private boolean isMetaDataPersistException(Exception e) {
return false;
}
-private boolean isRetryableExecutionResult(ExecuteResult result) {
-if (result != null && result.getThrowable() != null &&
isRetrableException(result.getThrowable())) {
-return true;
-}
-return false;
-}
-
protected abstract ExecuteResult doWork(ExecutableContext context) throws
ExecuteException;
@Override
@@ -468,25 +461,20 @@ protected final boolean isPaused() {
return status == ExecutableState.STOPPED;
}
-protected boolean isRetrableException(Throwable t) {
-return
ArrayUtils.contains(KylinConfig.getInstanceFromEnv().getJobRetryExceptions(),
t.getClass().getName());
-}
-
// Retry will happen in below cases:
// 1) if property "kylin.job.retry-exception-classes" is not set or is
null, all jobs with exceptions will retry according to the retry times.
// 2) if property "kylin.job.retry-exception-classes" is set and is not
null, only jobs with the specified exceptions will retry according to the retry
times.
-protected boolean needRetry(ExecuteResult result, Throwable e) {
-if (this.retry > KylinConfig.getInstanceFromEnv().getJobRetry()) {
+public static boolean needRetry(int retry, Throwable t) {
+if (retry > KylinConfig.getInstanceFromEnv().getJobRetry() || t ==
null) {
return false;
+} else {
+return isRetryableException(t.getClass().getName());
}
-String[] retryableEx =
KylinConfig.getInstanceFromEnv().getJobRetryExceptions();
-if (retryableEx == null || retryableEx.length == 0) {
-return true;
-}
-if ((result != null && isRetryableExecutionResult(result)) || e !=
null && isRetrableException(e)) {
-return true;
-}
-return false;
+}
+
+private static boolean isRetryableException(String exceptionName) {
+String[] jobRetryExceptions =
KylinConfig.getInstanceFromEnv().getJobRetryExceptions();
+return ArrayUtils.isEmpty(jobRetryExceptions) ||
ArrayUtils.contains(jobRetryExceptions, exceptionName);
}
@Override
diff --git
a/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java
b/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java
deleted file mode 100644
index f656c44058..00
--- a/core-job/src/test/java/org/apache/kylin/job/RetryableTestExecutable.java
+++ /dev/null
@@ -1,50 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.kylin.job;
-
-import org.apache.kylin.common.KylinConfig;
-import org.apache.kylin.job.execution.ExecutableContext;
-import org.apache.kylin.job.execution.ExecuteResult;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-/**
- */
-public class RetryableTestExecutable extends BaseTestExecutable {
-private static final Logger
[GitHub] asfgit commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix
asfgit commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix URL: https://github.com/apache/kylin/pull/105#issuecomment-36820 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sanjulian opened a new pull request #105: KYLIN-2884 Add delete segment function for portal - bug fix
sanjulian opened a new pull request #105: KYLIN-2884 Add delete segment function for portal - bug fix URL: https://github.com/apache/kylin/pull/105 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix
coveralls commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix URL: https://github.com/apache/kylin/pull/105#issuecomment-368205238 ## Pull Request Test Coverage Report for [Build 2997](https://coveralls.io/builds/15677654) * **0** of **0** **(NaN%)** changed or added relevant lines in **0** files are covered. * **6** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.002%**) to **23.451%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-job/src/main/java/org/apache/kylin/job/execution/AbstractExecutable.java](https://coveralls.io/builds/15677654/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fexecution%2FAbstractExecutable.java#L157) | 1 | 58.94% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15677654/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | Totals | [](https://coveralls.io/builds/15677654) | | :-- | --: | | Change from base [Build 2992](https://coveralls.io/builds/15667361): | -0.002% | | Covered Lines: | 14008 | | Relevant Lines: | 59734 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix
codecov-io commented on issue #105: KYLIN-2884 Add delete segment function for portal - bug fix URL: https://github.com/apache/kylin/pull/105#issuecomment-368205395 # [Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr&el=h1) Report > Merging [#105](https://codecov.io/gh/apache/kylin/pull/105?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/66ea154ecee74a18066e9b6ea706e7232fb19bf5?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/105?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #105 +/- ## - Coverage 21.47% 21.47% -0.01% + Complexity 3822 3820 -2 Files 992 992 Lines 5973459734 Branches 8638 8638 - Hits 1282612825 -1 - Misses4572745728 +1 Partials 1181 1181 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/105?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | `51.69% <0%> (-1.45%)` | `46% <0%> (-2%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.31%)` | `7% <0%> (?)` | | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `55.72% <0%> (+0.49%)` | `21% <0%> (?)` | :arrow_down: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/105/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (?)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/105?src=pr&el=footer). Last update [66ea154...23641a2](https://codecov.io/gh/apache/kylin/pull/105?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenzhx closed pull request #105: KYLIN-2884 Add delete segment function for portal - bug fix
chenzhx closed pull request #105: KYLIN-2884 Add delete segment function for
portal - bug fix
URL: https://github.com/apache/kylin/pull/105
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/webapp/app/js/controllers/cubes.js
b/webapp/app/js/controllers/cubes.js
index a38620218b..cbd6fad1bb 100644
--- a/webapp/app/js/controllers/cubes.js
+++ b/webapp/app/js/controllers/cubes.js
@@ -522,23 +522,25 @@ KylinApp.controller('CubesCtrl', function ($scope, $q,
$routeParams, $location,
})
};
-$scope.startDeleteSegment = function (cube) {
- $scope.metaModel={
-model:modelsManager.getModelByCube(cube.name)
- };
- $modal.open({
-templateUrl: 'deleteSegment.html',
-controller: deleteSegmentCtrl,
-resolve: {
- cube: function () {
-return cube;
- },
- scope: function() {
-return $scope;
- }
-}
- });
-};
+ $scope.startDeleteSegment = function (cube) {
+ $scope.loadDetail(cube).then(function () {
+ $scope.metaModel={
+ model:modelsManager.getModelByCube(cube.name)
+ };
+ $modal.open({
+ templateUrl: 'deleteSegment.html',
+ controller: deleteSegmentCtrl,
+ resolve: {
+ cube: function () {
+ return cube;
+ },
+ scope: function() {
+ return $scope;
+ }
+ }
+ });
+ });
+ };
});
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asfgit commented on issue #106: When I connect kylin with JDBC, the query date has a problem.
asfgit commented on issue #106: When I connect kylin with JDBC, the query date has a problem. URL: https://github.com/apache/kylin/pull/106#issuecomment-368213461 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] starbow727 opened a new pull request #106: When I connect kylin with JDBC, the query date has a problem.
starbow727 opened a new pull request #106: When I connect kylin with JDBC, the query date has a problem. URL: https://github.com/apache/kylin/pull/106 hello, When I connect kylin with JDBC, the query date has a problem. The query condition is WHERE td.calendar_date >= DATE '2018-02-15' AND td.calendar_date < DATE '2018-02-22' but the result is 2018-02-14~2018-02-20 Time deviation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 commented on issue #106: When I connect kylin with JDBC, the query date has a problem.
yiming187 commented on issue #106: When I connect kylin with JDBC, the query date has a problem. URL: https://github.com/apache/kylin/pull/106#issuecomment-368216841 Hi @starbow727, for questions, please ask it in kylin user mailer, not github PR. Cloud you close this PR and subscribe to kylin user mailer? http://kylin.apache.org/community/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pengjianhua opened a new pull request #107: kylin-3119
pengjianhua opened a new pull request #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #107: kylin-3119
asfgit commented on issue #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107#issuecomment-368736036 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #107: kylin-3119
coveralls commented on issue #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107#issuecomment-368738219 ## Pull Request Test Coverage Report for [Build 2999](https://coveralls.io/builds/15711288) * **16** of **16** **(100.0%)** changed or added relevant lines in **1** file are covered. * **30** unchanged lines in **6** files lost coverage. * Overall coverage decreased (**-0.03%**) to **23.419%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/15711288/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L129) | 1 | 68.5% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigCannotInitException.java](https://coveralls.io/builds/15711288/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigCannotInitException.java#L24) | 2 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfig.java](https://coveralls.io/builds/15711288/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfig.java#L278) | 4 | 33.19% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java](https://coveralls.io/builds/15711288/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2FHBaseConnection.java#L81) | 6 | 19.37% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/15711288/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L67) | 8 | 16.22% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15711288/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193) | 9 | 76.29% | | Totals | [](https://coveralls.io/builds/15711288) | | :-- | --: | | Change from base [Build 2998](https://coveralls.io/builds/15678208): | -0.03% | | Covered Lines: | 13991 | | Relevant Lines: | 59741 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #107: kylin-3119
codecov-io commented on issue #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107#issuecomment-368738780 # [Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=h1) Report > Merging [#107](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/865e377b6803caa2e2b2aeab2e5bb77f6470c3e6?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #107 +/- ## - Coverage 21.47% 21.43% -0.04% + Complexity 3820 3818 -2 Files 992 992 Lines 5973459741 +7 Branches 8638 8639 +1 - Hits 1282512806 -19 - Misses4572845752 +24 - Partials 1181 1183 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `55.88% <75%> (+6.7%)` | `15 <0> (+2)` | :arrow_up: | | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `66.56% <0%> (-2.74%)` | `7% <0%> (?)` | | | [...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==) | `15.18% <0%> (-2.62%)` | `6% <0%> (?)` | | | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `30.67% <0%> (-1.69%)` | `20% <0%> (-1%)` | | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `14.98% <0%> (-1.24%)` | `35% <0%> (-2%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `64.56% <0%> (-0.79%)` | `0% <0%> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=footer). Last update [865e377...beba49a](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pengjianhua commented on issue #107: kylin-3119
pengjianhua commented on issue #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107#issuecomment-368739294 https://issues.apache.org/jira/browse/KYLIN-3119 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rogercloud commented on a change in pull request #107: kylin-3119
rogercloud commented on a change in pull request #107: kylin-3119
URL: https://github.com/apache/kylin/pull/107#discussion_r170827219
##
File path: query/src/main/java/org/apache/kylin/query/util/QueryUtil.java
##
@@ -50,32 +50,39 @@ public static String massageSql(String sql, String
project, int limit, int offse
ProjectManager projectManager =
ProjectManager.getInstance(KylinConfig.getInstanceFromEnv());
ProjectInstance projectInstance = projectManager.getProject(project);
KylinConfig kylinConfig = projectInstance.getConfig();
-
+sql = removeCommentInSql(sql);
while (sql.endsWith(";"))
sql = sql.substring(0, sql.length() - 1);
-if (limit > 0 && !sql.toLowerCase().contains("limit")) {
-sql += ("\nLIMIT " + limit);
-}
+String sql1=sql;
+final String suffixPattern =
"^.+?\\s(limit\\s\\d+)?\\s(offset\\s\\d+)?\\s*$";
+sql = sql.replaceAll("\\s+", " ");
+Pattern pattern = Pattern.compile(suffixPattern);
+Matcher matcher = pattern.matcher(sql.toLowerCase() + " ");
-if (offset > 0 && !sql.toLowerCase().contains("offset")) {
-sql += ("\nOFFSET " + offset);
+if (matcher.find()) {
+if (limit > 0 && matcher.group(1) == null) {
+sql1 += ("\nLIMIT " + limit);
+}
+if (offset > 0 && matcher.group(2) == null) {
+sql1 += ("\nOFFSET " + offset);
+}
}
// https://issues.apache.org/jira/browse/KYLIN-2649
-if (kylinConfig.getForceLimit() > 0 &&
!sql.toLowerCase().contains("limit")
-&& sql.toLowerCase().matches("^select\\s+\\*\\p{all}*")) {
-sql += ("\nLIMIT " + kylinConfig.getForceLimit());
+if (kylinConfig.getForceLimit() > 0 &&
!sql1.toLowerCase().contains("limit")
Review comment:
Here's another place that check "limit", would you please consider it in
this fix?
A possible fix is record the previous match result, telling whether the SQL
contains limit or not.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rogercloud commented on a change in pull request #107: kylin-3119
rogercloud commented on a change in pull request #107: kylin-3119
URL: https://github.com/apache/kylin/pull/107#discussion_r170828728
##
File path: query/src/test/java/org/apache/kylin/query/util/QueryUtilTest.java
##
@@ -51,6 +51,58 @@ public void testMassageSql() {
"select ( date '2001-09-28' + interval '2' month) from
test_kylin_fact group by ( date '2001-09-28' + interval '2' month)",
s);
}
+{
+String sql = "select count(*) test_limit from test_kylin_fact
where price > 10.0";
+String s = QueryUtil.massageSql(sql, "default", 5, 0,
"DEFAULT");
+Assert.assertEquals(
+"select count(*) test_limit from test_kylin_fact where
price > 10.0\n" +
+"LIMIT 5",
+s);
+}
+{
+String sql = "select count(*) test_offset from test_kylin_fact
where price > 10.0";
+String s = QueryUtil.massageSql(sql, "default", 0, 50, "DEFAULT");
+Assert.assertEquals(
+"select count(*) test_offset from test_kylin_fact where
price > 10.0\n" +
+"OFFSET 50",
+s);
+}
+{
+String sql = "select count(*) test_limit_and_offset from
test_kylin_fact where price > 10.0";
+String s = QueryUtil.massageSql(sql, "default", 5, 50,
"DEFAULT");
+Assert.assertEquals(
+"select count(*) test_limit_and_offset from
test_kylin_fact where price > 10.0\n" +
+"LIMIT 5\nOFFSET 50",
+s);
+}
+
+{
+String newLine = System.getProperty("line.separator");
Review comment:
I guess you want to test newline character on different platform. It's a
good point. I suggest to hard code "\r\n" for Windows and "\n" for Linux
instead of reading "line.separator". Maybe I misunderstand, please figure it
out.
As there are more code blocks here, some comments to explain the test
purpose is a good practice. :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asfgit commented on issue #108: Apache kylin 2895
asfgit commented on issue #108: Apache kylin 2895 URL: https://github.com/apache/kylin/pull/108#issuecomment-368778494 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kyotoYaho opened a new pull request #108: Apache kylin 2895
kyotoYaho opened a new pull request #108: Apache kylin 2895 URL: https://github.com/apache/kylin/pull/108 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pengjianhua commented on issue #107: kylin-3119
pengjianhua commented on issue #107: kylin-3119
URL: https://github.com/apache/kylin/pull/107#issuecomment-369110791
hi,rogercloud.the `kylinConfig.getForceLimit()` add a check too.
And the reason that I use "line.separator" is in function massageSql has
the code
`sql = sql.replace("\r", " ").replace("\n",
System.getProperty("line.separator"));`
In windows,if I use '\n',it will be replaced by '\r\n',
if I use '\r\n',it will be replaced by ' \r\n'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] coveralls commented on issue #107: kylin-3119
coveralls commented on issue #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107#issuecomment-368738219 ## Pull Request Test Coverage Report for [Build 3001](https://coveralls.io/builds/15731959) * **16** of **16** **(100.0%)** changed or added relevant lines in **1** file are covered. * **5** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.01%**) to **23.463%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/15731959/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L129) | 1 | 68.5% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15731959/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 4 | 78.12% | | Totals | [](https://coveralls.io/builds/15731959) | | :-- | --: | | Change from base [Build 2998](https://coveralls.io/builds/15678208): | 0.01% | | Covered Lines: | 14017 | | Relevant Lines: | 59741 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #107: kylin-3119
codecov-io commented on issue #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107#issuecomment-368738780 # [Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=h1) Report > Merging [#107](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/865e377b6803caa2e2b2aeab2e5bb77f6470c3e6?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #107 +/- ## + Coverage 21.47% 21.48% +0.01% - Complexity 3820 3822 +2 Files 992 992 Lines 5973459741 +7 Branches 8638 8639 +1 + Hits 1282512833 +8 + Misses4572845726 -2 - Partials 1181 1182 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `55.88% <75%> (+6.7%)` | `15 <0> (+2)` | :arrow_up: | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `64.56% <0%> (-0.79%)` | `0% <0%> (?)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (+0.3%)` | `7% <0%> (?)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=footer). Last update [865e377...73c1c2a](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part
asfgit commented on issue #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part URL: https://github.com/apache/kylin/pull/109#issuecomment-369451560 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenzhx opened a new pull request #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part
chenzhx opened a new pull request #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part URL: https://github.com/apache/kylin/pull/109 Signed-off-by: chenzhx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chenzhx closed pull request #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part
chenzhx closed pull request #109: KYLIN-3265 Add jobSearchMode as a filter
condition for jobs UI part
URL: https://github.com/apache/kylin/pull/109
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/webapp/app/js/controllers/job.js b/webapp/app/js/controllers/job.js
index 51de7874e0..130f14dffc 100644
--- a/webapp/app/js/controllers/job.js
+++ b/webapp/app/js/controllers/job.js
@@ -28,6 +28,7 @@ KylinApp
//$scope.projects = [];
$scope.action = {};
$scope.timeFilter =
jobConfig.timeFilter[JobList.jobFilter.timeFilterId];
+$scope.searchMode =
jobConfig.searchMode[JobList.jobFilter.searchModeId];
if ($routeParams.jobTimeFilter) {
$scope.timeFilter =
jobConfig.timeFilter[$routeParams.jobTimeFilter];
}
@@ -82,6 +83,7 @@ KylinApp
$scope.cubeName=$scope.cubeName == ""?null:$scope.cubeName;
JobList.jobFilter.cubeName = $scope.cubeName;
JobList.jobFilter.timeFilterId = $scope.timeFilter.value;
+JobList.jobFilter.searchModeId = _.indexOf(jobConfig.searchMode,
$scope.searchMode);
JobList.jobFilter.statusIds = statusIds;
var jobRequest = {
@@ -90,7 +92,8 @@ KylinApp
status: statusIds,
offset: offset,
limit: limit,
-timeFilter: $scope.timeFilter.value
+timeFilter: $scope.timeFilter.value,
+jobSearchMode: $scope.searchMode.value
};
$scope.state.loading = true;
diff --git a/webapp/app/js/model/jobConfig.js b/webapp/app/js/model/jobConfig.js
index 4548366579..19ae882c98 100644
--- a/webapp/app/js/model/jobConfig.js
+++ b/webapp/app/js/model/jobConfig.js
@@ -40,6 +40,11 @@ KylinApp.constant('jobConfig', {
{attr: 'last_modified', name: 'Last Modified Time'},
{attr: 'duration', name: 'Duration'}
],
+ searchMode: [
+{name: 'CUBING', value: 'CUBING_ONLY'},
+{name: 'CHECK POINT', value: 'CHECKPOINT_ONLY'},
+{name: 'ALL', value: 'ALL'}
+ ],
queryitems: [
{attr: 'server', name: 'Server'},
{attr: 'user', name: 'User'},
diff --git a/webapp/app/js/model/jobListModel.js
b/webapp/app/js/model/jobListModel.js
index 45948d63e3..197532c076 100755
--- a/webapp/app/js/model/jobListModel.js
+++ b/webapp/app/js/model/jobListModel.js
@@ -26,6 +26,7 @@ KylinApp.service('JobList',function(JobService,$q){
this.jobFilter = {
cubeName : null,
timeFilterId : 1,
+searchModeId: 2,
statusIds: []
};
@@ -33,6 +34,7 @@ KylinApp.service('JobList',function(JobService,$q){
this.jobFilter = {
cubeName : null,
timeFilterId : 1,
+ searchModeId: 2,
statusIds: []
};
};
diff --git a/webapp/app/partials/jobs/jobList.html
b/webapp/app/partials/jobs/jobList.html
index 1ff6ea4f2f..ae05590669 100644
--- a/webapp/app/partials/jobs/jobList.html
+++ b/webapp/app/partials/jobs/jobList.html
@@ -45,6 +45,9 @@
+
+
[GitHub] codecov-io commented on issue #107: kylin-3119
codecov-io commented on issue #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107#issuecomment-368738780 # [Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=h1) Report > Merging [#107](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/76934db8fcddabf437f490e77c8f06c9a4a3db86?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #107 +/- ## - Coverage 21.47% 21.46% -0.02% Complexity 3822 3822 Files 992 992 Lines 5974259749 +7 Branches 8639 8640 +1 - Hits 1283012823 -7 - Misses4573245747 +15 + Partials 1180 1179 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=) | `55.88% <75%> (+6.7%)` | `15 <0> (+2)` | :arrow_up: | | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | | | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `30.67% <0%> (-1.69%)` | `20% <0%> (-1%)` | | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `70.94% <0%> (-1.36%)` | `8% <0%> (?)` | | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `14.98% <0%> (-1.24%)` | `35% <0%> (-2%)` | | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `54.72% <0%> (-1%)` | `21% <0%> (?)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (?)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `65.35% <0%> (+0.78%)` | `0% <0%> (?)` | :arrow_down: | | [...apache/kylin/job/execution/AbstractExecutable.java](https://codecov.io/gh/apache/kylin/pull/107/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9leGVjdXRpb24vQWJzdHJhY3RFeGVjdXRhYmxlLmphdmE=) | `53.14% <0%> (+1.44%)` | `48% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=footer). Last update [76934db...e01648b](https://codecov.io/gh/apache/kylin/pull/107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #107: kylin-3119
coveralls commented on issue #107: kylin-3119 URL: https://github.com/apache/kylin/pull/107#issuecomment-368738219 ## Pull Request Test Coverage Report for [Build 3008](https://coveralls.io/builds/15751320) * **16** of **16** **(100.0%)** changed or added relevant lines in **1** file are covered. * **22** unchanged lines in **6** files lost coverage. * Overall coverage decreased (**-0.02%**) to **23.438%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-metadata/src/main/java/org/apache/kylin/source/datagen/ColumnGenerator.java](https://coveralls.io/builds/15751320/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fdatagen%2FColumnGenerator.java#L317) | 1 | 81.08% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigCannotInitException.java](https://coveralls.io/builds/15751320/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigCannotInitException.java#L24) | 2 | 0.0% | | [core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java](https://coveralls.io/builds/15751320/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fcachesync%2FBroadcaster.java#L145) | 2 | 60.2% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfig.java](https://coveralls.io/builds/15751320/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfig.java#L278) | 4 | 33.19% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15751320/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/15751320/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L67) | 8 | 16.22% | | Totals | [](https://coveralls.io/builds/15751320) | | :-- | --: | | Change from base [Build 3006](https://coveralls.io/builds/15741228): | -0.02% | | Covered Lines: | 14004 | | Relevant Lines: | 59749 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part
codecov-io commented on issue #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part URL: https://github.com/apache/kylin/pull/109#issuecomment-369454646 # [Codecov](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=h1) Report > Merging [#109](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/76934db8fcddabf437f490e77c8f06c9a4a3db86?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #109 +/- ## - Coverage 21.47% 21.45% -0.03% + Complexity 3822 3817 -5 Files 992 992 Lines 5974259742 Branches 8639 8639 - Hits 1283012815 -15 - Misses4573245747 +15 Partials 1180 1180 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | | | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `30.67% <0%> (-1.69%)` | `20% <0%> (-1%)` | | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `14.98% <0%> (-1.24%)` | `35% <0%> (-2%)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/109/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (-0.61%)` | `7% <0%> (?)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=footer). Last update [76934db...31cc006](https://codecov.io/gh/apache/kylin/pull/109?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part
coveralls commented on issue #109: KYLIN-3265 Add jobSearchMode as a filter condition for jobs UI part URL: https://github.com/apache/kylin/pull/109#issuecomment-369454934 ## Pull Request Test Coverage Report for [Build 3009](https://coveralls.io/builds/15751349) * **0** of **0** **(NaN%)** changed or added relevant lines in **0** files are covered. * **15** unchanged lines in **4** files lost coverage. * Overall coverage decreased (**-0.03%**) to **23.429%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15751349/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigCannotInitException.java](https://coveralls.io/builds/15751349/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigCannotInitException.java#L24) | 2 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfig.java](https://coveralls.io/builds/15751349/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfig.java#L278) | 4 | 33.19% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/15751349/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L67) | 8 | 16.22% | | Totals | [](https://coveralls.io/builds/15751349) | | :-- | --: | | Change from base [Build 3006](https://coveralls.io/builds/15741228): | -0.03% | | Covered Lines: | 13997 | | Relevant Lines: | 59742 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #110: KYLIN-3236
asfgit commented on issue #110: KYLIN-3236 URL: https://github.com/apache/kylin/pull/110#issuecomment-369859958 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xingpeng1 opened a new pull request #110: KYLIN-3236
xingpeng1 opened a new pull request #110: KYLIN-3236 URL: https://github.com/apache/kylin/pull/110 KYLIN-3236 The function 'reGenerateAdvancedDict()' has an error logical judgment, which will cause an exception when you edit the cube. Signed-off-by: xingpeng1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 commented on issue #106: When I connect kylin with JDBC, the query date has a problem.
yiming187 commented on issue #106: When I connect kylin with JDBC, the query date has a problem. URL: https://github.com/apache/kylin/pull/106#issuecomment-370492412 Close it, as it's an invalid PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #106: When I connect kylin with JDBC, the query date has a problem.
yiming187 closed pull request #106: When I connect kylin with JDBC, the query date has a problem. URL: https://github.com/apache/kylin/pull/106 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tttMelody opened a new pull request #111: ACL enhancement.
tttMelody opened a new pull request #111: ACL enhancement. URL: https://github.com/apache/kylin/pull/111 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #111: ACL enhancement.
asfgit commented on issue #111: ACL enhancement. URL: https://github.com/apache/kylin/pull/111#issuecomment-370662030 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #111: ACL enhancement.
codecov-io commented on issue #111: ACL enhancement. URL: https://github.com/apache/kylin/pull/111#issuecomment-370668481 # [Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=h1) Report > Merging [#111](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/1e7825bd8b69ad7517298175d2d5bb0fde578fca?src=pr&el=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `0.58%`. [](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#111 +/- ## === - Coverage 21.66% 21.6% -0.06% - Complexity 38573859 +2 === Files 992 996 +4 Lines 59797 59964 +167 Branches 86538661 +8 === + Hits 12954 12956 +2 - Misses45645 45811 +166 + Partials 11981197 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=) | `59% (?)` | `25 <0> (?)` | :arrow_down: | | [...a/org/apache/kylin/rest/request/AccessRequest.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvcmVxdWVzdC9BY2Nlc3NSZXF1ZXN0LmphdmE=) | `100% (?)` | `9 <0> (?)` | :arrow_down: | | [...pache/kylin/rest/security/springacl/AclRecord.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL0FjbFJlY29yZC5qYXZh) | `0% <0%> (?)` | `0 <0> (?)` | | | [...ache/kylin/rest/controller/TableACLController.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9UYWJsZUFDTENvbnRyb2xsZXIuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [...va/org/apache/kylin/rest/security/ManagedUser.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvTWFuYWdlZFVzZXIuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | :arrow_down: | | [...ylin/rest/security/springacl/MutableAclRecord.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL011dGFibGVBY2xSZWNvcmQuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [...pache/kylin/common/persistence/JsonSerializer.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Kc29uU2VyaWFsaXplci5qYXZh) | `0% <0%> (?)` | `0 <0> (?)` | :arrow_down: | | [.../java/org/apache/kylin/rest/util/ValidateUtil.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9WYWxpZGF0ZVV0aWwuamF2YQ==) | `3.07% <0%> (-0.1%)` | `3 <0> (?)` | | | [.../apache/kylin/rest/security/springacl/AceImpl.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL0FjZUltcGwuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [.../apache/kylin/rest/security/springacl/SidInfo.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL1NpZEluZm8uamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | ... and [20 more](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=footer). Last update [1e7825b...fb633e4](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an aut
[GitHub] coveralls commented on issue #111: ACL enhancement.
coveralls commented on issue #111: ACL enhancement. URL: https://github.com/apache/kylin/pull/111#issuecomment-370668572 ## Pull Request Test Coverage Report for [Build 3026](https://coveralls.io/builds/15823854) * **3** of **515** **(0.58%)** changed or added relevant lines in **19** files are covered. * **19** unchanged lines in **7** files lost coverage. * Overall coverage decreased (**-0.06%**) to **23.606%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/security/springacl/LegacyAceInfo.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2Fspringacl%2FLegacyAceInfo.java#L37) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/acl/TableACLManager.java](https://coveralls.io/builds/15823854/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Facl%2FTableACLManager.java#L61) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/security/ManagedUser.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FManagedUser.java#L118) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L327) | 0 | 3 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/security/springacl/SidInfo.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2Fspringacl%2FSidInfo.java#L53) | 0 | 4 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/controller/TableACLController.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FTableACLController.java#L41) | 0 | 7 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/AclTableMigrationTool.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAclTableMigrationTool.java#L60) | 0 | 8 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/persistence/JsonSerializer.java](https://coveralls.io/builds/15823854/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJsonSerializer.java#L33) | 0 | 8 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/util/ValidateUtil.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FValidateUtil.java#L80) | 0 | 8 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/KylinUserService.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserService.java#L85) | 0 | 16 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-common/src/main/java/org/apache/kylin/common/persistence/JsonSerializer.java](https://coveralls.io/builds/15823854/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJsonSerializer.java#L55) | 1 | 0.0% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15823854/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% | | [server-base/src/main/java/org/apache/kylin/rest/service/AclTableMigrationTool.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAclTableMigrationTool.java#L227) | 1 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/service/KylinUserService.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserService.java#L88) | 2 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L330) | 2 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/service/AccessService.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAccessService.java#L70) | 6 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/service/AclService.java](https://coveralls.io/builds/15823854/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FA
[GitHub] codecov-io commented on issue #111: ACL enhancement.
codecov-io commented on issue #111: ACL enhancement. URL: https://github.com/apache/kylin/pull/111#issuecomment-370668481 # [Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=h1) Report > Merging [#111](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/1e7825bd8b69ad7517298175d2d5bb0fde578fca?src=pr&el=desc) will **decrease** coverage by `0.09%`. > The diff coverage is `0.58%`. [](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #111 +/- ## === - Coverage 21.66% 21.56% -0.1% + Complexity 3857 3851 -6 === Files 992 996 +4 Lines 5979759964+167 Branches 8653 8661 +8 === - Hits 1295412933 -21 - Misses4564545837+192 + Partials 1198 1194 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=) | `59% (?)` | `25 <0> (?)` | :arrow_down: | | [...a/org/apache/kylin/rest/request/AccessRequest.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvcmVxdWVzdC9BY2Nlc3NSZXF1ZXN0LmphdmE=) | `100% (?)` | `9 <0> (?)` | :arrow_down: | | [...pache/kylin/common/persistence/JsonSerializer.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Kc29uU2VyaWFsaXplci5qYXZh) | `0% <0%> (?)` | `0 <0> (?)` | :arrow_down: | | [.../apache/kylin/rest/security/springacl/SidInfo.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL1NpZEluZm8uamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [...a/org/apache/kylin/rest/service/AccessService.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9BY2Nlc3NTZXJ2aWNlLmphdmE=) | `0% <0%> (?)` | `0 <0> (?)` | :arrow_down: | | [...in/rest/security/springacl/ObjectIdentityImpl.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL09iamVjdElkZW50aXR5SW1wbC5qYXZh) | `0% <0%> (?)` | `0 <0> (?)` | | | [...org/apache/kylin/metadata/acl/TableACLManager.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvYWNsL1RhYmxlQUNMTWFuYWdlci5qYXZh) | `0% <0%> (?)` | `0 <0> (?)` | :arrow_down: | | [...ache/kylin/rest/controller/TableACLController.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9UYWJsZUFDTENvbnRyb2xsZXIuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [...e/kylin/rest/security/springacl/LegacyAceInfo.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL0xlZ2FjeUFjZUluZm8uamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | [.../apache/kylin/rest/security/springacl/AceImpl.java](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VjdXJpdHkvc3ByaW5nYWNsL0FjZUltcGwuamF2YQ==) | `0% <0%> (?)` | `0 <0> (?)` | | | ... and [22 more](https://codecov.io/gh/apache/kylin/pull/111/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=footer). Last update [1e7825b...a437b4a](https://codecov.io/gh/apache/kylin/pull/111?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -
[GitHub] coveralls commented on issue #111: ACL enhancement.
coveralls commented on issue #111: ACL enhancement. URL: https://github.com/apache/kylin/pull/111#issuecomment-370668572 ## Pull Request Test Coverage Report for [Build 3027](https://coveralls.io/builds/15828627) * **3** of **515** **(0.58%)** changed or added relevant lines in **19** files are covered. * **44** unchanged lines in **11** files lost coverage. * Overall coverage decreased (**-0.1%**) to **23.562%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/security/springacl/LegacyAceInfo.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2Fspringacl%2FLegacyAceInfo.java#L37) | 0 | 1 | 0.0% | [core-metadata/src/main/java/org/apache/kylin/metadata/acl/TableACLManager.java](https://coveralls.io/builds/15828627/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Facl%2FTableACLManager.java#L61) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/security/ManagedUser.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2FManagedUser.java#L118) | 0 | 1 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L327) | 0 | 3 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/security/springacl/SidInfo.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsecurity%2Fspringacl%2FSidInfo.java#L53) | 0 | 4 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/controller/TableACLController.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fcontroller%2FTableACLController.java#L41) | 0 | 7 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/AclTableMigrationTool.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAclTableMigrationTool.java#L60) | 0 | 8 | 0.0% | [core-common/src/main/java/org/apache/kylin/common/persistence/JsonSerializer.java](https://coveralls.io/builds/15828627/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJsonSerializer.java#L33) | 0 | 8 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/util/ValidateUtil.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FValidateUtil.java#L80) | 0 | 8 | 0.0% | [server-base/src/main/java/org/apache/kylin/rest/service/KylinUserService.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserService.java#L85) | 0 | 16 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [server-base/src/main/java/org/apache/kylin/rest/service/AclTableMigrationTool.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAclTableMigrationTool.java#L227) | 1 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/persistence/JsonSerializer.java](https://coveralls.io/builds/15828627/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Fpersistence%2FJsonSerializer.java#L55) | 1 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/service/QueryService.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FQueryService.java#L330) | 2 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfigCannotInitException.java](https://coveralls.io/builds/15828627/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigCannotInitException.java#L24) | 2 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/util/ValidateUtil.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FValidateUtil.java#L53) | 2 | 0.0% | | [server-base/src/main/java/org/apache/kylin/rest/service/KylinUserService.java](https://coveralls.io/builds/15828627/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FKylinUserService.java#L88) | 2 | 0.0% | | [core-common/src/main/java/org/apache/kylin/common/KylinConfig.java](https://coveralls.io/builds/15828627/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinCo
[GitHub] tttMelody commented on issue #111: ACL enhancement.
tttMelody commented on issue #111: ACL enhancement. URL: https://github.com/apache/kylin/pull/111#issuecomment-370774979 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #111: ACL enhancement.
yiming187 closed pull request #111: ACL enhancement.
URL: https://github.com/apache/kylin/pull/111
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-common/src/main/java/org/apache/kylin/common/persistence/JsonSerializer.java
b/core-common/src/main/java/org/apache/kylin/common/persistence/JsonSerializer.java
index 8f0cc51ff9..508b2ab6bf 100644
---
a/core-common/src/main/java/org/apache/kylin/common/persistence/JsonSerializer.java
+++
b/core-common/src/main/java/org/apache/kylin/common/persistence/JsonSerializer.java
@@ -30,11 +30,17 @@
public class JsonSerializer implements
Serializer {
Class clz;
+boolean compact = false;
public JsonSerializer(Class clz) {
this.clz = clz;
}
+public JsonSerializer(Class clz, boolean compact) {
+this.clz = clz;
+this.compact = compact;
+}
+
@Override
public T deserialize(DataInputStream in) throws IOException {
return JsonUtil.readValue(in, clz);
@@ -42,6 +48,9 @@ public T deserialize(DataInputStream in) throws IOException {
@Override
public void serialize(T obj, DataOutputStream out) throws IOException {
-JsonUtil.writeValueIndent(out, obj);
+if (compact)
+JsonUtil.writeValue(out, obj);
+else
+JsonUtil.writeValueIndent(out, obj);
}
}
diff --git
a/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
b/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
index a6b3337842..2bccd67f35 100644
---
a/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
+++
b/core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
@@ -76,6 +76,7 @@
public static final String CUBE_STATISTICS_ROOT = "/cube_statistics";
public static final String BAD_QUERY_RESOURCE_ROOT = "/bad_query";
public static final String DRAFT_RESOURCE_ROOT = "/draft";
+public static final String USER_ROOT = "/user";
public static final String METASTORE_UUID_TAG = "/UUID";
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/acl/TableACLManager.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/acl/TableACLManager.java
index 163d340c74..9f74decc77 100644
---
a/core-metadata/src/main/java/org/apache/kylin/metadata/acl/TableACLManager.java
+++
b/core-metadata/src/main/java/org/apache/kylin/metadata/acl/TableACLManager.java
@@ -58,7 +58,7 @@ public TableACLManager(KylinConfig config) throws IOException
{
logger.info("Initializing TableACLManager with config " + config);
this.config = config;
this.tableACLMap = new CaseInsensitiveStringCache<>(config,
"table_acl");
-this.crud = new CachedCrudAssist(getStore(), "/table_acl",
"", TableACL.class, tableACLMap) {
+this.crud = new CachedCrudAssist(getStore(), "/table_acl",
"", TableACL.class, tableACLMap, true) {
@Override
protected TableACL initEntityAfterReload(TableACL acl, String
resourceName) {
acl.init(resourceName);
diff --git
a/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/CachedCrudAssist.java
b/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/CachedCrudAssist.java
index b3c200ea5a..be3d8d470f 100644
---
a/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/CachedCrudAssist.java
+++
b/core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/CachedCrudAssist.java
@@ -51,16 +51,16 @@
public CachedCrudAssist(ResourceStore store, String resourceRootPath,
Class entityType,
SingleValueCache cache) {
-this(store, resourceRootPath, MetadataConstants.FILE_SURFIX,
entityType, cache);
+this(store, resourceRootPath, MetadataConstants.FILE_SURFIX,
entityType, cache, false);
}
public CachedCrudAssist(ResourceStore store, String resourceRootPath,
String resourcePathSuffix,
-Class entityType, SingleValueCache cache) {
+Class entityType, SingleValueCache cache, boolean
compact) {
this.store = store;
this.entityType = entityType;
this.resRootPath = resourceRootPath;
this.resPathSuffix = resourcePathSuffix;
-this.serializer = new JsonSerializer(entityType);
+this.serializer = new JsonSerializer(entityType, compact);
this.cache = cache;
this.checkCopyOnWrite = store.getConfig().isCheckCopyOnWrite();
diff --git a/examples/test_case_data/localmeta/acl/legacy-test-domain-object
b/examples/test_case_data/localmeta/acl/legacy-test-domain-object
new file mode 100644
index 00..46cae53055
--- /dev/null
+++ b/examples/test_case_data/localmeta/acl
[GitHub] asfgit commented on issue #112: Merge pull request #1 from apache/master
asfgit commented on issue #112: Merge pull request #1 from apache/master URL: https://github.com/apache/kylin/pull/112#issuecomment-371382910 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eissac opened a new pull request #112: Merge pull request #1 from apache/master
eissac opened a new pull request #112: Merge pull request #1 from apache/master URL: https://github.com/apache/kylin/pull/112 syncing a fork This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eissac closed pull request #112: Merge pull request #1 from apache/master
eissac closed pull request #112: Merge pull request #1 from apache/master URL: https://github.com/apache/kylin/pull/112 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #112: Merge pull request #1 from apache/master
coveralls commented on issue #112: Merge pull request #1 from apache/master URL: https://github.com/apache/kylin/pull/112#issuecomment-371385216 ## Pull Request Test Coverage Report for [Build 3029](https://coveralls.io/builds/15868118) * **0** of **0** **(NaN%)** changed or added relevant lines in **0** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.04%**) to **23.589%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15868118/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/15868118) | | :-- | --: | | Change from base [Build 3028](https://coveralls.io/builds/15835845): | 0.04% | | Covered Lines: | 14145 | | Relevant Lines: | 59964 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #112: Merge pull request #1 from apache/master
codecov-io commented on issue #112: Merge pull request #1 from apache/master URL: https://github.com/apache/kylin/pull/112#issuecomment-371385736 # [Codecov](https://codecov.io/gh/apache/kylin/pull/112?src=pr&el=h1) Report > Merging [#112](https://codecov.io/gh/apache/kylin/pull/112?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/56e7dc6f4b7e074826070c806209d0bdab79?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/112?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #112 +/- ## + Coverage 21.55% 21.58% +0.03% - Complexity 3850 3855 +5 Files 996 996 Lines 5996459964 Branches 8661 8661 + Hits 1292412946 +22 + Misses4584345821 -22 Partials 1197 1197 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/112?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/112/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `82.53% <0%> (+0.79%)` | `18% <0%> (+1%)` | :arrow_up: | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/112/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.91%)` | `7% <0%> (?)` | :arrow_down: | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/112/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `55.72% <0%> (+0.99%)` | `21% <0%> (?)` | :arrow_down: | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/112/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `16.18% <0%> (+1.22%)` | `37% <0%> (+2%)` | :arrow_up: | | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/112/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `32.35% <0%> (+1.68%)` | `21% <0%> (+1%)` | :arrow_up: | | [...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/112/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==) | `15.18% <0%> (+2.09%)` | `6% <0%> (?)` | :arrow_down: | | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/112/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==) | `100% <0%> (+100%)` | `1% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/112?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/112?src=pr&el=footer). Last update [56e7333...d5fa261](https://codecov.io/gh/apache/kylin/pull/112?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #113: KYLIN-3280
asfgit commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-371694247 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xingpeng1 opened a new pull request #113: KYLIN-3280
xingpeng1 opened a new pull request #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113 KYLIN-3280 The delete button should not be enabled without any segment in cube segment delete confirm dialog This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #113: KYLIN-3280
coveralls commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-371696607 ## Pull Request Test Coverage Report for [Build 3030](https://coveralls.io/builds/15887406) * **0** of **0** **(NaN%)** changed or added relevant lines in **0** files are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.03%**) to **23.581%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15887406/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/15887406) | | :-- | --: | | Change from base [Build 3028](https://coveralls.io/builds/15835845): | 0.03% | | Covered Lines: | 14140 | | Relevant Lines: | 59964 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #113: KYLIN-3280
codecov-io commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-371697041 # [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=h1) Report > Merging [#113](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/56e7dc6f4b7e074826070c806209d0bdab79?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #113 +/- ## + Coverage 21.55% 21.58% +0.02% - Complexity 3850 3854 +4 Files 996 996 Lines 5996459964 Branches 8661 8661 + Hits 1292412941 +17 + Misses4584345826 -17 Partials 1197 1197 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.91%)` | `7% <0%> (?)` | :arrow_down: | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `16.18% <0%> (+1.22%)` | `37% <0%> (+2%)` | :arrow_up: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (?)` | :arrow_down: | | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `32.35% <0%> (+1.68%)` | `21% <0%> (+1%)` | :arrow_up: | | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==) | `100% <0%> (+100%)` | `1% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=footer). Last update [56e7333...e4819c9](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shaofengshi commented on issue #113: KYLIN-3280
shaofengshi commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-372112662 As there is just 1 line code change, can you merge the 3 commits to 1? thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #113: KYLIN-3280
coveralls commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-371696607 ## Pull Request Test Coverage Report for [Build 3034](https://coveralls.io/builds/15920496) * **0** of **0** **(NaN%)** changed or added relevant lines in **0** files are covered. * **3** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.002%**) to **23.9%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/15920496/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L129) | 1 | 68.5% | | [core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java](https://coveralls.io/builds/15920496/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fcachesync%2FBroadcaster.java#L145) | 2 | 60.2% | | Totals | [](https://coveralls.io/builds/15920496) | | :-- | --: | | Change from base [Build 3033](https://coveralls.io/builds/15913920): | -0.002% | | Covered Lines: | 14338 | | Relevant Lines: | 59992 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #113: KYLIN-3280
codecov-io commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-371697041 # [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=h1) Report > Merging [#113](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/06f497eb603134a6b0ddbfd88739ccaddab007fb?src=pr&el=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #113 +/- ## - Coverage 21.86% 21.58% -0.29% + Complexity 3887 3854 -33 Files 996 996 Lines 5999259964 -28 Branches 8665 8661 -4 - Hits 1311912941 -178 - Misses4565345826 +173 + Partials 1220 1197 -23 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...a/org/apache/kylin/rest/job/StorageCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbnVwSm9iLmphdmE=) | `0% <0%> (-65.06%)` | `0% <0%> (-24%)` | | | [...pache/kylin/rest/job/StorageCleanJobHbaseUtil.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbkpvYkhiYXNlVXRpbC5qYXZh) | `0% <0%> (-60.66%)` | `0% <0%> (-7%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==) | `13.08% <0%> (-4.72%)` | `6% <0%> (?)` | | | [.../apache/kylin/common/persistence/ResourceTool.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVRvb2wuamF2YQ==) | `8.14% <0%> (-1.51%)` | `5% <0%> (?)` | | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `54.72% <0%> (-1%)` | `21% <0%> (?)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `64.56% <0%> (-0.79%)` | `0% <0%> (?)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `46.26% <0%> (-0.37%)` | `9% <0%> (?)` | | | [...va/org/apache/kylin/rest/service/AdminService.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9BZG1pblNlcnZpY2UuamF2YQ==) | `0% <0%> (?)` | `0% <0%> (?)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=footer). Last update [06f497e...117edef](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] xingpeng1 commented on issue #113: KYLIN-3280
xingpeng1 commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-372183815 @shaofengshi , I have modified, there is only one commit for this PR, thanks for your reminder. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xingpeng1 opened a new pull request #113: KYLIN-3280
xingpeng1 opened a new pull request #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113 KYLIN-3280 The delete button should not be enabled without any segment in cube segment delete confirm dialog This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #113: KYLIN-3280
asfgit commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-372183900 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xingpeng1 closed pull request #113: KYLIN-3280
xingpeng1 closed pull request #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/webapp/app/partials/cubes/cube_delete_segment.html b/webapp/app/partials/cubes/cube_delete_segment.html index 8500f3f7a9..93356eeeae 100644 --- a/webapp/app/partials/cubes/cube_delete_segment.html +++ b/webapp/app/partials/cubes/cube_delete_segment.html @@ -83,7 +83,7 @@ CUBE SEGMENT DELETE CONFIRM Close -Delete +Delete \ No newline at end of file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #113: KYLIN-3280
coveralls commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-371696607 ## Pull Request Test Coverage Report for [Build 3035](https://coveralls.io/builds/15920601) * **0** of **0** **(NaN%)** changed or added relevant lines in **0** files are covered. * **8** unchanged lines in **2** files lost coverage. * Overall coverage decreased (**-0.01%**) to **23.89%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-job/src/main/java/org/apache/kylin/job/dao/ExecutableDao.java](https://coveralls.io/builds/15920601/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fdao%2FExecutableDao.java#L131) | 1 | 41.24% | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15920601/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L193) | 7 | 75.99% | | Totals | [](https://coveralls.io/builds/15920601) | | :-- | --: | | Change from base [Build 3033](https://coveralls.io/builds/15913920): | -0.01% | | Covered Lines: | 14332 | | Relevant Lines: | 59992 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #113: KYLIN-3280
codecov-io commented on issue #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113#issuecomment-371697041 # [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=h1) Report > Merging [#113](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/06f497eb603134a6b0ddbfd88739ccaddab007fb?src=pr&el=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #113 +/- ## - Coverage 21.86% 21.58% -0.29% + Complexity 3887 3854 -33 Files 996 996 Lines 5999259964 -28 Branches 8665 8661 -4 - Hits 1311912941 -178 - Misses4565345826 +173 + Partials 1220 1197 -23 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...a/org/apache/kylin/rest/job/StorageCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbnVwSm9iLmphdmE=) | `0% <0%> (-65.06%)` | `0% <0%> (-24%)` | | | [...pache/kylin/rest/job/StorageCleanJobHbaseUtil.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbkpvYkhiYXNlVXRpbC5qYXZh) | `0% <0%> (-60.66%)` | `0% <0%> (-7%)` | | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==) | `13.08% <0%> (-4.72%)` | `6% <0%> (?)` | | | [.../apache/kylin/common/persistence/ResourceTool.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVRvb2wuamF2YQ==) | `8.14% <0%> (-1.51%)` | `5% <0%> (?)` | | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `54.72% <0%> (-1%)` | `21% <0%> (?)` | | | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh) | `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `64.56% <0%> (-0.79%)` | `0% <0%> (?)` | | | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `46.26% <0%> (-0.37%)` | `9% <0%> (?)` | | | [...va/org/apache/kylin/rest/service/AdminService.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9BZG1pblNlcnZpY2UuamF2YQ==) | `0% <0%> (?)` | `0% <0%> (?)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=footer). Last update [06f497e...117edef](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[GitHub] tttMelody opened a new pull request #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil?
tttMelody opened a new pull request #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil? URL: https://github.com/apache/kylin/pull/114 ?ding error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil?
asfgit commented on issue #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil? URL: https://github.com/apache/kylin/pull/114#issuecomment-372291210 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liyang-gmt8 closed pull request #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil?
liyang-gmt8 closed pull request #114: KYLIN-3287, fix when a shard by column is
in dict encoding, dict buil?
URL: https://github.com/apache/kylin/pull/114
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
index a4576774aa..dab4880390 100644
---
a/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
+++
b/engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java
@@ -82,7 +82,7 @@ public IReadableTable getDistinctValuesFor(TblColRef col) {
List uhcColumns =
cube.getDescriptor().getAllUHCColumns();
Path colDir;
-if (uhcColumns.contains(col)) {
+if (config.isBuildUHCDictWithMREnabled() &&
uhcColumns.contains(col)) {
colDir = new Path(dictPath, col.getIdentity());
} else {
colDir = new Path(factColumnsInputPath, col.getIdentity());
diff --git
a/examples/test_case_data/localmeta/cube_desc/ci_inner_join_cube.json
b/examples/test_case_data/localmeta/cube_desc/ci_inner_join_cube.json
index 809e188ee3..ec1100a1da 100644
--- a/examples/test_case_data/localmeta/cube_desc/ci_inner_join_cube.json
+++ b/examples/test_case_data/localmeta/cube_desc/ci_inner_join_cube.json
@@ -342,7 +342,8 @@
},
{
"column": "TEST_KYLIN_FACT.LEAF_CATEG_ID",
-"encoding": "dict"
+"encoding": "dict",
+"isShardBy" : true
},
{
"column": "TEST_CATEGORY_GROUPINGS.META_CATEG_NAME",
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil?
codecov-io commented on issue #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil? URL: https://github.com/apache/kylin/pull/114#issuecomment-372295252 # [Codecov](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=h1) Report > Merging [#114](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/06f497eb603134a6b0ddbfd88739ccaddab007fb?src=pr&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #114 +/- ## - Coverage 21.86% 21.84% -0.03% + Complexity 3887 3886 -1 Files 996 996 Lines 5999259992 Branches 8665 8665 - Hits 1311913106 -13 - Misses4565345665 +12 - Partials 1220 1221 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=tree) | Coverage ? | Complexity ? | | |---|---|---|---| | [...che/kylin/engine/mr/steps/CreateDictionaryJob.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQ3JlYXRlRGljdGlvbmFyeUpvYi5qYXZh) | `0% <0%> (?)` | `0 <0> (?)` | :arrow_down: | | [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | | | [...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==) | `13.08% <0%> (-4.72%)` | `6% <0%> (?)` | | | [...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=) | `54.22% <0%> (-1.5%)` | `21% <0%> (?)` | | | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `64.56% <0%> (-0.79%)` | `0% <0%> (?)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/114/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+0.6%)` | `7% <0%> (?)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=footer). Last update [06f497e...f26969c](https://codecov.io/gh/apache/kylin/pull/114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil?
coveralls commented on issue #114: KYLIN-3287, fix when a shard by column is in dict encoding, dict buil? URL: https://github.com/apache/kylin/pull/114#issuecomment-372295747 ## Pull Request Test Coverage Report for [Build 3036](https://coveralls.io/builds/15926510) * **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered. * **12** unchanged lines in **3** files lost coverage. * Overall coverage decreased (**-0.02%**) to **23.885%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java](https://coveralls.io/builds/15926510/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCreateDictionaryJob.java#L85) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/15926510/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L129) | 1 | 68.5% | | [core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java](https://coveralls.io/builds/15926510/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fcachesync%2FBroadcaster.java#L149) | 1 | 60.7% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java](https://coveralls.io/builds/15926510/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2FHBaseConnection.java#L81) | 10 | 17.28% | | Totals | [](https://coveralls.io/builds/15926510) | | :-- | --: | | Change from base [Build 3033](https://coveralls.io/builds/15913920): | -0.02% | | Covered Lines: | 14329 | | Relevant Lines: | 59992 | --- # ? - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #107: kylin-3119
yiming187 closed pull request #107: kylin-3119
URL: https://github.com/apache/kylin/pull/107
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/query/src/main/java/org/apache/kylin/query/util/QueryUtil.java
b/query/src/main/java/org/apache/kylin/query/util/QueryUtil.java
index 4de6a2c337..055289578a 100644
--- a/query/src/main/java/org/apache/kylin/query/util/QueryUtil.java
+++ b/query/src/main/java/org/apache/kylin/query/util/QueryUtil.java
@@ -50,22 +50,29 @@ public static String massageSql(String sql, String project,
int limit, int offse
ProjectManager projectManager =
ProjectManager.getInstance(KylinConfig.getInstanceFromEnv());
ProjectInstance projectInstance = projectManager.getProject(project);
KylinConfig kylinConfig = projectInstance.getConfig();
-
+sql = removeCommentInSql(sql);
while (sql.endsWith(";"))
sql = sql.substring(0, sql.length() - 1);
-if (limit > 0 && !sql.toLowerCase().contains("limit")) {
-sql += ("\nLIMIT " + limit);
-}
+String sql1=sql;
+final String suffixPattern =
"^.+?\\s(limit\\s\\d+)?\\s(offset\\s\\d+)?\\s*$";
+sql = sql.replaceAll("\\s+", " ");
+Pattern pattern = Pattern.compile(suffixPattern);
+Matcher matcher = pattern.matcher(sql.toLowerCase() + " ");
-if (offset > 0 && !sql.toLowerCase().contains("offset")) {
-sql += ("\nOFFSET " + offset);
+if (matcher.find()) {
+if (limit > 0 && matcher.group(1) == null) {
+sql1 += ("\nLIMIT " + limit);
+}
+if (offset > 0 && matcher.group(2) == null) {
+sql1 += ("\nOFFSET " + offset);
+}
}
// https://issues.apache.org/jira/browse/KYLIN-2649
-if (kylinConfig.getForceLimit() > 0 &&
!sql.toLowerCase().contains("limit")
-&& sql.toLowerCase().matches("^select\\s+\\*\\p{all}*")) {
-sql += ("\nLIMIT " + kylinConfig.getForceLimit());
+if (kylinConfig.getForceLimit() > 0 && limit <= 0 && matcher.group(1)
== null
+&& sql1.toLowerCase().matches("^select\\s+\\*\\p{all}*")) {
+sql1 += ("\nLIMIT " + kylinConfig.getForceLimit());
}
// customizable SQL transformation
@@ -73,9 +80,9 @@ public static String massageSql(String sql, String project,
int limit, int offse
initQueryTransformers();
}
for (IQueryTransformer t : queryTransformers) {
-sql = t.transform(sql, project, defaultSchema);
+sql1 = t.transform(sql1, project, defaultSchema);
}
-return sql;
+return sql1;
}
private static void initQueryTransformers() {
diff --git a/query/src/test/java/org/apache/kylin/query/util/QueryUtilTest.java
b/query/src/test/java/org/apache/kylin/query/util/QueryUtilTest.java
index 01c2f7f113..4d766b9e33 100644
--- a/query/src/test/java/org/apache/kylin/query/util/QueryUtilTest.java
+++ b/query/src/test/java/org/apache/kylin/query/util/QueryUtilTest.java
@@ -51,6 +51,58 @@ public void testMassageSql() {
"select ( date '2001-09-28' + interval '2' month) from
test_kylin_fact group by ( date '2001-09-28' + interval '2' month)",
s);
}
+{
+String sql = "select count(*) test_limit from test_kylin_fact
where price > 10.0";
+String s = QueryUtil.massageSql(sql, "default", 5, 0,
"DEFAULT");
+Assert.assertEquals(
+"select count(*) test_limit from test_kylin_fact where
price > 10.0\n" +
+"LIMIT 5",
+s);
+}
+{
+String sql = "select count(*) test_offset from test_kylin_fact
where price > 10.0";
+String s = QueryUtil.massageSql(sql, "default", 0, 50, "DEFAULT");
+Assert.assertEquals(
+"select count(*) test_offset from test_kylin_fact where
price > 10.0\n" +
+"OFFSET 50",
+s);
+}
+{
+String sql = "select count(*) test_limit_and_offset from
test_kylin_fact where price > 10.0";
+String s = QueryUtil.massageSql(sql, "default", 5, 50,
"DEFAULT");
+Assert.assertEquals(
+"select count(*) test_limit_and_offset from
test_kylin_fact where price > 10.0\n" +
+"LIMIT 5\nOFFSET 50",
+s);
+}
+
+{
+String newLine = System.getProperty("line.separator");
+String sql = "select count(*) test_limit from " + newLine +
"test_kylin_fact where price > 10.0";
+
[GitHub] yiming187 closed pull request #113: KYLIN-3280
yiming187 closed pull request #113: KYLIN-3280 URL: https://github.com/apache/kylin/pull/113 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/webapp/app/partials/cubes/cube_delete_segment.html b/webapp/app/partials/cubes/cube_delete_segment.html index 8500f3f7a9..93356eeeae 100644 --- a/webapp/app/partials/cubes/cube_delete_segment.html +++ b/webapp/app/partials/cubes/cube_delete_segment.html @@ -83,7 +83,7 @@ CUBE SEGMENT DELETE CONFIRM Close -Delete +Delete \ No newline at end of file This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #115: minor, refine exception handling.
asfgit commented on issue #115: minor, refine exception handling. URL: https://github.com/apache/kylin/pull/115#issuecomment-372889290 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tttMelody opened a new pull request #115: minor, refine exception handling.
tttMelody opened a new pull request #115: minor, refine exception handling. URL: https://github.com/apache/kylin/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #115: minor, refine exception handling.
coveralls commented on issue #115: minor, refine exception handling. URL: https://github.com/apache/kylin/pull/115#issuecomment-372891622 ## Pull Request Test Coverage Report for [Build 3045](https://coveralls.io/builds/15963074) * **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered. * **3** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.005%**) to **23.894%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [server-base/src/main/java/org/apache/kylin/rest/service/AdminService.java](https://coveralls.io/builds/15963074/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FAdminService.java#L96) | 0 | 1 | 0.0% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/15963074/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% | | Totals | [](https://coveralls.io/builds/15963074) | | :-- | --: | | Change from base [Build 3044](https://coveralls.io/builds/15960099): | 0.005% | | Covered Lines: | 14336 | | Relevant Lines: | 5 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] yiming187 closed pull request #115: minor, refine exception handling.
yiming187 closed pull request #115: minor, refine exception handling.
URL: https://github.com/apache/kylin/pull/115
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/server-base/src/main/java/org/apache/kylin/rest/service/AdminService.java
b/server-base/src/main/java/org/apache/kylin/rest/service/AdminService.java
index 70afefdce7..f7881f141c 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/service/AdminService.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/service/AdminService.java
@@ -93,7 +93,7 @@ public void cleanupStorage() {
try {
job = new StorageCleanupJob();
} catch (IOException e) {
-logger.error("can not init StorageCleanupJob", e);
+throw new RuntimeException("Can not init StorageCleanupJob", e);
}
String[] args = new String[] { "-delete", "true" };
job.execute(args);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] xingpeng1 opened a new pull request #116: KYLIN-3292
xingpeng1 opened a new pull request #116: KYLIN-3292 URL: https://github.com/apache/kylin/pull/116 KYLIN-3292 The update button should be disabled with none key and value in setting config dialog This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #116: KYLIN-3292
asfgit commented on issue #116: KYLIN-3292 URL: https://github.com/apache/kylin/pull/116#issuecomment-373620961 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #116: KYLIN-3292
coveralls commented on issue #116: KYLIN-3292 URL: https://github.com/apache/kylin/pull/116#issuecomment-373624959 ## Pull Request Test Coverage Report for [Build 3048](https://coveralls.io/builds/16010769) * **0** of **0** **(NaN%)** changed or added relevant lines in **0** files are covered. * **10** unchanged lines in **1** file lost coverage. * Overall coverage increased (+**0.008%**) to **23.899%** --- | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java](https://coveralls.io/builds/16010769/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2FHBaseConnection.java#L81) | 10 | 17.28% | | Totals | [](https://coveralls.io/builds/16010769) | | :-- | --: | | Change from base [Build 3046](https://coveralls.io/builds/15980899): | 0.008% | | Covered Lines: | 14339 | | Relevant Lines: | 5 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea…
asfgit commented on issue #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea… URL: https://github.com/apache/kylin/pull/117#issuecomment-373730001 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tttMelody opened a new pull request #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea…
tttMelody opened a new pull request #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea… URL: https://github.com/apache/kylin/pull/117 …ds to cut bytes error. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea…
codecov-io commented on issue #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea… URL: https://github.com/apache/kylin/pull/117#issuecomment-373735030 # [Codecov](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=h1) Report > Merging [#117](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/cf6d76d2dd5c96d3979481fe4d7ca69bbb626b30?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `55.55%`. [](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #117 +/- ## + Coverage 21.85% 21.85% +<.01% - Complexity 3884 3889 +5 Files 996 996 Lines 55 Branches 8666 8666 + Hits 1311213114 +2 + Misses4566745664 -3 - Partials 1220 1221 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../org/apache/kylin/dimension/FixedLenHexDimEnc.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vZGltZW5zaW9uL0ZpeGVkTGVuSGV4RGltRW5jLmphdmE=) | `83.46% <55.55%> (ø)` | `23 <6> (+1)` | :arrow_up: | | [...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==) | `13.08% <0%> (-4.72%)` | `6% <0%> (ø)` | | | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | | | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `16.18% <0%> (+1.22%)` | `37% <0%> (+2%)` | :arrow_up: | | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=) | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: | | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh) | `32.35% <0%> (+1.68%)` | `21% <0%> (+1%)` | :arrow_up: | | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==) | `100% <0%> (+100%)` | `1% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=footer). Last update [cf6d76d...1d2d804](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea…
coveralls commented on issue #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code length lea… URL: https://github.com/apache/kylin/pull/117#issuecomment-373735894 ## Pull Request Test Coverage Report for [Build 3049](https://coveralls.io/builds/16016963) * **6** of **9** **(66.67%)** changed or added relevant lines in **1** file are covered. * **15** unchanged lines in **2** files lost coverage. * Overall coverage increased (+**0.005%**) to **23.895%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-|--||---: | | [core-metadata/src/main/java/org/apache/kylin/dimension/FixedLenHexDimEnc.java](https://coveralls.io/builds/16016963/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdimension%2FFixedLenHexDimEnc.java#L253) | 6 | 9 | 66.67% | Files with Coverage Reduction | New Missed Lines | % | | :-|--|--: | | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/16016963/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% | | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java](https://coveralls.io/builds/16016963/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2FHBaseConnection.java#L81) | 10 | 17.28% | | Totals | [](https://coveralls.io/builds/16016963) | | :-- | --: | | Change from base [Build 3046](https://coveralls.io/builds/15980899): | 0.005% | | Covered Lines: | 14337 | | Relevant Lines: | 5 | --- # 💛 - [Coveralls](https://coveralls.io) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #118: Kyligence weekly update
asfgit commented on issue #118: Kyligence weekly update URL: https://github.com/apache/kylin/pull/118#issuecomment-373979533 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] liyang-gmt8 opened a new pull request #118: Kyligence weekly update
liyang-gmt8 opened a new pull request #118: Kyligence weekly update URL: https://github.com/apache/kylin/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
