Re: Review Request 44171: Lens-915 : query execute (non async option) should use EXECUTE_WITH_TIMEOUT option instead of EXECUTE followed by status polling

2016-02-29 Thread Rajat Khandelwal
> On March 1, 2016, 7:37 a.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/LensStatement.java, line > > 360 > > > > > > Should we try to prevent this extra call ? It can introduce delay

Re: Review Request 44171: Lens-915 : query execute (non async option) should use EXECUTE_WITH_TIMEOUT option instead of EXECUTE followed by status polling

2016-02-29 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44171/#review121400 --- lens-client/src/main/java/org/apache/lens/client/LensClient.java

[jira] [Updated] (LENS-833) Limit number of open sessions per user on session service

2016-02-29 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raju Bairishetti updated LENS-833: -- Attachment: LENS-833.patch > Limit number of open sessions per user on session service >

[jira] [Updated] (LENS-833) Limit number of open sessions per user on session service

2016-02-29 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raju Bairishetti updated LENS-833: -- Status: Patch Available (was: In Progress) > Limit number of open sessions per user on session

[jira] [Updated] (LENS-954) await() is not inside loop in FairPriorityBlockingQueue#waitUntilNotEmpty()

2016-02-29 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajay Yadava updated LENS-954: - Status: Patch Available (was: Open) > await() is not inside loop in

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39576/#review121388 --- Ship it! Ship It! - Amareshwari Sriramadasu On Feb. 29,

Re: Review Request 44180: Fixes LENS UI module after API contracts change.

2016-02-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44180/#review121387 --- Ship it! Changes look fine to me. - Amareshwari Sriramadasu

[jira] [Created] (LENS-979) A client should not be able to fetch InMemory Results more than once

2016-02-29 Thread Puneet Gupta (JIRA)
Puneet Gupta created LENS-979: - Summary: A client should not be able to fetch InMemory Results more than once Key: LENS-979 URL: https://issues.apache.org/jira/browse/LENS-979 Project: Apache Lens

[jira] [Commented] (LENS-915) Update CLI to show streaming results

2016-02-29 Thread Puneet Gupta (JIRA)
[ https://issues.apache.org/jira/browse/LENS-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173104#comment-15173104 ] Puneet Gupta commented on LENS-915: --- https://reviews.apache.org/r/44171/ > Update CLI to show streaming

Re: Review Request 44171: Lens-915 : query execute (non async option) should use EXECUTE_WITH_TIMEOUT option instead of EXECUTE followed by status polling

2016-02-29 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44171/#review121381 ---

[jira] [Commented] (LENS-976) Too many warnings in YAMLToStringStrategy in test cases

2016-02-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173029#comment-15173029 ] Hudson commented on LENS-976: - UNSTABLE: Integrated in Lens-Commit #1198 (See

[jira] [Commented] (LENS-976) Too many warnings in YAMLToStringStrategy in test cases

2016-02-29 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/LENS-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172990#comment-15172990 ] Hudson commented on LENS-976: - UNSTABLE: Integrated in Lens-Commit-Java8 #111 (See

[jira] [Updated] (LENS-976) Too many warnings in YAMLToStringStrategy in test cases

2016-02-29 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raju Bairishetti updated LENS-976: -- Resolution: Fixed Fix Version/s: 2.6 Status: Resolved (was: Patch Available)

Re: Review Request 44143: LENS-976: Too many warnings in YAMLToStringStrategy in test cases

2016-02-29 Thread Raju Bairishetti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44143/#review121362 --- Ship it! Ship It! - Raju Bairishetti On Feb. 27, 2016, 1:29

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Raju Bairishetti
> On Feb. 29, 2016, 12:44 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 218 > > > > > > Seems the update is not happening upon restore. We

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Raju Bairishetti
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 318 > > > > > > Shouldnt we remove from map when count reaches

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Raju Bairishetti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39576/ --- (Updated Feb. 29, 2016, 11:10 p.m.) Review request for lens, Amareshwari

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Raju Bairishetti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39576/ --- (Updated Feb. 29, 2016, 11:09 p.m.) Review request for lens, Amareshwari

[jira] [Commented] (LENS-971) Lens UI module broken on 2.5 release build

2016-02-29 Thread Ankeet Maini (JIRA)
[ https://issues.apache.org/jira/browse/LENS-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172533#comment-15172533 ] Ankeet Maini commented on LENS-971: --- Review: https://reviews.apache.org/r/44180/diff/1#index_header I'll

Re: Review Request 44180: Fixes LENS UI module after API contracts change.

2016-02-29 Thread Ankeet Maini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44180/ --- (Updated Feb. 29, 2016, 8:18 p.m.) Review request for lens, Amareshwari

Review Request 44180: Fixes LENS UI module after API contracts change.

2016-02-29 Thread Ankeet Maini
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44180/ --- Review request for lens, Amareshwari Sriramadasu, Deepak Barr, and Rajat

Review Request 44171: Lens-915 : query execute (non async option) should use EXECUTE_WITH_TIMEOUT option instead of EXECUTE followed by status polling

2016-02-29 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44171/ --- Review request for lens. Bugs: LENS_915

[jira] [Commented] (LENS-317) Server side calls for updating database jars

2016-02-29 Thread Badrinath Kulkarni (JIRA)
[ https://issues.apache.org/jira/browse/LENS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171834#comment-15171834 ] Badrinath Kulkarni commented on LENS-317: - Updated approach : Support both old and new flows. Over

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39576/#review121233 ---

[jira] [Commented] (LENS-317) Server side calls for updating database jars

2016-02-29 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171784#comment-15171784 ] Amareshwari Sriramadasu commented on LENS-317: -- [~Bakul], Please take care of supporting

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Raju Bairishetti
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java, > > line 51 > > > > > > Error wont not be coming in Data.

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Amareshwari Sriramadasu
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java, > > line 51 > > > > > > Error wont not be coming in Data.

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2016-02-29 Thread Raju Bairishetti
> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 318 > > > > > > Shouldnt we remove from map when count reaches