[jira] [Created] (LENS-819) Timeline of the fact returned should have structure instead of String

[Amareshwari Sriramadasu (JIRA)]

Amareshwari Sriramadasu created LENS-819:


 Summary: Timeline of the fact returned should have structure 
instead of String
 Key: LENS-819
 URL: https://issues.apache.org/jira/browse/LENS-819
 Project: Apache Lens
  Issue Type: Improvement
  Components: api, client, server
Reporter: Amareshwari Sriramadasu


Right now, the fact timeline returned is a string representation of the 
underlying timeline. Instead, we should return a proper structure to the user 
for them to avoid parsing and figuring out the timeline. This is useful mainly 
for the api users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 416)


can you take care of the TODO?


- Rajat Khandelwal


On Oct. 14, 2015, 7 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 7 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39311: LENS-820: Add relative end time for facts

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39311/
---

(Updated Oct. 14, 2015, 2 p.m.)


Review request for lens.


Bugs: LENS-820
https://issues.apache.org/jira/browse/LENS-820


Repository: lens


Description
---


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
a6cff417ee88b2ab3799e86d314b56035b7e304c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 

Diff: https://reviews.apache.org/r/39311/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Created] (LENS-820) Add relative end time for facts

[Rajat Khandelwal (JIRA)]

Rajat Khandelwal created LENS-820:
-

 Summary: Add relative end time for facts
 Key: LENS-820
 URL: https://issues.apache.org/jira/browse/LENS-820
 Project: Apache Lens
  Issue Type: Improvement
Reporter: Rajat Khandelwal
Assignee: Rajat Khandelwal






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (LENS-820) Add relative end time for facts

[Rajat Khandelwal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-820 started by Rajat Khandelwal.
-
> Add relative end time for facts
> ---
>
> Key: LENS-820
> URL: https://issues.apache.org/jira/browse/LENS-820
> Project: Apache Lens
>  Issue Type: Improvement
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 39311: LENS-820: Add relative end time for facts

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39311/
---

Review request for lens.


Bugs: LENS-820
https://issues.apache.org/jira/browse/LENS-820


Repository: lens


Description
---


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
a6cff417ee88b2ab3799e86d314b56035b7e304c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 

Diff: https://reviews.apache.org/r/39311/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Assigned] (LENS-815) query list api should have an option to filter by driver

[Deepak Barr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Barr reassigned LENS-815:


Assignee: Deepak Barr

> query list api should have an option to filter by driver
> 
>
> Key: LENS-815
> URL: https://issues.apache.org/jira/browse/LENS-815
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Deepak Barr
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39311: LENS-820: Add relative end time for facts

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39311/
---

(Updated Oct. 14, 2015, 3:24 p.m.)


Review request for lens.


Bugs: LENS-820
https://issues.apache.org/jira/browse/LENS-820


Repository: lens


Description
---


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
a6cff417ee88b2ab3799e86d314b56035b7e304c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39311/diff/


Testing
---


Thanks,

Rajat Khandelwal

[jira] [Commented] (LENS-815) query list api should have an option to filter by driver

[Deepak Barr (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956698#comment-14956698
 ] 

Deepak Barr commented on LENS-815:
--

Review request - https://reviews.apache.org/r/39314/

> query list api should have an option to filter by driver
> 
>
> Key: LENS-815
> URL: https://issues.apache.org/jira/browse/LENS-815
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Rajat Khandelwal
>Assignee: Deepak Barr
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39314: LENS-815 : Query list api should have an option to filter by driver

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39314/#review102601
---



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 2076)


Should we do a contains check instead of equality?

As a cli user I doubt I'd like to give whole class name to get queries of a 
driver.


- Rajat Khandelwal


On Oct. 14, 2015, 4:33 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39314/
> ---
> 
> (Updated Oct. 14, 2015, 4:33 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-815
> https://issues.apache.org/jira/browse/LENS-815
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added the ability in query list API to filter the queries on driver class.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
>  724e36a 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
> 8a2ac19 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  d57812f 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
>  96f6aea 
>   
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java
>  17022aa 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
> 708afe5 
> 
> Diff: https://reviews.apache.org/r/39314/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested the API with driver parameter.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  3.460 
> s]
> [INFO] Lens ... SUCCESS [  4.422 
> s]
> [INFO] Lens API ... SUCCESS [ 30.327 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 27.110 
> s]
> [INFO] Lens Cube .. SUCCESS [07:13 
> min]
> [INFO] Lens DB storage  SUCCESS [ 28.907 
> s]
> [INFO] Lens Query Library . SUCCESS [ 21.291 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:09 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 50.378 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 21.401 
> s]
> [INFO] Lens Server  SUCCESS [11:19 
> min]
> [INFO] Lens client  SUCCESS [ 47.817 
> s]
> [INFO] Lens CLI ... SUCCESS [03:46 
> min]
> [INFO] Lens Examples .. SUCCESS [ 13.728 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 13.644 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:01 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.141 
> s]
> [INFO] Lens Regression  SUCCESS [ 18.077 
> s]
> [INFO] Lens UI  SUCCESS [ 47.318 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 34:02 min
> [INFO] Finished at: 2015-10-14T16:10:22+05:30
> [INFO] Final Memory: 216M/3029M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

Re: Review Request 39311: LENS-820: Add relative end time for facts

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39311/
---

(Updated Oct. 14, 2015, 5:08 p.m.)


Review request for lens.


Bugs: LENS-820
https://issues.apache.org/jira/browse/LENS-820


Repository: lens


Description (updated)
---

added property


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
a6cff417ee88b2ab3799e86d314b56035b7e304c 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39311/diff/


Testing (updated)
---

[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [2.519s]
[INFO] Lens .. SUCCESS [3.301s]
[INFO] Lens API .. SUCCESS [23.379s]
[INFO] Lens API for server and extensions  SUCCESS [21.752s]
[INFO] Lens Cube . SUCCESS [5:25.540s]
[INFO] Lens DB storage ... SUCCESS [19.670s]
[INFO] Lens Query Library  SUCCESS [15.986s]
[INFO] Lens Hive Driver .. SUCCESS [2:47.367s]
[INFO] Lens Driver for JDBC .. SUCCESS [35.821s]
[INFO] Lens Elastic Search Driver  SUCCESS [16.156s]
[INFO] Lens Server ... SUCCESS [8:05.578s]
[INFO] Lens client ... SUCCESS [36.839s]
[INFO] Lens CLI .. SUCCESS [2:34.421s]
[INFO] Lens Examples . SUCCESS [8.540s]
[INFO] Lens Distribution . SUCCESS [8.020s]
[INFO] Lens ML Lib ... SUCCESS [1:19.947s]
[INFO] Lens ML Ext Distribution .. SUCCESS [1.896s]
[INFO] Lens Regression ... SUCCESS [12.341s]
[INFO] Lens UI ... SUCCESS [26.619s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:06.662s
[INFO] Finished at: Wed Oct 14 11:27:13 UTC 2015
[INFO] Final Memory: 194M/2045M
[INFO] 


Thanks,

Rajat Khandelwal

[jira] [Created] (LENS-821) Filters with comma in IN filters not replacing table alias properly

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-821:
---

 Summary: Filters with comma in IN filters not replacing table 
alias properly
 Key: LENS-821
 URL: https://issues.apache.org/jira/browse/LENS-821
 Project: Apache Lens
  Issue Type: Bug
  Components: driver-jdbc
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty
 Fix For: 2.6


Cube queries with filters with comma in IN list for eg.  column IN ('test,123', 
'test,345') not replacing table alias in fact subquery properly.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-734) Query output files should have the query name

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-734:
-
Labels: incompatible  (was: )

> Query output files should have the query name
> -
>
> Key: LENS-734
> URL: https://issues.apache.org/jira/browse/LENS-734
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>  Labels: incompatible
> Fix For: 2.4
>
> Attachments: LENS-734.patch
>
>
> Query output persisted files generated post execution should have the query 
> name specified with the query. This will let users track the query outputs 
> better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-774) Unable to override "lens.server.session.expiry.service.interval.secs" because of spelling mistake

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-774:
-
Labels: incompatible  (was: )

> Unable to override "lens.server.session.expiry.service.interval.secs" because 
> of spelling mistake
> -
>
> Key: LENS-774
> URL: https://issues.apache.org/jira/browse/LENS-774
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Deepak Barr
>Assignee: Deepak Barr
>Priority: Minor
>  Labels: incompatible
> Fix For: 2.4
>
> Attachments: LENS-774.2.patch, LENS-774.patch
>
>
> Property String in LensConfConstants.java
> public static final String SESSION_EXPIRY_SERVICE_INTERVAL_IN_SECS = 
> SERVER_PFX
> + "session.expiry.serivce.interval.secs";
> Property in lensserver-default.xml
>  
> lens.server.session.expiry.service.interval.secs
> 3600
> Interval at which lens session expiry service 
> runs
>   



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-224) FinishedLensQuery is not storing selectedDriver

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-224:
-
Labels: incompatible  (was: )

> FinishedLensQuery is not storing selectedDriver
> ---
>
> Key: LENS-224
> URL: https://issues.apache.org/jira/browse/LENS-224
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Deepak Barr
>  Labels: incompatible
> Fix For: 2.4
>
> Attachments: LENS-224.patch
>
>
> FinishedLensQuery is not storing selectedDriver. Once the query is purged to 
> DB, the reconstructed query does not have selectedDriver.
> This makes missing information for user for knowing where the query ran.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39286: LENS-817 : No need to persist metadata class information in DB after LENS-576 fix

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39286/#review102729
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 13, 2015, 6:32 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39286/
> ---
> 
> (Updated Oct. 13, 2015, 6:32 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Removed the persistence of metadata class along with other references.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
>  8308198 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
> 8a2ac19 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  d57812f 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
> 708afe5 
> 
> Diff: https://reviews.apache.org/r/39286/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested the query status and resultset related APIs after the query is 
> purged to DB.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.592 
> s]
> [INFO] Lens ... SUCCESS [  3.872 
> s]
> [INFO] Lens API ... SUCCESS [ 28.298 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 27.500 
> s]
> [INFO] Lens Cube .. SUCCESS [07:04 
> min]
> [INFO] Lens DB storage  SUCCESS [ 26.356 
> s]
> [INFO] Lens Query Library . SUCCESS [ 22.843 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:13 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 50.457 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 21.378 
> s]
> [INFO] Lens Server  SUCCESS [10:52 
> min]
> [INFO] Lens client  SUCCESS [ 47.565 
> s]
> [INFO] Lens CLI ... SUCCESS [03:46 
> min]
> [INFO] Lens Examples .. SUCCESS [ 12.484 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.654 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:01 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.704 
> s]
> [INFO] Lens Regression  SUCCESS [ 18.117 
> s]
> [INFO] Lens UI  SUCCESS [ 46.465 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 33:24 min
> [INFO] Finished at: 2015-10-13T19:33:57+05:30
> [INFO] Final Memory: 206M/2383M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

[jira] [Commented] (LENS-807) Priority is not getting set in QueryContext. It's always NORMAL

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958112#comment-14958112
 ] 

Hudson commented on LENS-807:
-

UNSTABLE: Integrated in Lens-Commit-Java8 #17 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/17/])
LENS-807 : Set priority in query context after driver decides priority 
(amareshwari: rev 5741aee71c8aeff595db3cf7116ef51ea30c9a6e)
* 
lens-server-api/src/test/java/org/apache/lens/server/api/query/priority/MockQueryPriorityDecider.java
* 
lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java
* 
lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java
* lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
* lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java
* 
lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java
* 
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
* lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
* lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
* 
lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java
* 
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java


> Priority is not getting set in QueryContext. It's always NORMAL
> ---
>
> Key: LENS-807
> URL: https://issues.apache.org/jira/browse/LENS-807
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-807.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-753) Queue number for queries

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-753:
-
Component/s: server
 client
 api

> Queue number for queries
> 
>
> Key: LENS-753
> URL: https://issues.apache.org/jira/browse/LENS-753
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: api, client, server
>Reporter: Akshay Goyal
>Assignee: Akshay Goyal
> Fix For: 2.4
>
> Attachments: LENS-753.02.patch, LENS-753.03.patch, LENS-753.04.patch
>
>
> This is to add queue number for queries after they were launched, in order to 
> give users an idea of the sequence in which their queries were launched. Or 
> in other words, to give them an idea of how many queries were launched before 
> them which are still competing for resources with their query. 
> Giving queue numbers from waiting query collection may not be correct as they 
> are not consistent. When a candidate query is picked up from waiting state, 
> it is removed from the collection and checked for cost constraints. If it 
> fails the constraints, the query is added back to the waiting query 
> collection. This causes inconsistency in terms of indices of queries within 
> the collection. Because of this inconsistency, user might see their queue 
> number increasing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-807) Priority is not getting set in QueryContext. It's always NORMAL

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-807:
-
   Resolution: Fixed
Fix Version/s: 2.5
   Status: Resolved  (was: Patch Available)

Committed. Thanks [~prongs]

> Priority is not getting set in QueryContext. It's always NORMAL
> ---
>
> Key: LENS-807
> URL: https://issues.apache.org/jira/browse/LENS-807
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-807.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?
> 
> Gabor Liptak wrote:
> Rajat, what is the recommended way to reset this value? This key might or 
> might not exists, the getConnectionParam() returns a List and there 
> doesn't seem to be a method to delete a key ... Thanks

This config is removed now and the setting and unsetting here can be removed as 
well.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

[jira] [Updated] (LENS-815) query list api should have an option to filter by driver

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-815:
-
Component/s: server
 api
 Issue Type: Improvement  (was: Bug)

> query list api should have an option to filter by driver
> 
>
> Key: LENS-815
> URL: https://issues.apache.org/jira/browse/LENS-815
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: api, server
>Reporter: Rajat Khandelwal
>Assignee: Deepak Barr
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-814) Queued queries should be listed in order.

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-814:
-
Component/s: server
 Issue Type: Improvement  (was: Bug)

> Queued queries should be listed in order. 
> --
>
> Key: LENS-814
> URL: https://issues.apache.org/jira/browse/LENS-814
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-816) ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958120#comment-14958120
 ] 

Hudson commented on LENS-816:
-

UNSTABLE: Integrated in Lens-Commit #1108 (See 
[https://builds.apache.org/job/Lens-Commit/1108/])
LENS-816 : Fix ThreadSafeEstimatedQueryCollection methods not to ignore 
(amareshwari: rev 5a40ee60c152a5acb547aa69dc714f51c42777ff)
* 
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java
* 
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java


> ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries 
> and getQueryCount
> --
>
> Key: LENS-816
> URL: https://issues.apache.org/jira/browse/LENS-816
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>Priority: Critical
> Fix For: 2.4
>
> Attachments: LENS-816.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

> On Oct. 15, 2015, 12:41 a.m., Amareshwari Sriramadasu wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 207
> > 
> >
> > Can you reset hive.exec.driver.run.hooks to be empty string?

Can you also review the TODO in purgedFinishedResultSet()?


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102735
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

[jira] [Commented] (LENS-816) ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958152#comment-14958152
 ] 

Hudson commented on LENS-816:
-

SUCCESS: Integrated in Lens-Commit-Java8 #18 (See 
[https://builds.apache.org/job/Lens-Commit-Java8/18/])
LENS-816 : Fix ThreadSafeEstimatedQueryCollection methods not to ignore 
(amareshwari: rev 5a40ee60c152a5acb547aa69dc714f51c42777ff)
* 
lens-server/src/main/java/org/apache/lens/server/query/collect/ThreadSafeEstimatedQueryCollection.java
* 
lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java


> ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries 
> and getQueryCount
> --
>
> Key: LENS-816
> URL: https://issues.apache.org/jira/browse/LENS-816
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>Priority: Critical
> Fix For: 2.4
>
> Attachments: LENS-816.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-446) server params should not be passed to session and drivers

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-446:
-
Labels: incompatible  (was: )

> server params should not be passed to session and drivers
> -
>
> Key: LENS-446
> URL: https://issues.apache.org/jira/browse/LENS-446
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Angad Singh
>Assignee: Amareshwari Sriramadasu
>  Labels: incompatible
> Fix For: 2.4
>
> Attachments: LENS-446.patch
>
>
> Lens is even showing sensitive properties like lens.server.db.jdbc.user and 
> lens.server.db.jdbc.pass to the client. Server-side params should be hidden 
> from this api
> api called:
> {noformat}
> http://internal-lens-server:/lensapi/session/params?sessionid=%3C?xml+version%3D%221.0%22+encoding%3D%22UTF-8%22+standalone%3D%22yes%22?%3E%3ClensSessionHandle%3E%3CpublicId%3E1ebec3a5-cd11-4a3d-b9d5-79e5d9707710%3C/publicId%3E%3CsecretId%3E524384d8-41c5-4459-87be-37fdde4ba14f%3C/secretId%3E%3C/lensSessionHandle%3E
> {noformat}
> sample output:
> {noformat}
> 
> hive.metastore.batch.retrieve.max=100
> 
> hive.metastore.batch.retrieve.table.partition.max=500
> 
> hive.metastore.client.connect.retry.delay=1
> hive.metastore.client.socket.timeout=20
> hive.metastore.connect.retries=5
> hive.metastore.failure.retries=3
> hive.metastore.uris=thrift://localhost:9083
> hive.server2.thrift.bind.host=localhost
> hive.server2.thrift.port=1
> lens.client.dbname=default
> lens.client.user.name=anonymous
> lens.cube.query.disable.aggregate.resolver=false
> lens.cube.query.disable.auto.join=false
> lens.cube.query.fail.if.data.partial=true
> lens.cube.query.promote.select.togroupby=true
> lens.query.add.insert.overwrite=true
> lens.query.enable.mail.notify=false
> lens.query.enable.metrics.per.query=false
> lens.query.enable.persistent.resultset=false
> 
> lens.query.enable.persistent.resultset.indriver=true
> 
> lens.query.hdfs.output.path=hdfsout
> lens.query.output.charset.encoding=UTF-8
> 
> lens.query.output.compression.codec=org.apache.hadoop.io.compress.GzipCodec
> 
> lens.query.output.enable.compression=false
> lens.query.output.file.extn=.csv
> lens.query.output.write.footer=false
> lens.query.output.write.header=false
> 
> lens.query.result.output.serde=org.apache.lens.lib.query.CSVSerde
> 
> 
> lens.query.result.parent.dir=file:///tmp/lensreports
> 
> 
> lens.query.result.size.format.threshold=10737418240
> 
> lens.query.result.split.multiple=false
> lens.query.result.split.multiple.maxrows=10
> lens.server.base.url=http://0.0.0.0:/lensapi
> lens.server.db.driver.name=com.mysql.jdbc.Driver
> lens.server.db.jdbc.pass={masked}
> 
> lens.server.db.jdbc.url=jdbc:mysql://localhost:3306/lens
> 
> lens.server.db.jdbc.user={masked}
> lens.server.db.validation.query=select 1
> 
> lens.server.drivers=org.apache.lens.driver.hive.HiveDriver
> 
> 
> lens.session.aux.jars={masked}
> 
> lens.session.cluster.user={masked}
> lens.session.loggedin.user=anonymous
> silent=off
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-693) Queries get purged to DB as soon as they finish

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-693:
-
Labels: incompatible  (was: )

> Queries get purged to DB as soon as they finish
> ---
>
> Key: LENS-693
> URL: https://issues.apache.org/jira/browse/LENS-693
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 2.0
>Reporter: Arshad Matin
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Fix For: 2.4
>
> Attachments: LENS-693.04.patch, LENS-693.12.patch
>
>
> Query Result Mail is not working when finished queries is set to zero as the 
> queries are immediately going to the DB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-737) Throw single error out with LensMultiException

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-737:
-
Labels: incompatible  (was: )

> Throw single error out with LensMultiException
> --
>
> Key: LENS-737
> URL: https://issues.apache.org/jira/browse/LENS-737
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: api, cube
>Reporter: Amareshwari Sriramadasu
>Assignee: Sushil Mohanty
>  Labels: incompatible
> Fix For: 2.4
>
> Attachments: LENS-737-5.patch, LENS-737-6.patch, LENS-737-7.patch
>
>
> Right now, when two drivers give two different errors, it results in Internal 
> server error with LensMultiCauseException. It should compare both errors and 
> give out one error for the end user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-341) Lens is not building against on JAVA-8

[Amareshwari Sriramadasu (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958027#comment-14958027
 ] 

Amareshwari Sriramadasu commented on LENS-341:
--

[~raju.bairishetti], Can you update docs relating to mention of build fails on 
java8? 

Moved making build fail on javadoc warnings/errors as a separate issue. After 
updating docs we should be good to resolve this.

> Lens is not building against on JAVA-8
> --
>
> Key: LENS-341
> URL: https://issues.apache.org/jira/browse/LENS-341
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: build
>Reporter: Raju Bairishetti
>Assignee: Raju Bairishetti
>Priority: Critical
> Fix For: 2.4
>
>
> Right now, lens is successfully compiled with *java6*. But it is failing with 
> *java8*.
> *Error stack trace*
> {noformat}
> [ERROR] Failed to execute goal 
> org.codehaus.enunciate:maven-enunciate-plugin:1.28:docs (default) on project 
> lens-server: Execution default of goal 
> org.codehaus.enunciate:maven-enunciate-plugin:1.28:docs failed: A required 
> class was missing while executing 
> org.codehaus.enunciate:maven-enunciate-plugin:1.28:docs: 
> com/sun/mirror/apt/AnnotationProcessorFactory
> [ERROR] -
> [ERROR] realm =plugin>org.codehaus.enunciate:maven-enunciate-plugin:1.28
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/enunciate/maven-enunciate-plugin/1.28/maven-enunciate-plugin-1.28.jar
> [ERROR] urls[1] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/enunciate/maven-enunciate-slim-plugin/1.28/maven-enunciate-slim-plugin-1.28.jar
> [ERROR] urls[2] = 
> file:/Users/raju.bairishetti/.m2/repository/org/apache/maven/plugins/maven-install-plugin/2.3.1/maven-install-plugin-2.3.1.jar
> [ERROR] urls[3] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/plexus/plexus-digest/1.0/plexus-digest-1.0.jar
> [ERROR] urls[4] = 
> file:/Users/raju.bairishetti/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/2.7/maven-deploy-plugin-2.7.jar
> [ERROR] urls[5] = 
> file:/Users/raju.bairishetti/.m2/repository/org/apache/maven/enforcer/enforcer-api/1.0/enforcer-api-1.0.jar
> [ERROR] urls[6] = 
> file:/Users/raju.bairishetti/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar
> [ERROR] urls[7] = 
> file:/Users/raju.bairishetti/.m2/repository/org/apache/maven/shared/maven-filtering/1.0/maven-filtering-1.0.jar
> [ERROR] urls[8] = 
> file:/Users/raju.bairishetti/.m2/repository/org/apache/maven/reporting/maven-reporting-api/2.0.6/maven-reporting-api-2.0.6.jar
> [ERROR] urls[9] = 
> file:/Users/raju.bairishetti/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.0-alpha-7/doxia-sink-api-1.0-alpha-7.jar
> [ERROR] urls[10] = 
> file:/Users/raju.bairishetti/.m2/repository/commons-cli/commons-cli/1.0/commons-cli-1.0.jar
> [ERROR] urls[11] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-4/plexus-interactivity-api-1.0-alpha-4.jar
> [ERROR] urls[12] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.12/plexus-interpolation-1.12.jar
> [ERROR] urls[13] = 
> file:/Users/raju.bairishetti/.m2/repository/org/sonatype/plexus/plexus-build-api/0.0.4/plexus-build-api-0.0.4.jar
> [ERROR] urls[14] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/plexus/plexus-utils/3.0/plexus-utils-3.0.jar
> [ERROR] urls[15] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/enunciate/enunciate-core/1.28/enunciate-core-1.28.jar
> [ERROR] urls[16] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/enunciate/enunciate-core-rt/1.28/enunciate-core-rt-1.28.jar
> [ERROR] urls[17] = 
> file:/Users/raju.bairishetti/.m2/repository/org/codehaus/enunciate/enunciate-core-annotations/1.28/enunciate-core-annotations-1.28.jar
> [ERROR] urls[18] = 
> file:/Users/raju.bairishetti/.m2/repository/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar
> [ERROR] urls[19] = 
> file:/Users/raju.bairishetti/.m2/repository/javax/ws/rs/jsr311-api/1.1.1/jsr311-api-1.1.1.jar
> [ERROR] urls[20] = 
> file:/Users/raju.bairishetti/.m2/repository/javax/servlet/servlet-api/2.3/servlet-api-2.3.jar
> [ERROR] urls[21] = 
> file:/Users/raju.bairishetti/.m2/repository/org/freemarker/freemarker/2.3.19/freemarker-2.3.19.jar
> [ERROR] urls[22] = 
> file:/Users/raju.bairishetti/.m2/repository/net/sf/apt-jelly/apt-jelly-freemarker/2.15/apt-jelly-freemarker-2.15.jar
> [ERROR] urls[23] = 
> file:/Users/raju.bairishetti/.m2/repository/net/sf/apt-jelly/apt-jelly-core/2.15/apt-jelly-core-2.15.jar
> [ERROR] urls[24] = 
> 

[jira] [Updated] (LENS-817) No need to persist metadata class information in DB after LENS-576 fix

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-817:
-
 Labels: incompatible  (was: )
Component/s: server

> No need to persist metadata class information in DB after LENS-576 fix
> --
>
> Key: LENS-817
> URL: https://issues.apache.org/jira/browse/LENS-817
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Deepak Barr
>Assignee: Deepak Barr
>Priority: Minor
>  Labels: incompatible
>
> Metadata class information is written to DB but no where used. This is 
> information is no longer required because after LENS-576, the class 
> information is stored in metadata column itself. E.g. 
> {  
>"@class":"org.apache.lens.driver.hive.HiveResultSetMetadata",
>"columns":[  
>   {  
>  "name":"test_data.name",
>  "comment":null,
>  "position":1,
>  "type":"STRING"
>   },
>   {  
>  "name":"test_data.country",
>  "comment":null,
>  "position":2,
>  "type":"STRING"
>   }
>]
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?

Rajat, what is the recommended way to reset this value? This key might or might 
not exists, the getConnectionParam() returns a List and there doesn't 
seem to be a method to delete a key ... Thanks


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102735
---



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 183)


Can you reset hive.exec.driver.run.hooks to be empty string?


- Amareshwari Sriramadasu


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Re: Review Request 39311: LENS-820: Add relative end time for facts

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39311/#review102736
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 14, 2015, 11:38 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39311/
> ---
> 
> (Updated Oct. 14, 2015, 11:38 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-820
> https://issues.apache.org/jira/browse/LENS-820
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> added property
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> a6cff417ee88b2ab3799e86d314b56035b7e304c 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
> da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39311/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [2.519s]
> [INFO] Lens .. SUCCESS [3.301s]
> [INFO] Lens API .. SUCCESS [23.379s]
> [INFO] Lens API for server and extensions  SUCCESS [21.752s]
> [INFO] Lens Cube . SUCCESS [5:25.540s]
> [INFO] Lens DB storage ... SUCCESS [19.670s]
> [INFO] Lens Query Library  SUCCESS [15.986s]
> [INFO] Lens Hive Driver .. SUCCESS [2:47.367s]
> [INFO] Lens Driver for JDBC .. SUCCESS [35.821s]
> [INFO] Lens Elastic Search Driver  SUCCESS [16.156s]
> [INFO] Lens Server ... SUCCESS [8:05.578s]
> [INFO] Lens client ... SUCCESS [36.839s]
> [INFO] Lens CLI .. SUCCESS [2:34.421s]
> [INFO] Lens Examples . SUCCESS [8.540s]
> [INFO] Lens Distribution . SUCCESS [8.020s]
> [INFO] Lens ML Lib ... SUCCESS [1:19.947s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [1.896s]
> [INFO] Lens Regression ... SUCCESS [12.341s]
> [INFO] Lens UI ... SUCCESS [26.619s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:06.662s
> [INFO] Finished at: Wed Oct 14 11:27:13 UTC 2015
> [INFO] Final Memory: 194M/2045M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Updated] (LENS-814) Queued queries should be listed in order.

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-814:
-
Labels: newbie  (was: )

> Queued queries should be listed in order. 
> --
>
> Key: LENS-814
> URL: https://issues.apache.org/jira/browse/LENS-814
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>Reporter: Rajat Khandelwal
>  Labels: newbie
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Gabor Liptak]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?
> 
> Gabor Liptak wrote:
> Rajat, what is the recommended way to reset this value? This key might or 
> might not exists, the getConnectionParam() returns a List and there 
> doesn't seem to be a method to delete a key ... Thanks
> 
> Amareshwari Sriramadasu wrote:
> This config is removed now and the setting and unsetting here can be 
> removed as well.

Removed as in I should delete both set/TODO lines?


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 14, 2015, 1:30 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

Review Request 39315: LENS-821:Filters with comma in IN filters not replacing table alias properly

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39315/
---

Review request for lens.


Bugs: LENS-821
https://issues.apache.org/jira/browse/LENS-821


Repository: lens


Description
---

Cube queries with filters with comma in IN list for eg. column IN ('test,123', 
'test,345') not replacing table alias in fact subquery properly.


Diffs
-

  
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
 295b476 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
 db09a4b 

Diff: https://reviews.apache.org/r/39315/diff/


Testing
---

Added unit test for the fix. mvn clean install is working fine.


[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules . SUCCESS [19.350s]
[INFO] Lens .. SUCCESS [23.089s]
[INFO] Lens API .. SUCCESS [45.152s]
[INFO] Lens API for server and extensions  SUCCESS [42.298s]
[INFO] Lens Cube . SUCCESS [7:22.998s]
[INFO] Lens DB storage ... SUCCESS [33.203s]
[INFO] Lens Query Library  SUCCESS [26.143s]
[INFO] Lens Hive Driver .. SUCCESS [4:23.919s]
[INFO] Lens Driver for JDBC .. SUCCESS [1:07.686s]
[INFO] Lens Elastic Search Driver  SUCCESS [31.795s]
[INFO] Lens Server ... SUCCESS [19:26.345s]
[INFO] Lens client ... SUCCESS [1:02.367s]
[INFO] Lens CLI .. SUCCESS [8:22.527s]
[INFO] Lens Examples . SUCCESS [32.166s]
[INFO] Lens Distribution . SUCCESS [32.780s]
[INFO] Lens ML Lib ... SUCCESS [4:02.491s]
[INFO] Lens ML Ext Distribution .. SUCCESS [13.711s]
[INFO] Lens Regression ... SUCCESS [23.502s]
[INFO] Lens UI ... SUCCESS [16.484s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 51:29.337s
[INFO] Finished at: Wed Oct 14 17:41:05 IST 2015
[INFO] Final Memory: 196M/1665M


Thanks,

Sushil Mohanty

Re: Review Request 39315: LENS-821:Filters with comma in IN filters not replacing table alias properly

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39315/#review102611
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Oct. 14, 2015, 12:11 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39315/
> ---
> 
> (Updated Oct. 14, 2015, 12:11 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-821
> https://issues.apache.org/jira/browse/LENS-821
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Cube queries with filters with comma in IN list for eg. column IN 
> ('test,123', 'test,345') not replacing table alias in fact subquery properly.
> 
> 
> Diffs
> -
> 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
>  295b476 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
>  db09a4b 
> 
> Diff: https://reviews.apache.org/r/39315/diff/
> 
> 
> Testing
> ---
> 
> Added unit test for the fix. mvn clean install is working fine.
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules . SUCCESS [19.350s]
> [INFO] Lens .. SUCCESS [23.089s]
> [INFO] Lens API .. SUCCESS [45.152s]
> [INFO] Lens API for server and extensions  SUCCESS [42.298s]
> [INFO] Lens Cube . SUCCESS [7:22.998s]
> [INFO] Lens DB storage ... SUCCESS [33.203s]
> [INFO] Lens Query Library  SUCCESS [26.143s]
> [INFO] Lens Hive Driver .. SUCCESS [4:23.919s]
> [INFO] Lens Driver for JDBC .. SUCCESS [1:07.686s]
> [INFO] Lens Elastic Search Driver  SUCCESS [31.795s]
> [INFO] Lens Server ... SUCCESS 
> [19:26.345s]
> [INFO] Lens client ... SUCCESS [1:02.367s]
> [INFO] Lens CLI .. SUCCESS [8:22.527s]
> [INFO] Lens Examples . SUCCESS [32.166s]
> [INFO] Lens Distribution . SUCCESS [32.780s]
> [INFO] Lens ML Lib ... SUCCESS [4:02.491s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [13.711s]
> [INFO] Lens Regression ... SUCCESS [23.502s]
> [INFO] Lens UI ... SUCCESS [16.484s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 51:29.337s
> [INFO] Finished at: Wed Oct 14 17:41:05 IST 2015
> [INFO] Final Memory: 196M/1665M
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Re: Review Request 39314: LENS-815 : Query list api should have an option to filter by driver

[Deepak Barr]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39314/
---

(Updated Oct. 14, 2015, 1:36 p.m.)


Review request for lens.


Changes
---

The filter will check whether the driverClass contains the query input.


Bugs: LENS-815
https://issues.apache.org/jira/browse/LENS-815


Repository: lens


Description
---

Added the ability in query list API to filter the queries on driver class.


Diffs (updated)
-

  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 724e36a 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
8a2ac19 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 d57812f 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
 96f6aea 
  
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 
17022aa 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
708afe5 

Diff: https://reviews.apache.org/r/39314/diff/


Testing
---

Yes. Tested the API with driver parameter.

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .. SUCCESS [  3.460 s]
[INFO] Lens ... SUCCESS [  4.422 s]
[INFO] Lens API ... SUCCESS [ 30.327 s]
[INFO] Lens API for server and extensions . SUCCESS [ 27.110 s]
[INFO] Lens Cube .. SUCCESS [07:13 min]
[INFO] Lens DB storage  SUCCESS [ 28.907 s]
[INFO] Lens Query Library . SUCCESS [ 21.291 s]
[INFO] Lens Hive Driver ... SUCCESS [04:09 min]
[INFO] Lens Driver for JDBC ... SUCCESS [ 50.378 s]
[INFO] Lens Elastic Search Driver . SUCCESS [ 21.401 s]
[INFO] Lens Server  SUCCESS [11:19 min]
[INFO] Lens client  SUCCESS [ 47.817 s]
[INFO] Lens CLI ... SUCCESS [03:46 min]
[INFO] Lens Examples .. SUCCESS [ 13.728 s]
[INFO] Lens Distribution .. SUCCESS [ 13.644 s]
[INFO] Lens ML Lib  SUCCESS [02:01 min]
[INFO] Lens ML Ext Distribution ... SUCCESS [  3.141 s]
[INFO] Lens Regression  SUCCESS [ 18.077 s]
[INFO] Lens UI  SUCCESS [ 47.318 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 34:02 min
[INFO] Finished at: 2015-10-14T16:10:22+05:30
[INFO] Final Memory: 216M/3029M
[INFO] 


Thanks,

Deepak Barr

Re: Review Request 39314: LENS-815 : Query list api should have an option to filter by driver

[Rajat Khandelwal]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39314/#review102631
---



lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
 (line 231)


Add driver param in the doc.



lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 
161)


doc update



lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
(lines 194 - 195)


`lower(%driverClass%)` doesn't seem valid. Can you do a quick check and 
verify ? A test case should be enough.



lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
 (line 144)


add param here.



lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
 (line 257)


add param here.



lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 
(line 109)


param update


- Rajat Khandelwal


On Oct. 14, 2015, 7:06 p.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39314/
> ---
> 
> (Updated Oct. 14, 2015, 7:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-815
> https://issues.apache.org/jira/browse/LENS-815
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added the ability in query list API to filter the queries on driver class.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
>  724e36a 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
> 8a2ac19 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  d57812f 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
>  96f6aea 
>   
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java
>  17022aa 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
> 708afe5 
> 
> Diff: https://reviews.apache.org/r/39314/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested the API with driver parameter.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  3.460 
> s]
> [INFO] Lens ... SUCCESS [  4.422 
> s]
> [INFO] Lens API ... SUCCESS [ 30.327 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 27.110 
> s]
> [INFO] Lens Cube .. SUCCESS [07:13 
> min]
> [INFO] Lens DB storage  SUCCESS [ 28.907 
> s]
> [INFO] Lens Query Library . SUCCESS [ 21.291 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:09 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 50.378 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 21.401 
> s]
> [INFO] Lens Server  SUCCESS [11:19 
> min]
> [INFO] Lens client  SUCCESS [ 47.817 
> s]
> [INFO] Lens CLI ... SUCCESS [03:46 
> min]
> [INFO] Lens Examples .. SUCCESS [ 13.728 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 13.644 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:01 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.141 
> s]
> [INFO] Lens Regression  SUCCESS [ 18.077 
> s]
> [INFO] Lens UI  SUCCESS [ 47.318 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 34:02 min
> [INFO] Finished at: 2015-10-14T16:10:22+05:30
> [INFO] Final Memory: 216M/3029M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

[jira] [Created] (LENS-823) Fetching already fetched inmemory result set should not give 500

[Amareshwari Sriramadasu (JIRA)]

Amareshwari Sriramadasu created LENS-823:


 Summary: Fetching already fetched inmemory result set should not 
give 500
 Key: LENS-823
 URL: https://issues.apache.org/jira/browse/LENS-823
 Project: Apache Lens
  Issue Type: Improvement
  Components: server
Reporter: Amareshwari Sriramadasu
Priority: Minor
 Fix For: 2.5


It fails with following exception right now :
{noformat}
15 Oct 2015 04:22:35 [90ca229a-7526-4a55-8f2b-fff2805fc45c] 
[Grizzly-worker(43)] WARN  org.glassfish.jersey.server.ServerRuntime$Responder 
- WebApplicationException cause:
org.apache.lens.server.api.error.LensException: INTERNAL_SERVER_ERROR
at 
org.apache.lens.driver.jdbc.JDBCResultSet.hasNext(JDBCResultSet.java:323) 
~[lens-driver-jdbc-2.4.1-inm-breakfix2.jar:2.4.1-inm-breakfix2]
at 
org.apache.lens.server.api.driver.InMemoryResultSet.toQueryResult(InMemoryResultSet.java:80)
 ~[lens-server-api-2.4.1-inm-breakfix2.jar:2.4.1-inm-breakfix2]
at 
org.apache.lens.server.api.driver.InMemoryResultSet.toQueryResult(InMemoryResultSet.java:33)
 ~[lens-server-api-2.4.1-inm-breakfix2.jar:2.4.1-inm-breakfix2]
at 
org.apache.lens.server.query.QueryExecutionServiceImpl.fetchResultSet(QueryExecutionServiceImpl.java:2016)
 ~[classes/:na]
at 
org.apache.lens.server.query.QueryServiceResource.getResultSet(QueryServiceResource.java:723)
 ~[classes/:na]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
~[na:1.7.0_67]
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
~[na:1.7.0_67]
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 ~[na:1.7.0_67]
at java.lang.reflect.Method.invoke(Method.java:606) ~[na:1.7.0_67]
at 
org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
 ~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:151)
 ~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:171)
 ~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$TypeOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:195)
 ~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:104)
 ~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:353)
 ~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:343)
 ~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:102)
 ~[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:255) 
~[jersey-server-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors$1.call(Errors.java:271) 
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors$1.call(Errors.java:267) 
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors.process(Errors.java:315) 
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors.process(Errors.java:297) 
[jersey-common-2.3.1.jar:na]
at org.glassfish.jersey.internal.Errors.process(Errors.java:267) 
[jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:318)
 [jersey-common-2.3.1.jar:na]
at 
org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:235) 
[jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:983)
 [jersey-server-2.3.1.jar:na]
at 
org.glassfish.jersey.grizzly2.httpserver.GrizzlyHttpContainer.service(GrizzlyHttpContainer.java:330)
 [jersey-container-grizzly2-http-2.3.1.jar:na]
at 
org.glassfish.grizzly.http.server.HttpHandler$1.run(HttpHandler.java:212) 
[grizzly-http-server-2.3.6.jar:2.3.6]
at 
org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.doWork(AbstractThreadPool.java:565)
 [grizzly-framework-2.3.6.jar:2.3.6]
at 
org.glassfish.grizzly.threadpool.AbstractThreadPool$Worker.run(AbstractThreadPool.java:545)
 [grizzly-framework-2.3.6.jar:2.3.6]
at java.lang.Thread.run(Thread.java:745) [na:1.7.0_67]
Caused by: java.sql.SQLException: You can't operate on a closed ResultSet!!!
at 

[jira] [Updated] (LENS-808) Test Failures in jenkins

[Raju Bairishetti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raju Bairishetti updated LENS-808:
--
Fix Version/s: (was: 2.4)
   2.5

> Test Failures in jenkins
> 
>
> Key: LENS-808
> URL: https://issues.apache.org/jira/browse/LENS-808
> Project: Apache Lens
>  Issue Type: Bug
>  Components: build, test
>Reporter: Raju Bairishetti
>Priority: Blocker
> Fix For: 2.5
>
>
> We are seeing test failures on jenkins. 
> https://builds.apache.org/job/Lens-Commit/1103/#showFailuresLink



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-620) Add profile for code coverage report

[Raju Bairishetti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raju Bairishetti updated LENS-620:
--
Fix Version/s: (was: 2.4)
   2.5

> Add profile for code coverage report
> 
>
> Key: LENS-620
> URL: https://issues.apache.org/jira/browse/LENS-620
> Project: Apache Lens
>  Issue Type: Task
>  Components: build, test
>Reporter: Arshad Matin
>Assignee: Arshad Matin
> Fix For: 2.5
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-804) Verify Lens 2.4 issues

[Raju Bairishetti (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958290#comment-14958290
 ] 

Raju Bairishetti commented on LENS-804:
---

@Arshad, can you share the status of this task?

> Verify Lens 2.4 issues
> --
>
> Key: LENS-804
> URL: https://issues.apache.org/jira/browse/LENS-804
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>Reporter: Raju Bairishetti
>Assignee: Arshad Matin
> Fix For: 2.4
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-824) Fix all javadoc warnings/errors

[Raju Bairishetti (JIRA)]

Raju Bairishetti created LENS-824:
-

 Summary: Fix all javadoc warnings/errors
 Key: LENS-824
 URL: https://issues.apache.org/jira/browse/LENS-824
 Project: Apache Lens
  Issue Type: Task
  Components: build
Reporter: Raju Bairishetti
 Fix For: 2.5


Creating this jira to find and fix the javadoc warnings and errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-825) Result formatting failure should not be INTERNAL_SERVER_ERROR

[Amareshwari Sriramadasu (JIRA)]

Amareshwari Sriramadasu created LENS-825:


 Summary: Result formatting failure should not be 
INTERNAL_SERVER_ERROR
 Key: LENS-825
 URL: https://issues.apache.org/jira/browse/LENS-825
 Project: Apache Lens
  Issue Type: Bug
  Components: server
Reporter: Amareshwari Sriramadasu
 Fix For: 2.5


We have seen the following :

{noformat}
15 Oct 2015 04:23:25 [13eb7ad2-b204-4d94-9c7c-8aa69caa1014] 
[event_processor_thread] WARN  org.apache.lens.server.query.ResultFormatter - 
Exception while formatting result for 13eb7ad2-b204-4d94-9c7c-8aa69caa1014
org.apache.lens.server.api.error.LensException: INTERNAL_SERVER_ERROR
at 
org.apache.lens.driver.jdbc.JDBCResultSet.next(JDBCResultSet.java:293) 
~[lens-driver-jdbc-2.4.1-inm-breakfix2.jar:2.4.1-inm-breakfix2]
at 
org.apache.lens.server.query.ResultFormatter.formatOutput(ResultFormatter.java:120)
 [classes/:na]
at 
org.apache.lens.server.query.ResultFormatter.process(ResultFormatter.java:68) 
[classes/:na]
at 
org.apache.lens.server.query.ResultFormatter.process(ResultFormatter.java:43) 
[classes/:na]
at 
org.apache.lens.server.api.events.AsyncEventListener$2.run(AsyncEventListener.java:101)
 [lens-server-api-2.4.1-inm-breakfix2.jar:2.4.1-inm-breakfix2]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) 
[na:1.7.0_67]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) 
[na:1.7.0_67]
at java.lang.Thread.run(Thread.java:745) [na:1.7.0_67]
Caused by: java.sql.SQLException:
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-822) Test are failing intermittently on jenkins

[Raju Bairishetti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raju Bairishetti updated LENS-822:
--
Summary: Test are failing  intermittently on jenkins  (was: Test failures 
intermittently on jenkins)

> Test are failing  intermittently on jenkins
> ---
>
> Key: LENS-822
> URL: https://issues.apache.org/jira/browse/LENS-822
> Project: Apache Lens
>  Issue Type: Bug
>  Components: build, test
>Reporter: Raju Bairishetti
>
> [https://builds.apache.org/job/Lens-Commit/1108/
> {noformat}
> Error Message
> expected [true] but found [false]
> Stacktrace
> java.lang.AssertionError: expected [true] but found [false]
>   at org.testng.Assert.fail(Assert.java:94)
>   at org.testng.Assert.failNotEquals(Assert.java:494)
>   at org.testng.Assert.assertTrue(Assert.java:42)
>   at org.testng.Assert.assertTrue(Assert.java:52)
>   at 
> org.apache.lens.cube.parse.TestCubeRewriter.compareContains(TestCubeRewriter.java:315)
>   at 
> org.apache.lens.cube.parse.TestCubeRewriter.testCubeWhereQueryWithMultipleTables(TestCubeRewriter.java:456)
> Standard Output
> HQL:SELECT sum(( testcube . msr2 )) FROM TestQueryRewrite.c1_testfact 
> testcube WHERE ( testcube . dt ) =  '2015-10-13' ) or (( testcube . dt ) 
> =  '2015-10-14' 
> Expected1 : select sum(testcube.msr2) FROM TestQueryRewrite.c1_testfact 
> testCube WHERE ((testCube.dt = '2015-10-13') OR (testCube.dt = '2015-10-14'))
> Expected2 : select sum(testcube.msr2) FROM TestQueryRewrite.c2_testfact 
> testCube WHERE ()
> Standard Error
> __FAILED__ testCubeWhereQueryWithMultipleTables:456
>   Expected: select sum(testcube.msr2) FROM TestQueryRewrite.c2_testfact 
> testCube WHERE ()
>   -
>   Actual: SELECT sum(( testcube . msr2 )) FROM 
> TestQueryRewrite.c1_testfact testcube WHERE ( testcube . dt ) =  
> '2015-10-13' ) or (( testcube . dt ) =  '2015-10-14' 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-822) Test failures intermittently on jenkins

[Raju Bairishetti (JIRA)]

Raju Bairishetti created LENS-822:
-

 Summary: Test failures intermittently on jenkins
 Key: LENS-822
 URL: https://issues.apache.org/jira/browse/LENS-822
 Project: Apache Lens
  Issue Type: Bug
  Components: build, test
Reporter: Raju Bairishetti


[https://builds.apache.org/job/Lens-Commit/1108/

{noformat}
Error Message

expected [true] but found [false]
Stacktrace

java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:494)
at org.testng.Assert.assertTrue(Assert.java:42)
at org.testng.Assert.assertTrue(Assert.java:52)
at 
org.apache.lens.cube.parse.TestCubeRewriter.compareContains(TestCubeRewriter.java:315)
at 
org.apache.lens.cube.parse.TestCubeRewriter.testCubeWhereQueryWithMultipleTables(TestCubeRewriter.java:456)
Standard Output

HQL:SELECT sum(( testcube . msr2 )) FROM TestQueryRewrite.c1_testfact testcube 
WHERE ( testcube . dt ) =  '2015-10-13' ) or (( testcube . dt ) =  
'2015-10-14' 
Expected1 : select sum(testcube.msr2) FROM TestQueryRewrite.c1_testfact 
testCube WHERE ((testCube.dt = '2015-10-13') OR (testCube.dt = '2015-10-14'))
Expected2 : select sum(testcube.msr2) FROM TestQueryRewrite.c2_testfact 
testCube WHERE ()
Standard Error

__FAILED__ testCubeWhereQueryWithMultipleTables:456
Expected: select sum(testcube.msr2) FROM TestQueryRewrite.c2_testfact 
testCube WHERE ()
-
Actual: SELECT sum(( testcube . msr2 )) FROM 
TestQueryRewrite.c1_testfact testcube WHERE ( testcube . dt ) =  
'2015-10-13' ) or (( testcube . dt ) =  '2015-10-14' 
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-816) ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-816:
-
   Resolution: Fixed
Fix Version/s: 2.4
   Status: Resolved  (was: Patch Available)

Committed this to both master and current-release-line, as the bug is critical.

> ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries 
> and getQueryCount
> --
>
> Key: LENS-816
> URL: https://issues.apache.org/jira/browse/LENS-816
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.4
>
> Attachments: LENS-816.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-816) ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-816:
-
Component/s: server

> ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries 
> and getQueryCount
> --
>
> Key: LENS-816
> URL: https://issues.apache.org/jira/browse/LENS-816
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>Priority: Critical
> Fix For: 2.4
>
> Attachments: LENS-816.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-816) ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

[Amareshwari Sriramadasu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amareshwari Sriramadasu updated LENS-816:
-
Priority: Critical  (was: Major)

> ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries 
> and getQueryCount
> --
>
> Key: LENS-816
> URL: https://issues.apache.org/jira/browse/LENS-816
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>Priority: Critical
> Fix For: 2.4
>
> Attachments: LENS-816.02.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39161: LENS-292 : Query result retention policy

[Amareshwari Sriramadasu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39161/#review102732
---



lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(line 958)


Can you name config to reflect the time unit as well ?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 1134)


Shutdown the executor in stop ?



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 40)


Please add a unit test for the purger.



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 49)


make it final



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(lines 62 - 63)


Can these moved to init?



lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
(line 75)


Can we have a different retention for hdfs output path? Once the result is 
formatted and pesristed by server, hdfs outputs can be purged earlier than 
final results.



lens-server/src/main/resources/lensserver-default.xml (line 288)


Can you update apt files as well?


- Amareshwari Sriramadasu


On Oct. 13, 2015, 11:48 a.m., Deepak Barr wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39161/
> ---
> 
> (Updated Oct. 13, 2015, 11:48 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-292
> https://issues.apache.org/jira/browse/LENS-292
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Added query result purge policy on both Driver persisted and Lens persisted 
> resultset. Default retention of 1 day. Purging can be turned off with a 
> setting.
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  f202603 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  73179e1 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java 
> PRE-CREATION 
>   lens-server/src/main/resources/lensserver-default.xml 1e6bd10 
> 
> Diff: https://reviews.apache.org/r/39161/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .. SUCCESS [  2.785 
> s]
> [INFO] Lens ... SUCCESS [  5.339 
> s]
> [INFO] Lens API ... SUCCESS [ 28.950 
> s]
> [INFO] Lens API for server and extensions . SUCCESS [ 28.187 
> s]
> [INFO] Lens Cube .. SUCCESS [07:05 
> min]
> [INFO] Lens DB storage  SUCCESS [ 28.169 
> s]
> [INFO] Lens Query Library . SUCCESS [ 22.031 
> s]
> [INFO] Lens Hive Driver ... SUCCESS [04:13 
> min]
> [INFO] Lens Driver for JDBC ... SUCCESS [ 49.452 
> s]
> [INFO] Lens Elastic Search Driver . SUCCESS [ 22.865 
> s]
> [INFO] Lens Server  SUCCESS [10:58 
> min]
> [INFO] Lens client  SUCCESS [ 47.198 
> s]
> [INFO] Lens CLI ... SUCCESS [03:44 
> min]
> [INFO] Lens Examples .. SUCCESS [ 11.516 
> s]
> [INFO] Lens Distribution .. SUCCESS [ 12.779 
> s]
> [INFO] Lens ML Lib  SUCCESS [02:00 
> min]
> [INFO] Lens ML Ext Distribution ... SUCCESS [  3.212 
> s]
> [INFO] Lens Regression  SUCCESS [ 15.624 
> s]
> [INFO] Lens UI  SUCCESS [  3.415 
> s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 32:45 min
> [INFO] Finished at: 2015-10-07T23:19:44+05:30
> [INFO] Final Memory: 218M/2795M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Deepak Barr
> 
>

[jira] [Commented] (LENS-635) Fail build for javadoc warnings/errors on java7 as well

[Raju Bairishetti (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958306#comment-14958306
 ] 

Raju Bairishetti commented on LENS-635:
---

Moving this out from 2.4 to 2.5. We need to fix all the warnings and errors 
before enforcing this constraint. Created a separate jira 
[LENS-824|https://issues.apache.org/jira/browse/LENS-824] to fix the javadoc 
warnings and errors.

> Fail build for javadoc warnings/errors on java7 as well
> ---
>
> Key: LENS-635
> URL: https://issues.apache.org/jira/browse/LENS-635
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: build
>Reporter: Amareshwari Sriramadasu
>Assignee: Raju Bairishetti
> Fix For: 2.4
>
> Attachments: LENS-635.patch
>
>
> We fixed javadoc warnings as they result as errors in java8. We should fail 
> the build with javadoc warnings or errors with new code getting checked in.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

[Amareshwari Sriramadasu]

> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 
> > 451
> > 
> >
> > can you take care of the TODO?
> 
> Gabor Liptak wrote:
> Rajat, what is the recommended way to reset this value? This key might or 
> might not exists, the getConnectionParam() returns a List and there 
> doesn't seem to be a method to delete a key ... Thanks
> 
> Amareshwari Sriramadasu wrote:
> This config is removed now and the setting and unsetting here can be 
> removed as well.
> 
> Gabor Liptak wrote:
> Removed as in I should delete both set/TODO lines?

Yes. Please go ahead.
The config is already removed from server side, by a different jira.


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39191/#review102598
---


On Oct. 15, 2015, 1:25 a.m., Gabor Liptak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39191/
> ---
> 
> (Updated Oct. 15, 2015, 1:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-615
> https://issues.apache.org/jira/browse/LENS-615
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> LENS-615 Refactoring of testQueryCommands test case
> 
> 
> Diffs
> -
> 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 
> 
> Diff: https://reviews.apache.org/r/39191/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Liptak
> 
>

[jira] [Updated] (LENS-635) Fail build for javadoc warnings/errors on java7 as well

[Raju Bairishetti (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raju Bairishetti updated LENS-635:
--
Fix Version/s: (was: 2.4)
   2.5

> Fail build for javadoc warnings/errors on java7 as well
> ---
>
> Key: LENS-635
> URL: https://issues.apache.org/jira/browse/LENS-635
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: build
>Reporter: Amareshwari Sriramadasu
>Assignee: Raju Bairishetti
> Fix For: 2.5
>
> Attachments: LENS-635.patch
>
>
> We fixed javadoc warnings as they result as errors in java8. We should fail 
> the build with javadoc warnings or errors with new code getting checked in.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-826) lens.client.query.poll.interval needs doc update

[Amareshwari Sriramadasu (JIRA)]

Amareshwari Sriramadasu created LENS-826:


 Summary: lens.client.query.poll.interval needs doc update
 Key: LENS-826
 URL: https://issues.apache.org/jira/browse/LENS-826
 Project: Apache Lens
  Issue Type: Bug
  Components: docs
Reporter: Amareshwari Sriramadasu
Priority: Minor
 Fix For: 2.4


lens.client.query.poll.interval is missing in lens-client-default.xml and the 
apt file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)