Re: June 2019

[Sushil Mohanty]

+1

On Wed, Jun 12, 2019 at 1:25 PM Raju Bairishetti  wrote:

> +1, looks good to me.
>
> On Wed, 12 Jun 2019, 13:10 Amareshwari Sriramdasu,  >
> wrote:
>
> > Hi all,
> >
> > On the last month's report we got feedback to resubmit the report, I have
> > put together the draft here :
> > https://cwiki.apache.org/confluence/display/LENS/June%2C+2019. Do review
> > and let me know your comments. Will be submitting report EOD.
> >
> > Thanks
> > Amareshwari
> >
>


-- 
-Sushil

Re: [VOTE] Lens - Code Commit using Pull Requests

[Sushil Mohanty]

+1

On Tue, Jan 22, 2019 at 1:15 PM Raghavendra Singh <
raghavendra.si...@inmobi.com> wrote:

> +1
>
> On Tue, Jan 22, 2019, 9:17 AM Puneet Gupta 
> > +1.
> >
> > On Tue, 22 Jan, 2019, 9:08 AM Amareshwari Sriramdasu <
> > amareshw...@apache.org
> > wrote:
> >
> > > Rajitha,
> > >
> > > Can we make sure emails for the new pull requests and the comments on
> > pull
> > > requests come to dev@lens.apache.org as part of this change?
> > >
> > > Thanks
> > >
> > > On Sun, Jan 20, 2019 at 10:29 AM Amareshwari Sriramdasu <
> > > amareshw...@apache.org> wrote:
> > >
> > > > +1
> > > >
> > > > On Sat, Jan 19, 2019 at 2:54 PM Rajat Khandelwal 
> > > > wrote:
> > > >
> > > >> +1
> > > >>
> > > >
> > >
> >
>
> --
> _
> The
> information contained in this communication is intended solely for the use
> of the individual or entity to whom it is addressed and others authorized
> to receive it. It may contain confidential or legally privileged
> information. If you are not the intended recipient you are hereby notified
> that any disclosure, copying, distribution or taking any action in
> reliance
> on the contents of this information is strictly prohibited and may be
> unlawful. If you have received this communication in error, please notify
> us immediately by responding to this email and then delete it from your
> system. The firm is neither liable for the proper and complete
> transmission
> of the information contained in this communication nor for any delay in
> its
> receipt.
>


-- 
-Sushil

Re: [DISCUSS] Lens Migration from Git-wip to Gitbox

[Sushil Mohanty]

+1

On Tue, Jan 8, 2019 at 11:26 AM Raju Bairishetti  wrote:

> +1
>
> On Tue, 8 Jan 2019, 11:15 Puneet Gupta 
> > +1
> >
> > On Tue, 8 Jan, 2019, 8:38 AM Amareshwari Sriramdasu <
> > amareshw...@apache.org
> > wrote:
> >
> > > +1
> > >
> > > On Mon, Jan 7, 2019 at 10:59 AM Rajitha R  wrote:
> > >
> > > > Hi All,
> > > >
> > > > ASF infra has decided to move all git repositories from
> > > > git-wip-us.apache.org URL to gitbox.apache.org with the former
> service
> > > > being decommisioned.
> > > >
> > > > This mail is to get a consensus from all of you regarding the
> > migration.
> > > >
> > > > Please vote within next 24 hours, which can help me in raising the
> > Infra
> > > > jira before the published timeline.
> > > >
> > > > [ ] +1 approve
> > > > [ ] 0 no opinion
> > > > [ ] -1 disapprove (and reason why)
> > > >
> > > > +1 from my side for the activity.
> > > >
> > > > For folks looking for more details, please refer this link :
> > > >
> > > >
> > >
> >
> https://blogs.apache.org/infra/entry/relocation-of-apache-git-repositories
> > > >
> > > > Regards,
> > > > Rajitha.R
> > > >
> > >
> >
>


-- 
-Sushil

Re: [ANNOUNCE] New Apache Lens committer : Rajitha R

[Sushil Mohanty]

Congratulations!! Rajitha.

On Fri, Feb 9, 2018 at 11:02 AM, Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Congratulations Rajitha !
>
> On Fri, Feb 9, 2018 at 10:58 AM, Puneet Gupta 
> wrote:
>
> > The PMC for Apache Lens has asked Rajitha to become Lens Committer. We
> are
> > pleased to announce that she has accepted.
> >
> > Being a committer enables access to commit to the source repositories
> > and binding
> > votes for code reviews.
> >
> > Join me in Congratulating Rajitha!
> >
> > Congratulations Rajitha! Looking forward for more of your contributions
> in
> > Apache Lens.
> >
> > Thanks
> > Puneet
> >
>



-- 
-Sushil

[jira] [Updated] (LENS-1496) Look ahead Time Partitions to be made configurable

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1496:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Look ahead Time Partitions to be made configurable 
> ---
>
> Key: LENS-1496
> URL: https://issues.apache.org/jira/browse/LENS-1496
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1496.01.patch, LENS-1496.patch
>
>
> Currently Lens only allows for Look ahead in the last partition. This needs 
> to be made  configurable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1496) Look ahead Time Partitions to be made configurable

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304334#comment-16304334
 ] 

Sushil Mohanty commented on LENS-1496:
--

Committed. Thanks [~rajitha.r]

> Look ahead Time Partitions to be made configurable 
> ---
>
> Key: LENS-1496
> URL: https://issues.apache.org/jira/browse/LENS-1496
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1496.01.patch, LENS-1496.patch
>
>
> Currently Lens only allows for Look ahead in the last partition. This needs 
> to be made  configurable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1486) Disable test case testQueryAliveOnSessionClose

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260489#comment-16260489
 ] 

Sushil Mohanty commented on LENS-1486:
--

Committed myself.

> Disable test case testQueryAliveOnSessionClose 
> ---
>
> Key: LENS-1486
> URL: https://issues.apache.org/jira/browse/LENS-1486
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1486.patch
>
>
> TestQueryIndependenceFromSessionClose.testQueryAliveOnSessionClose is failing 
> in past few builds, commenting it temporarily to make the build pass. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1486) Disable test case testQueryAliveOnSessionClose

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1486:
-
Status: Patch Available  (was: Open)

> Disable test case testQueryAliveOnSessionClose 
> ---
>
> Key: LENS-1486
> URL: https://issues.apache.org/jira/browse/LENS-1486
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1486.patch
>
>
> TestQueryIndependenceFromSessionClose.testQueryAliveOnSessionClose is failing 
> in past few builds, commenting it temporarily to make the build pass. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1486) Disable test case testQueryAliveOnSessionClose

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1486:
-
Attachment: LENS-1486.patch

> Disable test case testQueryAliveOnSessionClose 
> ---
>
> Key: LENS-1486
> URL: https://issues.apache.org/jira/browse/LENS-1486
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1486.patch
>
>
> TestQueryIndependenceFromSessionClose.testQueryAliveOnSessionClose is failing 
> in past few builds, commenting it temporarily to make the build pass. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LENS-1486) Disable test case testQueryAliveOnSessionClose

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1486:


 Summary: Disable test case testQueryAliveOnSessionClose 
 Key: LENS-1486
 URL: https://issues.apache.org/jira/browse/LENS-1486
 Project: Apache Lens
  Issue Type: Bug
  Components: server
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


TestQueryIndependenceFromSessionClose.testQueryAliveOnSessionClose is failing 
in past few builds, commenting it temporarily to make the build pass. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1483) Implementation for Jdbc driver cost

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1483:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Implementation for Jdbc driver cost 
> 
>
> Key: LENS-1483
> URL: https://issues.apache.org/jira/browse/LENS-1483
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1483.5.patch, LENS-1483.6.patch
>
>
> Jdbc driver cost has been hardcoded to zero currently in Lens code. This 
> makes it difficult to add more jdbc drivers which have different costs. Hence 
> there is a need for having a driver level implementation for calculating cost.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1483) Implementation for Jdbc driver cost

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256640#comment-16256640
 ] 

Sushil Mohanty commented on LENS-1483:
--

Committed. Thanks [~rajitha.r]

> Implementation for Jdbc driver cost 
> 
>
> Key: LENS-1483
> URL: https://issues.apache.org/jira/browse/LENS-1483
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1483.5.patch, LENS-1483.6.patch
>
>
> Jdbc driver cost has been hardcoded to zero currently in Lens code. This 
> makes it difficult to add more jdbc drivers which have different costs. Hence 
> there is a need for having a driver level implementation for calculating cost.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Report for November,2017

[Sushil Mohanty]

+1

On Fri, Nov 10, 2017 at 1:12 PM, Raghavendra Singh <
raghavendra.si...@inmobi.com> wrote:

> +1
>
> On Fri, Nov 10, 2017 at 1:10 PM, Puneet Gupta 
> wrote:
>
> > +1
> >
> > On Wed, Nov 8, 2017 at 5:27 PM, Amareshwari Sriramdasu <
> > amareshw...@apache.org> wrote:
> >
> > > Hi,
> > >
> > > Have put November, 2017 report here -
> > > https://cwiki.apache.org/confluence/display/LENS/November%2C2017.
> > >
> > > Please review and let me know your comments.
> > >
> > > Thanks
> > > Amareshwari
> > >
> >
>
> --
> _
> The information contained in this communication is intended solely for the
> use of the individual or entity to whom it is addressed and others
> authorized to receive it. It may contain confidential or legally privileged
> information. If you are not the intended recipient you are hereby notified
> that any disclosure, copying, distribution or taking any action in reliance
> on the contents of this information is strictly prohibited and may be
> unlawful. If you have received this communication in error, please notify
> us immediately by responding to this email and then delete it from your
> system. The firm is neither liable for the proper and complete transmission
> of the information contained in this communication nor for any delay in its
> receipt.
>



-- 
-Sushil

[jira] [Updated] (LENS-1461) Lens services state are not persisted correctly

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1461:
-
Attachment: LENS-1461_3.patch

Corrected the extension.

> Lens services state are not persisted correctly
> ---
>
> Key: LENS-1461
> URL: https://issues.apache.org/jira/browse/LENS-1461
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
>Priority: Major
> Attachments: LENS-1461.patch_3, LENS-1461_3.patch
>
>
> Lens services state are not persisted correctly causing lens  to fail at 
> startup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1461) Lens services state are not persisted correctly

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1461:
-
Status: Patch Available  (was: Open)

> Lens services state are not persisted correctly
> ---
>
> Key: LENS-1461
> URL: https://issues.apache.org/jira/browse/LENS-1461
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
> Attachments: LENS-1461.patch_3
>
>
> Lens services state are not persisted correctly causing lens  to fail at 
> startup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1461) Lens services state are not persisted correctly

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1461:
-
Attachment: LENS-1461.patch_3

Taken patch from review board and attaching.

> Lens services state are not persisted correctly
> ---
>
> Key: LENS-1461
> URL: https://issues.apache.org/jira/browse/LENS-1461
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Ankit Kailaswar
>Assignee: Ankit Kailaswar
> Attachments: LENS-1461.patch_3
>
>
> Lens services state are not persisted correctly causing lens  to fail at 
> startup.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1478) Queries with partial data set as false lookahead not working

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171399#comment-16171399
 ] 

Sushil Mohanty commented on LENS-1478:
--

Committed myself.

> Queries with partial data set as false lookahead not working
> 
>
> Key: LENS-1478
> URL: https://issues.apache.org/jira/browse/LENS-1478
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1478.patch
>
>
> For queries with set lens.cube.query.fail.if.data.partial=false lookahead 
> queries partitions are not getting resolved and the being rewritten same as 
> input time_range_in function. This results query failure with syntax error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1478) Queries with partial data set as false lookahead not working

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1478:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Queries with partial data set as false lookahead not working
> 
>
> Key: LENS-1478
> URL: https://issues.apache.org/jira/browse/LENS-1478
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1478.patch
>
>
> For queries with set lens.cube.query.fail.if.data.partial=false lookahead 
> queries partitions are not getting resolved and the being rewritten same as 
> input time_range_in function. This results query failure with syntax error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1478) Queries with partial data set as false lookahead not working

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1478:
-
Status: Patch Available  (was: Open)

> Queries with partial data set as false lookahead not working
> 
>
> Key: LENS-1478
> URL: https://issues.apache.org/jira/browse/LENS-1478
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1478.patch
>
>
> For queries with set lens.cube.query.fail.if.data.partial=false lookahead 
> queries partitions are not getting resolved and the being rewritten same as 
> input time_range_in function. This results query failure with syntax error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1478) Queries with partial data set as false lookahead not working

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1478:
-
Attachment: LENS-1478.patch

Small patch, attaching directly.

> Queries with partial data set as false lookahead not working
> 
>
> Key: LENS-1478
> URL: https://issues.apache.org/jira/browse/LENS-1478
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1478.patch
>
>
> For queries with set lens.cube.query.fail.if.data.partial=false lookahead 
> queries partitions are not getting resolved and the being rewritten same as 
> input time_range_in function. This results query failure with syntax error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LENS-1478) Queries with partial data set as false lookahead not working

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1478:


 Summary: Queries with partial data set as false lookahead not 
working
 Key: LENS-1478
 URL: https://issues.apache.org/jira/browse/LENS-1478
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


For queries with set lens.cube.query.fail.if.data.partial=false lookahead 
queries partitions are not getting resolved and the being rewritten same as 
input time_range_in function. This results query failure with syntax error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1477) Change default measure value to "0" instead of "0.0" in union queries

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169895#comment-16169895
 ] 

Sushil Mohanty commented on LENS-1477:
--

Committed myself.

> Change default measure value to "0" instead of "0.0" in union queries
> -
>
> Key: LENS-1477
> URL: https://issues.apache.org/jira/browse/LENS-1477
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1477.patch
>
>
> Changing this value to "0", so data type conversion of integer with double 
> can be avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1477) Change default measure value to "0" instead of "0.0" in union queries

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1477:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Change default measure value to "0" instead of "0.0" in union queries
> -
>
> Key: LENS-1477
> URL: https://issues.apache.org/jira/browse/LENS-1477
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1477.patch
>
>
> Changing this value to "0", so data type conversion of integer with double 
> can be avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1477) Change default measure value to "0" instead of "0.0" in union queries

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1477:
-
Status: Patch Available  (was: Open)

> Change default measure value to "0" instead of "0.0" in union queries
> -
>
> Key: LENS-1477
> URL: https://issues.apache.org/jira/browse/LENS-1477
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1477.patch
>
>
> Changing this value to "0", so data type conversion of integer with double 
> can be avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1477) Change default measure value to "0" instead of "0.0" in union queries

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1477:
-
Attachment: LENS-1477.patch

> Change default measure value to "0" instead of "0.0" in union queries
> -
>
> Key: LENS-1477
> URL: https://issues.apache.org/jira/browse/LENS-1477
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1477.patch
>
>
> Changing this value to "0", so data type conversion of integer with double 
> can be avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1477) Change default measure value to "0" instead of "0.0" in union queries

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169787#comment-16169787
 ] 

Sushil Mohanty commented on LENS-1477:
--

Review : https://reviews.apache.org/r/62377/

> Change default measure value to "0" instead of "0.0" in union queries
> -
>
> Key: LENS-1477
> URL: https://issues.apache.org/jira/browse/LENS-1477
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
>
> Changing this value to "0", so data type conversion of integer with double 
> can be avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 62377: LENS-1477 : Change default measure value to "0" instead of "0.0" in union queries

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62377/
---

Review request for lens.


Repository: lens


Description
---

Change default measure value to "0" instead of "0.0" in union queries


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
553468f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
0d512e4 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
35cb2b5 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java 
9fbeb41 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java
 8a76f4a 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java
 ccc3bf4 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java 
94e836c 


Diff: https://reviews.apache.org/r/62377/diff/1/


Testing
---

All unit tests in lens-cube passed.


Thanks,

Sushil Mohanty

[jira] [Created] (LENS-1477) Change default measure value to "0" instead of "0.0" in union queries

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1477:


 Summary: Change default measure value to "0" instead of "0.0" in 
union queries
 Key: LENS-1477
 URL: https://issues.apache.org/jira/browse/LENS-1477
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
        Reporter: Sushil Mohanty
        Assignee: Sushil Mohanty


Changing this value to "0", so data type conversion of integer with double can 
be avoided.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1475) Override equals(Object obj) and hashcode() methods of SegmentationCandidate

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1475:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Override equals(Object obj) and hashcode() methods of SegmentationCandidate
> ---
>
> Key: LENS-1475
> URL: https://issues.apache.org/jira/browse/LENS-1475
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1475.patch
>
>
> Override both equals() and hashcode() 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1476) Order By clause is not rewritten correctly when column is wrapped with function

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1476:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Order By clause is not rewritten correctly when column is wrapped with 
> function
> ---
>
> Key: LENS-1476
> URL: https://issues.apache.org/jira/browse/LENS-1476
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1476.patch
>
>
> Order by clauses like to_date(datecol) is not not rewritten properly in the 
> final union query.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1475) Override equals(Object obj) and hashcode() methods of SegmentationCandidate

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165864#comment-16165864
 ] 

Sushil Mohanty commented on LENS-1475:
--

Committed myself.

> Override equals(Object obj) and hashcode() methods of SegmentationCandidate
> ---
>
> Key: LENS-1475
> URL: https://issues.apache.org/jira/browse/LENS-1475
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1475.patch
>
>
> Override both equals() and hashcode() 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1476) Order By clause is not rewritten correctly when column is wrapped with function

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165863#comment-16165863
 ] 

Sushil Mohanty commented on LENS-1476:
--

Committed myself.

> Order By clause is not rewritten correctly when column is wrapped with 
> function
> ---
>
> Key: LENS-1476
> URL: https://issues.apache.org/jira/browse/LENS-1476
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1476.patch
>
>
> Order by clauses like to_date(datecol) is not not rewritten properly in the 
> final union query.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1476) Order By clause is not rewritten correctly when column is wrapped with function

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1476:
-
Status: Patch Available  (was: Open)

> Order By clause is not rewritten correctly when column is wrapped with 
> function
> ---
>
> Key: LENS-1476
> URL: https://issues.apache.org/jira/browse/LENS-1476
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1476.patch
>
>
> Order by clauses like to_date(datecol) is not not rewritten properly in the 
> final union query.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1475) Override equals(Object obj) and hashcode() methods of SegmentationCandidate

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1475:
-
Attachment: LENS-1475.patch

> Override equals(Object obj) and hashcode() methods of SegmentationCandidate
> ---
>
> Key: LENS-1475
> URL: https://issues.apache.org/jira/browse/LENS-1475
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1475.patch
>
>
> Override both equals() and hashcode() 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1475) Override equals(Object obj) and hashcode() methods of SegmentationCandidate

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1475:
-
Status: Patch Available  (was: Open)

> Override equals(Object obj) and hashcode() methods of SegmentationCandidate
> ---
>
> Key: LENS-1475
> URL: https://issues.apache.org/jira/browse/LENS-1475
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1475.patch
>
>
> Override both equals() and hashcode() 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1476) Order By clause is not rewritten correctly when column is wrapped with function

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1476:
-
Attachment: LENS-1476.patch

Minor change, attaching patch directly.

> Order By clause is not rewritten correctly when column is wrapped with 
> function
> ---
>
> Key: LENS-1476
> URL: https://issues.apache.org/jira/browse/LENS-1476
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1476.patch
>
>
> Order by clauses like to_date(datecol) is not not rewritten properly in the 
> final union query.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LENS-1476) Order By clause is not rewritten correctly when column is wrapped with function

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1476:


 Summary: Order By clause is not rewritten correctly when column is 
wrapped with function
 Key: LENS-1476
 URL: https://issues.apache.org/jira/browse/LENS-1476
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


Order by clauses like to_date(datecol) is not not rewritten properly in the 
final union query.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1475) Override equals(Object obj) and hashcode() methods of SegmentationCandidate

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161126#comment-16161126
 ] 

Sushil Mohanty commented on LENS-1475:
--

review : https://reviews.apache.org/r/62218/

> Override equals(Object obj) and hashcode() methods of SegmentationCandidate
> ---
>
> Key: LENS-1475
> URL: https://issues.apache.org/jira/browse/LENS-1475
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
>
> Override both equals() and hashcode() 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 62218: LENS-1475 : Override equals(Object obj) and hashcode() methods of SegmentationCandidate

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62218/
---

Review request for lens.


Bugs: LENS-1475
https://issues.apache.org/jira/browse/LENS-1475


Repository: lens


Description
---

Override equals(Object obj) and hashcode() methods of SegmentationCandidate


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java 
055d6ef 


Diff: https://reviews.apache.org/r/62218/diff/1/


Testing
---


Thanks,

Sushil Mohanty

[jira] [Created] (LENS-1475) Override equals(Object obj) and hashcode() methods of SegmentationCandidate

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1475:


 Summary: Override equals(Object obj) and hashcode() methods of 
SegmentationCandidate
 Key: LENS-1475
 URL: https://issues.apache.org/jira/browse/LENS-1475
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


Override both equals() and hashcode() 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 61992: LENS-1468: Expressions in having clauses are not getting rewritten properly for join queries

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61992/#review184347
---


Ship it!




Ship It!

- Sushil Mohanty


On Aug. 30, 2017, 2:52 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61992/
> ---
> 
> (Updated Aug. 30, 2017, 2:52 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1468
> https://issues.apache.org/jira/browse/LENS-1468
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The issue is not seen in test cases yet since somehow the order of child 
> candidates in {{JoinCandidate}} has been fixed. We have observed the order 
> being non-deterministic in production. And in one ordering, having clause 
> works fine and in another it doesn't. Will be adding test cases to reproduce 
> this issue and the fix as well.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 8906fae1915e71a38e18f42145825afcfe1a1d0b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java
>  993aa4cbf26d4771bbe714c95abc471534802780 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> 9dc7ee67deb7495f99b53b01839722fb42446d03 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> cf29dff9058aa98bccff9d986fb3756438b50b83 
>   lens-cube/src/test/resources/schema/cubes/base/basecube.xml 
> 6bb5eb9c0cefbec3bf85bf245a3d25b9b4c67b6e 
>   lens-cube/src/test/resources/schema/cubes/derived/der2.xml 
> 337e7f450f96a3b1459556655680388ae2445f25 
> 
> 
> Diff: https://reviews.apache.org/r/61992/diff/2/
> 
> 
> Testing
> ---
> 
> This is the output of the newly added test case after reverting code fixes:
> 
> ```
> java.lang.AssertionError: having1: HAVING (((sum((basecube.alias1)) + 
> sum((basecube.alias3)) + sum((basecube.alias4))) > 0) and 
> ((floor(sum((basecube.alias1))) + 0) > 10))
> having2: HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
> sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10)) 
> expected [HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
> sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))] 
> but found [HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) + 
> sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))]
> Expected :HAVING (((sum((basecube.alias1)) + sum((basecube.alias1)) + 
> sum((basecube.alias1))) > 0) and ((floor(sum((basecube.alias5))) + 0) > 10))
> Actual   :HAVING (((sum((basecube.alias1)) + sum((basecube.alias3)) + 
> sum((basecube.alias4))) > 0) and ((floor(sum((basecube.alias1))) + 0) > 10))
> 
> ```
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Closed] (LENS-1408) Fix test cases after LENS-1399

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty closed LENS-1408.


> Fix test cases after LENS-1399
> --
>
> Key: LENS-1408
> URL: https://issues.apache.org/jira/browse/LENS-1408
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Fix For: 2.7
>
>
> As LENS-1397 is done, we need to fix the dependent test cases.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Report for August, 2017

[Sushil Mohanty]

Looks good to me.
+1

Thanks,
Sushil

On Wed, Aug 9, 2017 at 10:27 AM, amareshwarisr . 
wrote:

> Hi all,
>
> Have put draft of report for August,2017 at
> https://cwiki.apache.org/confluence/display/LENS/August%2C2017. Please
> review and let me know your comments. Will publish it EOD.
>
> Thanks
>



-- 
-Sushil

[jira] [Commented] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116552#comment-16116552
 ] 

Sushil Mohanty commented on LENS-1458:
--

Committed myself.

> RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued 
> queries after server restart
> -
>
> Key: LENS-1458
> URL: https://issues.apache.org/jira/browse/LENS-1458
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1458_1.patch, LENS-1458_2.patch, LENS-1458_3.patch
>
>
> This is happening when queries are getting restored after server restart and 
> driver specific conf  is overwritten with server conf.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1458:
-
Attachment: LENS-1458_3.patch

Checkstyle issue fixed.

> RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued 
> queries after server restart
> -
>
> Key: LENS-1458
> URL: https://issues.apache.org/jira/browse/LENS-1458
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1458_1.patch, LENS-1458_2.patch, LENS-1458_3.patch
>
>
> This is happening when queries are getting restored after server restart and 
> driver specific conf  is overwritten with server conf.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1458:
-
Attachment: LENS-1458_2.patch

Added assert to verify RESULT_SET_PARENT_DIR after restart.

> RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued 
> queries after server restart
> -
>
> Key: LENS-1458
> URL: https://issues.apache.org/jira/browse/LENS-1458
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1458_1.patch, LENS-1458_2.patch
>
>
> This is happening when queries are getting restored after server restart and 
> driver specific conf  is overwritten with server conf.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1458:
-
Attachment: LENS-1458_1.patch

Updated patch with unit test fix. 
{CODE}
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules . SUCCESS [1.864s]
[INFO] Lens .. SUCCESS [3.679s]
[INFO] Lens API .. SUCCESS [27.437s]
[INFO] Lens API for server and extensions  SUCCESS [19.440s]
[INFO] Lens Cube . SUCCESS [4:15.267s]
[INFO] Lens DB storage ... SUCCESS [20.270s]
[INFO] Lens Query Library  SUCCESS [14.641s]
[INFO] Lens Hive Driver .. SUCCESS [1:30.885s]
[INFO] Lens Driver for JDBC .. SUCCESS [52.203s]
[INFO] Lens Elastic Search Driver  SUCCESS [23.204s]
[INFO] Lens Server ... SUCCESS [16:46.678s]
[INFO] Lens client ... SUCCESS [1:25.148s]
[INFO] Lens CLI .. SUCCESS [1:19.012s]
[INFO] Lens Examples . SUCCESS [9.237s]
[INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.692s]
[INFO] Lens Distribution . SUCCESS [9.100s]
[INFO] Lens ML Lib ... SUCCESS [1:04.634s]
[INFO] Lens ML Ext Distribution .. SUCCESS [2.052s]
[INFO] Lens Regression ... SUCCESS [12.196s]
[INFO] Lens UI ... SUCCESS [31.196s]
[INFO] Lens Contrib .. SUCCESS [0.357s]
[INFO] Lens Contributed Clients .. SUCCESS [0.353s]
[INFO] Lens Python Client  SUCCESS [0.369s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 30:10.847s
[INFO] Finished at: Fri Aug 04 11:08:28 UTC 2017
[INFO] Final Memory: 288M/3047M
[INFO] 
{CODE}

> RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued 
> queries after server restart
> -
>
> Key: LENS-1458
> URL: https://issues.apache.org/jira/browse/LENS-1458
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1458_1.patch
>
>
> This is happening when queries are getting restored after server restart and 
> driver specific conf  is overwritten with server conf.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1458:
-
Attachment: (was: LENS-1458.patch)

> RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued 
> queries after server restart
> -
>
> Key: LENS-1458
> URL: https://issues.apache.org/jira/browse/LENS-1458
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
>
> This is happening when queries are getting restored after server restart and 
> driver specific conf  is overwritten with server conf.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1458:
-
Status: Patch Available  (was: Open)

> RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued 
> queries after server restart
> -
>
> Key: LENS-1458
> URL: https://issues.apache.org/jira/browse/LENS-1458
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1458.patch
>
>
> This is happening when queries are getting restored after server restart and 
> driver specific conf  is overwritten with server conf.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1458:
-
Attachment: LENS-1458.patch

Small change, attaching directly.

> RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued 
> queries after server restart
> -
>
> Key: LENS-1458
> URL: https://issues.apache.org/jira/browse/LENS-1458
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>    Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1458.patch
>
>
> This is happening when queries are getting restored after server restart and 
> driver specific conf  is overwritten with server conf.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (LENS-1458) RESULT_SET_PARENT_DIR set at driver level getting overwritten for queued queries after server restart

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1458:


 Summary: RESULT_SET_PARENT_DIR set at driver level getting 
overwritten for queued queries after server restart
 Key: LENS-1458
 URL: https://issues.apache.org/jira/browse/LENS-1458
 Project: Apache Lens
  Issue Type: Bug
  Components: server
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


This is happening when queries are getting restored after server restart and 
driver specific conf  is overwritten with server conf.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 60973: LENS-1455: Getting expression ast to generate default expression should consider all expression contexts

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60973/#review181026
---


Ship it!




Ship It!

- Sushil Mohanty


On July 20, 2017, 7:51 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60973/
> ---
> 
> (Updated July 20, 2017, 7:51 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1455
> https://issues.apache.org/jira/browse/LENS-1455
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> in case an expression is answered from a segmentation, the default expression 
> can't be generated.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  69d9562f39c91d050db4b2af5c5c4f9b6161f0f0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 66b043e51b1a838139090e851d62dcb249fab382 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/SegmentationCandidate.java 
> a2bd485005272f5fbb4d71879716f2afb5bc6771 
> 
> 
> Diff: https://reviews.apache.org/r/60973/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 60965: LENS-1454: Time Covering set algorithm is skipping some combinations

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60965/#review181022
---


Ship it!




Ship It!

- Sushil Mohanty


On July 19, 2017, 11:54 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60965/
> ---
> 
> (Updated July 19, 2017, 11:54 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1454
> https://issues.apache.org/jira/browse/LENS-1454
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> The current algorithm is incomplete. Will attach a patch.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  69d9562f39c91d050db4b2af5c5c4f9b6161f0f0 
> 
> 
> Diff: https://reviews.apache.org/r/60965/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 60679: LENS-1451: Enforcing valid fact tables doesn't filter out segmentations

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60679/#review179765
---


Ship it!




Ship It!

- Sushil Mohanty


On July 6, 2017, 8:13 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60679/
> ---
> 
> (Updated July 6, 2017, 8:13 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1451
> https://issues.apache.org/jira/browse/LENS-1451
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> valid fact tables key is used to enforce which facts can be picked. 
> Currently, this property still lets segmentations remain valid candidates and 
> enforcing doesn't happen.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  be3b4749fd7780b83f9d0c7dbeb674dff284a1f4 
> 
> 
> Diff: https://reviews.apache.org/r/60679/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Work started] (LENS-1448) Having clause expressions are not resolved correctly for JoinCandidates

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1448 started by Sushil Mohanty.

> Having clause expressions are not resolved correctly for JoinCandidates
> ---
>
> Key: LENS-1448
> URL: https://issues.apache.org/jira/browse/LENS-1448
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1448.patch
>
>
> In the below query expr1 and expr2 are answered from Cadidate1 and Candidate2 
> respectively. 
> The union rewritten query should have both the expressions projected in the 
> inner queries which is not happening right now.
> {CODE}
> cube select dim1, expr1 from testcube where time_range_in(time, 
> '2017-06-13-00', '2017-06-14-00') having expr2 > ('0')
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1437) Missing unit test cases for virtual fact

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1437:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Missing unit test cases for virtual fact 
> -
>
> Key: LENS-1437
> URL: https://issues.apache.org/jira/browse/LENS-1437
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1437.patch
>
>
> Need unit test cases for following :
> 1. Virtual fact union with direct/base fact
> 2. LENS-1433
> 3. Virtual fact join with Dim table



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (LENS-1437) Missing unit test cases for virtual fact

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064636#comment-16064636
 ] 

Sushil Mohanty commented on LENS-1437:
--

Committed. Thanks [~rajitha.r]

> Missing unit test cases for virtual fact 
> -
>
> Key: LENS-1437
> URL: https://issues.apache.org/jira/browse/LENS-1437
> Project: Apache Lens
>  Issue Type: Task
>  Components: cube
>Reporter: Rajitha R
>Assignee: Rajitha R
> Attachments: LENS-1437.patch
>
>
> Need unit test cases for following :
> 1. Virtual fact union with direct/base fact
> 2. LENS-1433
> 3. Virtual fact join with Dim table



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1445) Expression having reference column ends up rewriting wrong query

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1445:
-
Status: Patch Available  (was: Open)

> Expression having reference column ends up rewriting wrong query
> 
>
> Key: LENS-1445
> URL: https://issues.apache.org/jira/browse/LENS-1445
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1445.patch
>
>
> Seeing failures in query rewrite when an expression is having a reference 
> column.
> for eg : sum(case when refcol = 'abc' then msr1 + msr2 end)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1445) Expression having reference column ends up rewriting wrong query

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1445:
-
Attachment: LENS-1445.patch

> Expression having reference column ends up rewriting wrong query
> 
>
> Key: LENS-1445
> URL: https://issues.apache.org/jira/browse/LENS-1445
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1445.patch
>
>
> Seeing failures in query rewrite when an expression is having a reference 
> column.
> for eg : sum(case when refcol = 'abc' then msr1 + msr2 end)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 60387: LENS-1445: Expression having reference column ends up rewriting wrong query

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60387/
---

Review request for lens.


Bugs: LENS-1445
https://issues.apache.org/jira/browse/LENS-1445


Repository: lens


Description
---

Seeing failures in query rewrite when an expression is having a reference 
column.
for eg : sum(case when refcol = 'abc' then msr1 + msr2 end)


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
cc0a2e5 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java
 9fa31dc 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java
 dc06ead 
  lens-cube/src/test/resources/schema/cubes/base/basecube.xml bcea938 
  lens-cube/src/test/resources/schema/cubes/base/testcube.xml 088c8de 


Diff: https://reviews.apache.org/r/60387/diff/1/


Testing
---


Thanks,

Sushil Mohanty

[jira] [Created] (LENS-1445) Expression having reference column ends up rewriting wrong query

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1445:


 Summary: Expression having reference column ends up rewriting 
wrong query
 Key: LENS-1445
 URL: https://issues.apache.org/jira/browse/LENS-1445
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


Seeing failures in query rewrite when an expression is having a reference 
column.
for eg : sum(case when refcol = 'abc' then msr1 + msr2 end)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 60364: LENS-1444: Optimize the algorithm of finding all eligible union candidates

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60364/#review178658
---


Ship it!




Ship It!

- Sushil Mohanty


On June 22, 2017, 11:09 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60364/
> ---
> 
> (Updated June 22, 2017, 11:09 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1444
> https://issues.apache.org/jira/browse/LENS-1444
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Current algorithm is given {{n}} candidates, first find {{2 ^n^ -1}} union 
> candidates using power set and then among them, remove the ones which don't 
> cover the queried time range(s). 
> 
> Proposed optimization: Pushdown of the prune logic. We'll not create a list 
> of {{2 ^n^ -1}} candidates, we'll check for coverability before adding it as 
> an eligible union candidate. This will bring down the number of 
> {{UnionCandidates}} in the memory and preventing Full-GC.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  61c28c6903b2029165df5d894b5b01ebd779405c 
> 
> 
> Diff: https://reviews.apache.org/r/60364/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Commented] (LENS-1438) Testcase failure after LENS-1432

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047652#comment-16047652
 ] 

Sushil Mohanty commented on LENS-1438:
--

+1

> Testcase failure after LENS-1432
> 
>
> Key: LENS-1438
> URL: https://issues.apache.org/jira/browse/LENS-1438
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Attachments: LENS-1438.2017-06-13_15:01:36.patch
>
>
> Test failing: org.apache.lens.server.rewrite.TestRewriting#testCubeQuery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (LENS-1435) Cube xml files are missing in lens-example

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1435:
-
Status: Patch Available  (was: Open)

> Cube xml files are missing in lens-example
> --
>
> Key: LENS-1435
> URL: https://issues.apache.org/jira/browse/LENS-1435
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1435.patch
>
>
> cube11, cube22 and cube33  schema are missing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1435) Cube xml files are missing in lens-example

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1435:
-
Attachment: LENS-1435.patch

> Cube xml files are missing in lens-example
> --
>
> Key: LENS-1435
> URL: https://issues.apache.org/jira/browse/LENS-1435
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1435.patch
>
>
> cube11, cube22 and cube33  schema are missing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1435) Cube xml files are missing in lens-example

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1435:


 Summary: Cube xml files are missing in lens-example
 Key: LENS-1435
 URL: https://issues.apache.org/jira/browse/LENS-1435
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


cube11, cube22 and cube33  schema are missing.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1430) Expressions are not getting resolved correctly in union query

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1430:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Expressions are not getting resolved correctly in union query
> -
>
> Key: LENS-1430
> URL: https://issues.apache.org/jira/browse/LENS-1430
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1430_1.patch, LENS-1430.patch
>
>
> Expressions are not getting resolved correctly for the below case
> {CODE} 
> case when expr1 = 0 then 0 else expr2 * 100 / expr1 end 
> {CODE}
> expr1 is answerable by Candidate1 and Candidate2
> expr2 is answerable by Candidate1 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1428) Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1428:
-
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Common measures are getting repeated in UnionQuery for JoinCandidate
> 
>
> Key: LENS-1428
> URL: https://issues.apache.org/jira/browse/LENS-1428
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1428_1.patch, LENS-1428_2.patch, LENS-1428_3.patch
>
>
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other in the rewritten union 
> query.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1428) Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038494#comment-16038494
 ] 

Sushil Mohanty commented on LENS-1428:
--

committed myself. 

> Common measures are getting repeated in UnionQuery for JoinCandidate
> 
>
> Key: LENS-1428
> URL: https://issues.apache.org/jira/browse/LENS-1428
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1428_1.patch, LENS-1428_2.patch, LENS-1428_3.patch
>
>
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other in the rewritten union 
> query.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1432) Map Join tuning broken for this query leading to Map timeouts

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1432:
-
Attachment: LENS-1432_2.patch

> Map Join tuning broken for this query leading to Map timeouts
> -
>
> Key: LENS-1432
> URL: https://issues.apache.org/jira/browse/LENS-1432
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1432_2.patch
>
>
> CubeQueryContext.getDimsToQuery() is empty, causing the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1432) Map Join tuning broken for this query leading to Map timeouts

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1432:
-
Status: Patch Available  (was: Open)

> Map Join tuning broken for this query leading to Map timeouts
> -
>
> Key: LENS-1432
> URL: https://issues.apache.org/jira/browse/LENS-1432
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1432_2.patch
>
>
> CubeQueryContext.getDimsToQuery() is empty, causing the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1428) Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1428:
-
Attachment: LENS-1428_3.patch

Removed the test case fix, which is committed as part of LENS-1412

> Common measures are getting repeated in UnionQuery for JoinCandidate
> 
>
> Key: LENS-1428
> URL: https://issues.apache.org/jira/browse/LENS-1428
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1428_1.patch, LENS-1428_2.patch, LENS-1428_3.patch
>
>
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other in the rewritten union 
> query.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this query leading to Map timeouts

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/
---

(Updated June 6, 2017, 6:59 a.m.)


Review request for lens.


Changes
---

- Addressed review.


Bugs: LENS-1432
https://issues.apache.org/jira/browse/LENS-1432


Repository: lens


Description
---

CubeQueryContext.getDimsToQuery() is empty, causing the problem.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java
 d57c027 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java 
d55de1f 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java caf8770 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 
76ea77d 


Diff: https://reviews.apache.org/r/59803/diff/3/

Changes: https://reviews.apache.org/r/59803/diff/2-3/


Testing
---


Thanks,

Sushil Mohanty

[jira] [Updated] (LENS-1428) Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1428:
-
Attachment: LENS-1428_2.patch

Fixed test case failing in master.

> Common measures are getting repeated in UnionQuery for JoinCandidate
> 
>
> Key: LENS-1428
> URL: https://issues.apache.org/jira/browse/LENS-1428
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1428_1.patch, LENS-1428_2.patch
>
>
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other in the rewritten union 
> query.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59803: LENS-1432 : Map Join tuning broken for this query leading to Map timeouts

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/
---

(Updated June 5, 2017, 2:18 p.m.)


Review request for lens.


Changes
---

- Added assert


Bugs: LENS-1432
https://issues.apache.org/jira/browse/LENS-1432


Repository: lens


Description
---

CubeQueryContext.getDimsToQuery() is empty, causing the problem.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java
 d57c027 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java 
d55de1f 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java caf8770 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 
76ea77d 


Diff: https://reviews.apache.org/r/59803/diff/2/

Changes: https://reviews.apache.org/r/59803/diff/1-2/


Testing
---


Thanks,

Sushil Mohanty

[jira] [Commented] (LENS-1430) Expressions are not getting resolved correctly in union query

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036975#comment-16036975
 ] 

Sushil Mohanty commented on LENS-1430:
--

This change is dependent on LENS-1428. Will trigger the build again once the 
changes merged to master.

> Expressions are not getting resolved correctly in union query
> -
>
> Key: LENS-1430
> URL: https://issues.apache.org/jira/browse/LENS-1430
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1430_1.patch, LENS-1430.patch
>
>
> Expressions are not getting resolved correctly for the below case
> {CODE} 
> case when expr1 = 0 then 0 else expr2 * 100 / expr1 end 
> {CODE}
> expr1 is answerable by Candidate1 and Candidate2
> expr2 is answerable by Candidate1 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1430) Expressions are not getting resolved correctly in union query

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1430:
-
Attachment: LENS-1430.patch

> Expressions are not getting resolved correctly in union query
> -
>
> Key: LENS-1430
> URL: https://issues.apache.org/jira/browse/LENS-1430
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1430.patch
>
>
> Expressions are not getting resolved correctly for the below case
> {CODE} 
> case when expr1 = 0 then 0 else expr2 * 100 / expr1 end 
> {CODE}
> expr1 is answerable by Candidate1 and Candidate2
> expr2 is answerable by Candidate1 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1428) Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1428:
-
Attachment: LENS-1428_1.patch

> Common measures are getting repeated in UnionQuery for JoinCandidate
> 
>
> Key: LENS-1428
> URL: https://issues.apache.org/jira/browse/LENS-1428
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1428_1.patch
>
>
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other in the rewritten union 
> query.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1429) Queries failing intermittently with NO_REF_COL_AVAILABLE

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1429:
-
Status: Patch Available  (was: Open)

> Queries failing intermittently with NO_REF_COL_AVAILABLE
> 
>
> Key: LENS-1429
> URL: https://issues.apache.org/jira/browse/LENS-1429
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1429.patch
>
>
> Have seen queries failing intermittently with below error.
> {CODE}
> 16 May 2017 11:59:39 [5af8e7ad-b9d7-44db-abdf-d8a28bdb9f3c] 
> [f38a238e-abcb-4168-a052-7114cee1c3a6 estimate-128] WARN  
> org.apache.lens.server.rewrite.RewriteUtil - Driver : hive/prod  Skipped for 
> the query rewriting due to
> org.apache.lens.server.api.error.LensException: 
> NO_REF_COL_AVAILABLE[my_ref_col]
> at 
> org.apache.lens.cube.parse.DenormalizationResolver$DenormalizationContext.pickColumnsForTable(DenormalizationResolver.java:227)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.DenormalizationResolver$DenormalizationContext.rewriteDenormctx(DenormalizationResolver.java:150)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.DimHQLContext.addDenormDims(DimHQLContext.java:119)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.MultiCandidateQueryWriterContext.addDenormDims(MultiCandidateQueryWriterContext.java:56)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.CubeQueryContext.getQueryWriter(CubeQueryContext.java:927)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.CubeQueryContext.toHQL(CubeQueryContext.java:947) 
> ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.server.rewrite.RewriteUtil$DriverRewriterRunnable.run(RewriteUtil.java:396)
>  ~[classes/:na]
> at 
> org.apache.lens.server.query.QueryExecutionServiceImpl$RewriteEstimateRunnable.run(QueryExecutionServiceImpl.java:1855)
>  [classes/:na]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_40]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [na:1.8.0_40]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [na:1.8.0_40]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_40]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1432) Map Join tuning broken for this query leading to Map timeouts

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036850#comment-16036850
 ] 

Sushil Mohanty commented on LENS-1432:
--

review : https://reviews.apache.org/r/59803/

> Map Join tuning broken for this query leading to Map timeouts
> -
>
> Key: LENS-1432
> URL: https://issues.apache.org/jira/browse/LENS-1432
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
>
> CubeQueryContext.getDimsToQuery() is empty, causing the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59803: LENS-1432 : Map Join tuning broken for this query leading to Map timeouts

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59803/
---

Review request for lens.


Bugs: LENS-1432
https://issues.apache.org/jira/browse/LENS-1432


Repository: lens


Description
---

CubeQueryContext.getDimsToQuery() is empty, causing the problem.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiCandidateQueryWriterContext.java
 d57c027 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryWriterContext.java 
d55de1f 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriterPlan.java caf8770 


Diff: https://reviews.apache.org/r/59803/diff/1/


Testing
---


Thanks,

Sushil Mohanty

[jira] [Created] (LENS-1432) Map Join tuning broken for this query leading to Map timeouts

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1432:


 Summary: Map Join tuning broken for this query leading to Map 
timeouts
 Key: LENS-1432
 URL: https://issues.apache.org/jira/browse/LENS-1432
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


CubeQueryContext.getDimsToQuery() is empty, causing the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59714: LENS-1428 : Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/
---

(Updated June 5, 2017, 8:51 a.m.)


Review request for lens.


Changes
---

Addressed review.


Bugs: LENS-1428
https://issues.apache.org/jira/browse/LENS-1428


Repository: lens


Description
---

For JoinCandidate if a measure is answerable by its children, getting projected 
in both. Instead the measure should be projected in one of the children and 
default measure i.e 0.0 for the other.


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
b5c4c89 
  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
47bce65 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
1e54f13 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
6c0d91a 


Diff: https://reviews.apache.org/r/59714/diff/2/

Changes: https://reviews.apache.org/r/59714/diff/1-2/


Testing
---


Thanks,

Sushil Mohanty

Re: Review Request 59714: LENS-1428 : Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty]

> On June 2, 2017, 4:01 a.m., Amareshwari Sriramadasu wrote:
> > Please include unit tests

Added as part of https://reviews.apache.org/r/59744/. I have schema setup here 
to reproduce this.


- Sushil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/#review176728
---


On June 1, 2017, 12:51 p.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59714/
> ---
> 
> (Updated June 1, 2017, 12:51 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1428
> https://issues.apache.org/jira/browse/LENS-1428
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  b5c4c89 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 47bce65 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
> 038d689 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 1e54f13 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> 6c0d91a 
> 
> 
> Diff: https://reviews.apache.org/r/59714/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Review Request 59744: LENS-1430 : Expressions are not getting resolved correctly in union query

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59744/
---

Review request for lens.


Bugs: LENS-1430
https://issues.apache.org/jira/browse/LENS-1430


Repository: lens


Description
---

Expressions are not getting resolved correctly for the below case
 "case when expr1 = 0 then 0 else expr2 * 100 / expr1 end"
expr1 is answerable by Candidate1 and Candidate2
expr2 is answerable by Candidate1


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
7cad400 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java
 9422a5c 
  lens-cube/src/test/resources/schema/cubes/base/basecube.xml 55099c8 
  lens-cube/src/test/resources/schema/cubes/base/testcube.xml f123341 
  lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml 
69eda6d 
  lens-cube/src/test/resources/schema/facts/union_join_ctx_fact1.xml d5ac70a 
  lens-cube/src/test/resources/schema/facts/union_join_ctx_fact3.xml 27e859e 
  lens-cube/src/test/resources/schema/facts/union_join_ctx_fact4.xml e69de29 


Diff: https://reviews.apache.org/r/59744/diff/1/


Testing
---


Thanks,

Sushil Mohanty

[jira] [Created] (LENS-1430) Expressions are not getting resolved correctly in union query

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1430:


 Summary: Expressions are not getting resolved correctly in union 
query
 Key: LENS-1430
 URL: https://issues.apache.org/jira/browse/LENS-1430
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


Expressions are not getting resolved correctly for the below case
{CODE} 
case when expr1 = 0 then 0 else expr2 * 100 / expr1 end 
{CODE}
expr1 is answerable by Candidate1 and Candidate2
expr2 is answerable by Candidate1 




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1429) Queries failing intermittently with NO_REF_COL_AVAILABLE

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1429:
-
Attachment: LENS-1429.patch

Minor change, attaching patch directly.

> Queries failing intermittently with NO_REF_COL_AVAILABLE
> 
>
> Key: LENS-1429
> URL: https://issues.apache.org/jira/browse/LENS-1429
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1429.patch
>
>
> Have seen queries failing intermittently with below error.
> {CODE}
> 16 May 2017 11:59:39 [5af8e7ad-b9d7-44db-abdf-d8a28bdb9f3c] 
> [f38a238e-abcb-4168-a052-7114cee1c3a6 estimate-128] WARN  
> org.apache.lens.server.rewrite.RewriteUtil - Driver : hive/prod  Skipped for 
> the query rewriting due to
> org.apache.lens.server.api.error.LensException: 
> NO_REF_COL_AVAILABLE[my_ref_col]
> at 
> org.apache.lens.cube.parse.DenormalizationResolver$DenormalizationContext.pickColumnsForTable(DenormalizationResolver.java:227)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.DenormalizationResolver$DenormalizationContext.rewriteDenormctx(DenormalizationResolver.java:150)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.DimHQLContext.addDenormDims(DimHQLContext.java:119)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.MultiCandidateQueryWriterContext.addDenormDims(MultiCandidateQueryWriterContext.java:56)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.CubeQueryContext.getQueryWriter(CubeQueryContext.java:927)
>  ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.cube.parse.CubeQueryContext.toHQL(CubeQueryContext.java:947) 
> ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
> at 
> org.apache.lens.server.rewrite.RewriteUtil$DriverRewriterRunnable.run(RewriteUtil.java:396)
>  ~[classes/:na]
> at 
> org.apache.lens.server.query.QueryExecutionServiceImpl$RewriteEstimateRunnable.run(QueryExecutionServiceImpl.java:1855)
>  [classes/:na]
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_40]
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
> [na:1.8.0_40]
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [na:1.8.0_40]
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_40]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
> {CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1428) Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032927#comment-16032927
 ] 

Sushil Mohanty commented on LENS-1428:
--

Review at : https://reviews.apache.org/r/59714/

> Common measures are getting repeated in UnionQuery for JoinCandidate
> 
>
> Key: LENS-1428
> URL: https://issues.apache.org/jira/browse/LENS-1428
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
>
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other in the rewritten union 
> query.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59714: LENS-1428 : Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59714/
---

Review request for lens.


Bugs: LENS-1428
https://issues.apache.org/jira/browse/LENS-1428


Repository: lens


Description
---

For JoinCandidate if a measure is answerable by its children, getting projected 
in both. Instead the measure should be projected in one of the children and 
default measure i.e 0.0 for the other.


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
b5c4c89 
  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
47bce65 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 038d689 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
1e54f13 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
6c0d91a 


Diff: https://reviews.apache.org/r/59714/diff/1/


Testing
---


Thanks,

Sushil Mohanty

[jira] [Updated] (LENS-1428) Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1428:
-
Description: For JoinCandidate if a measure is answerable by its children, 
getting projected in both. Instead the measure should be projected in one of 
the children and default measure i.e 0.0 for the other in the rewritten union 
query.  (was: For JoinCandidate if a measure is answerable its children its 
getting projected in both. Instead the measure should be project in one of the 
children and default measure i.e 0.0 for the other.)

> Common measures are getting repeated in UnionQuery for JoinCandidate
> 
>
> Key: LENS-1428
> URL: https://issues.apache.org/jira/browse/LENS-1428
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
>
> For JoinCandidate if a measure is answerable by its children, getting 
> projected in both. Instead the measure should be projected in one of the 
> children and default measure i.e 0.0 for the other in the rewritten union 
> query.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1429) Queries failing intermittently with NO_REF_COL_AVAILABLE

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1429:


 Summary: Queries failing intermittently with NO_REF_COL_AVAILABLE
 Key: LENS-1429
 URL: https://issues.apache.org/jira/browse/LENS-1429
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


Have seen queries failing intermittently with below error.
{CODE}
16 May 2017 11:59:39 [5af8e7ad-b9d7-44db-abdf-d8a28bdb9f3c] 
[f38a238e-abcb-4168-a052-7114cee1c3a6 estimate-128] WARN  
org.apache.lens.server.rewrite.RewriteUtil - Driver : hive/prod  Skipped for 
the query rewriting due to
org.apache.lens.server.api.error.LensException: NO_REF_COL_AVAILABLE[my_ref_col]
at 
org.apache.lens.cube.parse.DenormalizationResolver$DenormalizationContext.pickColumnsForTable(DenormalizationResolver.java:227)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.DenormalizationResolver$DenormalizationContext.rewriteDenormctx(DenormalizationResolver.java:150)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.DimHQLContext.addDenormDims(DimHQLContext.java:119) 
~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.MultiCandidateQueryWriterContext.addDenormDims(MultiCandidateQueryWriterContext.java:56)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.CubeQueryContext.getQueryWriter(CubeQueryContext.java:927)
 ~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.cube.parse.CubeQueryContext.toHQL(CubeQueryContext.java:947) 
~[lens-cube-2.7.0-SNAPSHOT.jar:2.7.0-SNAPSHOT]
at 
org.apache.lens.server.rewrite.RewriteUtil$DriverRewriterRunnable.run(RewriteUtil.java:396)
 ~[classes/:na]
at 
org.apache.lens.server.query.QueryExecutionServiceImpl$RewriteEstimateRunnable.run(QueryExecutionServiceImpl.java:1855)
 [classes/:na]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[na:1.8.0_40]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
[na:1.8.0_40]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
[na:1.8.0_40]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
[na:1.8.0_40]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_40]
{CODE}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1428) Common measures are getting repeated in UnionQuery for JoinCandidate

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1428:


 Summary: Common measures are getting repeated in UnionQuery for 
JoinCandidate
 Key: LENS-1428
 URL: https://issues.apache.org/jira/browse/LENS-1428
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


For JoinCandidate if a measure is answerable its children its getting projected 
in both. Instead the measure should be project in one of the children and 
default measure i.e 0.0 for the other.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59223: LENS-1420 : Bug fixes in cube segmentation final rewritten query

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59223/
---

(Updated May 12, 2017, 11:07 a.m.)


Review request for lens.


Changes
---

Added unit tests to validate the bug fixes.


Bugs: LENS-1420
https://issues.apache.org/jira/browse/LENS-1420


Repository: lens


Description
---

Below bugs are addressed in final rewritten query.
1. Expressions used in having clause are not resolved in the final rewritten 
query incase of picked candidate is a segmentation.
2. Alias is not being replaced in order by clause for segmentation queries.
3. Query with two dim attributes referring to same join chain ending with wrong 
alias replacement.


Diffs (updated)
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
f86a84a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
bd7134b 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java
 7f8662a 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java
 0119f2e 
  lens-cube/src/test/resources/schema/cubes/base/b1c1cube.xml 6ab528a 
  lens-cube/src/test/resources/schema/cubes/base/b1cube.xml ef0e33d 
  lens-cube/src/test/resources/schema/cubes/base/b2c1cube.xml c71540b 
  lens-cube/src/test/resources/schema/cubes/base/b2cube.xml f0a80be 
  lens-cube/src/test/resources/schema/cubes/base/basecube.xml b8585ac 
  lens-cube/src/test/resources/schema/cubes/base/testcube.xml 2a11c88 
  lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml 
1308483 


Diff: https://reviews.apache.org/r/59223/diff/2/

Changes: https://reviews.apache.org/r/59223/diff/1-2/


Testing
---

lens-cube test cases are running fine.

---
 T E S T S
---
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; 
support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
support was removed in 8.0
Running TestSuite

Tests run: 440, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 493.856 sec - 
in TestSuite

Results :

Tests run: 440, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 9:37.126s
[INFO] Finished at: Fri May 12 12:44:16 IST 2017
[INFO] Final Memory: 65M/1499M
[INFO] 


Thanks,

Sushil Mohanty

[jira] [Commented] (LENS-1420) Bug fixes in cube segmentation final rewritten query

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007819#comment-16007819
 ] 

Sushil Mohanty commented on LENS-1420:
--

review at : https://reviews.apache.org/r/59223/

> Bug fixes in cube segmentation final rewritten query 
> -
>
> Key: LENS-1420
> URL: https://issues.apache.org/jira/browse/LENS-1420
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
>
> Found the below issues in fact-to-fact union and cube  segmentation rewritten 
> query.
> 1. Expressions used in having clause are not resolved in the final rewritten 
> query incase of picked candidate is a segmentation.
> 2. Alias is not being replaced in order by clause for segmentation queries.
> 3. Query with two dim attributes referring to same join chain ending with 
> wrong alias replacement.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 59223: LENS-1420 : Bug fixes in cube segmentation final rewritten query

[Sushil Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59223/
---

Review request for lens.


Bugs: LENS-1420
https://issues.apache.org/jira/browse/LENS-1420


Repository: lens


Description
---

Below bugs are addressed in final rewritten query.
1. Expressions used in having clause are not resolved in the final rewritten 
query incase of picked candidate is a segmentation.
2. Alias is not being replaced in order by clause for segmentation queries.
3. Query with two dim attributes referring to same join chain ending with wrong 
alias replacement.


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
f86a84a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
bd7134b 


Diff: https://reviews.apache.org/r/59223/diff/1/


Testing
---

lens-cube test cases are running fine.

---
 T E S T S
---
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; 
support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
support was removed in 8.0
Running TestSuite

Tests run: 440, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 493.856 sec - 
in TestSuite

Results :

Tests run: 440, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 9:37.126s
[INFO] Finished at: Fri May 12 12:44:16 IST 2017
[INFO] Final Memory: 65M/1499M
[INFO] 


Thanks,

Sushil Mohanty

[jira] [Created] (LENS-1420) Bug fixes in cube segmentation final rewritten query

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1420:


 Summary: Bug fixes in cube segmentation final rewritten query 
 Key: LENS-1420
 URL: https://issues.apache.org/jira/browse/LENS-1420
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


Found the below issues in fact-to-fact union and cube  segmentation rewritten 
query.
1. Expressions used in having clause are not resolved in the final rewritten 
query incase of picked candidate is a segmentation.
2. Alias is not being replaced in order by clause for segmentation queries.
3. Query with two dim attributes referring to same join chain ending with wrong 
alias replacement.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

[Sushil Mohanty (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996494#comment-15996494
 ] 

Sushil Mohanty commented on LENS-1419:
--

This patch also includes changes we missed due to merge conflicts in 
CubeSegmentation. 

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1419:
-
Attachment: LENS-1419.patch

Small change, attaching patch directly.

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

[Sushil Mohanty (JIRA)]

Sushil Mohanty created LENS-1419:


 Summary: UnionCandidates getting pruned when only dim attributes 
projected
 Key: LENS-1419
 URL: https://issues.apache.org/jira/browse/LENS-1419
 Project: Apache Lens
  Issue Type: Bug
  Components: cube
Reporter: Sushil Mohanty
Assignee: Sushil Mohanty


In current code there is a bug which prunes all UnionCandidates when only dim 
attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1416) Union query order by should work on column alias

[Sushil Mohanty (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sushil Mohanty updated LENS-1416:
-
Attachment: LENS-1416_2.patch

> Union query order by should work on column alias
> 
>
> Key: LENS-1416
> URL: https://issues.apache.org/jira/browse/LENS-1416
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>        Reporter: Sushil Mohanty
>    Assignee: Sushil Mohanty
> Attachments: LENS-1416_1.patch, LENS-1416_2.patch, LENS-1416.patch
>
>
> In union queries order by clause should have column alias instead of column.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)