subject:"Review Request 52040\: Handling data delay"

Re: Review Request 52040: Handling data delay

2016-10-21 Thread Lavkesh Lahngir


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/
---

(Updated Oct. 21, 2016, 8:56 a.m.)


Review request for lens.


Changes
---

Rebased with the master


Bugs: LENS-1327
https://issues.apache.org/jira/browse/LENS-1327


Repository: lens


Description
---

A instance goes to waiting state when there is some data missing. They are 
retried after some time.


Diffs (updated)
-

  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
 4f3409c 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 3d2605e 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
3ae59c6 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
5f472fc 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 1db8136 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 73277de 
  lens-server/src/main/resources/lensserver-default.xml 8e5fe8a 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 e698e2b 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java
 03f5d9b 
  src/site/apt/admin/config.apt f22fc0c 

Diff: https://reviews.apache.org/r/52040/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 52040: Handling data delay

2016-10-03 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review151147
---


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Sept. 30, 2016, 1 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> ---
> 
> (Updated Sept. 30, 2016, 1 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
> https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   lens-server/src/main/resources/lensserver-default.xml 
> 84ff9f9e42015da570eae94bf9748aa090417bae 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java
>  de364994ebf70ba92692f1745bf254b1c0046d79 
>   src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 52040: Handling data delay

2016-09-30 Thread Lavkesh Lahngir


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/
---

(Updated Sept. 30, 2016, 1 p.m.)


Review request for lens.


Bugs: LENS-1327
https://issues.apache.org/jira/browse/LENS-1327


Repository: lens


Description
---

A instance goes to waiting state when there is some data missing. They are 
retried after some time.


Diffs (updated)
-

  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
 4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
b924167fb819b3baae6be14efbb085fe72f99f54 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 1db8136c4e352d7dc03d7614511e89c6209ae151 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
  lens-server/src/main/resources/lensserver-default.xml 
84ff9f9e42015da570eae94bf9748aa090417bae 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java
 de364994ebf70ba92692f1745bf254b1c0046d79 
  src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5 

Diff: https://reviews.apache.org/r/52040/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 52040: Handling data delay

2016-09-30 Thread Amareshwari Sriramadasu



> On Sept. 29, 2016, 4:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java,
> >  line 60
> > 
> >
> > I'm still wondering if there should be a LAUNCHED state for 
> > ON_CONDITIONS_MET.
> 
> Lavkesh Lahngir wrote:
> That's why I changed it to LAUNCHING state from LAUNCHED.

LAUNCHING->WAITING->LAUNCHING->WAITING->LAUNCHING->WAITING->LAUNCHING and 
finally stopping at LAUNCHING only.

should we make  
LAUNCHING->WAITING->LAUNCHING->WAITING->LAUNCHING->WAITING->LAUNCHING-LAUNCHED 
? it would be clean state machine. Otherwise it seems confusing.

LAUNCHED is when all conditions are met. Then it is given to query service - it 
will be in LAUNCHED state as long as it is queued in query service. becomes 
running when it is running


- Amareshwari


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review150810
---


On Sept. 26, 2016, 9:53 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> ---
> 
> (Updated Sept. 26, 2016, 9:53 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
> https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   lens-server/src/main/resources/lensserver-default.xml 
> 84ff9f9e42015da570eae94bf9748aa090417bae 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
>   src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 52040: Handling data delay

2016-09-30 Thread Lavkesh Lahngir



> On Sept. 29, 2016, 4:58 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java,
> >  line 60
> > 
> >
> > I'm still wondering if there should be a LAUNCHED state for 
> > ON_CONDITIONS_MET.

That's why I changed it to LAUNCHING state from LAUNCHED.


- Lavkesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review150810
---


On Sept. 26, 2016, 9:53 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> ---
> 
> (Updated Sept. 26, 2016, 9:53 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
> https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   lens-server/src/main/resources/lensserver-default.xml 
> 84ff9f9e42015da570eae94bf9748aa090417bae 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
>   src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 52040: Handling data delay

2016-09-28 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review150810
---




lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 (line 58)


I'm still wondering if there should be a LAUNCHED state for 
ON_CONDITIONS_MET.


- Amareshwari Sriramadasu


On Sept. 26, 2016, 9:53 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> ---
> 
> (Updated Sept. 26, 2016, 9:53 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
> https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   lens-server/src/main/resources/lensserver-default.xml 
> 84ff9f9e42015da570eae94bf9748aa090417bae 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
>   src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 52040: Handling data delay

2016-09-26 Thread Lavkesh Lahngir


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/
---

(Updated Sept. 26, 2016, 9:53 a.m.)


Review request for lens.


Bugs: LENS-1327
https://issues.apache.org/jira/browse/LENS-1327


Repository: lens


Description
---

A instance goes to waiting state when there is some data missing. They are 
retried after some time.


Diffs (updated)
-

  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
 4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
b924167fb819b3baae6be14efbb085fe72f99f54 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 1db8136c4e352d7dc03d7614511e89c6209ae151 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
  lens-server/src/main/resources/lensserver-default.xml 
84ff9f9e42015da570eae94bf9748aa090417bae 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
  src/site/apt/admin/config.apt 24d5fd6e9bcfc38b6543ffc8ac16a32a025d70c5 

Diff: https://reviews.apache.org/r/52040/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 52040: Handling data delay

2016-09-20 Thread Lavkesh Lahngir



> On Sept. 20, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java,
> >  line 62
> > 
> >
> > Do we need ON_CONDITIONS_NOT_MET to be separate? I see on_creation it 
> > is waiting and on conditions_met it is Launched. I dont see any need for 
> > launching -> waiting.

The launching status will be set when we first create the an instanceRun. The 
schedule event handler will call estimate() method and set the method to 
waiting if some partitions are missing. 
A thread will be looking for all the instances which are in waiting state, and 
set the state to launching before notifying the event service with schedule 
event. 

I guess the definition has been changed a little bit.


- Lavkesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review149639
---


On Sept. 19, 2016, 3:14 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> ---
> 
> (Updated Sept. 19, 2016, 3:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
> https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 52040: Handling data delay

2016-09-20 Thread Amareshwari Sriramadasu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review149639
---




lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 (line 62)


Do we need ON_CONDITIONS_NOT_MET to be separate? I see on_creation it is 
waiting and on conditions_met it is Launched. I dont see any need for launching 
-> waiting.


- Amareshwari Sriramadasu


On Sept. 19, 2016, 3:14 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> ---
> 
> (Updated Sept. 19, 2016, 3:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
> https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Review Request 52040: Handling data delay

2016-09-19 Thread Lavkesh Lahngir


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/
---

Review request for lens.


Bugs: LENS-1327
https://issues.apache.org/jira/browse/LENS-1327


Repository: lens


Description
---

A instance goes to waiting state when there is some data missing. They are 
retried after some time.


Diffs
-

  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
 4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
  
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
  lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
b924167fb819b3baae6be14efbb085fe72f99f54 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
 1db8136c4e352d7dc03d7614511e89c6209ae151 
  
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
  
lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
 16a6c78ba5b36e3a164646fec6c2aca9f032d03e 

Diff: https://reviews.apache.org/r/52040/diff/


Testing
---


Thanks,

Lavkesh Lahngir

Re: Review Request 52040: Handling data delay

2016-09-19 Thread Lavkesh Lahngir


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review149478
---




lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
 (line 580)


This should come fron Configuration


- Lavkesh Lahngir


On Sept. 19, 2016, 3:14 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> ---
> 
> (Updated Sept. 19, 2016, 3:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
> https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

Review Request 52040: Handling data delay

Re: Review Request 52040: Handling data delay

11 matches

Site Navigation

Mail list logo

Footer information