subject:"Review Request 53059\: Druid sql rewriter changes"

Re: Review Request 53059: Druid sql rewriter changes

2016-11-06 Thread Rajitha R

> On Oct. 27, 2016, 12:17 p.m., Rajat Khandelwal wrote: > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java, > > line 681 > > > > > > We need to test for the opposite scenario too, if

Re: Review Request 53059: Druid sql rewriter changes

2016-11-06 Thread Rajat Khandelwal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/#review155111 --- Ship it! Ship It! - Rajat Khandelwal On Nov. 7, 2016, 12:27

Re: Review Request 53059: Druid sql rewriter changes

2016-11-06 Thread Rajitha R

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/ --- (Updated Nov. 7, 2016, 6:57 a.m.) Review request for lens and Rajat

Re: Review Request 53059: Druid sql rewriter changes

2016-11-04 Thread Rajat Khandelwal

> On Nov. 4, 2016, 12:55 p.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java, > > lines 133-152 > > > > > > This test confused me untill I downloaded

Re: Review Request 53059: Druid sql rewriter changes

2016-11-04 Thread Rajat Khandelwal

> On Oct. 27, 2016, 5:47 p.m., Rajat Khandelwal wrote: > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java, > > line 681 > > > > > > We need to test for the opposite scenario too, if

Re: Review Request 53059: Druid sql rewriter changes

2016-11-03 Thread Rajitha R

> On Oct. 27, 2016, 12:17 p.m., Rajat Khandelwal wrote: > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java, > > line 681 > > > > > > We need to test for the opposite scenario too, if

Re: Review Request 53059: Druid sql rewriter changes

2016-10-27 Thread Rajat Khandelwal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/#review153996 ---

Re: Review Request 53059: Druid sql rewriter changes

2016-10-27 Thread Rajitha R

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/ --- (Updated Oct. 27, 2016, 10:12 a.m.) Review request for lens and Rajat

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/ --- (Updated Oct. 26, 2016, 1:39 p.m.) Review request for lens and Rajat

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/ --- (Updated Oct. 26, 2016, 1:32 p.m.) Review request for lens and Rajat

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajat Khandelwal

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/#review153865 ---

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/ --- (Updated Oct. 26, 2016, 10:45 a.m.) Review request for lens and Rajat

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R

> On Oct. 21, 2016, 9:46 a.m., Rajat Khandelwal wrote: > > lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml, > > line 72 > > > > > > default should be false. This is already set to default

Re: Review Request 53059: Druid sql rewriter changes

2016-10-26 Thread Rajitha R

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53059/ --- (Updated Oct. 26, 2016, 10:38 a.m.) Review request for lens and Rajat