Re: [GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

It says that wildcard static imports are fine in unit tests specifically for things like JUnit, Hamcrest, and Mockito. On 7 August 2017 at 23:40, kenneth mcfarland wrote: > Can you be more specific as your own style guide forbids wildcards.. > > Thanks Matt! > > On

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user kpm1985 closed the pull request at: https://github.com/apache/logging-log4j2/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] logging-log4j2 issue #106: LOG4J2-1997 This cleans up the entire test packag...

Github user kpm1985 commented on the issue: https://github.com/apache/logging-log4j2/pull/106 And thanks for your input, but I think my time would be better served somewhere else where people don't refer the COD for calling out some childish commenting and capital letters. Take care!

[jira] [Closed] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kenneth mcfarland closed LOG4J2-1997. - Resolution: Fixed Someone else can fix this mess. > Test classes do not close resources

Re: [GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Can you be more specific as your own style guide forbids wildcards.. Thanks Matt! On Aug 7, 2017 9:13 PM, "Matt Sicker" wrote: > Did you even look at the style guide before going through with this? > > http://logging.apache.org/log4j/2.x/javastyle.html > > We use a code

Re: [GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Did you even look at the style guide before going through with this? http://logging.apache.org/log4j/2.x/javastyle.html We use a code formatter, too, which gets you most of the way there. If you want to help fix up style issues, contributing a better checkstyle configuration and fixing the

Re: [GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

The comment " this would look so cool using lambdas " is in my opinion childish. I did not know the order of static imports was incorrect, I'm used to seeing them at top almost every other project but a simple copy paste is fine. Even the Oracle examples do it but I really don't think it's worth

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117665#comment-16117665 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117648#comment-16117648 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117646#comment-16117646 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117639#comment-16117639 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798431 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/ShutdownTimeoutConfigurationTest.java --- @@ -16,13 +16,14 @@ */ package

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117643#comment-16117643 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797459 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java --- @@ -16,21 +16,24 @@ */ package

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117645#comment-16117645 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117659#comment-16117659 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797863 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventFactoryTest.java --- @@ -52,7 +53,7 @@ private ListAppender

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117649#comment-16117649 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798408 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java --- @@ -52,7 +53,7 @@ public void

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117652#comment-16117652 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798474 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/TimestampMessageTest.java --- @@ -16,6 +16,9 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797094 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/DeadlockTest.java --- @@ -17,6 +17,7 @@ package org.apache.logging.log4j.core;

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798273 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerUpdateTest.java --- @@ -16,11 +16,15 @@ */ package

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117656#comment-16117656 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117666#comment-16117666 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797908 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LogEventTest.java --- @@ -27,6 +27,7 @@ import

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117640#comment-16117640 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117658#comment-16117658 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798101 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/LoggerDateTest.java --- @@ -16,6 +16,8 @@ */ package

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117660#comment-16117660 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117668#comment-16117668 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798450 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/StrictXmlConfigTest.java --- @@ -16,6 +16,8 @@ */ package

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117641#comment-16117641 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798369 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/PropertiesFileConfigTest.java --- @@ -24,6 +24,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797278 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/GcFreeAsynchronousLoggingTest.java --- @@ -18,6 +18,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797686 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/HostNameTest.java --- @@ -16,21 +16,24 @@ */ package

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117638#comment-16117638 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131798324 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/PatternSelectorTest.java --- @@ -16,6 +16,10 @@ */ package

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117657#comment-16117657 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797217 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/CustomLevelsTest.java --- @@ -26,6 +26,7 @@ import

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131796906 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/BasicLoggingTest.java --- @@ -28,7 +29,7 @@ @Test public void

[jira] [Commented] (LOG4J2-1997) Test classes do not close resources and use deprecated methods

[ https://issues.apache.org/jira/browse/LOG4J2-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117653#comment-16117653 ] ASF GitHub Bot commented on LOG4J2-1997: Github user rgoers commented on a diff in the pull

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131796799 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelJsonTest.java --- @@ -16,19 +16,20 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131796844 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/AppenderRefLevelTest.java --- @@ -16,6 +16,8 @@ */ package

[GitHub] logging-log4j2 pull request #106: LOG4J2-1997 This cleans up the entire test...

Github user rgoers commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/106#discussion_r131797005 --- Diff: log4j-core/src/test/java/org/apache/logging/log4j/core/CronRolloverApp.java --- @@ -20,7 +20,7 @@ import

[GitHub] logging-log4j2 issue #29: Property log4j.skipJansi should have a default of ...

Github user rgoers commented on the issue: https://github.com/apache/logging-log4j2/pull/29 Jansi requires native code? That sucks. That means that Jansi can only be loaded by a single class loader and has to be in Tomcat's classpath. Given that, Jansi should default to being

Simple Patch Log4j2-1997

https://github.com/apache/logging-log4j2/pull/106

Re: [log4net][log4php] Xml Config file

To me this sounds rather strange because it sounds like a mix-up of unrelated applications. Let me explain my reasoning.. Typically, log4net would run on an entirely different machine than where log4php runs (i.e. apache2). At least it would not coexist within an apache2 process since apache2

Re: picocli in log4j

JCommander is in use mainly for the log4j-server stuff. On 7 August 2017 at 10:21, Chandra wrote: > +1 for picocli, I looked into it some time ago and looked pretty good. > In-fact, I wanted to use it for my own project for `JvmTop`. > > btw, where are we

Re: picocli in log4j

+1 for picocli, I looked into it some time ago and looked pretty good. In-fact, I wanted to use it for my own project for `JvmTop`. btw, where are we using `Jcommander` in log4j2? thanks, Chandra On 7 Aug 2017, 8:32 PM +0530, Matt Sicker , wrote: > I have no objections. I do

Re: [log4net][log4php] Xml Config file

I'm guessing that there are two separate applications running that want to use the same configuration. Such an idea wouldn't allow for logging to the same file all that well (synchronization issues), but being able to use the same config file across different languages would be nice. On 7 August

Re: picocli in log4j

I have no objections. I do like your library, though I haven't used it for any of my own projects yet (since most of what I've been working on for the past several months have all been Mesos-managed containers, so startup has been mostly delegated to environment variables for configuration). The

Re: [log4net][log4php] Xml Config file

You have an application that both runs log4net AND log4php in the same process? On 7 Aug 2017 12:51 p.m., "Domínguez Moraleja, Jose Luis" < jldomingue...@sice.com> wrote: > I'm working in a project and we want to use this two libraries log4php and > log4net. > > We want to use just one

[log4net][log4php] Xml Config file

I'm working in a project and we want to use this two libraries log4php and log4net. We want to use just one configuration file, is there any way to do it like this?: