+1
I have:
- checked the SHA512 checksums
- checked for unexpected changes in the list of files in the 1.2.0.tar.gz
archive compared to the 1.1.0.tar.gz release archive
- built on Windows using each compressed archive (using two conan recipes)
- built and tested a suite of applications using
Thanks for the prompt response Robert. Appreciated the pointers. Log4cxx
docs are indeed helpful. But a little bit more guidance in the vote email
could be helpful.
See that two other people (Piotr and Matt) quickly reviewed the release
after my email sharing the steps I followed
+1
Same checks as Volkan. Platform build info:
cmake version 3.28.1
GNU Make 3.81
Apple clang version 15.0.0 (clang-1500.1.0.2.5)
Target: arm64-apple-darwin23.2.0
Thread model: posix
pkg-config: 0.29.2
apr-1: 1.5.2
apr-util-1: 1.5.4
EXPAT: 2.5.0
—
Matt Sicker
> On Dec 28, 2023, at 18:00,
Hi,
On Fri, 29 Dec 2023 at 10:24, Volkan Yazıcı wrote:
> Skimmed through https://logging.staged.apache.org/log4cxx ✅
> `shasum --check *.512` ✅
> `for sigFile in *.asc; do gpg --verify $sigFile; done` ✅
> `cmake . && make && make test` ✅
I performed the same checks as Volkan (hashes,
1. staging website was in the email
2/3: I use this script to verify things. Feel free to adapt for your
own purposes: https://gist.github.com/rm5248/b2abba4bb4f1d9cf518be49d064a0be1
4. Build instructions are on the website:
https://logging.staged.apache.org/log4cxx/latest_stable/build-cmake.html
+1
Skimmed through https://logging.staged.apache.org/log4cxx ✅
`shasum --check *.512` ✅
`for sigFile in *.asc; do gpg --verify $sigFile; done` ✅
`cmake . && make && make test` ✅
I was keeping an eye on log4cxx commits, great activity! Kudos to Robert
and Stephen! ♂️
Nitpicks:
- `make
I would really appreciate a "review kit" for voting on log4cxx releases:
1. Where is the staging website?
2. How can I verify the checksum?
3. How can I verify the signatures?
4. How can I build and test the sources?
(For inspiration, you can check out the review kit we use for
