Re: Lucene 9.0 Java module system support

2020-04-11 Thread David Ryan
Hi Uwe, Thanks for taking the time out of your Easter break to respond. I've created the following Jira tickets for preparatory tasks: LUCENE-9317 Resolve package name conflicts for StandardAnalyzer to allow Java module system support LUCENE-931

Re: Lucene 9.0 Java module system support

2020-04-11 Thread Dawid Weiss
Thanks Uwe. On Sat, Apr 11, 2020 at 2:36 PM Uwe Schindler wrote: > > Hi, > > If you check my plan, that's my intended way to proceed. The preparatory > things like package fixes and api changes can be done before. Like the huge > commit regarding service loader that was done already. > > Uwe >

Re: Is defaults-javadoc.gradle still required?

2020-04-11 Thread Dawid Weiss
Thanks Tomoko. I will return to this tomorrow though as I wanted to fully understand what happened. I thought command-line tasks were ordered by gradle... but maybe I'm wrong and they're not! I'll clean up the default javadoc tomorrow too (so that it depends on renderJavadoc but doesn't do anything

Re: Is defaults-javadoc.gradle still required?

2020-04-11 Thread Tomoko Uchida
Hi Dawid, I've ported all options in default-javadoc.gradle to render-javadoc.gradle. I think we can now omit the default javaoc task. Note: I didn't encounter the same error related to apache yetus in default-javadoc.gradle (not sure why) when I wrote renderJavadoc task, so I skipped the workaroun

Re: Lucene 9.0 Java module system support

2020-04-11 Thread Uwe Schindler
Hi, If you check my plan, that's my intended way to proceed. The preparatory things like package fixes and api changes can be done before. Like the huge commit regarding service loader that was done already. Uwe Am April 11, 2020 12:27:26 PM UTC schrieb Dawid Weiss : >Can we focus on moving ou

Re: Lucene 9.0 Java module system support

2020-04-11 Thread Dawid Weiss
Can we focus on moving out of ant world on master first? :) It's already painful to maintain the gradle build in parallel. D. On Sat, Apr 11, 2020 at 1:14 PM Uwe Schindler wrote: > > Hi, > > > > I am currently on Easter vacation, but just wanted to give some feedback: > > They wy you are doing i

RE: Lucene 9.0 Java module system support

2020-04-11 Thread Uwe Schindler
Hi, I am currently on Easter vacation, but just wanted to give some feedback: They wy you are doing it works at the moment, because you don’t have anything to do with service providers. You don’t use custom codecs (outside lucene-core.jar) and you just ignored the META-IF/services folder. Yo

Is defaults-javadoc.gradle still required?

2020-04-11 Thread Dawid Weiss
Hi Tomoko, Is the default javadoc for gradle (defaults-javadoc.gradle) still required? I ask because renderJavadoc and the default javadoc seem to be clashing when they're executed together (especially in parallel; I discovered this when I would like to append all precommit tasks to root project's

Re: Lucene 9.0 Java module system support

2020-04-11 Thread David Ryan
Thanks, I had probably missed some of what Uwe was saying in regards to the limitation of what would be possible even if the suggested changes were made. Given your points and the fact that it would take a while to have any of the changes filter into a release version, I decided to develop a patch-