[jira] [Comment Edited] (LUCENE-6849) Add IndexWriter API to write segment(s) without refreshing them

2015-11-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991515#comment-14991515 ] Shai Erera edited comment on LUCENE-6849 at 11/5/15 10:5

[jira] [Commented] (LUCENE-6849) Add IndexWriter API to write segment(s) without refreshing them

2015-11-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991515#comment-14991515 ] Shai Erera commented on LUCENE-6849: LGTM. And +1 on making both flush public

[jira] [Commented] (SOLR-5944) Support updates of numeric DocValues

2015-10-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952290#comment-14952290 ] Shai Erera commented on SOLR-5944: -- Thanks Yonik for the clarification. The issue the

[jira] [Commented] (SOLR-5944) Support updates of numeric DocValues

2015-10-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948912#comment-14948912 ] Shai Erera commented on SOLR-5944: -- I'll admit that I haven't dug t

[jira] [Commented] (LUCENE-6828) Speed up requests for many rows

2015-10-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946187#comment-14946187 ] Shai Erera commented on LUCENE-6828: I read the post [~toke], very interesting!

Re: Encrypted index?

2015-09-08 Thread Shai Erera
> > I'm not a security folk, some of the responders might be. I am just trying > to deliver a requirement, and have been told by the client that the > suggested encrypted filesystem etc is not good enough. By 'we' I meant both you and the rest of us. I consider you on our side, the Lucene/Solr fo

Re: Encrypted index?

2015-09-08 Thread Shai Erera
The problem with encrypted file systems is that if someone gets access to the file system (not the disk, the file system e.g via ssh), it is wide open to it. It's like my work laptop's disk is encrypted, but after I've entered my password, all files are readable to me. However, files that are passw

[jira] [Commented] (SOLR-5606) REST based Collections API

2015-07-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646275#comment-14646275 ] Shai Erera commented on SOLR-5606: -- I like the {{POST /solr/admin/collect

[jira] [Commented] (SOLR-5606) REST based Collections API

2015-07-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645547#comment-14645547 ] Shai Erera commented on SOLR-5606: -- +1 on having /admin/* paths for Solr admin rel

[jira] [Comment Edited] (SOLR-5606) REST based Collections API

2015-07-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645547#comment-14645547 ] Shai Erera edited comment on SOLR-5606 at 7/29/15 6:35 AM: ---

[jira] [Commented] (SOLR-7233) rename zkcli.sh script it clashes with zkCli.sh from ZooKeeper on Mac when both are in $PATH

2015-07-27 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642394#comment-14642394 ] Shai Erera commented on SOLR-7233: -- Thanks [~janhoy]! > rename zkcli.sh sc

[jira] [Commented] (SOLR-7233) rename zkcli.sh script it clashes with zkCli.sh from ZooKeeper on Mac when both are in $PATH

2015-07-25 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641829#comment-14641829 ] Shai Erera commented on SOLR-7233: -- While we're at it, how about moving from s

[jira] [Commented] (SOLR-7825) Use slf4j consistently

2015-07-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640771#comment-14640771 ] Shai Erera commented on SOLR-7825: -- [~shalinmangar] I think I left it there by mis

Re: Welcome Christine Poerschke as Lucene/Solr committer

2015-07-24 Thread Shai Erera
Welcome! On Jul 24, 2015 11:13 AM, "Han Jiang" wrote: > Welcome, Christine! > > On Fri, Jul 24, 2015 at 3:27 PM, Adrien Grand wrote: > >> I'm pleased to announce that Christine Poerschke has accepted the PMC's >> invitation to become a committer. >> >> Christine, it's tradition that you introduc

RE: Why do SolrIndex/QueryAnalyzers use PER_FIELD_REUSE_STRATEGY

2015-07-24 Thread Shai Erera
gt; FieldType caches globally, no matter how many field instances.. > > > > So all is fine, it is just 4.7 where this optimization is not used. > > > > Uwe > > > > - > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.theta

Re: Why do SolrIndex/QueryAnalyzers use PER_FIELD_REUSE_STRATEGY

2015-07-23 Thread Shai Erera
they don't anymore. I will double check that too. Shai On Jul 24, 2015 9:39 AM, "Shai Erera" wrote: > Thanks Shalin, but I reviewed the code in trunk, and it still passes > PER_FIELD. I can double check but I'm pretty sure that's what I saw. > > Shai > On

Re: Why do SolrIndex/QueryAnalyzers use PER_FIELD_REUSE_STRATEGY

2015-07-23 Thread Shai Erera
SE_STRATEGY on a per-field type basis. One of my todos is to > create field types per node instead of per core for more savings. > > On Fri, Jul 24, 2015 at 3:24 AM, Shai Erera wrote: > > Hi > > > > I am helping to debug a Solr (4.7) deployment which shows >5.5GB of heap &

Why do SolrIndex/QueryAnalyzers use PER_FIELD_REUSE_STRATEGY

2015-07-23 Thread Shai Erera
Hi I am helping to debug a Solr (4.7) deployment which shows >5.5GB of heap usage by IndexSchema. This Solr in particular has one collection with 64 shards (2 replicas, but 64 cores on one node). The schema has ~120 fields, ~20 of them are of the same field type (text_general) and is serving aroun

[jira] [Resolved] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-7748. -- Resolution: Fixed > Fix bin/solr to work on IBM

[jira] [Commented] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637425#comment-14637425 ] Shai Erera commented on SOLR-7748: -- Thanks [~thelabdude]! > Fix bin/solr to work

[jira] [Updated] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7748: - Attachment: SOLR-7748.patch I messed up the comments so I decided to take care of the fix now :). I plan

[jira] [Issue Comment Deleted] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7748: - Comment: was deleted (was: Thanks [~thelabdude], that seems correct. I will try to upload a patch today

[jira] [Issue Comment Deleted] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7748: - Comment: was deleted (was: Thanks [~thelabdude], that seems correct. I will try to upload a patch today

[jira] [Issue Comment Deleted] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7748: - Comment: was deleted (was: Thanks [~thelabdude], that seems correct. I will try to upload a patch today

[jira] [Commented] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637327#comment-14637327 ] Shai Erera commented on SOLR-7748: -- Thanks [~thelabdude], that seems correct. I will

[jira] [Commented] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637325#comment-14637325 ] Shai Erera commented on SOLR-7748: -- Thanks [~thelabdude], that seems correct. I will

[jira] [Commented] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637326#comment-14637326 ] Shai Erera commented on SOLR-7748: -- Thanks [~thelabdude], that seems correct. I will

[jira] [Commented] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637324#comment-14637324 ] Shai Erera commented on SOLR-7748: -- Thanks [~thelabdude], that seems correct. I will

[jira] [Comment Edited] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637326#comment-14637326 ] Shai Erera edited comment on SOLR-7748 at 7/22/15 6:0

Re: Welcome Mikhail Khludnev as Lucene/Solr committer

2015-07-21 Thread Shai Erera
Welcome Mikhail! On Jul 21, 2015 10:23 AM, "Adrien Grand" wrote: > I'm pleased to announce that Mikhail Khludnev has accepted the PMC's > invitation to become a committer. > > Mikhail, it's tradition that you introduce yourself with a brief bio. > > Your handle "mkhl" has already added to the “lu

Re: ADDREPLICA and maxShardsPerNode and specifying a node

2015-07-08 Thread Shai Erera
I think that if addreplica is called, we should assume the user understands what he's doing, and we can safely ignore maxShardsPerNode. +1 in renaming it. I don't think it's late to do anything. First, it probably is an advanced parameter to be specified, if not expert. Second, we can always depre

Re: [CI] Lucene 5x Linux 64 Test Only - Build # 54928 - Failure!

2015-07-08 Thread Shai Erera
I failed to reproduce using IBM J9 1.8.0. I didn't beast it though, just ran the "reproduce with" line several times. Do you know the specific 1.8 version this build used? I'm using the latest, so could be it's a bug that was fixed. Shai On Wed, Jul 8, 2015 at 6:12 PM, Michael McCandless wrote:

[jira] [Resolved] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-7748. -- Resolution: Fixed Committed to trunk and 5x. Thanks [~elyograg] for the review! > Fix bin/solr to w

[jira] [Updated] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7748: - Attachment: SOLR-7748.patch Patch addresses Shawn's comments. [~elyograg], I also verified that the

[jira] [Comment Edited] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616349#comment-14616349 ] Shai Erera edited comment on SOLR-7748 at 7/7/15 10:42 AM: ---

[jira] [Commented] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-07 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616349#comment-14616349 ] Shai Erera commented on SOLR-7748: -- bq. but for J9, it sets the variable and doe

[jira] [Updated] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7748: - Attachment: SOLR-7748.patch Added CHANGES entry. I think it's ready, but will appreciate a second lo

[jira] [Updated] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-06 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7748: - Attachment: SOLR-7748.patch Patch fixes bin/solr too. > Fix bin/solr to work on IBM

[jira] [Commented] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612332#comment-14612332 ] Shai Erera commented on SOLR-7748: -- Thanks Shawn. I actually started to work with t

[jira] [Updated] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7748: - Attachment: solr-7748.patch Patch fixes bin/solr.cmd since I tested it on Windows. If there are no

[jira] [Created] (SOLR-7748) Fix bin/solr to work on IBM J9

2015-07-02 Thread Shai Erera (JIRA)
Shai Erera created SOLR-7748: Summary: Fix bin/solr to work on IBM J9 Key: SOLR-7748 URL: https://issues.apache.org/jira/browse/SOLR-7748 Project: Solr Issue Type: Bug Components

CLUSTERSTATUS times out after 180s

2015-06-26 Thread Shai Erera
Hi I'm using vanilla Solr 5.1.0 and see the CLUSTERSTATUS API sometimes times out after 180s in unit tests. For instance, one test does the following: - Start an embedded Solr instance (equivalent to MiniSolrCloudCluster), and sets up HttpSolrClient against it. - Starts another Solr instance - Cr

RE: Version field as DV

2015-06-22 Thread Shai Erera
There is one advantage to setting DocValues=true, if the application frequently updates documents. Pulling this value from a DV will be faster than stored fields. The latter need to be decompressed, filter all but the _version_ field etc. indexed=true is only needed if Solr needs to know which doc

Re: Moving to git?

2015-05-30 Thread Shai Erera
The commit then push workflow *is* what allows you to maintain multiple local branches without the nightmare of having multiple checkouts, and managing them. I don't think that moving to GIT has anything to do with Github. With SVN, we also don't have any nice user interface and/or pull requests,

Re: Moving to git?

2015-05-29 Thread Shai Erera
+1 to moving to git. Shai On May 30, 2015 6:24 AM, "Anshum Gupta" wrote: > *> There may be other good reasons for using git, but this is not one.* > I just added one more to the list. I think most other reasons have already > been spoken about in previous discussions. I'm not trying to debate on

Re: Solr log messages include the information of whoever created the release?

2015-05-18 Thread Shai Erera
g layout which logs the > jar file along with these details. For example, logback does this if the > xThrowable conversion word is enabled. > > See http://logback.qos.ch/manual/layouts.html#xThrowable > > On Mon, May 18, 2015 at 5:43 PM, Shai Erera wrote: > >> Hi >>

Solr log messages include the information of whoever created the release?

2015-05-18 Thread Shai Erera
Hi While inspecting Solr logs (vanilla 5.1), I've noticed log messages appear like this: Caused by: org.apache.solr.client.solrj.SolrServerException: Server refused connection at: http://localhost:43458/solr at org.apache.solr.client.solrj.impl.HttpSolrClient.executeMethod(HttpSolrClient.java

[jira] [Resolved] (SOLR-7486) HttpSolrClient.shutdown() should call close() and not vice versa

2015-04-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-7486. -- Resolution: Fixed Committed to 5x. > HttpSolrClient.shutdown() should call close() and not vice ve

[jira] [Commented] (SOLR-7486) HttpSolrClient.shutdown() should call close() and not vice versa

2015-04-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520735#comment-14520735 ] Shai Erera commented on SOLR-7486: -- Unless there are objections, I will commit this l

[jira] [Commented] (SOLR-7486) HttpSolrClient.shutdown() should call close() and not vice versa

2015-04-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519806#comment-14519806 ] Shai Erera commented on SOLR-7486: -- This is the usual pattern when deprecating code -

[jira] [Updated] (SOLR-7486) HttpSolrClient.shutdown() should call close() and not vice versa

2015-04-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7486: - Attachment: SOLR-7486.patch Trivial patch. This only affects 5x as shutdown() has been removed in trunk

[jira] [Created] (SOLR-7486) HttpSolrClient.shutdown() should call close() and not vice versa

2015-04-29 Thread Shai Erera (JIRA)
Shai Erera created SOLR-7486: Summary: HttpSolrClient.shutdown() should call close() and not vice versa Key: SOLR-7486 URL: https://issues.apache.org/jira/browse/SOLR-7486 Project: Solr Issue

Re: Default Solr response writer

2015-04-27 Thread Shai Erera
Thanks! I tracked down where the default is used in SolrDispatchFilter.handleAdminRequest(): QueryResponseWriter respWriter = SolrCore.DEFAULT_RESPONSE_WRITERS.get(solrReq.getParams().get(CommonParams.WT)); if (respWriter == null) respWriter = SolrCore.DEFAULT_RESPONSE_WRITERS.get("standa

Default Solr response writer

2015-04-27 Thread Shai Erera
Hi I tried to set the default response writer for admin operations to JSON by putting the following in solrconfig.xml: text/plain; charset=UTF-8 However, when I send a request, e.g.: curl -i -X GET http://localhost:8983/solr/admin/collections?action=LIST I still get the respons

[jira] [Resolved] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-7408. -- Resolution: Fixed Fix Version/s: 5.2 Trunk Committed to trunk and 5x. Thanks

[jira] [Updated] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7408: - Attachment: SOLR-7408.patch removed .trim() call in CloudDescriptor and also in ZkController.unregister

[jira] [Updated] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7408: - Attachment: SOLR-7408.patch \@Nightly annotation moved to class-level. > Let SolrCore be the only th

[jira] [Updated] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7408: - Attachment: SOLR-7408.patch Marked tests as \@Nightly and changed the assertion. BTW, I also noticed there

[jira] [Commented] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506550#comment-14506550 ] Shai Erera commented on SOLR-7408: -- I think that removing that check is dangerous s

[jira] [Updated] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7408: - Attachment: SOLR-7408.patch Thanks Anshum. Good catch on OnReconnect()! I applied all your comments

[jira] [Commented] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506443#comment-14506443 ] Shai Erera commented on SOLR-7408: -- Sure! > Let SolrCore be the only thin

[jira] [Commented] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504955#comment-14504955 ] Shai Erera commented on SOLR-7408: -- If there are no objections, I will commit

[jira] [Resolved] (LUCENE-6441) Change default formatting settings to break lines at 120 characters

2015-04-21 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-6441. Resolution: Fixed Fix Version/s: 5.2 Trunk Lucene Fields: New,Patch

Re: No CloudSolrClient.deleteConfig API

2015-04-20 Thread Shai Erera
> > Alan Woodward > www.flax.co.uk > > > On 20 Apr 2015, at 16:44, Shai Erera wrote: > > Hi > > In 5.1 CloudSolrClient offers uploadConfig, downloadConfig, listConfigs, > but no deleteConfig. Is that because it's covered by another class, or > there is an i

[jira] [Updated] (LUCENE-6441) Change default formatting settings to break lines at 120 characters

2015-04-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-6441: --- Attachment: LUCENE-6441.patch Thanks [~erickerickson], I didn't find a file under dev-tools

Re: No CloudSolrClient.deleteConfig API

2015-04-20 Thread Shai Erera
Correction, listConfigs() was added to ZkConfManager, not CloudSolrClient. Shai On Mon, Apr 20, 2015 at 6:44 PM, Shai Erera wrote: > Hi > > In 5.1 CloudSolrClient offers uploadConfig, downloadConfig, listConfigs, > but no deleteConfig. Is that because it's covered by another

No CloudSolrClient.deleteConfig API

2015-04-20 Thread Shai Erera
Hi In 5.1 CloudSolrClient offers uploadConfig, downloadConfig, listConfigs, but no deleteConfig. Is that because it's covered by another class, or there is an issue to support it? I don't mind adding one, just wanted to check it wasn't added because it can't be supported now. Shai

[jira] [Updated] (LUCENE-6441) Change default formatting settings to break lines at 120 characters

2015-04-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-6441: --- Attachment: LUCENE-6441.patch > Change default formatting settings to break lines at 120 charact

Re: Change line length setting in eclipse to 120 chars

2015-04-20 Thread Shai Erera
>> Please fix the Eclipse config to not force any breaks. >> >> Uwe >> >> Am 20. April 2015 14:13:15 MESZ, schrieb Toke Eskildsen < >> t...@statsbiblioteket.dk>: >> >>> On Sat, 2015-04-18 at 10:07 +0300, Shai Erera wrote: >>>

[jira] [Created] (LUCENE-6441) Change default formatting settings to break lines at 120 characters

2015-04-20 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-6441: -- Summary: Change default formatting settings to break lines at 120 characters Key: LUCENE-6441 URL: https://issues.apache.org/jira/browse/LUCENE-6441 Project: Lucene

Re: Change line length setting in eclipse to 120 chars

2015-04-20 Thread Shai Erera
wrote: > On Sat, 2015-04-18 at 10:07 +0300, Shai Erera wrote: > > > Our dev-tools/eclipse configure the project to break lines on 80 > > characters. Are there objections to change it to 120? > > Line length was discussed back in 2013 (search for "Line length in

[jira] [Updated] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7408: - Attachment: SOLR-7408.patch * Remove ZkController.watchZkDir * Remove code which cleaned the map in

[jira] [Commented] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501737#comment-14501737 ] Shai Erera commented on SOLR-7408: -- bq. Should we start ref counting the ZK watches?

Change line length setting in eclipse to 120 chars

2015-04-18 Thread Shai Erera
Hi Our dev-tools/eclipse configure the project to break lines on 80 characters. Are there objections to change it to 120? Shai

[jira] [Updated] (SOLR-7408) Let SolrCore be the only thing which registers/unregisters a config directory listener

2015-04-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7408: - Description: As reported here: http://markmail.org/message/ynkm2axkdprppgef, there is a race condition

[jira] [Commented] (SOLR-7408) Race condition can cause a config directory listener to be removed

2015-04-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501152#comment-14501152 ] Shai Erera commented on SOLR-7408: -- There are two ctors which aren't called by

[jira] [Commented] (SOLR-7408) Race condition can cause a config directory listener to be removed

2015-04-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499636#comment-14499636 ] Shai Erera commented on SOLR-7408: -- I will update the title of this JIRA and handl

[jira] [Commented] (SOLR-7408) Race condition can cause a config directory listener to be removed

2015-04-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499217#comment-14499217 ] Shai Erera commented on SOLR-7408: -- bq. Though I think I understand what you'

[jira] [Updated] (SOLR-7408) Race condition can cause a config directory listener to be removed

2015-04-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7408: - Attachment: SOLR-7408.patch Patch implements what I proposed: {{SorlCore.registerConfListener()}} is made

[jira] [Updated] (SOLR-7408) Race condition can cause a config directory listener to be removed

2015-04-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7408: - Attachment: SOLR-7408.patch The patch adds a test which reproduces the bug, however only if you place

[jira] [Created] (SOLR-7408) Race condition can cause a config directory listener to be removed

2015-04-16 Thread Shai Erera (JIRA)
Shai Erera created SOLR-7408: Summary: Race condition can cause a config directory listener to be removed Key: SOLR-7408 URL: https://issues.apache.org/jira/browse/SOLR-7408 Project: Solr Issue

Re: [JENKINS] Lucene-Solr-5.x-Linux (64bit/jdk1.7.0_76) - Build # 12145 - Failure!

2015-04-15 Thread Shai Erera
Committed a fix. It was a silly copy/paste error from a test inside solrj. It now passes from eclipse and cmd-line. Sorry for the noise. Shai On Wed, Apr 15, 2015 at 7:58 PM, Shai Erera wrote: > I'm looking into this. Strangely it passes from eclipse. > > On Wed, Apr 15, 2

Re: [JENKINS] Lucene-Solr-5.x-Linux (64bit/jdk1.7.0_76) - Build # 12145 - Failure!

2015-04-15 Thread Shai Erera
I'm looking into this. Strangely it passes from eclipse. On Wed, Apr 15, 2015 at 7:30 PM, Policeman Jenkins Server < jenk...@thetaphi.de> wrote: > Build: http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/12145/ > Java: 64bit/jdk1.7.0_76 -XX:-UseCompressedOops -XX:+UseSerialGC > > 1 tests faile

[jira] [Resolved] (SOLR-7401) NPE when concurrently creating and deleting collections

2015-04-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-7401. -- Resolution: Fixed Fix Version/s: 5.2 Trunk Committed to trunk and 5x. >

[jira] [Updated] (SOLR-7401) NPE when concurrently creating and deleting collections

2015-04-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7401: - Attachment: SOLR-7401.patch Patch adds a test and fixes the bug. Without the fix, the test fails pretty

[jira] [Created] (SOLR-7401) NPE when concurrently creating and deleting collections

2015-04-15 Thread Shai Erera (JIRA)
Shai Erera created SOLR-7401: Summary: NPE when concurrently creating and deleting collections Key: SOLR-7401 URL: https://issues.apache.org/jira/browse/SOLR-7401 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-7385) The clusterstatus API does not return the config name for a collection

2015-04-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493762#comment-14493762 ] Shai Erera commented on SOLR-7385: -- Thanks for the quick turnaround [~shalinma

Re: API for retrieving the configuration a collection was created with

2015-04-13 Thread Shai Erera
Thanks! On Apr 13, 2015 7:18 PM, "Shalin Shekhar Mangar" wrote: > I opened https://issues.apache.org/jira/browse/SOLR-7385 > > On Mon, Apr 13, 2015 at 8:08 PM, Shai Erera wrote: > >> Thanks Shalin, don't know how did I miss it :). I see that besides just >

Re: API for retrieving the configuration a collection was created with

2015-04-13 Thread Shai Erera
; shalinman...@gmail.com> wrote: > You can use the oddly named ZkStateReader.readConfigName(String > Collection) to get this information. We should add this information to the > cluster status API. > > On Mon, Apr 13, 2015 at 6:58 PM, Shai Erera wrote: > >> Hi >> >

API for retrieving the configuration a collection was created with

2015-04-13 Thread Shai Erera
Hi I was looking for some API (Java or REST) for retrieving the configuration name with which a collection was created. It doesn't appear as part of the cluster status information, nor is part of the DocCollection class. I eventually wrote this code: /** Returns a collection's configuration na

[jira] [Resolved] (SOLR-7336) Add State enum to Replica

2015-04-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved SOLR-7336. -- Resolution: Fixed Fix Version/s: 5.2 Trunk Committed to trunk and 5x. Thanks

TestRestoreCore failure on Windows

2015-04-04 Thread Shai Erera
Hi I updated to latest trunk and this test fails for me consistently: ant test -Dtestcase=TestRestoreCore -Dtests.seed=95E1D628B966 -Dtests.slow=true -Dtests.locale=ar_LB -Dtests.timezone=Africa/Addis_Ababa -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1 I run on Windows 7 64-bit, Ora

[jira] [Commented] (SOLR-7336) Add State enum to Replica

2015-04-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394044#comment-14394044 ] Shai Erera commented on SOLR-7336: -- [~markrmil...@gmail.com] if you have no objection

[jira] [Updated] (SOLR-7336) Add State enum to Replica

2015-04-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7336: - Attachment: SOLR-7336.patch Thanks Mark for the clarifications. I improved the javadocs of all the states

[jira] [Commented] (SOLR-7336) Add State enum to Replica

2015-04-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392920#comment-14392920 ] Shai Erera commented on SOLR-7336: -- OK. I will update the documentation to what you

[jira] [Commented] (LUCENE-6386) TestIndexWriterForceMerge still unreliable in NIGHTLY

2015-04-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392917#comment-14392917 ] Shai Erera commented on LUCENE-6386: OK, I understand. So in theory we could re

[jira] [Updated] (SOLR-7336) Add State enum to Replica

2015-04-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated SOLR-7336: - Attachment: SOLR-7336.patch Patch updated to latest trunk and with Mark's comments compiled. > A

[jira] [Commented] (SOLR-7336) Add State enum to Replica

2015-04-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392894#comment-14392894 ] Shai Erera commented on SOLR-7336: -- bq. ACTIVE Changed. bq. RECOVERING Changed.

[jira] [Commented] (LUCENE-6386) TestIndexWriterForceMerge still unreliable in NIGHTLY

2015-04-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392855#comment-14392855 ] Shai Erera commented on LUCENE-6386: I thought we only write the final segment

[jira] [Commented] (SOLR-7336) Add State enum to Replica

2015-04-02 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392582#comment-14392582 ] Shai Erera commented on SOLR-7336: -- Forgot to mention that I also rem

<    1   2   3   4   5   6   7   8   9   10   >