[jira] [Commented] (LUCENE-5460) Allow driving a query by sparse filters

2014-02-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906956#comment-13906956 ] Shai Erera commented on LUCENE-5460: You mean that if the filter is wrapped

[jira] [Commented] (LUCENE-5460) Allow driving a query by sparse filters

2014-02-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907009#comment-13907009 ] Shai Erera commented on LUCENE-5460: There is a TODO

[jira] [Commented] (LUCENE-5438) add near-real-time replication

2014-02-19 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905331#comment-13905331 ] Shai Erera commented on LUCENE-5438: I committed NRTIndexRevision and matching test

Refactoring code through Github pull requests

2014-02-18 Thread Shai Erera
Hi I tried to understand how do I merge changes that involve code refactoring, e.g. class rename, from github to our SVN. I had such a need, but I also thought about this issue, now that we accept PRs. So the scenario is this: - In your git clone, you rename class Foo to Bar - In order to commit

Re: Refactoring code through Github pull requests

2014-02-18 Thread Shai Erera
a workflow that works with the ASF mirror and svn, please write it up on the Wiki! On Tue, Feb 18, 2014 at 7:23 AM, Thomas Matthijs li...@selckin.be wrote: On Tue, Feb 18, 2014 at 1:18 PM, Shai Erera ser...@gmail.com wrote: Second, has anyone perhaps found a way to overcome that issue

Re: What's up w/ our github clone?

2014-02-18 Thread Shai Erera
anything. - Mark http://about.me/markrmiller On Feb 17, 2014, at 8:10 AM, Shai Erera ser...@gmail.com wrote: Hi Does anybody know what's up w/ our github clone? According to this: https://github.com/apache/lucene-solr, the last commit was 3 days ago... Shai

Re: Exposing random string generation

2014-02-17 Thread Shai Erera
I think you can rename _TestUtil for 4.x too - we're not obligated to any back-compat in test-framework. Shai On Mon, Feb 17, 2014 at 2:48 PM, Benson Margulies bimargul...@gmail.comwrote: Right, that's my target. Might I rename _TestUtil for 5.0 :-? On Mon, Feb 17, 2014 at 7:44 AM,

What's up w/ our github clone?

2014-02-17 Thread Shai Erera
Hi Does anybody know what's up w/ our github clone? According to this: https://github.com/apache/lucene-solr, the last commit was 3 days ago... Shai

[jira] [Commented] (LUCENE-5438) add near-real-time replication

2014-02-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903366#comment-13903366 ] Shai Erera commented on LUCENE-5438: I reviewed the patch and looks like it can

[jira] [Resolved] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5440. Resolution: Fixed Fix Version/s: 4.7 5.0 Committed the Solr changes

[jira] [Commented] (LUCENE-5443) DocValuesProducer#ramBytesUsed throws ConcurrentModificationException

2014-02-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900118#comment-13900118 ] Shai Erera commented on LUCENE-5443: I see that in Lucene45DVP, all access

Re: [jira] [Commented] (LUCENE-5443) DocValuesProducer#ramBytesUsed throws ConcurrentModificationException

2014-02-13 Thread Shai Erera
Right. I can create a patch a bit later, unless someone beats me to it... On Thu, Feb 13, 2014 at 10:21 AM, Uwe Schindler (JIRA) j...@apache.orgwrote: [

[jira] [Commented] (LUCENE-5443) DocValuesProducer#ramBytesUsed throws ConcurrentModificationException

2014-02-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900122#comment-13900122 ] Shai Erera commented on LUCENE-5443: Right. I can create a patch a bit later, unless

Re: DISCUSS: Go all in on github integration

2014-02-13 Thread Shai Erera
+1. I read on the Apache page that part of the integration lets us reply to an email from the GitHub issue, and the response is recorded on the issue. Does that work w/ JIRA as well? I gave it a quick try and seems like it doesn't.. Shai On Thu, Feb 13, 2014 at 9:41 AM, Tommaso Teofili

Re: DISCUSS: Go all in on github integration

2014-02-13 Thread Shai Erera
-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de *From:* Shai Erera [mailto:ser...@gmail.com] *Sent:* Thursday, February 13, 2014 9:30 AM *To:* dev@lucene.apache.org *Subject:* Re: DISCUSS: Go all in on github integration +1. I read on the Apache page that part

[jira] [Commented] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13900170#comment-13900170 ] Shai Erera commented on LUCENE-5440: I reviewed how we can perhaps not break the API

[jira] [Updated] (LUCENE-5443) DocValuesProducer#ramBytesUsed throws ConcurrentModificationException

2014-02-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5443: --- Attachment: LUCENE-5443.patch Add AtomicLong ramBytesUsed and compute it whenever a new buffer

Can we commit from github?

2014-02-13 Thread Shai Erera
Hi A while ago I decided to give git(hub) a try and forked trunk. I was able to work on several issues in parallel (while switching branches) and all within a single checkout and project in eclipse. It seemed to work well. But whenever I was ready to commit the work to Apache SVN, I applied a

[jira] [Resolved] (LUCENE-5443) DocValuesProducer#ramBytesUsed throws ConcurrentModificationException

2014-02-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5443. Resolution: Fixed Assignee: Shai Erera (was: Simon Willnauer) Lucene Fields: New

[jira] [Updated] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-13 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5440: --- Attachment: LUCENE-5440-solr.patch Patch decouples DocSet from Fixed/OpenBitSet. DocSet.setBitsOn

[jira] [Commented] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13897786#comment-13897786 ] Shai Erera commented on LUCENE-5440: I don't mind if we do it only in trunk. However

Re: [JENKINS] Lucene-4x-Linux-Java6-64-test-only - Build # 12501 - Failure!

2014-02-11 Thread Shai Erera
I committed a fix. Shai On Tue, Feb 11, 2014 at 4:57 PM, buil...@flonkings.com wrote: Build: builds.flonkings.com/job/Lucene-4x-Linux-Java6-64-test-only/12501/ 1 tests failed. REGRESSION: org.apache.lucene.search.TestSloppyPhraseQuery2.testRandomIncreasingSloppiness Error Message:

[jira] [Commented] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13897949#comment-13897949 ] Shai Erera commented on LUCENE-5440: bq. I don't think FixedBitSet should be external

[jira] [Updated] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5440: --- Attachment: LUCENE-5440-solr.patch Patch resolves an error I had w/ grouping (under Solr

[jira] [Commented] (LUCENE-5441) Decouple DocIdSet from OpenBitSet and FixedBitSet

2014-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896393#comment-13896393 ] Shai Erera commented on LUCENE-5441: OK, but I prefer a shorter name. I see that we

[jira] [Commented] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896717#comment-13896717 ] Shai Erera commented on LUCENE-5440: Committed this patch to trunk and 4x. I

[jira] [Commented] (LUCENE-5441) Decouple DocIdSet from OpenBitSet and FixedBitSet

2014-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896944#comment-13896944 ] Shai Erera commented on LUCENE-5441: Uwe, just a wild thought -- since you already

[jira] [Updated] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-10 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5440: --- Attachment: LUCENE-5440-solr.patch Patch moves solr/ code to use FixedBitSet instead of OpenBitSet

[jira] [Updated] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5440: --- Attachment: LUCENE-5440.patch bq. Maybe if we added a FixedBitSet.ensureCapacity You're right

[jira] [Commented] (LUCENE-5441) Decouple DocIdSet from OpenBitSet and FixedBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895937#comment-13895937 ] Shai Erera commented on LUCENE-5441: +1 to make the separation, I was thinking

[jira] [Commented] (LUCENE-5441) Decouple DocIdSet from OpenBitSet and FixedBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895972#comment-13895972 ] Shai Erera commented on LUCENE-5441: Yes, a dedicated class, I would call it maybe

[jira] [Updated] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5440: --- Attachment: LUCENE-5440.patch New patch: * All lucene/ code is now cut over to (Long)FixedBitSet

[jira] [Updated] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5440: --- Attachment: LUCENE-5440.patch Added a FixedBitSetIterator class and optimization in or/and etc

[jira] [Commented] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896039#comment-13896039 ] Shai Erera commented on LUCENE-5440: I don't think we should deprecate anything. We

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896200#comment-13896200 ] Shai Erera commented on LUCENE-5425: Uwe, I added an explicit FixedBitSetIterator

[jira] [Commented] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896202#comment-13896202 ] Shai Erera commented on LUCENE-5440: Fair enough, I will rename the Long version

[jira] [Updated] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5440: --- Attachment: LUCENE-5440.patch Patch renames to LongBitSet. Add LongFixedBitSet and replace usage

[jira] [Resolved] (LUCENE-3459) Change ChainedFilter to use FixedBitSet

2014-02-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-3459. Resolution: Duplicate Fix Version/s: (was: 4.7) ChainedFilter was changed to use

[jira] [Created] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-08 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5440: -- Summary: Add LongFixedBitSet and replace usage of OpenBitSet Key: LUCENE-5440 URL: https://issues.apache.org/jira/browse/LUCENE-5440 Project: Lucene - Core

[jira] [Updated] (LUCENE-5440) Add LongFixedBitSet and replace usage of OpenBitSet

2014-02-08 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5440: --- Attachment: LUCENE-5440.patch Attached patch contains LongFixedBitSet: * Only set/get(long

FixedBitSet vs OpenBitSet

2014-02-06 Thread Shai Erera
Hi I recently modified FixedBitSet.iterator() to return its own iterator, instead of OpenBitSetIterator, and while I haven't done a thorough performance test, the results on LUCENE-5425 suggested this helped in general (even though we only tested facets). Also, last night's benchmark for

Re: FixedBitSet vs OpenBitSet

2014-02-06 Thread Shai Erera
that wouldn't hurt performance? If we replaced get/set(int) with get/set(long) I'm not sure... Mike McCandless http://blog.mikemccandless.com On Thu, Feb 6, 2014 at 3:39 AM, Shai Erera ser...@gmail.com wrote: Hi I recently modified FixedBitSet.iterator() to return its own iterator

[jira] [Updated] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5425: --- Attachment: LUCENE-5425.patch * I implemented FixedBitSet.iterator() to return what I think

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892131#comment-13892131 ] Shai Erera commented on LUCENE-5425: I ran this on a 2013 Wikipedia dump w/ 6.7M docs

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892144#comment-13892144 ] Shai Erera commented on LUCENE-5425: John/Lei, can you please review the new patch

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892363#comment-13892363 ] Shai Erera commented on LUCENE-5425: bq. The createHitsSet is marked as protected

[jira] [Resolved] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-05 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5425. Resolution: Fixed Fix Version/s: 4.7 5.0 Assignee: Shai Erera

[jira] [Updated] (LUCENE-5431) Add FSLockFactory.toString()

2014-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5431: --- Attachment: LUCENE-5431.patch Modified FSDirectory/FSLockFactory.toString() to use getSimpleName

[jira] [Resolved] (LUCENE-5431) Add FSLockFactory.toString()

2014-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5431. Resolution: Fixed Fix Version/s: 4.7 5.0 Committed to trunk and 4x

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890892#comment-13890892 ] Shai Erera commented on LUCENE-5425: I think we shouldn't rush into changing

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891022#comment-13891022 ] Shai Erera commented on LUCENE-5425: I understand John. I wonder, if you can use

[jira] [Created] (LUCENE-5431) Add FSLockFactory.toString()

2014-02-03 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5431: -- Summary: Add FSLockFactory.toString() Key: LUCENE-5431 URL: https://issues.apache.org/jira/browse/LUCENE-5431 Project: Lucene - Core Issue Type: Improvement

[jira] [Updated] (LUCENE-5431) Add FSLockFactory.toString()

2014-02-03 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5431: --- Attachment: LUCENE-5431.patch * Add toString to FSLockFactory * Fix FilterDirectory to override

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888674#comment-13888674 ] Shai Erera commented on LUCENE-5425: The benchmarks that we ran were with luceneutil

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888676#comment-13888676 ] Shai Erera commented on LUCENE-5425: bq. Shai, given that using OBS Iterator

[jira] [Comment Edited] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888676#comment-13888676 ] Shai Erera edited comment on LUCENE-5425 at 2/1/14 7:07 PM

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-02-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888680#comment-13888680 ] Shai Erera commented on LUCENE-5425: Looks good. BTW newHitSet -- is that intentional

[jira] [Commented] (LUCENE-5428) Make Faceting counting array overridable

2014-02-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888682#comment-13888682 ] Shai Erera commented on LUCENE-5428: bq. Do you mean the method call overhead

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-01-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888445#comment-13888445 ] Shai Erera commented on LUCENE-5425: If we need to make any change to the API, it has

[jira] [Commented] (LUCENE-5428) Make Faceting counting array overridable

2014-01-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888449#comment-13888449 ] Shai Erera commented on LUCENE-5428: Mike and I discussed this in the past, but I

[jira] [Commented] (LUCENE-5426) Make SortedSetDocValuesReaderState customizable

2014-01-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888451#comment-13888451 ] Shai Erera commented on LUCENE-5426: Looks good to me. +1! Make

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-01-31 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13888452#comment-13888452 ] Shai Erera commented on LUCENE-5425: Just to make sure I don't come across wrong

[jira] [Updated] (LUCENE-5320) Create SearcherTaxonomyManager over Directory

2014-01-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5320: --- Attachment: LUCENE-5320.patch Patch adds a ctor to SearcherTaxoManager and tests. Create

[jira] [Resolved] (LUCENE-5320) Create SearcherTaxonomyManager over Directory

2014-01-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5320. Resolution: Fixed Fix Version/s: 4.7 5.0 Assignee: Shai Erera

[jira] [Commented] (LUCENE-5426) Make SortedSetDocValuesReaderState customizable

2014-01-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887465#comment-13887465 ] Shai Erera commented on LUCENE-5426: I've got few questions: * Why is this code now

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-01-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887469#comment-13887469 ] Shai Erera commented on LUCENE-5425: The current patch's intention seems to allow

[jira] [Commented] (LUCENE-5425) Make creation of FixedBitSet in FacetsCollector overridable

2014-01-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887548#comment-13887548 ] Shai Erera commented on LUCENE-5425: bq. didn't know a wrapper will affect

[jira] [Resolved] (LUCENE-5367) NoSuchElementException occurs when org.apache.lucene.facet.index.FacetFields is used.

2014-01-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5367. Resolution: Fixed Fix Version/s: 4.7 5.0 Assignee: Shai Erera

[jira] [Updated] (LUCENE-5387) Improve FacetConfig.build

2014-01-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5387: --- Attachment: LUCENE-5387.patch Patch fixes FacetConfig.build to take and return Document. I had

[jira] [Resolved] (LUCENE-5387) Improve FacetConfig.build

2014-01-29 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera resolved LUCENE-5387. Resolution: Fixed Fix Version/s: 4.7 5.0 Thanks Mike. Committed to 4x

[jira] [Commented] (LUCENE-5377) Lucene 4.6 cause mixed version segments info file(.si) wrong

2014-01-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878604#comment-13878604 ] Shai Erera commented on LUCENE-5377: Isn't it then a problem of anyone that will try

[jira] [Commented] (LUCENE-5377) Lucene 4.6 cause mixed version segments info file(.si) wrong

2014-01-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878701#comment-13878701 ] Shai Erera commented on LUCENE-5377: bq. First of all, some test should fail. I

[jira] [Commented] (LUCENE-5377) IW.addIndexes(Dir[]) causes silent index corruption

2014-01-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878719#comment-13878719 ] Shai Erera commented on LUCENE-5377: bq. For the short term i think we should just

[jira] [Commented] (LUCENE-5377) IW.addIndexes(Dir[]) causes silent index corruption

2014-01-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878726#comment-13878726 ] Shai Erera commented on LUCENE-5377: OK let's fix it separately. A new Codec ... just

[jira] [Commented] (LUCENE-5377) IW.addIndexes(Dir[]) causes silent index corruption

2014-01-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878764#comment-13878764 ] Shai Erera commented on LUCENE-5377: I guess I messed this up when working on LUCENE

[jira] [Commented] (LUCENE-5377) IW.addIndexes(Dir[]) causes silent index corruption

2014-01-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878778#comment-13878778 ] Shai Erera commented on LUCENE-5377: +1, looks good! IW.addIndexes(Dir[]) causes

[jira] [Commented] (LUCENE-5412) SI.files should strip segment names

2014-01-22 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13878796#comment-13878796 ] Shai Erera commented on LUCENE-5412: Could we change SegmentInfo.setFiles() to strip

Re: Iterating BinaryDocValues

2014-01-10 Thread Shai Erera
I agree with Robert. We should leave cloning BytesRefs to whoever needs that, and not penalize everyone else who don't need it. I must say I didn't know I can own those BytesRefs and I clone them whenever I need to. I think I was bitten by one of the other APIs, so I assumed returned BytesRefs are

[jira] [Commented] (LUCENE-5345) range facets don't work with float/double fields

2014-01-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867495#comment-13867495 ] Shai Erera commented on LUCENE-5345: You can try fixing the log message, I wonder

[jira] [Commented] (SOLR-5621) Let Solr use Lucene's SeacherManager

2014-01-09 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867499#comment-13867499 ] Shai Erera commented on SOLR-5621: -- +1 for using SearcherManager. In fact, I think

[jira] [Created] (LUCENE-5387) Improve FacetConfig.build

2014-01-06 Thread Shai Erera (JIRA)
Shai Erera created LUCENE-5387: -- Summary: Improve FacetConfig.build Key: LUCENE-5387 URL: https://issues.apache.org/jira/browse/LUCENE-5387 Project: Lucene - Core Issue Type: Improvement

[jira] [Commented] (LUCENE-5339) Simplify the facet module APIs

2014-01-04 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862499#comment-13862499 ] Shai Erera commented on LUCENE-5339: Thanks Mike! Do we need to delete the branch

Re: The Old Git Discussion

2014-01-03 Thread Shai Erera
I tried working with git several times, every time I told myself this time you're going to give it a serious try, and yet I kept going back to SVN each and every time. At times I thought it's because you're too familiar with SVN, git is probably at least as good once you'll get to master it. But

Re: The Old Git Discussion

2014-01-03 Thread Shai Erera
Also: if you fork https://github.com/apache/lucene-solr today, you can have this workflow, I think. This is how I worked on several Lucene issues in parallel, so it works .. sort of. The problem is that while your github changes are public, none of this appears in the Apache SVN after I

[jira] [Commented] (LUCENE-5339) Simplify the facet module APIs

2013-12-30 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13859394#comment-13859394 ] Shai Erera commented on LUCENE-5339: Committed the packages changes. Simplify

[jira] [Commented] (LUCENE-5339) Simplify the facet module APIs

2013-12-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858276#comment-13858276 ] Shai Erera commented on LUCENE-5339: It's just that we have *.facet.taxonomy package

[jira] [Comment Edited] (LUCENE-5339) Simplify the facet module APIs

2013-12-28 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858276#comment-13858276 ] Shai Erera edited comment on LUCENE-5339 at 12/29/13 7:48 AM

[jira] [Commented] (LUCENE-5376) Add a demo search server

2013-12-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856528#comment-13856528 ] Shai Erera commented on LUCENE-5376: bq. I think we should put it under lucene/demo

[jira] [Commented] (LUCENE-5367) NoSuchElementException occurs when org.apache.lucene.facet.index.FacetFields is used.

2013-12-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856533#comment-13856533 ] Shai Erera commented on LUCENE-5367: Thanks Lucien, this helps clarify the issue

[jira] [Updated] (LUCENE-5367) NoSuchElementException occurs when org.apache.lucene.facet.index.FacetFields is used.

2013-12-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-5367: --- Priority: Blocker (was: Major) NoSuchElementException occurs when

[jira] [Commented] (LUCENE-5367) NoSuchElementException occurs when org.apache.lucene.facet.index.FacetFields is used.

2013-12-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856534#comment-13856534 ] Shai Erera commented on LUCENE-5367: If LUCENE-5339 isn't committed before we release

[jira] [Commented] (LUCENE-5339) Simplify the facet module APIs

2013-12-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856535#comment-13856535 ] Shai Erera commented on LUCENE-5339: Few comments about package organization

[jira] [Commented] (LUCENE-5367) NoSuchElementException occurs when org.apache.lucene.facet.index.FacetFields is used.

2013-12-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13856187#comment-13856187 ] Shai Erera commented on LUCENE-5367: Lucien, do you have a testcase which reproduces

[jira] [Commented] (LUCENE-5367) NoSuchElementException occurs when org.apache.lucene.facet.index.FacetFields is used.

2013-12-12 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846204#comment-13846204 ] Shai Erera commented on LUCENE-5367: This is strange, it means that reset() is called

[jira] [Commented] (LUCENE-5345) range facets don't work with float/double fields

2013-12-01 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836016#comment-13836016 ] Shai Erera commented on LUCENE-5345: Is it mandatory to have facet/ depend

[jira] [Commented] (LUCENE-5339) Simplify the facet module APIs

2013-11-26 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13832824#comment-13832824 ] Shai Erera commented on LUCENE-5339: bq. Can we do something about the .writercache

[jira] [Commented] (LUCENE-5316) Taxonomy tree traversing improvement

2013-11-24 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13831050#comment-13831050 ] Shai Erera commented on LUCENE-5316: bq. we could hold in an int[][] * If we do

[jira] [Commented] (LUCENE-5316) Taxonomy tree traversing improvement

2013-11-23 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830874#comment-13830874 ] Shai Erera commented on LUCENE-5316: Thanks Mike. Looks like for the usual case

[jira] [Commented] (LUCENE-5345) range facets don't work with float/double fields

2013-11-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827827#comment-13827827 ] Shai Erera commented on LUCENE-5345: I'm not sure either if the problem

[jira] [Commented] (LUCENE-5345) range facets don't work with float/double fields

2013-11-20 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-5345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13827829#comment-13827829 ] Shai Erera commented on LUCENE-5345: Or, we could modify the test to use a custom

<    4   5   6   7   8   9   10   11   12   13   >