[jira] [Commented] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List

[ https://issues.apache.org/jira/browse/LUCENE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347823#comment-16347823 ] Timothy M. Rodriguez commented on LUCENE-8145: -- Thanks for the CC [~dsmiley]. [~romseygeek]

[jira] [Commented] (LUCENE-7976) Add a parameter to TieredMergePolicy to merge segments that have more than X percent deleted documents

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213052#comment-16213052 ] Timothy M. Rodriguez commented on LUCENE-7976: -- I didn't know that! Thanks for pointing out.

[jira] [Commented] (LUCENE-8000) Document Length Normalization in BM25Similarity correct?

[ https://issues.apache.org/jira/browse/LUCENE-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213042#comment-16213042 ] Timothy M. Rodriguez commented on LUCENE-8000: -- [~rcmuir] thanks for the further

[jira] [Commented] (LUCENE-7976) Add a parameter to TieredMergePolicy to merge segments that have more than X percent deleted documents

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213024#comment-16213024 ] Timothy M. Rodriguez commented on LUCENE-7976: -- An additional place where deletions come up

[jira] [Commented] (LUCENE-8000) Document Length Normalization in BM25Similarity correct?

[ https://issues.apache.org/jira/browse/LUCENE-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211286#comment-16211286 ] Timothy M. Rodriguez commented on LUCENE-8000: -- Makes sense, agreed on both points. >

[jira] [Commented] (LUCENE-8000) Document Length Normalization in BM25Similarity correct?

[ https://issues.apache.org/jira/browse/LUCENE-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211227#comment-16211227 ] Timothy M. Rodriguez commented on LUCENE-8000: -- +1 for keeping the existing behavior of

[jira] [Commented] (LUCENE-7976) Add a parameter to TieredMergePolicy to merge segments that have more than X percent deleted documents

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191470#comment-16191470 ] Timothy M. Rodriguez commented on LUCENE-7976: -- If a collection has many 5GB segments, it's

[jira] [Commented] (LUCENE-7976) Add a parameter to TieredMergePolicy to merge segments that have more than X percent deleted documents

[ https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191319#comment-16191319 ] Timothy M. Rodriguez commented on LUCENE-7976: -- Agreed, it's not strictly a result of

[jira] [Commented] (LUCENE-6513) Allow limits on SpanMultiTermQueryWrapper expansion

[ https://issues.apache.org/jira/browse/LUCENE-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16188913#comment-16188913 ] Timothy M. Rodriguez commented on LUCENE-6513: -- Apologies for the late alternative

[jira] [Commented] (LUCENE-6513) Allow limits on SpanMultiTermQueryWrapper expansion

[ https://issues.apache.org/jira/browse/LUCENE-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075601#comment-16075601 ] Timothy M. Rodriguez commented on LUCENE-6513: -- [~romseygeek] we've written a patch to solve

[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025178#comment-16025178 ] Timothy M. Rodriguez commented on LUCENE-7844: -- This syntax looks really good! {code}

[jira] [Commented] (LUCENE-7844) UnifiedHighlighter: simplify "maxPassages" input API

[ https://issues.apache.org/jira/browse/LUCENE-7844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024765#comment-16024765 ] Timothy M. Rodriguez commented on LUCENE-7844: -- +1 on the comparator use. That definitely

[jira] [Commented] (LUCENE-7620) UnifiedHighlighter: add target character width BreakIterator wrapper

[ https://issues.apache.org/jira/browse/LUCENE-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813306#comment-15813306 ] Timothy M. Rodriguez commented on LUCENE-7620: -- Me too! > UnifiedHighlighter: add target

[jira] [Comment Edited] (LUCENE-7620) UnifiedHighlighter: add target character width BreakIterator wrapper

[ https://issues.apache.org/jira/browse/LUCENE-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806094#comment-15806094 ] Timothy M. Rodriguez edited comment on LUCENE-7620 at 1/6/17 11:09 PM:

[jira] [Commented] (LUCENE-7620) UnifiedHighlighter: add target character width BreakIterator wrapper

[ https://issues.apache.org/jira/browse/LUCENE-7620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806094#comment-15806094 ] Timothy M. Rodriguez commented on LUCENE-7620: -- Very useful! I like that it decorates an

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801792#comment-15801792 ] Timothy M. Rodriguez commented on SOLR-8241: +1 for this issue. Solr currently uses

[jira] [Comment Edited] (LUCENE-7578) UnifiedHighlighter: Convert PhraseHelper to use SpanCollector API

[ https://issues.apache.org/jira/browse/LUCENE-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709795#comment-15709795 ] Timothy M. Rodriguez edited comment on LUCENE-7578 at 11/30/16 9:15 PM:

[jira] [Commented] (LUCENE-7578) UnifiedHighlighter: Convert PhraseHelper to use SpanCollector API

[ https://issues.apache.org/jira/browse/LUCENE-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709795#comment-15709795 ] Timothy M. Rodriguez commented on LUCENE-7578: -- Some care would have to be taken with spans,

[jira] [Commented] (LUCENE-7575) UnifiedHighlighter: add requireFieldMatch=false support

[ https://issues.apache.org/jira/browse/LUCENE-7575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709621#comment-15709621 ] Timothy M. Rodriguez commented on LUCENE-7575: -- Looks good to me too. Some additional

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693717#comment-15693717 ] Timothy M. Rodriguez commented on SOLR-9708: Haha, no problem. It'll improve usability quite a

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691807#comment-15691807 ] Timothy M. Rodriguez commented on SOLR-9708: Looks great! Adding the other highlighters to

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683730#comment-15683730 ] Timothy M. Rodriguez commented on SOLR-9708: Added a normalizeParameters method that will set

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683698#comment-15683698 ] Timothy M. Rodriguez commented on SOLR-9708: I've posted an initial commit that allows the user

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668824#comment-15668824 ] Timothy M. Rodriguez commented on SOLR-9708: I was suggesting instead of hl.tag.pre, but

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668766#comment-15668766 ] Timothy M. Rodriguez commented on SOLR-9708: I thought the suggestion was to use hl.tag.pre

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15668715#comment-15668715 ] Timothy M. Rodriguez commented on SOLR-9708: I'm okay with hl.tag.pre/post, but it may not

[jira] [Commented] (LUCENE-7526) Improvements to UnifiedHighlighter OffsetStrategies

[ https://issues.apache.org/jira/browse/LUCENE-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665317#comment-15665317 ] Timothy M. Rodriguez commented on LUCENE-7526: -- Added the proposed changes. I'm on the

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665291#comment-15665291 ] Timothy M. Rodriguez commented on SOLR-9708: Thanks for catching those things. I've fixed them

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662087#comment-15662087 ] Timothy M. Rodriguez commented on SOLR-9708: Let me know what you think. If it looks good, I

[jira] [Commented] (SOLR-9708) Expose UnifiedHighlighter in Solr

[ https://issues.apache.org/jira/browse/SOLR-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662086#comment-15662086 ] Timothy M. Rodriguez commented on SOLR-9708: I've pushed tests for the configurable items in

[jira] [Commented] (LUCENE-7526) Improvements to UnifiedHighlighter OffsetStrategies

[ https://issues.apache.org/jira/browse/LUCENE-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660330#comment-15660330 ] Timothy M. Rodriguez commented on LUCENE-7526: -- Other than that, I think this code is in

[jira] [Commented] (LUCENE-7526) Improvements to UnifiedHighlighter OffsetStrategies

[ https://issues.apache.org/jira/browse/LUCENE-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660328#comment-15660328 ] Timothy M. Rodriguez commented on LUCENE-7526: -- I've merged with the changes from

[jira] [Commented] (LUCENE-7546) Rename uses of people.apache.org to home.apache.org

[ https://issues.apache.org/jira/browse/LUCENE-7546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649031#comment-15649031 ] Timothy M. Rodriguez commented on LUCENE-7546: -- I like the idea of dist.apache.org as an

[jira] [Commented] (LUCENE-7438) UnifiedHighlighter

[ https://issues.apache.org/jira/browse/LUCENE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15623451#comment-15623451 ] Timothy M. Rodriguez commented on LUCENE-7438: -- Not yet, we have an initial general

[jira] [Created] (SOLR-9708) Expose UnifiedHighlighter in Solr

Timothy M. Rodriguez created SOLR-9708: -- Summary: Expose UnifiedHighlighter in Solr Key: SOLR-9708 URL: https://issues.apache.org/jira/browse/SOLR-9708 Project: Solr Issue Type:

[jira] [Commented] (LUCENE-7526) Improvements to UnifiedHighlighter OffsetStrategies

[ https://issues.apache.org/jira/browse/LUCENE-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616294#comment-15616294 ] Timothy M. Rodriguez commented on LUCENE-7526: -- Thanks [~dsmiley] :). I've just submitted

[jira] [Commented] (LUCENE-7526) Improvements to UnifiedHighlighter OffsetStrategies

[ https://issues.apache.org/jira/browse/LUCENE-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612996#comment-15612996 ] Timothy M. Rodriguez commented on LUCENE-7526: -- Pull request forthcoming - I had some more

[jira] [Created] (LUCENE-7526) Improvements to UnifiedHighlighter OffsetStrategies

Timothy M. Rodriguez created LUCENE-7526: Summary: Improvements to UnifiedHighlighter OffsetStrategies Key: LUCENE-7526 URL: https://issues.apache.org/jira/browse/LUCENE-7526 Project: Lucene -

[jira] [Updated] (LUCENE-7526) Improvements to UnifiedHighlighter OffsetStrategies

[ https://issues.apache.org/jira/browse/LUCENE-7526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy M. Rodriguez updated LUCENE-7526: - Description: This ticket improves several of the UnifiedHighlighter

[jira] [Commented] (SOLR-9542) Kerberos delegation tokens requires missing Jackson library

[ https://issues.apache.org/jira/browse/SOLR-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537247#comment-15537247 ] Timothy M. Rodriguez commented on SOLR-9542: Not sure it makes sense to introduce a Jackson

[jira] [Commented] (LUCENE-7438) UnifiedHighlighter

[ https://issues.apache.org/jira/browse/LUCENE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537117#comment-15537117 ] Timothy M. Rodriguez commented on LUCENE-7438: -- After further consideration, it seems best

[jira] [Commented] (LUCENE-7438) UnifiedHighlighter

[ https://issues.apache.org/jira/browse/LUCENE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474731#comment-15474731 ] Timothy M. Rodriguez commented on LUCENE-7438: -- Actually, I think passage relevancy might be

[jira] [Commented] (LUCENE-7438) UnifiedHighlighter

[ https://issues.apache.org/jira/browse/LUCENE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473896#comment-15473896 ] Timothy M. Rodriguez commented on LUCENE-7438: -- I'm not a fan of forking classes with Uxyz

[jira] [Comment Edited] (LUCENE-7438) UnifiedHighlighter

[ https://issues.apache.org/jira/browse/LUCENE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470904#comment-15470904 ] Timothy M. Rodriguez edited comment on LUCENE-7438 at 9/7/16 7:31 PM:

[jira] [Comment Edited] (LUCENE-7438) UnifiedHighlighter

[ https://issues.apache.org/jira/browse/LUCENE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470904#comment-15470904 ] Timothy M. Rodriguez edited comment on LUCENE-7438 at 9/7/16 3:49 PM:

[jira] [Commented] (LUCENE-7438) UnifiedHighlighter

[ https://issues.apache.org/jira/browse/LUCENE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470904#comment-15470904 ] Timothy M. Rodriguez commented on LUCENE-7438: -- Pull request here:

[jira] [Commented] (LUCENE-7438) UnifiedHighlighter

[ https://issues.apache.org/jira/browse/LUCENE-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470848#comment-15470848 ] Timothy M. Rodriguez commented on LUCENE-7438: -- Some additional information: h2. Missing

[jira] [Created] (LUCENE-7438) UnifiedHighlighter

Timothy M. Rodriguez created LUCENE-7438: Summary: UnifiedHighlighter Key: LUCENE-7438 URL: https://issues.apache.org/jira/browse/LUCENE-7438 Project: Lucene - Core Issue Type: