[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243153#comment-13243153
]
Yonik Seeley commented on LUCENE-3774:
--
bq. I have a different view on this. Things
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243160#comment-13243160
]
Robert Muir commented on LUCENE-3774:
-
I agree too I think, its worse now that
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13243162#comment-13243162
]
Dawid Weiss commented on LUCENE-3774:
-
I'm for pushing it to the top level. This will
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210392#comment-13210392
]
Steven Rowe commented on LUCENE-3774:
-
Hi Dawid,
I noticed that on branch_3x, there
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210399#comment-13210399
]
Dawid Weiss commented on LUCENE-3774:
-
Mhmm... this would be weird, wouldn't it? I'll
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210400#comment-13210400
]
Dawid Weiss commented on LUCENE-3774:
-
Mhmm... this would be weird, wouldn't it? I'll
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210402#comment-13210402
]
Dawid Weiss commented on LUCENE-3774:
-
It's under lucene/tools/custom-tasks.xml? It
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210406#comment-13210406
]
Steven Rowe commented on LUCENE-3774:
-
Aha - sorry for the noise - I was restricting
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210412#comment-13210412
]
Steven Rowe commented on LUCENE-3774:
-
bq. It needs to be in a separate file because
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210415#comment-13210415
]
Steven Rowe commented on LUCENE-3774:
-
Crap, my last comment is wrong too:
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13210418#comment-13210418
]
Dawid Weiss commented on LUCENE-3774:
-
No worries, I'm glad you're double checking
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206739#comment-13206739
]
Dawid Weiss commented on LUCENE-3774:
-
I assumed modules doesn't need to be
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206767#comment-13206767
]
Uwe Schindler commented on LUCENE-3774:
---
Thanks Dawid, especially for the really
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206770#comment-13206770
]
Dawid Weiss commented on LUCENE-3774:
-
No problem, like I said -- we have dealt with
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206793#comment-13206793
]
Dawid Weiss commented on LUCENE-3774:
-
Steve, will you double check again if
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206875#comment-13206875
]
Steven Rowe commented on LUCENE-3774:
-
bq. I assumed modules doesn't need to be
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206887#comment-13206887
]
Dawid Weiss commented on LUCENE-3774:
-
bq. Is there some reason why you can't do
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206893#comment-13206893
]
Steven Rowe commented on LUCENE-3774:
-
:) OK - please assign to yourself.
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206963#comment-13206963
]
Steven Rowe commented on LUCENE-3774:
-
Hi Dawid,
I noticed you put a CHANGES.txt
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206972#comment-13206972
]
Dawid Weiss commented on LUCENE-3774:
-
See, that's why I insisted you do the commit
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206378#comment-13206378
]
Dawid Weiss commented on LUCENE-3774:
-
I looked at DependencyChecker, we should
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206396#comment-13206396
]
Dawid Weiss commented on LUCENE-3774:
-
I wrote a task as a quick experiment, it looks
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206397#comment-13206397
]
Dawid Weiss commented on LUCENE-3774:
-
An example output:
{noformat}
[license-check]
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206399#comment-13206399
]
Robert Muir commented on LUCENE-3774:
-
{quote}
The upside of this is that we could
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206410#comment-13206410
]
Dawid Weiss commented on LUCENE-3774:
-
I'll finish the implementation and add to this
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206409#comment-13206409
]
Dawid Weiss commented on LUCENE-3774:
-
I have a different view on this. Things like
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206414#comment-13206414
]
Robert Muir commented on LUCENE-3774:
-
{quote}
The task can be used per-module (even
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206415#comment-13206415
]
Dawid Weiss commented on LUCENE-3774:
-
Sure there are pros and cons. I just tend to
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206425#comment-13206425
]
Dawid Weiss commented on LUCENE-3774:
-
I've attached a patch and pushed the branch to
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206427#comment-13206427
]
Dawid Weiss commented on LUCENE-3774:
-
You can add verbose=true to check-licenses
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206441#comment-13206441
]
Steven Rowe commented on LUCENE-3774:
-
Hi Dawid,
I agree with you that a top-level
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206445#comment-13206445
]
Steven Rowe commented on LUCENE-3774:
-
Dawid, I just skimmed your patch and I see
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206461#comment-13206461
]
Robert Muir commented on LUCENE-3774:
-
{quote}
Having a few top-level exclusion rules
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206465#comment-13206465
]
Dawid Weiss commented on LUCENE-3774:
-
Hi Steven. I will merge the changes, no
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206469#comment-13206469
]
Dawid Weiss commented on LUCENE-3774:
-
bq. because lucene/ must be
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206473#comment-13206473
]
Dawid Weiss commented on LUCENE-3774:
-
Ok, so now Solr reaches out to Lucene's
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206476#comment-13206476
]
Uwe Schindler commented on LUCENE-3774:
---
Dawid: Nice Task implementation, I like
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206488#comment-13206488
]
Steven Rowe commented on LUCENE-3774:
-
bq. I'll re-generate the patch.
bq. git patch
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206490#comment-13206490
]
Dawid Weiss commented on LUCENE-3774:
-
Uwe: I'm not sure if I used anything that
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206496#comment-13206496
]
Dawid Weiss commented on LUCENE-3774:
-
Steve what computer are you working on? I just
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206497#comment-13206497
]
Dawid Weiss commented on LUCENE-3774:
-
I know whom to blame. I used ant 1.7.1 and the
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206504#comment-13206504
]
Steven Rowe commented on LUCENE-3774:
-
bq. I know whom to blame. I used ant 1.7.1 and
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206511#comment-13206511
]
Uwe Schindler commented on LUCENE-3774:
---
ANT 1.8 improved performance of fileSet/,
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206515#comment-13206515
]
Dawid Weiss commented on LUCENE-3774:
-
Yep, sure, this isn't crucial by any means. I
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206528#comment-13206528
]
Dawid Weiss commented on LUCENE-3774:
-
Oh, ok. I see the slowdown still, it's just
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206529#comment-13206529
]
Uwe Schindler commented on LUCENE-3774:
---
bq. Oh, ok. I see the slowdown still, it's
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206531#comment-13206531
]
Steven Rowe commented on LUCENE-3774:
-
bq. Can you please double check that
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206530#comment-13206530
]
Dawid Weiss commented on LUCENE-3774:
-
That had to be something really ugly in ANT
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206533#comment-13206533
]
Steven Rowe commented on LUCENE-3774:
-
Timings for me under Ant 1.7.1:
{noformat}
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206535#comment-13206535
]
Dawid Weiss commented on LUCENE-3774:
-
As for jsonic-NOTICE.txt, I have that file on
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206536#comment-13206536
]
Dawid Weiss commented on LUCENE-3774:
-
Ok, fixed jsonic-NOTICE.txt (added the
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206539#comment-13206539
]
Dawid Weiss commented on LUCENE-3774:
-
Ehm. Weird, I used ANT 1.7.1 and everything
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206541#comment-13206541
]
Dawid Weiss commented on LUCENE-3774:
-
Oh, I see what's wrong now. import is before
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206544#comment-13206544
]
Steven Rowe commented on LUCENE-3774:
-
bq. This patch fixes the issue with failing
[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206354#comment-13206354
]
Mark Miller commented on LUCENE-3774:
-
Thanks for taking this on Steve!
55 matches
Mail list logo
