[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-11-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237022#comment-16237022 ] ASF subversion and git services commented on LUCENE-8007: - Commit

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-11-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235677#comment-16235677 ] Robert Muir commented on LUCENE-8007: - I think there may be some stuff like: {code} if

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-11-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235669#comment-16235669 ] Adrien Grand commented on LUCENE-8007: -- Do you have ideas in mind already regarding CheckIndex? >

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-11-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235648#comment-16235648 ] Robert Muir commented on LUCENE-8007: - I'll take another pass on the patch for sure: I'm not sure

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-11-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235482#comment-16235482 ] Adrien Grand commented on LUCENE-8007: -- I like how it really makes everything simpler. > Require

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-11-02 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235478#comment-16235478 ] Adrien Grand commented on LUCENE-8007: -- +1 > Require that codecs always store totalTermFreq,

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226966#comment-16226966 ] Robert Muir commented on LUCENE-8007: - I think i caused confusion with my comments, sorry. I wanted

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-31 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226945#comment-16226945 ] Adrien Grand commented on LUCENE-8007: -- bq. the codec (e.g. BlockTree) could just return docFreq and

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226932#comment-16226932 ] Robert Muir commented on LUCENE-8007: - So we are keeping the possibility of -1 for totalTermFreq and

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226165#comment-16226165 ] Robert Muir commented on LUCENE-8007: - I spun off the bogus calculations into LUCENE-8025 as it seems

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225972#comment-16225972 ] Robert Muir commented on LUCENE-8007: - Based on this issue, SimilarityBase can be really improved and

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223747#comment-16223747 ] Robert Muir commented on LUCENE-8007: - Looks mostly ok but i am confused by some size-related changes

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-25 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218703#comment-16218703 ] Adrien Grand commented on LUCENE-8007: -- I can remove that one from the list. > Require that codecs

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-25 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218687#comment-16218687 ] Robert Muir commented on LUCENE-8007: - Do we need the terms.size? I am concerned about a trappy

[jira] [Commented] (LUCENE-8007) Require that codecs always store totalTermFreq, sumDocFreq and sumTotalTermFreq

2017-10-24 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16217106#comment-16217106 ] Michael McCandless commented on LUCENE-8007: +1 > Require that codecs always store