[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405005#comment-16405005 ] Adrien Grand commented on LUCENE-8126: -- [~ivera] Can you set the "Fix Version/s" on this issue? >

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386261#comment-16386261 ] ASF subversion and git services commented on LUCENE-8126: - Commit

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386251#comment-16386251 ] ASF subversion and git services commented on LUCENE-8126: - Commit

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386196#comment-16386196 ] David Smiley commented on LUCENE-8126: -- I'll just do it; no point in asking you -- sorry > Spatial

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386195#comment-16386195 ] David Smiley commented on LUCENE-8126: -- [~ivera] can you also please add a 2-line change to

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384757#comment-16384757 ] David Smiley commented on LUCENE-8126: -- bq. Make prune code depend on this interface and not

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384663#comment-16384663 ] Ignacio Vera commented on LUCENE-8126: -- I have come across this problem as well and it was in my

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384273#comment-16384273 ] David Smiley commented on LUCENE-8126: -- Nice to finally see this in! I was trying to use this from

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383671#comment-16383671 ] ASF subversion and git services commented on LUCENE-8126: - Commit

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383657#comment-16383657 ] ASF subversion and git services commented on LUCENE-8126: - Commit

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383422#comment-16383422 ] ASF subversion and git services commented on LUCENE-8126: - Commit

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383399#comment-16383399 ] ASF subversion and git services commented on LUCENE-8126: - Commit

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383398#comment-16383398 ] ASF subversion and git services commented on LUCENE-8126: - Commit

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371423#comment-16371423 ] David Smiley commented on LUCENE-8126: -- bq. I am not sure that a different projection will help on

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369955#comment-16369955 ] Ignacio Vera commented on LUCENE-8126: -- They are in reality spherical polygons with 4 edges not

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369716#comment-16369716 ] David Smiley commented on LUCENE-8126: -- Thanks for investing the time into the illustrations

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363593#comment-16363593 ] Adrien Grand commented on LUCENE-8126: -- Thanks for the explanation [~ivera]. > Spatial prefix tree

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363013#comment-16363013 ] David Smiley commented on LUCENE-8126: -- BTW I’m on vacation with almost no Internet thru the 21st >

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362014#comment-16362014 ] Ignacio Vera commented on LUCENE-8126: -- [~jpountz], the important thing here is if the shape is

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361161#comment-16361161 ] Adrien Grand commented on LUCENE-8126: -- These are significant speedups and reduction of the index

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360632#comment-16360632 ] Ignacio Vera commented on LUCENE-8126: -- [~dsmiley], indeed I have to iterate a few times with ant

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357202#comment-16357202 ] David Smiley commented on LUCENE-8126: -- These are fantastic results [~ivera]! > Spatial prefix tree

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356757#comment-16356757 ] Ignacio Vera commented on LUCENE-8126: -- I have added the performance test classes on the branch in

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355620#comment-16355620 ] David Smiley commented on LUCENE-8126: -- Overall looks good [~ivera].  I think it's ready to be

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355494#comment-16355494 ] Karl Wright commented on LUCENE-8126: - [~ivera], I think this is great, but I haven't been following

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355439#comment-16355439 ] Ignacio Vera commented on LUCENE-8126: -- I would like to move these forward, any comment [~dsmiley],

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325523#comment-16325523 ] Ignacio Vera commented on LUCENE-8126: -- I committed a new version of the SPT with variable arity.

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321747#comment-16321747 ] Ignacio Vera commented on LUCENE-8126: -- Note that S2 geometry has 6-arity for the first level, after

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321726#comment-16321726 ] ASF GitHub Bot commented on LUCENE-8126: Github user iverase commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320976#comment-16320976 ] David Smiley commented on LUCENE-8126: -- _(an aside: I wish the JIRA GitHub integration didn't put so

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320916#comment-16320916 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320915#comment-16320915 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320909#comment-16320909 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320913#comment-16320913 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320914#comment-16320914 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320917#comment-16320917 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320912#comment-16320912 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320910#comment-16320910 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320911#comment-16320911 ] ASF GitHub Bot commented on LUCENE-8126: Github user dsmiley commented on a diff in the pull

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320485#comment-16320485 ] Ignacio Vera commented on LUCENE-8126: -- Hi [~dsmiley], I created a pull request that hopefully

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320448#comment-16320448 ] ASF GitHub Bot commented on LUCENE-8126: GitHub user iverase opened a pull request:

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16319669#comment-16319669 ] David Smiley commented on LUCENE-8126: -- This sounds very interesting Ignacio! In spatial-extras,

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318453#comment-16318453 ] Karl Wright commented on LUCENE-8126: - Sounds reasonable. > Spatial prefix tree based on S2

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318449#comment-16318449 ] Ignacio Vera commented on LUCENE-8126: -- Still I might want to add a new GeoShape that represents a

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318444#comment-16318444 ] Ignacio Vera commented on LUCENE-8126: -- module spatial-extras. I do not plan/want to add any

[jira] [Commented] (LUCENE-8126) Spatial prefix tree based on S2 geometry

[ https://issues.apache.org/jira/browse/LUCENE-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318439#comment-16318439 ] Karl Wright commented on LUCENE-8126: - [~ivera], which Lucene module would have this dependency? >