[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573249#comment-16573249 ] ASF subversion and git services commented on LUCENE-8204: - Commit

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573150#comment-16573150 ] Lucene/Solr QA commented on LUCENE-8204: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573112#comment-16573112 ] Adrien Grand commented on LUCENE-8204: -- +1 > ReqOptSumScorer should leverage sub scorers'

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573030#comment-16573030 ] Jim Ferenczi commented on LUCENE-8204: -- Thanks Adrien, I pushed a new patch that addresses your

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572971#comment-16572971 ] Adrien Grand commented on LUCENE-8204: -- +1 in general, some minor comments below: {code}

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572880#comment-16572880 ] Jim Ferenczi commented on LUCENE-8204: -- {quote}  I'm just a bit worried about the way that

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571947#comment-16571947 ] Adrien Grand commented on LUCENE-8204: -- Thanks Jim! It looks great in general, I'm just a bit

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571575#comment-16571575 ] Lucene/Solr QA commented on LUCENE-8204: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571237#comment-16571237 ] Jim Ferenczi commented on LUCENE-8204: -- Thanks for looking Adrien ! I pushed a new patch that adds

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564306#comment-16564306 ] Adrien Grand commented on LUCENE-8204: -- +1 on the approach, thanks for the explanation about why we

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561774#comment-16561774 ] Lucene/Solr QA commented on LUCENE-8204: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561657#comment-16561657 ] Jim Ferenczi commented on LUCENE-8204: -- Here is a new patch that changes the heuristic for the

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558370#comment-16558370 ] Jim Ferenczi commented on LUCENE-8204: -- {quote} Could we somehow merge optIsRequiredBlock and

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558269#comment-16558269 ] Adrien Grand commented on LUCENE-8204: -- The benchmark numbers look great! Some comments on the

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556445#comment-16556445 ] Lucene/Solr QA commented on LUCENE-8204: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8204) ReqOptSumScorer should leverage sub scorers' per-block max scores

[ https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555729#comment-16555729 ] Jim Ferenczi commented on LUCENE-8204: -- Here is a patch that implements the block skipping logic. I