[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624348#comment-16624348 ] ASF subversion and git services commented on SOLR-11836: Commit

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-21 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624345#comment-16624345 ] ASF subversion and git services commented on SOLR-11836: Commit

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611347#comment-16611347 ] Joel Bernstein commented on SOLR-11836: --- It's the FacetStream that causing the -1 to stop working

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611275#comment-16611275 ] Yonik Seeley commented on SOLR-11836: - limit:-1 should work fine for JSON Facets. bq. Also when I

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611272#comment-16611272 ] Joel Bernstein commented on SOLR-11836: --- I believe the Integer.MAX_VALUE is safe to use based on a

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611165#comment-16611165 ] Joel Bernstein commented on SOLR-11836: --- Also when I sent -1 directly to the JSON facet API it

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611163#comment-16611163 ] Joel Bernstein commented on SOLR-11836: --- In that particular spot there are no array allocations

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Varun Thacker (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611161#comment-16611161 ] Varun Thacker commented on SOLR-11836: -- I think we need to modify the patch a little after Joe's

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Varun Thacker (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611158#comment-16611158 ] Varun Thacker commented on SOLR-11836: -- Hi Joel, I checked FacetFieldMerger and saw this statement

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611153#comment-16611153 ] Joel Bernstein commented on SOLR-11836: --- I was just looking this over and testing some things out

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611142#comment-16611142 ] ASF subversion and git services commented on SOLR-11836: Commit

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611140#comment-16611140 ] ASF subversion and git services commented on SOLR-11836: Commit

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Varun Thacker (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611050#comment-16611050 ] Varun Thacker commented on SOLR-11836: -- Okay looks like the patch was provided by Amrit and not 

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611049#comment-16611049 ] ASF subversion and git services commented on SOLR-11836: Commit

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611046#comment-16611046 ] ASF subversion and git services commented on SOLR-11836: Commit

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Varun Thacker (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611011#comment-16611011 ] Varun Thacker commented on SOLR-11836: -- Running tests and committing it to master and 7_x  and then

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-09-11 Thread Varun Thacker (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611004#comment-16611004 ] Varun Thacker commented on SOLR-11836: -- Patch applies cleanly on master. Looks good to me! We

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-03-16 Thread Amrit Sarkar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402564#comment-16402564 ] Amrit Sarkar commented on SOLR-11836: - [~joel.bernstein] will the fix / workaround be part of Solr

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-01-11 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322022#comment-16322022 ] Alfonso Muñoz-Pomer Fuentes commented on SOLR-11836: Thanks all for such a quick

[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API

2018-01-10 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16320511#comment-16320511 ] Joel Bernstein commented on SOLR-11836: --- I haven't looked at the patch yet, but it sounds like a