[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483630#comment-15483630
]
ASF subversion and git services commented on SOLR-9444:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483629#comment-15483629
]
ASF subversion and git services commented on SOLR-9444:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458371#comment-15458371
]
ASF subversion and git services commented on SOLR-9444:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458372#comment-15458372
]
ASF subversion and git services commented on SOLR-9444:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458363#comment-15458363
]
ASF GitHub Bot commented on SOLR-9444:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458360#comment-15458360
]
ASF subversion and git services commented on SOLR-9444:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458361#comment-15458361
]
ASF subversion and git services commented on SOLR-9444:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458359#comment-15458359
]
ASF subversion and git services commented on SOLR-9444:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457763#comment-15457763
]
Uwe Schindler commented on SOLR-9444:
-
OK!
> Fix path usage for cloud backup/restore
>
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457754#comment-15457754
]
Varun Thacker commented on SOLR-9444:
-
Hi Uwe,
Would you be committing this?
> Fix path usage for
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457743#comment-15457743
]
Uwe Schindler commented on SOLR-9444:
-
Hi, looks fine to me!
> Fix path usage for cloud backup/restore
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457741#comment-15457741
]
ASF GitHub Bot commented on SOLR-9444:
--
Github user uschindler commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457052#comment-15457052
]
Hrishikesh Gadre commented on SOLR-9444:
[~varunthacker] [~thetaphi] I have updated the PR with
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451142#comment-15451142
]
Hrishikesh Gadre commented on SOLR-9444:
[~thetaphi] [~varunthacker] Thanks for the reviews! Let me
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449122#comment-15449122
]
Uwe Schindler commented on SOLR-9444:
-
SOLR-9460, not sure which one caused this. But you made changes
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449119#comment-15449119
]
Uwe Schindler commented on SOLR-9444:
-
SOLR-9460, not sure which one caused this. But you made changes
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15449012#comment-15449012
]
Noble Paul commented on SOLR-9444:
--
Which ticket exactly?
> Fix path usage for cloud backup/restore
>
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448997#comment-15448997
]
Uwe Schindler commented on SOLR-9444:
-
Hi,
to me this looks fine. I agree, adding a separate test for
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448315#comment-15448315
]
Varun Thacker commented on SOLR-9444:
-
bq. will try it out in a minute on my windows with whitespace
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448306#comment-15448306
]
Uwe Schindler commented on SOLR-9444:
-
In the future, once the HDFS people created a working filesystem
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448302#comment-15448302
]
Uwe Schindler commented on SOLR-9444:
-
Hi,
this looks cool! I will try it out in a minute on my windows
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448293#comment-15448293
]
ASF GitHub Bot commented on SOLR-9444:
--
Github user uschindler commented on a diff in the pull
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448044#comment-15448044
]
Hrishikesh Gadre commented on SOLR-9444:
[~varunthacker] [~thetaphi] Could you please review the PR
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15444718#comment-15444718
]
ASF GitHub Bot commented on SOLR-9444:
--
GitHub user hgadre opened a pull request:
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439223#comment-15439223
]
Uwe Schindler commented on SOLR-9444:
-
bq. Quick patch which uses Paths.get() instead of URI.getPath.
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439207#comment-15439207
]
Uwe Schindler commented on SOLR-9444:
-
I think the file system repository should only be used if the
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439200#comment-15439200
]
Varun Thacker commented on SOLR-9444:
-
I'm going to take a look at this
> Fix path usage for cloud
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439185#comment-15439185
]
Uwe Schindler commented on SOLR-9444:
-
I'd suggest do let the first parameter of the createURI abstract
[
https://issues.apache.org/jira/browse/SOLR-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439163#comment-15439163
]
Hrishikesh Gadre commented on SOLR-9444:
[~varunthacker] Thanks for creating the JIRA. I will send
29 matches
Mail list logo