[GitHub] [lucene-solr] iverase opened a new pull request #878: LUCENE-8746: Refactor EdgeTree

2019-09-13 Thread GitBox
iverase opened a new pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878 Another try in refactoring edge tree. This PR splits Edge Tree class into two and adds a new interface: * Component2D: Interface defining an object that knows i

[GitHub] [lucene-solr] iverase commented on issue #627: LUCENE-8746: Make EdgeTree (aka ComponentTree) support different type of components

2019-09-13 Thread GitBox
iverase commented on issue #627: LUCENE-8746: Make EdgeTree (aka ComponentTree) support different type of components URL: https://github.com/apache/lucene-solr/pull/627#issuecomment-531271483 See #878 This is an automated me

[GitHub] [lucene-solr] iverase closed pull request #627: LUCENE-8746: Make EdgeTree (aka ComponentTree) support different type of components

2019-09-13 Thread GitBox
iverase closed pull request #627: LUCENE-8746: Make EdgeTree (aka ComponentTree) support different type of components URL: https://github.com/apache/lucene-solr/pull/627 This is an automated message from the Apache Git Servi

[GitHub] [lucene-solr] atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531275454 @jimczi Here is the link: https://issues.apache.org/jira/browse/LUCENE-8978?focusedCommentId=16929277&page=com.atlassia

[GitHub] [lucene-solr] atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination

2019-09-13 Thread GitBox
atris commented on issue #877: LUCENE-8978: Maximal Bottom Score Based Early Termination URL: https://github.com/apache/lucene-solr/pull/877#issuecomment-531276346 Hmm, the precommit failure seems to be coming from `JdbcDataSource.java`?

[GitHub] [lucene-solr] dsmiley closed pull request #855: SOLR-13739: Improve performance on huge schema updates

2019-09-13 Thread GitBox
dsmiley closed pull request #855: SOLR-13739: Improve performance on huge schema updates URL: https://github.com/apache/lucene-solr/pull/855 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-26 Thread GitBox
dsmiley commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#discussion_r297927222 ## File path: lucene/core/src/java/org/apache/lucene/geo/Polygon.java #

[GitHub] [lucene-solr] msokolov merged pull request #739: LUCENE-8871: promote kuromoji tools to main jar

2019-06-26 Thread GitBox
msokolov merged pull request #739: LUCENE-8871: promote kuromoji tools to main jar URL: https://github.com/apache/lucene-solr/pull/739 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [lucene-solr] luyuncheng commented on issue #640: LUCENE-8671: Introduce Reader attributes

2019-06-26 Thread GitBox
luyuncheng commented on issue #640: LUCENE-8671: Introduce Reader attributes URL: https://github.com/apache/lucene-solr/pull/640#issuecomment-506144930 LGTM This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] iverase opened a new pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-26 Thread GitBox
iverase opened a new pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746 A `DocIdSetIterator` is added to the BKD reader and use when we have cardinality information. ---

[GitHub] [lucene-solr] iverase opened a new pull request #747: LUCENE-8888: Improve distribution of points with data dimension in BKD tree leaves

2019-06-27 Thread GitBox
iverase opened a new pull request #747: LUCENE-: Improve distribution of points with data dimension in BKD tree leaves URL: https://github.com/apache/lucene-solr/pull/747 Sorting/selection algorithms on the BKD tree are updated to tie-break on the data dimensions when they exist. ---

[GitHub] [lucene-solr] atris commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge

2019-06-27 Thread GitBox
atris commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#issuecomment-506240304 @jpountz Thanks for your comments, I have fixed the same. I think we should push this to master as you advised. Concurr

[GitHub] [lucene-solr] atris commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting

2019-06-27 Thread GitBox
atris commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting URL: https://github.com/apache/lucene-solr/pull/729#issuecomment-506245998 @jpountz Thanks for clarifying. I have moved both the collector and the tracker to misc module. --

[GitHub] [lucene-solr] iverase commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-27 Thread GitBox
iverase commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#discussion_r298065063 ## File path: lucene/core/src/java/org/apache/lucene/geo/Polygon.java #

[GitHub] [lucene-solr] iverase commented on issue #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-27 Thread GitBox
iverase commented on issue #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#issuecomment-506251019 One of the things I notice with this change is that it breaks some of the benchmarks, in particul

[GitHub] [lucene-solr] iverase closed pull request #728: LUCENE-8867: Store point with cardinality for low cardinality leaves

2019-06-27 Thread GitBox
iverase closed pull request #728: LUCENE-8867: Store point with cardinality for low cardinality leaves URL: https://github.com/apache/lucene-solr/pull/728 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] iverase commented on issue #728: LUCENE-8867: Store point with cardinality for low cardinality leaves

2019-06-27 Thread GitBox
iverase commented on issue #728: LUCENE-8867: Store point with cardinality for low cardinality leaves URL: https://github.com/apache/lucene-solr/pull/728#issuecomment-506254318 This PR has been splitter into #730 and #746 so I will close it.

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

2019-06-27 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-506257792 Already had time to review? This is an automated message from the Apache Git Service. To res

[GitHub] [lucene-solr] jpountz commented on issue #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-27 Thread GitBox
jpountz commented on issue #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#issuecomment-506260864 What is the particular rule that breaks?

[GitHub] [lucene-solr] iverase commented on issue #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-27 Thread GitBox
iverase commented on issue #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#issuecomment-506280771 Reading one of the polygons representing a London Borough it fails because it contains a hole whe

[GitHub] [lucene-solr] jpountz commented on a change in pull request #747: LUCENE-8888: Improve distribution of points with data dimension in BKD tree leaves

2019-06-27 Thread GitBox
jpountz commented on a change in pull request #747: LUCENE-: Improve distribution of points with data dimension in BKD tree leaves URL: https://github.com/apache/lucene-solr/pull/747#discussion_r298102774 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDRadixSel

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #633: LUCENE-8753 UniformSplit PostingsFormat

2019-06-27 Thread GitBox
bruno-roustant commented on a change in pull request #633: LUCENE-8753 UniformSplit PostingsFormat URL: https://github.com/apache/lucene-solr/pull/633#discussion_r298111969 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80Codec.java ## @@ -91,7

[GitHub] [lucene-solr] atris opened a new pull request #748: LUCENE-8889: Add Tests For Accessors Of Ranges in PointRangeQuery

2019-06-27 Thread GitBox
atris opened a new pull request #748: LUCENE-8889: Add Tests For Accessors Of Ranges in PointRangeQuery URL: https://github.com/apache/lucene-solr/pull/748 This commit beefs up equality tests for PointRangeQuery by deep checking range points as well. This also serves to have an internal us

[GitHub] [lucene-solr] atris commented on a change in pull request #602: docu change: use class TopDocs instead of Hits

2019-06-27 Thread GitBox
atris commented on a change in pull request #602: docu change: use class TopDocs instead of Hits URL: https://github.com/apache/lucene-solr/pull/602#discussion_r298130573 ## File path: lucene/queries/src/java/org/apache/lucene/queries/mlt/MoreLikeThis.java ## @@ -92,9 +92

[GitHub] [lucene-solr] atris commented on issue #219: TieredMergePolicy.findMerges improvements

2019-06-27 Thread GitBox
atris commented on issue #219: TieredMergePolicy.findMerges improvements URL: https://github.com/apache/lucene-solr/pull/219#issuecomment-506308759 Is this still relevant? This is an automated message from the Apache Git Servi

[GitHub] [lucene-solr] atris commented on issue #192: LUCENE-7786 - add getter for field to TermInSetQuery

2019-06-27 Thread GitBox
atris commented on issue #192: LUCENE-7786 - add getter for field to TermInSetQuery URL: https://github.com/apache/lucene-solr/pull/192#issuecomment-506309256 What would be the need for this accessor? Also, could you elaborate a bit on the usecase you are thinking of for this API change, a

[GitHub] [lucene-solr] atris commented on issue #533: LUCENE-8636: TestPointQueries and long execution times

2019-06-27 Thread GitBox
atris commented on issue #533: LUCENE-8636: TestPointQueries and long execution times URL: https://github.com/apache/lucene-solr/pull/533#issuecomment-506309671 Is this redundant now? Should we close it? This is an automated

[GitHub] [lucene-solr] jpountz merged pull request #748: LUCENE-8889: Add Tests For Accessors Of Ranges in PointRangeQuery

2019-06-27 Thread GitBox
jpountz merged pull request #748: LUCENE-8889: Add Tests For Accessors Of Ranges in PointRangeQuery URL: https://github.com/apache/lucene-solr/pull/748 This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene-solr] jpountz commented on a change in pull request #729: LUCENE-8862: Introduce Collector Level Memory Accounting

2019-06-27 Thread GitBox
jpountz commented on a change in pull request #729: LUCENE-8862: Introduce Collector Level Memory Accounting URL: https://github.com/apache/lucene-solr/pull/729#discussion_r298139002 ## File path: lucene/core/src/java/org/apache/lucene/util/MemoryTracker.java ## @@ -0,0 +1

[GitHub] [lucene-solr] iverase commented on issue #747: LUCENE-8888: Improve distribution of points with data dimension in BKD tree leaves

2019-06-27 Thread GitBox
iverase commented on issue #747: LUCENE-: Improve distribution of points with data dimension in BKD tree leaves URL: https://github.com/apache/lucene-solr/pull/747#issuecomment-506317120 Thanks @jpountz, I can indeed refactor PointValue and it seems it makes a lot of sense. It simplifi

[GitHub] [lucene-solr] jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-27 Thread GitBox
jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298140894 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDRead

[GitHub] [lucene-solr] jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-27 Thread GitBox
jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298139661 ## File path: lucene/core/src/java/org/apache/lucene/index/PointValue

[GitHub] [lucene-solr] atris commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting

2019-06-27 Thread GitBox
atris commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting URL: https://github.com/apache/lucene-solr/pull/729#issuecomment-506330431 @jpountz Sorry, somehow missed moving the actual interface. Done now, let me know if it seems fine. -

[GitHub] [lucene-solr] atris commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting

2019-06-27 Thread GitBox
atris commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting URL: https://github.com/apache/lucene-solr/pull/729#issuecomment-506336287 Thanks a ton! This is an automated message from the Apache Git

[GitHub] [lucene-solr] jpountz commented on a change in pull request #747: LUCENE-8888: Improve distribution of points with data dimension in BKD tree leaves

2019-06-27 Thread GitBox
jpountz commented on a change in pull request #747: LUCENE-: Improve distribution of points with data dimension in BKD tree leaves URL: https://github.com/apache/lucene-solr/pull/747#discussion_r298148028 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDRadixSel

[GitHub] [lucene-solr] jpountz commented on a change in pull request #747: LUCENE-8888: Improve distribution of points with data dimension in BKD tree leaves

2019-06-27 Thread GitBox
jpountz commented on a change in pull request #747: LUCENE-: Improve distribution of points with data dimension in BKD tree leaves URL: https://github.com/apache/lucene-solr/pull/747#discussion_r298148526 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDRadixSel

[GitHub] [lucene-solr] s1monw commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge

2019-06-27 Thread GitBox
s1monw commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#issuecomment-506355727 > I think we should push this to master as you advised. Concurrently, should I raise a PR to add the old slicing algorithm b

[GitHub] [lucene-solr] nknize commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-27 Thread GitBox
nknize commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#discussion_r298261656 ## File path: lucene/core/src/java/org/apache/lucene/geo/Polygon.java ##

[GitHub] [lucene-solr] atris commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge

2019-06-27 Thread GitBox
atris commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#issuecomment-506506869 Thanks @s1monw ! @jpountz Would you want to add the CHANGES entry during merging, or should I push an iteration?

[GitHub] [lucene-solr] mayya-sharipova commented on issue #595: Load freqs lazily in Postings

2019-06-27 Thread GitBox
mayya-sharipova commented on issue #595: Load freqs lazily in Postings URL: https://github.com/apache/lucene-solr/pull/595#issuecomment-506546238 @jpountz This PR is ready for another round of review. Sorry for a delay. I still need to run it through luceneutil though. --

[GitHub] [lucene-solr] iverase commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-27 Thread GitBox
iverase commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#discussion_r298453900 ## File path: lucene/core/src/java/org/apache/lucene/geo/Polygon.java #

[GitHub] [lucene-solr] jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-28 Thread GitBox
jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298482772 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDRead

[GitHub] [lucene-solr] iverase commented on a change in pull request #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries

2019-06-28 Thread GitBox
iverase commented on a change in pull request #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries URL: https://github.com/apache/lucene-solr/pull/726#discussion_r298475736 ## File path: lucene/sandbox/src/java/org/apache/lucene/ge

[GitHub] [lucene-solr] iverase commented on a change in pull request #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries

2019-06-28 Thread GitBox
iverase commented on a change in pull request #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries URL: https://github.com/apache/lucene-solr/pull/726#discussion_r298479770 ## File path: lucene/sandbox/src/java/org/apache/lucene/ge

[GitHub] [lucene-solr] iverase commented on a change in pull request #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries

2019-06-28 Thread GitBox
iverase commented on a change in pull request #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries URL: https://github.com/apache/lucene-solr/pull/726#discussion_r298470637 ## File path: lucene/sandbox/src/java/org/apache/lucene/ge

[GitHub] [lucene-solr] jpountz commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting

2019-06-28 Thread GitBox
jpountz commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting URL: https://github.com/apache/lucene-solr/pull/729#issuecomment-506638036 `ant precommit` fails for me with this change, it needs a `package.html` file in `lucene/misc/src/java/org/apache/lucene/util

[GitHub] [lucene-solr] jpountz merged pull request #446: LUCENE-8890: Improve parallel iteration of two lists of same length.

2019-06-28 Thread GitBox
jpountz merged pull request #446: LUCENE-8890: Improve parallel iteration of two lists of same length. URL: https://github.com/apache/lucene-solr/pull/446 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] iverase commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-28 Thread GitBox
iverase commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298499256 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDRead

[GitHub] [lucene-solr] jpountz commented on a change in pull request #595: Load freqs lazily in Postings

2019-06-28 Thread GitBox
jpountz commented on a change in pull request #595: Load freqs lazily in Postings URL: https://github.com/apache/lucene-solr/pull/595#discussion_r298502690 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50PostingsReader.java ## @@ -391,22 +408,

[GitHub] [lucene-solr] jpountz commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge

2019-06-28 Thread GitBox
jpountz commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#issuecomment-506674452 If you can add it now that would be great. This is an auto

[GitHub] [lucene-solr] jpountz commented on a change in pull request #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge

2019-06-28 Thread GitBox
jpountz commented on a change in pull request #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#discussion_r298529210 ## File path: lucene/MIGRATE.txt ## @@ -182,3 +182,9 @@ to concurrent changes. ## maxCl

[GitHub] [lucene-solr] jpountz commented on a change in pull request #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge

2019-06-28 Thread GitBox
jpountz commented on a change in pull request #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#discussion_r298529361 ## File path: lucene/core/src/java/org/apache/lucene/search/TopDocs.java ## @@ -39,66 +5

[GitHub] [lucene-solr] romseygeek opened a new pull request #749: LUCENE-8893: Intervals.prefix() and Intervals.wildcard() should take BytesRef

2019-06-28 Thread GitBox
romseygeek opened a new pull request #749: LUCENE-8893: Intervals.prefix() and Intervals.wildcard() should take BytesRef URL: https://github.com/apache/lucene-solr/pull/749 Generally speaking, when parsers are creating wildcard or prefix IntervalsSources, they will first want to pass th

[GitHub] [lucene-solr] gpaimla opened a new pull request #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class

2019-06-28 Thread GitBox
gpaimla opened a new pull request #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class URL: https://github.com/apache/lucene-solr/pull/750 # Description Currently lucene doesn't have a stemmer/analyzer for Estonian. # Solution Compiled

[GitHub] [lucene-solr] atris commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge

2019-06-28 Thread GitBox
atris commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#issuecomment-506738434 @jpountz I have updated per comments and added CHANGES entry, let me know if this looks ok -

[GitHub] [lucene-solr] atris commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting

2019-06-28 Thread GitBox
atris commented on issue #729: LUCENE-8862: Introduce Collector Level Memory Accounting URL: https://github.com/apache/lucene-solr/pull/729#issuecomment-506740202 @jpountz Added the same, please see if it works now This is an

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-28 Thread GitBox
dsmiley commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#discussion_r298616974 ## File path: lucene/core/src/java/org/apache/lucene/geo/Polygon.java #

[GitHub] [lucene-solr] iverase commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-28 Thread GitBox
iverase commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#discussion_r298453900 ## File path: lucene/core/src/java/org/apache/lucene/geo/Polygon.java #

[GitHub] [lucene-solr] iverase commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid

2019-06-28 Thread GitBox
iverase commented on a change in pull request #709: LUCENE-8850: Calculate the area of a polygon and throw error when values are invalid URL: https://github.com/apache/lucene-solr/pull/709#discussion_r298453900 ## File path: lucene/core/src/java/org/apache/lucene/geo/Polygon.java #

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #595: Load freqs lazily in Postings

2019-06-28 Thread GitBox
mayya-sharipova commented on a change in pull request #595: Load freqs lazily in Postings URL: https://github.com/apache/lucene-solr/pull/595#discussion_r298628008 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50PostingsReader.java ## @@ -391,

[GitHub] [lucene-solr] jpountz commented on a change in pull request #595: Load freqs lazily in Postings

2019-06-28 Thread GitBox
jpountz commented on a change in pull request #595: Load freqs lazily in Postings URL: https://github.com/apache/lucene-solr/pull/595#discussion_r298630153 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50PostingsReader.java ## @@ -391,22 +408,

[GitHub] [lucene-solr] magibney opened a new pull request #751: SOLR-13132: single sweep iteration over base, foreground, and background sets for "relatedness" calculation

2019-06-28 Thread GitBox
magibney opened a new pull request #751: SOLR-13132: single sweep iteration over base, foreground, and background sets for "relatedness" calculation URL: https://github.com/apache/lucene-solr/pull/751 Relatedness essentially calculates facets separately across three different docSets; th

[GitHub] [lucene-solr] mayya-sharipova commented on issue #595: Load freqs lazily in Postings

2019-06-28 Thread GitBox
mayya-sharipova commented on issue #595: Load freqs lazily in Postings URL: https://github.com/apache/lucene-solr/pull/595#issuecomment-506811878 Results running the current version against master: ```bash python src/python/localrun.py -source wikimedium10k ``` ``` Report

[GitHub] [lucene-solr] mayya-sharipova commented on issue #595: Load freqs lazily in Postings

2019-06-28 Thread GitBox
mayya-sharipova commented on issue #595: Load freqs lazily in Postings URL: https://github.com/apache/lucene-solr/pull/595#issuecomment-506834942 ```bash python src/python/localrun.py -source wikimedium500k ``` ``` Report after iter 19: TaskQPS baseline

[GitHub] [lucene-solr] cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

2019-06-28 Thread GitBox
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch) URL: https://github.com/apache/lucene-solr/pull/300#discussion_r298725095 ## File path: solr/core/src/java/org/apache/solr/search/grouping/distribu

[GitHub] [lucene-solr] mayya-sharipova commented on issue #595: Load freqs lazily in Postings

2019-06-28 Thread GitBox
mayya-sharipova commented on issue #595: Load freqs lazily in Postings URL: https://github.com/apache/lucene-solr/pull/595#issuecomment-506866675 ```bash python src/python/localrun.py -source wikimedium10m ``` ``` Report after iter 19: TaskQPS baseline

[GitHub] [lucene-solr] mayya-sharipova commented on issue #595: Load freqs lazily in Postings

2019-06-28 Thread GitBox
mayya-sharipova commented on issue #595: Load freqs lazily in Postings URL: https://github.com/apache/lucene-solr/pull/595#issuecomment-506868411 @jpountz I have run `luceneutil` on wikimedium10k, 500k and 10M, but have a difficulty interpreting results. For `wikimedium10k`, we have dif

[GitHub] [lucene-solr] mocobeta opened a new pull request #752: LUCENE-8894: Add APIs to look up SPI name for a concrete factory class

2019-06-29 Thread GitBox
mocobeta opened a new pull request #752: LUCENE-8894: Add APIs to look up SPI name for a concrete factory class URL: https://github.com/apache/lucene-solr/pull/752 # Description Currently, reflection tricks are needed to obtain SPI name (this is now stored in static NAME fields in e

[GitHub] [lucene-solr] gerlowskija merged pull request #714: SOLR-13537: README Build Status

2019-06-29 Thread GitBox
gerlowskija merged pull request #714: SOLR-13537: README Build Status URL: https://github.com/apache/lucene-solr/pull/714 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [lucene-solr] jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-29 Thread GitBox
jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298797885 ## File path: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD

[GitHub] [lucene-solr] jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-29 Thread GitBox
jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298797828 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDRead

[GitHub] [lucene-solr] jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-29 Thread GitBox
jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298797880 ## File path: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD

[GitHub] [lucene-solr] jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-29 Thread GitBox
jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298797876 ## File path: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD

[GitHub] [lucene-solr] jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-29 Thread GitBox
jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298797868 ## File path: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539

2019-06-29 Thread GitBox
thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#discussion_r298802123 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/response/TermsResponseTest.java ## @@ -15,31 +15,33 @@ *

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539

2019-06-29 Thread GitBox
thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#discussion_r298802127 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java ## @@ -27,13 +27,13 @@ import org.junit.B

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539

2019-06-29 Thread GitBox
thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#discussion_r298802156 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSuggesterResponse.java ## @@ -32,14 +33,15 @@

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539

2019-06-29 Thread GitBox
thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#discussion_r298802139 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/response/TestSpellCheckResponse.java ## @@ -27,21 +29,22 @

[GitHub] [lucene-solr] thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539

2019-06-29 Thread GitBox
thomaswoeckinger commented on a change in pull request #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#discussion_r296456996 ## File path: solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java ## @@ -140,29 +139,17 @@ public synchron

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-06-29 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-506257792 Already had time to review? All tests should pass now. This is an automated messag

[GitHub] [lucene-solr] mocobeta commented on issue #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class

2019-06-29 Thread GitBox
mocobeta commented on issue #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class URL: https://github.com/apache/lucene-solr/pull/750#issuecomment-506997854 Hi @gpaimla, the patch was just merged into upstream master and 8x branch. Thanks for the nice patch! I f

[GitHub] [lucene-solr] mocobeta edited a comment on issue #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class

2019-06-29 Thread GitBox
mocobeta edited a comment on issue #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class URL: https://github.com/apache/lucene-solr/pull/750#issuecomment-506997854 Hi @gpaimla, the patch was just merged into upstream master and 8x branch. Thanks for the nice patch!

[GitHub] [lucene-solr] mocobeta commented on issue #752: LUCENE-8894: Add APIs to look up SPI name for a concrete factory class

2019-06-29 Thread GitBox
mocobeta commented on issue #752: LUCENE-8894: Add APIs to look up SPI name for a concrete factory class URL: https://github.com/apache/lucene-solr/pull/752#issuecomment-507004406 Merged into ASF gitbox: https://github.com/apache/lucene-solr/commit/7ac77ce4418c06d01af97663230b00c1b4b44d22

[GitHub] [lucene-solr] mocobeta closed pull request #752: LUCENE-8894: Add APIs to look up SPI name for a concrete factory class

2019-06-29 Thread GitBox
mocobeta closed pull request #752: LUCENE-8894: Add APIs to look up SPI name for a concrete factory class URL: https://github.com/apache/lucene-solr/pull/752 This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene-solr] gpaimla closed pull request #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class

2019-06-30 Thread GitBox
gpaimla closed pull request #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class URL: https://github.com/apache/lucene-solr/pull/750 This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene-solr] gerlowskija commented on issue #665: Fixes SOLR-13539

2019-06-30 Thread GitBox
gerlowskija commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507029199 Changes look good. Running tests now and hoping to commit later today once those pass. This is

[GitHub] [lucene-solr] mocobeta commented on issue #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class

2019-06-30 Thread GitBox
mocobeta commented on issue #750: LUCENE-8891 Snowball stemmer for Estonian and EstonianAnalyzer class URL: https://github.com/apache/lucene-solr/pull/750#issuecomment-507033858 Thanks for closing this. Just to let you know, you do not have to create both of a patch and a pull request next

[GitHub] [lucene-solr] gerlowskija commented on issue #665: Fixes SOLR-13539

2019-06-30 Thread GitBox
gerlowskija commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507056931 Hmm, I'm still seeing test-failures with this PR that look pretty related to the changes: ``` [junit4] Tests with failures [seed: AD13CA5C9C515876]:

[GitHub] [lucene-solr] msokolov opened a new pull request #753: LUCENE-8895: switch all FST usage to enable array-with-gaps encoding

2019-06-30 Thread GitBox
msokolov opened a new pull request #753: LUCENE-8895: switch all FST usage to enable array-with-gaps encoding URL: https://github.com/apache/lucene-solr/pull/753 I'm not sure we want to commit this as-is, mainly because of the change to {{blocktreeords}} codec. With this change, if we enco

[GitHub] [lucene-solr] gerlowskija commented on issue #665: Fixes SOLR-13539

2019-06-30 Thread GitBox
gerlowskija commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507078815 I was able to clean up some of the failures locally by removing the second clause in the if-statement below. (This was added in this PR in EmbeddedSolrServer)

[GitHub] [lucene-solr] iverase merged pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves

2019-06-30 Thread GitBox
iverase merged pull request #746: LUCENE-8885: Optimise BKD reader by exploiting cardinality information stored on leaves URL: https://github.com/apache/lucene-solr/pull/746 This is an automated message from the Apache Git S

[GitHub] [lucene-solr] romseygeek closed pull request #749: LUCENE-8893: Intervals.prefix() and Intervals.wildcard() should take BytesRef

2019-07-01 Thread GitBox
romseygeek closed pull request #749: LUCENE-8893: Intervals.prefix() and Intervals.wildcard() should take BytesRef URL: https://github.com/apache/lucene-solr/pull/749 This is an automated message from the Apache Git Service.

[GitHub] [lucene-solr] atris commented on issue #742: LUCENE-8882: Extend QueryVisitor To Maintain Metadata State

2019-07-01 Thread GitBox
atris commented on issue #742: LUCENE-8882: Extend QueryVisitor To Maintain Metadata State URL: https://github.com/apache/lucene-solr/pull/742#issuecomment-507178876 Any thoughts on this? Happy to iterate This is an automated

[GitHub] [lucene-solr] jpountz merged pull request #729: LUCENE-8862: Introduce Collector Level Memory Accounting

2019-07-01 Thread GitBox
jpountz merged pull request #729: LUCENE-8862: Introduce Collector Level Memory Accounting URL: https://github.com/apache/lucene-solr/pull/729 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-solr] atris opened a new pull request #754: LUCENE-8875: Introduce Optimized Collector For Large Number Of Hits

2019-07-01 Thread GitBox
atris opened a new pull request #754: LUCENE-8875: Introduce Optimized Collector For Large Number Of Hits URL: https://github.com/apache/lucene-solr/pull/754 Existing top score docs collectors prepopulate the priority queue with sentinel objects, which can be expensive for large number

[GitHub] [lucene-solr] jpountz commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge

2019-07-01 Thread GitBox
jpountz commented on issue #734: LUCENE-8857: Introduce Custom Tiebreakers in TopDocs#merge URL: https://github.com/apache/lucene-solr/pull/734#issuecomment-507237517 I tried to merge but I'm hitting a reproducible test failure: `ant test -Dtestcase=TestShardSearching -Dtests.method=testS

[GitHub] [lucene-solr] thomaswoeckinger opened a new pull request #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests

2019-07-01 Thread GitBox
thomaswoeckinger opened a new pull request #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests URL: https://github.com/apache/lucene-solr/pull/755 To allow better integration of EmbeddedSolrServer, hidden implementation should be moved out of SolrJettyTestBase --

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests

2019-07-01 Thread GitBox
thomaswoeckinger commented on issue #755: SOLR-13592: Introduce EmbeddedSolrTestBase for better integration tests URL: https://github.com/apache/lucene-solr/pull/755#issuecomment-507241912 @gerlowskija plz review This is an a

[GitHub] [lucene-solr] thomaswoeckinger commented on issue #665: Fixes SOLR-13539

2019-07-01 Thread GitBox
thomaswoeckinger commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507243090 > I was able to clean up some of the failures locally by removing the second clause in the if-statement below. (This was added in this PR in EmbeddedSolrSer

[GitHub] [lucene-solr] thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539

2019-07-01 Thread GitBox
thomaswoeckinger edited a comment on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-507243090 > I was able to clean up some of the failures locally by removing the second clause in the if-statement below. (This was added in this PR in Embedded

<    1   2   3   4   5   6   7   8   9   10   >