[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

2018-03-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394668#comment-16394668 ] Robert Muir commented on LUCENE-8197: - FWIW: the computePivotFeatureValue helper make

[jira] [Commented] (LUCENE-8198) Add ability to persist deletes across merges

2018-03-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394667#comment-16394667 ] Robert Muir commented on LUCENE-8198: - Well the overhead should be... 1 bit per docum

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

2018-03-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394664#comment-16394664 ] Robert Muir commented on LUCENE-8197: - Well it seems strange what its doing: using av

[jira] [Commented] (LUCENE-8198) Add ability to persist deletes across merges

2018-03-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394658#comment-16394658 ] Robert Muir commented on LUCENE-8198: - Why wouldn't a user use IndexWriter.updateDocV

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

2018-03-09 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393358#comment-16393358 ] Robert Muir commented on LUCENE-8197: - I'm confused about the first method, why would

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

2018-03-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392154#comment-16392154 ] Robert Muir commented on LUCENE-8197: - Also i'm not sure what the explanation current

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

2018-03-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392146#comment-16392146 ] Robert Muir commented on LUCENE-8197: - Looks much better, a few more notes on the jav

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

2018-03-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391636#comment-16391636 ] Robert Muir commented on LUCENE-8197: - Also i would personally maybe move the guards

[jira] [Commented] (LUCENE-8197) Make top-k queries fast when static scoring signals are incorporated into the score

2018-03-08 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391623#comment-16391623 ] Robert Muir commented on LUCENE-8197: - Great! nit on the naming: I think we should av

[jira] [Commented] (LUCENE-8186) CustomAnalyzer with a LowerCaseTokenizerFactory fails to normalize multiterms

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385449#comment-16385449 ] Robert Muir commented on LUCENE-8186: - I think it would be best to fix this bug here,

[jira] [Commented] (LUCENE-8186) CustomAnalyzer with a LowerCaseTokenizerFactory fails to normalize multiterms

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385323#comment-16385323 ] Robert Muir commented on LUCENE-8186: - Yeah, the biggest issue i see is the lack of t

[jira] [Commented] (LUCENE-8186) CustomAnalyzer with a LowerCaseTokenizerFactory fails to normalize multiterms

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385312#comment-16385312 ] Robert Muir commented on LUCENE-8186: - See code for that: https://github.com/apache/

[jira] [Commented] (LUCENE-8186) CustomAnalyzer with a LowerCaseTokenizerFactory fails to normalize multiterms

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385309#comment-16385309 ] Robert Muir commented on LUCENE-8186: - CharFilterFactories can normalize too, but I t

[jira] [Updated] (LUCENE-8186) CustomAnalyzer with a LowerCaseTokenizerFactory fails to normalize multiterms

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8186: Attachment: LUCENE-8186.patch > CustomAnalyzer with a LowerCaseTokenizerFactory fails to normalize

[jira] [Commented] (LUCENE-8186) CustomAnalyzer with a LowerCaseTokenizerFactory fails to normalize multiterms

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385297#comment-16385297 ] Robert Muir commented on LUCENE-8186: - Uwe: I agree with you. For "normalize" the tok

[jira] [Commented] (LUCENE-8159) Add a copy constructor in AutomatonQuery to copy directly the compiled automaton

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385277#comment-16385277 ] Robert Muir commented on LUCENE-8159: - I don't think we should add this CompiledAutom

[jira] [Commented] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385254#comment-16385254 ] Robert Muir commented on LUCENE-8192: - I was wrong about posinc/poslen checks, these

[jira] [Updated] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8192: Attachment: LUCENE-8192.patch > Remove offsetsAreCorrect from BaseTokenStreamTestCase > ---

[jira] [Commented] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385253#comment-16385253 ] Robert Muir commented on LUCENE-8192: - This boolean is also guarding some posInc chec

[jira] [Commented] (LUCENE-8191) merge TestRandomChains "brokenConstructors" list with "brokenOffsetsConstructors"

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385252#comment-16385252 ] Robert Muir commented on LUCENE-8191: - As noted in LUCENE-8192, this boolean actually

[jira] [Commented] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385242#comment-16385242 ] Robert Muir commented on LUCENE-8192: - Second, less aggressive patch: it *changes the

[jira] [Updated] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8192: Attachment: LUCENE-8192_take_two.patch > Remove offsetsAreCorrect from BaseTokenStreamTestCase > --

[jira] [Commented] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385233#comment-16385233 ] Robert Muir commented on LUCENE-8192: - I wrote a patch to do this, but it causes many

[jira] [Updated] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8192: Attachment: LUCENE-8192_prototype.patch > Remove offsetsAreCorrect from BaseTokenStreamTestCase > -

[jira] [Resolved] (LUCENE-8191) merge TestRandomChains "brokenConstructors" list with "brokenOffsetsConstructors"

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-8191. - Resolution: Fixed Fix Version/s: 7.3 master (8.0) > merge TestRandomCha

[jira] [Created] (LUCENE-8192) Remove offsetsAreCorrect from BaseTokenStreamTestCase

2018-03-04 Thread Robert Muir (JIRA)
Robert Muir created LUCENE-8192: --- Summary: Remove offsetsAreCorrect from BaseTokenStreamTestCase Key: LUCENE-8192 URL: https://issues.apache.org/jira/browse/LUCENE-8192 Project: Lucene - Core I

[jira] [Updated] (LUCENE-8191) merge TestRandomChains "brokenConstructors" list with "brokenOffsetsConstructors"

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8191: Attachment: LUCENE-8191.patch > merge TestRandomChains "brokenConstructors" list with > "brokenOff

[jira] [Commented] (LUCENE-8092) TestRandomChains failure

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385204#comment-16385204 ] Robert Muir commented on LUCENE-8092: - CJKBigramFilter was already in the offsetsAreB

[jira] [Commented] (LUCENE-8191) merge TestRandomChains "brokenConstructors" list with "brokenOffsetsConstructors"

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385202#comment-16385202 ] Robert Muir commented on LUCENE-8191: - Attached is a patch: I tested it with {{ant be

[jira] [Updated] (LUCENE-8191) merge TestRandomChains "brokenConstructors" list with "brokenOffsetsConstructors"

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8191: Attachment: LUCENE-8191.patch > merge TestRandomChains "brokenConstructors" list with > "brokenOff

[jira] [Created] (LUCENE-8191) merge TestRandomChains "brokenConstructors" list with "brokenOffsetsConstructors"

2018-03-04 Thread Robert Muir (JIRA)
Robert Muir created LUCENE-8191: --- Summary: merge TestRandomChains "brokenConstructors" list with "brokenOffsetsConstructors" Key: LUCENE-8191 URL: https://issues.apache.org/jira/browse/LUCENE-8191 Proje

[jira] [Commented] (LUCENE-8092) TestRandomChains failure

2018-03-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385188#comment-16385188 ] Robert Muir commented on LUCENE-8092: - CJKBigramFilter isn't really prepared to handl

[jira] [Commented] (LUCENE-8159) Add a copy constructor in AutomatonQuery to copy directly the compiled automaton

2018-02-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380260#comment-16380260 ] Robert Muir commented on LUCENE-8159: - -1 to a copy constructor. This is java! > Add

[jira] [Deleted] (SOLR-12016) Reduce noise from flakey tests

2018-02-25 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir deleted SOLR-12016: --- > Reduce noise from flakey tests > -- > > Key: SOLR-12016 >

[jira] [Commented] (LUCENE-8031) DOCS_ONLY fields set incorrect length norms

2018-02-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375632#comment-16375632 ] Robert Muir commented on LUCENE-8031: - Thank you for doing the hard part Adrien! > D

[jira] [Resolved] (LUCENE-8031) DOCS_ONLY fields set incorrect length norms

2018-02-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-8031. - Resolution: Fixed Fix Version/s: master (8.0) > DOCS_ONLY fields set incorrect length norm

[jira] [Commented] (SOLR-11968) Multi-words query time synonyms

2018-02-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373936#comment-16373936 ] Robert Muir commented on SOLR-11968: Also the stupid gap stuff acts different dependin

[jira] [Commented] (SOLR-11968) Multi-words query time synonyms

2018-02-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373928#comment-16373928 ] Robert Muir commented on SOLR-11968: {quote} AFAICT Robert is suggesting a StopFilter

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373757#comment-16373757 ] Robert Muir commented on LUCENE-4065: - Yeah, i mean we should split it up. Its probab

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373727#comment-16373727 ] Robert Muir commented on LUCENE-4065: - Well, i think thats a separate, "new" issue, r

[jira] [Commented] (SOLR-12017) Remove BadApple and AwaitsFix annotations that link to closed JIRAs

2018-02-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373282#comment-16373282 ] Robert Muir commented on SOLR-12017: How is this going to help exactly? This is only g

[jira] [Commented] (SOLR-12016) Reduce noise from flakey tests

2018-02-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373273#comment-16373273 ] Robert Muir commented on SOLR-12016: I don't think the lucene tests marked with Awaits

[jira] [Commented] (LUCENE-8175) ICUTokenizer might return corrupt tokens due to concurrency bug in ICU4J

2018-02-21 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372206#comment-16372206 ] Robert Muir commented on LUCENE-8175: - ICU responded to Adrien's email about release

[jira] [Commented] (LUCENE-4065) FilteringTokenFilter should never corrupt the tokenstream graph

2018-02-21 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372072#comment-16372072 ] Robert Muir commented on LUCENE-4065: - Yeah, you've got it. I really prefer your {{en

[jira] [Commented] (SOLR-11968) Multi-words query time synonyms

2018-02-20 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370916#comment-16370916 ] Robert Muir commented on SOLR-11968: I think the issue is still valid, its a little mo

[jira] [Commented] (LUCENE-8153) checkindex time more than doubles for wikipedia index with recent change

2018-02-20 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370111#comment-16370111 ] Robert Muir commented on LUCENE-8153: - +1 > checkindex time more than doubles for wi

[jira] [Commented] (LUCENE-8122) upgrade icu to 60.2

2018-02-20 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370085#comment-16370085 ] Robert Muir commented on LUCENE-8122: - Can we just keep the issue open? If there is a

[jira] [Commented] (LUCENE-8180) Explore using (Future)Arrays.mismatch for FixedBitSet.nextSetBit

2018-02-20 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370082#comment-16370082 ] Robert Muir commented on LUCENE-8180: - I'm not sure this would help unless the bitset

[jira] [Commented] (LUCENE-8178) Bulk operations for LongValues and Sorted[Set]DocValues

2018-02-20 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369985#comment-16369985 ] Robert Muir commented on LUCENE-8178: - I agree, I think decode done in bulk shouldn't

[jira] [Commented] (LUCENE-8153) checkindex time more than doubles for wikipedia index with recent change

2018-02-15 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365811#comment-16365811 ] Robert Muir commented on LUCENE-8153: - Can we also update the "usage" for this tool (

[jira] [Commented] (LUCENE-8175) ICUTokenizer might return corrupt tokens due to concurrency bug in ICU4J

2018-02-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365075#comment-16365075 ] Robert Muir commented on LUCENE-8175: - Since it will easily trip with threads on CJK/

[jira] [Commented] (LUCENE-8175) ICUTokenizer might return corrupt tokens due to concurrency bug in ICU4J

2018-02-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364577#comment-16364577 ] Robert Muir commented on LUCENE-8175: - Because we will still do break iteration for s

[jira] [Commented] (LUCENE-8175) ICUTokenizer might return corrupt tokens due to concurrency bug in ICU4J

2018-02-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364529#comment-16364529 ] Robert Muir commented on LUCENE-8175: - thanks for debugging. i saw a jenkins failure

[jira] [Commented] (LUCENE-7966) build mr-jar and use some java 9 methods if available

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356418#comment-16356418 ] Robert Muir commented on LUCENE-7966: - The issue with backporting to 7x is that we ha

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356399#comment-16356399 ] Robert Muir commented on LUCENE-8165: - For the record copyOf does similar lenient fil

[jira] [Updated] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8165: Attachment: LUCENE-8165_start.patch > ban Arrays.copyOfRange with forbidden APIs >

[jira] [Commented] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356376#comment-16356376 ] Robert Muir commented on LUCENE-8165: - attached starter patch that fixes BytesRef/Cha

[jira] [Updated] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8165: Attachment: LUCENE-8165_start.patch > ban Arrays.copyOfRange with forbidden APIs >

[jira] [Created] (LUCENE-8165) ban Arrays.copyOfRange with forbidden APIs

2018-02-07 Thread Robert Muir (JIRA)
Robert Muir created LUCENE-8165: --- Summary: ban Arrays.copyOfRange with forbidden APIs Key: LUCENE-8165 URL: https://issues.apache.org/jira/browse/LUCENE-8165 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356341#comment-16356341 ] Robert Muir commented on LUCENE-8164: - And the bug in PayloadAttributeImpl.copyTo boi

[jira] [Commented] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356334#comment-16356334 ] Robert Muir commented on LUCENE-8164: - I think in this particular test PayloadAttribu

[jira] [Commented] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356313#comment-16356313 ] Robert Muir commented on LUCENE-8164: - Basically was looking at this in response to T

[jira] [Commented] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356301#comment-16356301 ] Robert Muir commented on LUCENE-8164: - Actually the test is valid. You can add this:

[jira] [Commented] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356294#comment-16356294 ] Robert Muir commented on LUCENE-8164: - At least in my case here, I think CannedTokenS

[jira] [Updated] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-02-07 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-8164: Attachment: LUCENE-8164_test.patch > IndexWriter silently accepts broken payload >

[jira] [Created] (LUCENE-8164) IndexWriter silently accepts broken payload

2018-02-07 Thread Robert Muir (JIRA)
Robert Muir created LUCENE-8164: --- Summary: IndexWriter silently accepts broken payload Key: LUCENE-8164 URL: https://issues.apache.org/jira/browse/LUCENE-8164 Project: Lucene - Core Issue Type:

[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath

2018-02-05 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353164#comment-16353164 ] Robert Muir commented on LUCENE-8156: - Is there no way to avoid relying on what is in

[jira] [Commented] (LUCENE-7966) build mr-jar and use some java 9 methods if available

2018-02-04 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351780#comment-16351780 ] Robert Muir commented on LUCENE-7966: - yes we have to proceed with caution. the probl

[jira] [Commented] (LUCENE-8153) checkindex time more than doubles for wikipedia index with recent change

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350636#comment-16350636 ] Robert Muir commented on LUCENE-8153: - Basically i would propose we deprecate crossCh

[jira] [Commented] (LUCENE-8153) checkindex time more than doubles for wikipedia index with recent change

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350626#comment-16350626 ] Robert Muir commented on LUCENE-8153: - also in both cases we are making a tradeoff fo

[jira] [Commented] (LUCENE-8153) checkindex time more than doubles for wikipedia index with recent change

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350624#comment-16350624 ] Robert Muir commented on LUCENE-8153: - for other skipping tests don't we already do o

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350376#comment-16350376 ] Robert Muir commented on LUCENE-8150: - Also, practically speaking there is enough 4.x

[jira] [Commented] (LUCENE-8150) Remove references to segments.gen.

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350374#comment-16350374 ] Robert Muir commented on LUCENE-8150: - Is it enough to try to contain the logic to ju

[jira] [Commented] (LUCENE-8138) Check that dv producers return the same values with advanceExact

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350352#comment-16350352 ] Robert Muir commented on LUCENE-8138: - I was hoping we could still see the huge chang

[jira] [Created] (LUCENE-8153) checkindex time more than doubles for wikipedia index with recent change

2018-02-02 Thread Robert Muir (JIRA)
Robert Muir created LUCENE-8153: --- Summary: checkindex time more than doubles for wikipedia index with recent change Key: LUCENE-8153 URL: https://issues.apache.org/jira/browse/LUCENE-8153 Project: Lucen

[jira] [Commented] (LUCENE-8138) Check that dv producers return the same values with advanceExact

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350347#comment-16350347 ] Robert Muir commented on LUCENE-8138: - Also because checkindex historically did a seq

[jira] [Commented] (LUCENE-8138) Check that dv producers return the same values with advanceExact

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350338#comment-16350338 ] Robert Muir commented on LUCENE-8138: - merge instance won't lazy-load stuff permanent

[jira] [Commented] (LUCENE-8134) Disallow changing index options on the fly

2018-02-02 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350234#comment-16350234 ] Robert Muir commented on LUCENE-8134: - +1 > Disallow changing index options on the f

[jira] [Commented] (LUCENE-8146) Unit tests using StringHelper fail with ExceptionInInitializerError for maven surefire >= 2.18

2018-02-01 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348507#comment-16348507 ] Robert Muir commented on LUCENE-8146: - Is there a bug in the maven bugtracker for thi

[jira] [Commented] (LUCENE-8148) Get precommit Lint warnings out of test code

2018-01-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348066#comment-16348066 ] Robert Muir commented on LUCENE-8148: - Wouldn't it be more prudent to first fix the n

[jira] [Commented] (SOLR-11858) NPE in DirectSpellChecker

2018-01-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347822#comment-16347822 ] Robert Muir commented on SOLR-11858: I opened LUCENE-8147 to give better exceptions he

[jira] [Created] (LUCENE-8147) DirectSpellChecker needs better parameter checks

2018-01-31 Thread Robert Muir (JIRA)
Robert Muir created LUCENE-8147: --- Summary: DirectSpellChecker needs better parameter checks Key: LUCENE-8147 URL: https://issues.apache.org/jira/browse/LUCENE-8147 Project: Lucene - Core Issue

[jira] [Commented] (SOLR-11858) NPE in DirectSpellChecker

2018-01-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347821#comment-16347821 ] Robert Muir commented on SOLR-11858: My best guess is the high level bug is here: [ht

[jira] [Commented] (LUCENE-8144) Remove QueryCachingPolicy.ALWAYS_CACHE

2018-01-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347513#comment-16347513 ] Robert Muir commented on LUCENE-8144: - +1 > Remove QueryCachingPolicy.ALWAYS_CACHE >

[jira] [Commented] (LUCENE-8146) Unit tests using StringHelper fail with ExceptionInInitializerError for maven surefire >= 2.18

2018-01-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347225#comment-16347225 ] Robert Muir commented on LUCENE-8146: - Well I'd probably feel different if it was mor

[jira] [Commented] (LUCENE-8146) Unit tests using StringHelper fail with ExceptionInInitializerError for maven surefire >= 2.18

2018-01-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347065#comment-16347065 ] Robert Muir commented on LUCENE-8146: - {quote} There was a change in Surefire's behav

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-28 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342865#comment-16342865 ] Robert Muir commented on LUCENE-4198: - Sorry, took me a long time (been traveling). I

[jira] [Commented] (SOLR-11892) Avoid unnecessary exceptions in FSDirectory and RAMDirectory

2018-01-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338695#comment-16338695 ] Robert Muir commented on SOLR-11892: The leniency there only exists for windows system

[jira] [Commented] (SOLR-11892) Avoid unnecessary exceptions in FSDirectory and RAMDirectory

2018-01-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338601#comment-16338601 ] Robert Muir commented on SOLR-11892: Exceptions are cheap, deleting files is scary and

[jira] [Commented] (SOLR-11892) Avoid unnecessary exceptions in FSDirectory and RAMDirectory

2018-01-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336933#comment-16336933 ] Robert Muir commented on SOLR-11892: -1: the exact exception type is important. Sorry,

[jira] [Commented] (LUCENE-7110) Add Shape Support to BKD (extend to an R*/X-Tree data structure)

2018-01-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336394#comment-16336394 ] Robert Muir commented on LUCENE-7110: - {quote} This is exactly what I was thinking. C

[jira] [Commented] (LUCENE-7110) Add Shape Support to BKD (extend to an R*/X-Tree data structure)

2018-01-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336199#comment-16336199 ] Robert Muir commented on LUCENE-7110: - Then shouldn't we just add Range? It'd like to

[jira] [Commented] (LUCENE-8132) HyphenationDecompoundTokenFilter does not set position/offset attributes correctly

2018-01-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334273#comment-16334273 ] Robert Muir commented on LUCENE-8132: - Thats what HyphenationDecompoundTokenFilter al

[jira] [Commented] (LUCENE-8132) HyphenationDecompoundTokenFilter does not set position/offset attributes correctly

2018-01-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334074#comment-16334074 ] Robert Muir commented on LUCENE-8132: - why do you need to decompound more than once?

[jira] [Commented] (LUCENE-8132) HyphenationDecompoundTokenFilter does not set position/offset attributes correctly

2018-01-22 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334027#comment-16334027 ] Robert Muir commented on LUCENE-8132: - Maybe the right solution is just to fix it cor

[jira] [Resolved] (LUCENE-8129) Support for defining a Unicode set filter when using ICUFoldingFilter

2018-01-16 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-8129. - Resolution: Fixed Fix Version/s: 7.3 trunk Thanks [~emaijala]! > Suppo

[jira] [Commented] (LUCENE-8122) upgrade icu to 60.2

2018-01-15 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326343#comment-16326343 ] Robert Muir commented on LUCENE-8122: - Thanks Uwe! i had neglected to regenerate from

[jira] [Resolved] (LUCENE-8125) emoji sequence support in ICUTokenizer

2018-01-14 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-8125. - Resolution: Fixed Fix Version/s: 7.3 trunk > emoji sequence support in

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324427#comment-16324427 ] Robert Muir commented on LUCENE-4198: - Yeah, its good to split it up into sizable chu

[jira] [Commented] (LUCENE-4198) Allow codecs to index term impacts

2018-01-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324250#comment-16324250 ] Robert Muir commented on LUCENE-4198: - There are a lot of approaches for getting the

<    1   2   3   4   5   6   7   8   9   10   >