Github user iverase commented on the issue:
https://github.com/apache/lucene-solr/pull/246
I have added the possibility to relate no geo3d rectangles. I was trying to
avoid that but I see that for the time being it is necessary.
I did the changes on the test as well so I am
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/246#discussion_r138556038
--- Diff:
lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dDistanceCalculator.java
---
@@ -70,7 +71,22 @@ public boolean within
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/246#discussion_r138555768
--- Diff:
lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShape.java
---
@@ -96,45 +95,25 @@ else if (relationship
GitHub user iverase opened a pull request:
https://github.com/apache/lucene-solr/pull/246
LUCENE-7951: New wrapper classes for Geo3d
Create a pull request for LUCENE-7951
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iverase
Github user iverase closed the pull request at:
https://github.com/apache/lucene-solr/pull/246
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
GitHub user iverase opened a pull request:
https://github.com/apache/lucene-solr/pull/288
LUCENE-8086
Here are the changes, in particular:
- Geo3dFactory: Use GeoExactCircle for non-spherical planets.
- Geo3dCircleShape: Remove method relate.
- Geo3DShape: Use new
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/288#discussion_r155843390
--- Diff:
lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
---
@@ -67,6 +74,25 @@ public SpatialContext
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/288#discussion_r155844229
--- Diff:
lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/Geo3dShapeRectRelationTestCase.java
---
@@ -155,16 +107,12 @@ protected
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/288#discussion_r155844074
--- Diff:
lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
---
@@ -55,6 +55,13 @@
private
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/288#discussion_r155843938
--- Diff:
lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
---
@@ -150,10 +176,21 @@ public Rectangle rect
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/288#discussion_r155844958
--- Diff:
lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/Geo3dShapeRectRelationTestCase.java
---
@@ -16,29 +16,15
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/302#discussion_r160868387
--- Diff:
lucene/spatial-extras/src/java/org/apache/lucene/spatial/prefix/tree/S2PrefixTreeCell.java
---
@@ -0,0 +1,285 @@
+/*
+ * Licensed
GitHub user iverase opened a pull request:
https://github.com/apache/lucene-solr/pull/302
LUCENE-8126: Spatial prefix tree based on S2 geometry
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iverase/lucene-solr master
Github user iverase closed the pull request at:
https://github.com/apache/lucene-solr/pull/288
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user iverase closed the pull request at:
https://github.com/apache/lucene-solr/pull/302
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r221582158
--- Diff: lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java ---
@@ -442,11 +442,12 @@ void visitDocValues(int[] commonPrefixLengths, byte
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r221581265
--- Diff: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java ---
@@ -1063,7 +1064,7 @@ public void testWastedLeadingBytes() throws Exception
Github user iverase commented on the issue:
https://github.com/apache/lucene-solr/pull/451
I have only one comment for this version that I think we should address. We
are allocation two byte arrays for each leaf we are visiting and I think we can
prevent it. Apart from that it looks
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r220196714
--- Diff: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java ---
@@ -1063,7 +1064,7 @@ public void testWastedLeadingBytes() throws Exception
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r218112746
--- Diff: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java ---
@@ -1063,7 +1064,7 @@ public void testWastedLeadingBytes() throws Exception
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r217970618
--- Diff: lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java ---
@@ -981,15 +988,15 @@ public long finish(IndexOutput out) throws
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r217971501
--- Diff: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java ---
@@ -1063,7 +1064,7 @@ public void testWastedLeadingBytes() throws Exception
Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/451#discussion_r217970947
--- Diff: lucene/core/src/java/org/apache/lucene/util/bkd/BKDReader.java ---
@@ -52,10 +53,17 @@
/** Caller must pre-seek the provided {@link
23 matches
Mail list logo
