Re: Branch branch_8_9 has been cut and versions updated to 8.10 on stable branch

2021-06-08 Thread Thomas Wöckinger
7 <https://issues.apache.org/jira/browse/SOLR-15457>. Is this a > blocker for 8.9? Should we wait till it gets fixed? > > On Tue, Jun 8, 2021 at 1:45 AM Thomas Wöckinger < > thomas.woeckin...@gmail.com> wrote: > >> Hi Mayya, >> >> I tested the branch_8_9

Re: Branch branch_8_9 has been cut and versions updated to 8.10 on stable branch

2021-06-07 Thread Thomas Wöckinger
Hi Mayya, I tested the branch_8_9 yesterday and found a behavioral change when using Faceting with Enum fields, the returned 'val' in the buckets has changed from EnumFieldValue to a String of the corresponding ordinal. I think it is related to https://issues.apache.org/jira/browse/SOLR-15191, I

Re: [jira] [Commented] (SOLR-15064) Atomic/partial updates to nested docs should not assume _route_ param is the root ID

2021-02-23 Thread Thomas Wöckinger
I am not sure how this happened, it was a comment form another thread, whatever i deleted it On Wed, Feb 24, 2021 at 5:48 AM David Smiley (Jira) wrote: > > [ >

Re: [jira] [Commented] (SOLR-14788) Solr: The Next Big Thing

2020-12-16 Thread Thomas Wöckinger
If you left over some configuration form 8.x, e.g old cache config this could be the reason On Wed, Dec 16, 2020 at 4:20 PM Markus Jelsma (Jira) wrote: > > [ >

Re: [jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-10-20 Thread Thomas Wöckinger
ecurity Level. Issues are Public) > > Components: update, UpdateRequestProcessors > >Affects Versions: master (9.0), 8.3, 8.4, 8.5, 8.6 > >Reporter: Thomas Wöckinger > >Priority: Critical > > Labels: performance > > &g

Re: [jira] [Commented] (SOLR-14923) Indexing performance is unacceptable when child documents are involved

2020-10-13 Thread Thomas Wöckinger
ult Security Level. Issues are Public) > > Components: update, UpdateRequestProcessors > >Affects Versions: master (9.0), 8.3, 8.4, 8.5, 8.6 > >Reporter: Thomas Wöckinger > >Priority: Critical > > Labels: performanc

Re: [jira] [Commented] (SOLR-13961) Unsetting Nested Documents using Atomic Update leads to SolrException: undefined field

2019-11-22 Thread Thomas Wöckinger
> > Components: Tests, UpdateRequestProcessors > >Affects Versions: master (9.0), 8.3, 8.4 > >Reporter: Thomas Wöckinger > >Priority: Critical > > Labels: easyfix > > Time Spent: 10m > > Rem

Re: [jira] [Commented] (SOLR-13961) Unsetting Nested Documents using Atomic Update leads to SolrException: undefined field

2019-11-22 Thread Thomas Wöckinger
I am not sure who is responsible for Atomic Updates and nested documents, it would be really great to get https://github.com/apache/lucene-solr/pull/1030 into 8.4. On Fri, Nov 22, 2019 at 7:17 PM Thomas Wöckinger (Jira) wrote: > > [ > https://issues.apache.org/jira/browse/SOLR-1

Re: [jira] [Created] (SOLR-13473) Ensure that the tests use JSON,javabin to update docs

2019-05-16 Thread Thomas Wöckinger
I think both, or ideally every used codec should be tested, so i refactored the test base to allow easy change of the used code when using EmbeddedSolrServer. The changes are done with PR https://github.com/apache/lucene-solr/pull/665, test also added for any multi value field operations which

Re: [jira] [Created] (SOLR-13471) javabin codec can marshal data that it can't unmarshal (ClassCastException: class java.lang.Boolean cannot be cast to class java.lang.String)

2019-05-15 Thread Thomas Wöckinger
Already fixed with issue SOLR-13331 , will add the issue as dependent On Tue, May 14, 2019 at 11:36 PM Hoss Man (JIRA) wrote: > Hoss Man created SOLR-13471: > --- > > Summary: javabin codec can marshal

Re: [VOTE] Release Lucene/Solr 8.1.0 RC1

2019-05-09 Thread Thomas Wöckinger
Fixed three other bugs (SOLR-13347, SOLR-13331, SOLR11841) with PR https://github.com/apache/lucene-solr/pull/665 which needs to be reviewed, ensures correct behavior when using solrj as client! On Thu, May 9, 2019 at 4:13 PM Jan Høydahl wrote: > I fixed

Re: Writing Unit test for SOLR Issue

2019-05-03 Thread Thomas Wöckinger
Now that all apache repos are moved to github, is it possible to do a pull request? I dont wan't to crunch all changes into one commit. Best, Tom On Thu, May 2, 2019 at 3:48 PM Thomas Wöckinger wrote: > In the middle of writing a test base, i realized that the > SolrJettyTestBase is

Re: Writing Unit test for SOLR Issue

2019-05-02 Thread Thomas Wöckinger
refactor EmbeddedSolrServer to use different codecs beside JavaBinCodec? Best, Tom On Thu, May 2, 2019 at 1:01 PM Thomas Wöckinger wrote: > Ok, thx for your fast response, i will start now, hope to be finished in > two days. > > Best, > > Tom > > On Thu, May 2, 2019 at

Re: Writing Unit test for SOLR Issue

2019-05-02 Thread Thomas Wöckinger
there). > > Best, > > Jason > > On Thu, May 2, 2019 at 5:36 AM Thomas Wöckinger > wrote: > > > > As i already commented on the issue SOLR-13331, i am starting writing > test on this issue using EmbbededSolrServer, i didn't had time the last few > weeks, should

Re: Writing Unit test for SOLR Issue

2019-05-02 Thread Thomas Wöckinger
EmbeddedSolrServer though, you'll probably need to use > HttpSolrClient and one of the other test bases. Other test base > options are RestTestBase or SolrJettyTestBase (see SolrJ's SchemaTest > or TestBatchUpdate for examples of each of these.) > > On Tue, Mar 26, 2019 at 10:03 AM Tho

Re: Writing Unit test for SOLR Issue

2019-03-26 Thread Thomas Wöckinger
test/org/apache/solr/update/processor/AtomicUpdatesTest.java > >> > >> If you don’t want to add tests to that class, that’ll be (roughly) the > place you’d add a new test class. > >> > >> Best, > >> Erick > >> > >> > On Mar 25, 2019,

Re: Writing Unit test for SOLR Issue

2019-03-26 Thread Thomas Wöckinger
:42 PM Erick Erickson wrote: > Take a look at > …/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdatesTest.java > > If you don’t want to add tests to that class, that’ll be (roughly) the > place you’d add a new test class. > > Best, > Erick > > > On

Re: Writing Unit test for SOLR Issue

2019-03-25 Thread Thomas Wöckinger
cessor/AtomicUpdatesTest.java > > If you don’t want to add tests to that class, that’ll be (roughly) the > place you’d add a new test class. > > Best, > Erick > > > On Mar 25, 2019, at 9:54 AM, Thomas Wöckinger < > thomas.woeckin...@gmail.com> wrote: > > > >

Re: Writing Unit test for SOLR Issue

2019-03-25 Thread Thomas Wöckinger
ass, that’ll be (roughly) the > place you’d add a new test class. > > Best, > Erick > > > On Mar 25, 2019, at 9:54 AM, Thomas Wöckinger < > thomas.woeckin...@gmail.com> wrote: > > > > Hi! > > > > I submitted a patch for a solr bug > https://iss

Writing Unit test for SOLR Issue

2019-03-25 Thread Thomas Wöckinger
Hi! I submitted a patch for a solr bug https://issues.apache.org/jira/browse/SOLR-13331, i also want to add unit test for that issue. May someone can give me an advice where to add these unit test, because a simple test can be made easy but i think there should be also some integration tests,