[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198047#comment-16198047
]
ASF subversion and git services commented on LUCENE-7951:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198044#comment-16198044
]
ASF subversion and git services commented on LUCENE-7951:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198039#comment-16198039
]
ASF subversion and git services commented on LUCENE-7951:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185783#comment-16185783
]
ASF GitHub Bot commented on LUCENE-7951:
Github user iverase closed the pull request at:
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174182#comment-16174182
]
ASF subversion and git services commented on LUCENE-7951:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174177#comment-16174177
]
ASF subversion and git services commented on LUCENE-7951:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173178#comment-16173178
]
Ignacio Vera commented on LUCENE-7951:
--
The problem is that in the test you do not have information
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173118#comment-16173118
]
Karl Wright commented on LUCENE-7951:
-
{quote}
The test generates points of a shape by creating a
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173092#comment-16173092
]
Ignacio Vera commented on LUCENE-7951:
--
Actually there is already a test: In
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173086#comment-16173086
]
Ignacio Vera commented on LUCENE-7951:
--
sure, I will add a test for this particular feature.
I
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173076#comment-16173076
]
David Smiley commented on LUCENE-7951:
--
I'm inclined to commit this branch despite the override in
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173045#comment-16173045
]
Ignacio Vera commented on LUCENE-7951:
--
There test generates points of a shape by creating a circle
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173036#comment-16173036
]
Karl Wright commented on LUCENE-7951:
-
[~ivera] I am curious as to why the GeoStandardCircle causes
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172931#comment-16172931
]
Ignacio Vera commented on LUCENE-7951:
--
I have merge the Geo3dAreaRptTest into Geo3dRptTest. T
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171100#comment-16171100
]
David Smiley commented on LUCENE-7951:
--
(I'm back from travel)
The current state is looking pretty
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165907#comment-16165907
]
Ignacio Vera commented on LUCENE-7951:
--
Hi [~dsmiley],
I would like to share some thoughts of the
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164335#comment-16164335
]
Ignacio Vera commented on LUCENE-7951:
--
Now all test are green. Note what I have to do with the
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164318#comment-16164318
]
ASF GitHub Bot commented on LUCENE-7951:
Github user iverase commented on a diff in the pull
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164316#comment-16164316
]
ASF GitHub Bot commented on LUCENE-7951:
Github user iverase commented on a diff in the pull
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159296#comment-16159296
]
ASF GitHub Bot commented on LUCENE-7951:
Github user iverase commented on the issue:
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158834#comment-16158834
]
ASF GitHub Bot commented on LUCENE-7951:
Github user dsmiley commented on a diff in the pull
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158835#comment-16158835
]
ASF GitHub Bot commented on LUCENE-7951:
Github user dsmiley commented on a diff in the pull
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158689#comment-16158689
]
Ignacio Vera commented on LUCENE-7951:
--
I put a new version where planetModel and distanceCalculator
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158617#comment-16158617
]
David Smiley commented on LUCENE-7951:
--
bq. We must always construct the calculator if
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158156#comment-16158156
]
Ignacio Vera commented on LUCENE-7951:
--
Hi [~dsmiley],
Updating the configuration files makes
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157460#comment-16157460
]
David Smiley commented on LUCENE-7951:
--
I propose the contents of the Geo3dSpatialContextFactory
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156980#comment-16156980
]
Ignacio Vera commented on LUCENE-7951:
--
The following error is thrown by precommit if you try to use
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156949#comment-16156949
]
David Smiley commented on LUCENE-7951:
--
I think Geo3d randomized shape generation should exist in
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156657#comment-16156657
]
ASF GitHub Bot commented on LUCENE-7951:
GitHub user iverase opened a pull request:
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156557#comment-16156557
]
Ignacio Vera commented on LUCENE-7951:
--
[~dsmiley], I am ok with the pull request but I have never
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156445#comment-16156445
]
Karl Wright commented on LUCENE-7951:
-
[~dsmiley] I'm fine if you want to cut down on code
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156438#comment-16156438
]
David Smiley commented on LUCENE-7951:
--
[~ivera] I'd prefer a GitHub Pull Request if we make further
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153199#comment-16153199
]
Karl Wright commented on LUCENE-7951:
-
[~dsmiley], I think that since this is mainly a spatial4j
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153177#comment-16153177
]
Karl Wright commented on LUCENE-7951:
-
{quote}
would it make sense to add a new GeoShape for
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152845#comment-16152845
]
David Smiley commented on LUCENE-7951:
--
Lets then add "Shape" suffix to those classes here
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152709#comment-16152709
]
Ignacio Vera commented on LUCENE-7951:
--
Thanks for the comments! please feel free to add more as
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152660#comment-16152660
]
Karl Wright commented on LUCENE-7951:
-
[~ivera], [~dsmiley], the distance calculator Ignacio wrote is
[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152635#comment-16152635
]
David Smiley commented on LUCENE-7951:
--
Thanks for contributing this Ignacio!
38 matches
Mail list logo
