[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463002#comment-16463002 ] Jan Høydahl commented on SOLR-11490: I think Robert says that "3.1" is fine, since that is a valid version. We can view lucene/solr as a "new product" separate since the merger, and that product started as v3.1. I'm ok with that as well, since the goal of Javadoc is not to track svn/git history, we still have repos for that, but to give a hint what releases a particular class has been present in. PS: When we had the Solr docs in the old wiki, we used to tag features, parameters etc with a "since" tag which was often very useful. I hope that adding these since annotations can get back some of that. I guess we can also tag new methods, not only classes? > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462616#comment-16462616 ] Alexandre Rafalovitch commented on SOLR-11490: -- Ok. But then I really don't get your proposal. What would you be ok with tagging - for example - PatternTokenizerFactory? "3.1" is not valid "pre-3.1 " you are blocking nothing is confusing to newbies, in my opinion, so that's what I am trying to avoid Do we have something between us that is not -1? > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[
https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462592#comment-16462592
]
Robert Muir commented on SOLR-11490:
I am against pre-3.1 or any other invalid versions in since tags. I'm gonna
quote myself just to re-iterate what I already said.
{quote}
Just like how you marked HMMChineseTokenizerFactory as 4.8.0, that's fine. But
lineage-wise (look at svn for that) you'd see its been around since 2.9, it was
just named something different (SmartChinese).
{quote}
> Add @since javadoc tags to the interesting Solr/Lucene classes
> --
>
> Key: SOLR-11490
> URL: https://issues.apache.org/jira/browse/SOLR-11490
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Alexandre Rafalovitch
>Assignee: Alexandre Rafalovitch
>Priority: Minor
>
> As per the discussion on the dev list, it may be useful to add Javadoc since
> tags to significant (or even all) Java files.
> For user-facing files (such as analyzers, URPs, stream evaluators, etc) it
> would be useful when trying to identifying whether a particular class only
> comes later than user's particular version.
> For other classes, it may be useful for historical reasons.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462585#comment-16462585 ] Alexandre Rafalovitch commented on SOLR-11490: -- 19 Oct, me: "Sure. Let's do 3.1+ as a joint tag and ignore anything before that. I'll roll-back the earlier ones." Perhaps I misunderstood. I thought it makes no sense to tag something that's been in lucene 1.x as 3.1, and read it that you meant to tag it not at all. So, my proposal now is to tag it "pre-3.1". Maybe we are on the same page. > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[
https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462549#comment-16462549
]
Robert Muir commented on SOLR-11490:
{quote}
We had agreed that pre-3.1 classes will get no since tag.
{quote}
Where was this? I see consensus above to simply label these as "3.1".
> Add @since javadoc tags to the interesting Solr/Lucene classes
> --
>
> Key: SOLR-11490
> URL: https://issues.apache.org/jira/browse/SOLR-11490
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Alexandre Rafalovitch
>Assignee: Alexandre Rafalovitch
>Priority: Minor
>
> As per the discussion on the dev list, it may be useful to add Javadoc since
> tags to significant (or even all) Java files.
> For user-facing files (such as analyzers, URPs, stream evaluators, etc) it
> would be useful when trying to identifying whether a particular class only
> comes later than user's particular version.
> For other classes, it may be useful for historical reasons.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462523#comment-16462523 ] Alexandre Rafalovitch commented on SOLR-11490: -- Yes, I will mark it resolved and come back to it later in more targeted groups. The only issue this tagging created is that there will always be new classes that are not (yet) tagged. And they will look identical as ones not tagged because they are pre-3.1 We had agreed that pre-3.1 classes will get no since tag. But perhaps I can retag them all "pre-3.1". This way only the newest classes in the particular category will be untagged. Obviously, this mostly matters to the Lucene/Solr newbies, but that's exactly my target audience with this JIRA. [~rcmuir] - is that ok with you to have a common-joint historical tag instead of no tag at all? I just want to resolve this in this case, as it was more common, to have the discussion finalized in one place. > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16455467#comment-16455467 ] Jan Høydahl commented on SOLR-11490: Can this be resolved and create new more targeted JIRAs for more groups of classes? > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214567#comment-16214567 ] ASF subversion and git services commented on SOLR-11490: Commit 60273fc52172d9774d399a26d4f349a52fcd6aed in lucene-solr's branch refs/heads/branch_7x from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=60273fc ] SOLR-11490: Undo since tags for pre-3.1 classes Reverse some of the added tags, to reduce possible solr/lucene version confusion (cherry picked from commit 2cd434e786065fe639d912230d44bf410024c85d) > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214565#comment-16214565 ] ASF subversion and git services commented on SOLR-11490: Commit 2cd434e786065fe639d912230d44bf410024c85d in lucene-solr's branch refs/heads/master from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2cd434e ] SOLR-11490: Undo since tags for pre-3.1 classes Reverse some of the added tags, to reduce possible solr/lucene version confusion > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211988#comment-16211988 ] David Smiley commented on SOLR-11490: - Thanks for doing this [~arafalov] -- I've already benefited with the knowledge from your previous commits here :-) +1 to "since 3.1". I concur with Rob's input here. > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211981#comment-16211981 ] Alexandre Rafalovitch commented on SOLR-11490: -- Sure. Let's do 3.1+ as a joint tag and ignore anything before that. I'll roll-back the earlier ones. And yes, there probably will be individual errors. Those can be corrected by hand as discovered. > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211583#comment-16211583 ] Robert Muir commented on SOLR-11490: And honestly, I think thats most correct anyway given how they are now structured. We aren't doing a historical traceing of lineage, for that, go to SVN (possibly under other names) :) Just like how you marked HMMChineseTokenizerFactory as 4.8.0, that's fine. But lineage-wise (look at svn for that) you'd see its been around since 2.9, it was just named something different (SmartChinese). > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[
https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211577#comment-16211577
]
Robert Muir commented on SOLR-11490:
Could we just do {{since 3.1}} for this old stuff? Then its agnostic, it works
for both lucene and solr users.
> Add @since javadoc tags to the interesting Solr/Lucene classes
> --
>
> Key: SOLR-11490
> URL: https://issues.apache.org/jira/browse/SOLR-11490
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Alexandre Rafalovitch
>Assignee: Alexandre Rafalovitch
>Priority: Minor
>
> As per the discussion on the dev list, it may be useful to add Javadoc since
> tags to significant (or even all) Java files.
> For user-facing files (such as analyzers, URPs, stream evaluators, etc) it
> would be useful when trying to identifying whether a particular class only
> comes later than user's particular version.
> For other classes, it may be useful for historical reasons.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211522#comment-16211522 ] Alexandre Rafalovitch commented on SOLR-11490: -- So, the problem I am trying to solve is a person using a semi-recent version of Solr (say 6.2) and trying to understand which of the Solr components were already available at their version and which are perhaps worth upgrading for. And same with Lucene, I guess, but my visibility into that project as standalone library is less clear. To that target audience, I do not see marking of anything before - say - Solr 4 to be of significant impact. I am just trying to be complete for the sake of completeness and because it does not take much longer. I understand we have complexity due to separate pre-history, due to migration of Solr components into Lucene packages and maybe more. Therefore, as the only person with concerns so far (thank you for making time), I am happy to address your concerns in whichever way you feel it would be reasonable. A concrete suggestion of specific versions/classes to do in a different way. I can: 1) Mark pre-3.1 with their individual Solr or Lucene histories 2) I can avoid marking pre-3.1 classes all together and just lump it into the murky back history of assumed general availability 3) I can - though would prefer not to - not mark the Lucene classes with earlier Solr-origin versions. I would prefer not to take that route because the functionality was clearly available, at least to Solr users. 4) Any other specific suggestion. I could not see anything specifically relevant in LUCENE-7964 discussion Again, this tagging does not affect anybody's code (it is just documentation), the historical tags do not really affect anybody on Lucene/Solr 4 or later, and whichever way you look at it, the current absence of tags is confusing by default. I understand the point of the precedent in general, so happy to let more experienced members of community to decide what needs to be done without causing one. > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211496#comment-16211496 ] Robert Muir commented on SOLR-11490: I still think its confusing having these solr version numbers here. There was already a recent discussion by Jan about this with respect to solr xml in these files, too: LUCENE-7964 I am concerned about setting the precedent, and putting more solr version numbers like this in other lucene sources and confusing users even more. IMO they already have enough to be confused about :) > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[
https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210934#comment-16210934
]
Alexandre Rafalovitch commented on SOLR-11490:
--
So, the last example looks like:
{panel}
ClassicTokenizerFactory.java first shows up in '3.1'
EdgeNGramTokenizerFactory.java first shows up in 'solr 1.2.0'
HMMChineseTokenizerFactory.java first shows up in '4.8.0'
ICUTokenizerFactory.java first shows up in '3.1'
JapaneseTokenizerFactory.java first shows up in '3.6.0'
KeywordTokenizerFactory.java first shows up in 'solr 1.1.0'
LetterTokenizerFactory.java first shows up in 'solr 1.1.0'
LowerCaseTokenizerFactory.java first shows up in 'solr 1.1.0'
NGramTokenizerFactory.java first shows up in 'solr 1.2.0'
PathHierarchyTokenizerFactory.java first shows up in '3.1'
PatternTokenizerFactory.java first shows up in 'solr1.2'
SimplePatternSplitTokenizerFactory.java first shows up in '6.5.0'
SimplePatternTokenizerFactory.java first shows up in '6.5.0'
StandardTokenizerFactory.java first shows up in 'solr 1.1.0'
ThaiTokenizerFactory.java first shows up in '4.8.0'
TokenizerFactory.java first shows up in 'solr 1.1.0'
UAX29URLEmailTokenizerFactory.java first shows up in '3.1'
UIMAAnnotationsTokenizerFactory.java first shows up in '4.0.0'
UIMATypeAwareAnnotationsTokenizerFactory.java first shows up in '4.0.0'
WhitespaceTokenizerFactory.java first shows up in 'solr 1.1.0'
WikipediaTokenizerFactory.java first shows up in '3.1'
{panel}
Are we good to go?
> Add @since javadoc tags to the interesting Solr/Lucene classes
> --
>
> Key: SOLR-11490
> URL: https://issues.apache.org/jira/browse/SOLR-11490
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Alexandre Rafalovitch
>Assignee: Alexandre Rafalovitch
>Priority: Minor
>
> As per the discussion on the dev list, it may be useful to add Javadoc since
> tags to significant (or even all) Java files.
> For user-facing files (such as analyzers, URPs, stream evaluators, etc) it
> would be useful when trying to identifying whether a particular class only
> comes later than user's particular version.
> For other classes, it may be useful for historical reasons.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210907#comment-16210907 ] Alexandre Rafalovitch commented on SOLR-11490: -- Ok, so I can split pre-3.1 tags into lucene-x.y.z and solr-x.y.z based on release tags. And then just general number from 3.1 forward. Does this address all your concerns? > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210899#comment-16210899 ] Robert Muir commented on SOLR-11490: bq. What am I missing? That these solr version numbers did not align with lucene version numbers until 3.1. Thats why I think its confusing, e.g. to someone just using CustomAnalyzer. > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[
https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210460#comment-16210460
]
Alexandre Rafalovitch commented on SOLR-11490:
--
Here's what I am getting for Tokenizer factories. Not committing them yet, as
they may have similar issues as mentioned before for Filter factories.
[~rcmuir], any of these look wrong to you, so we could figure out where the
problem exactly is?
{panel}
ClassicTokenizerFactory.java first shows up in 3.1
EdgeNGramTokenizerFactory.java first shows up in 1.2.0
HMMChineseTokenizerFactory.java first shows up in 4.8.0
ICUTokenizerFactory.java first shows up in 3.1
JapaneseTokenizerFactory.java first shows up in 3.6.0
KeywordTokenizerFactory.java first shows up in 1.1.0
LetterTokenizerFactory.java first shows up in 1.1.0
LowerCaseTokenizerFactory.java first shows up in 1.1.0
NGramTokenizerFactory.java first shows up in 1.2.0
PathHierarchyTokenizerFactory.java first shows up in 3.1
PatternTokenizerFactory.java first shows up in solr1.2
SimplePatternSplitTokenizerFactory.java first shows up in 6.5.0
SimplePatternTokenizerFactory.java first shows up in 6.5.0
StandardTokenizerFactory.java first shows up in 1.1.0
ThaiTokenizerFactory.java first shows up in 4.8.0
TokenizerFactory.java first shows up in 1.1.0
UAX29URLEmailTokenizerFactory.java first shows up in 3.1
UIMAAnnotationsTokenizerFactory.java first shows up in 4.0.0
UIMATypeAwareAnnotationsTokenizerFactory.java first shows up in 4.0.0
WhitespaceTokenizerFactory.java first shows up in 1.1.0
WikipediaTokenizerFactory.java first shows up in 3.1
{panel}
Note, PatternTokenizerFactory already has a @since tag, which is why it looks
different from those proposed automatically.
> Add @since javadoc tags to the interesting Solr/Lucene classes
> --
>
> Key: SOLR-11490
> URL: https://issues.apache.org/jira/browse/SOLR-11490
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Alexandre Rafalovitch
>Assignee: Alexandre Rafalovitch
>Priority: Minor
>
> As per the discussion on the dev list, it may be useful to add Javadoc since
> tags to significant (or even all) Java files.
> For user-facing files (such as analyzers, URPs, stream evaluators, etc) it
> would be useful when trying to identifying whether a particular class only
> comes later than user's particular version.
> For other classes, it may be useful for historical reasons.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210444#comment-16210444 ] ASF subversion and git services commented on SOLR-11490: Commit a69a519de5e508f7073ef4e01b1e2c34ea8032bf in lucene-solr's branch refs/heads/branch_7x from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a69a519 ] SOLR-11490: Add missing @since tags To all descendants of TupleStream (cherry picked from commit 70784f456119e44e936d058c541945ebec0efaff) > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210443#comment-16210443 ] ASF subversion and git services commented on SOLR-11490: Commit 70784f456119e44e936d058c541945ebec0efaff in lucene-solr's branch refs/heads/master from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=70784f4 ] SOLR-11490: Add missing @since tags To all descendants of TupleStream > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209519#comment-16209519 ] Alexandre Rafalovitch commented on SOLR-11490: -- Sure. Let's correct whatever is wrong. Maybe this patch is correct for most of entries but is wrong for some specific ones. Then, we can figure out the specific set and ensure it is treated right for both this and future additions. So, let's take ArabicStemFilterFactory as an example you probably meant to use (ArabicTokenizer does not seem to exist). I see it in the release 1.4: https://github.com/apache/lucene-solr/blob/releases/solr/1.4.0/src/java/org/apache/solr/analysis/ArabicStemFilterFactory.java Now, that's release predating Lucene and Solr merge (in 3.1), so perhaps this is the part we need to discuss to make it clearer? I also see that it was moved to Lucene packages from Solr packages: https://github.com/apache/lucene-solr/blob/master/lucene/analysis/common/src/java/org/apache/lucene/analysis/ar/ArabicStemFilterFactory.java This happened with LUCENE-2510 for Lucene/Solr 4. But that's the package change and the functionality did not change. So, the user that needs to work with Arabic text still could. I am not sure what happened in Lucene 2.9.0. I can see LUCENE-1460 which seems relevant, but the functionality in question seems to have been present both before and after. What am I missing? > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209138#comment-16209138 ] Robert Muir commented on SOLR-11490: Can you please back out the change to TokenFilterFactory? This needs discussion. I think its extremely confusing that e.g. ArabicTokenizer says since 1.4.0. It was added in Lucene 2.9.0 and that is what any since tag should show. > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208765#comment-16208765 ] ASF subversion and git services commented on SOLR-11490: Commit e4bed5ff9c791a1467003efe6ce5b525c62f9afb in lucene-solr's branch refs/heads/branch_7x from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e4bed5f ] SOLR-11490: Add missing @since tags To all descendants of TokenFilterFactory (cherry picked from commit 3eeeb9fa4d2cf1751b6cc60b2f1fb708417af8e8) > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208764#comment-16208764 ] ASF subversion and git services commented on SOLR-11490: Commit 3eeeb9fa4d2cf1751b6cc60b2f1fb708417af8e8 in lucene-solr's branch refs/heads/master from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3eeeb9f ] SOLR-11490: Add missing @since tags To all descendants of TokenFilterFactory > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208729#comment-16208729 ] ASF subversion and git services commented on SOLR-11490: Commit c6f26e2943c26533c416d79b0214205fd1a710e7 in lucene-solr's branch refs/heads/branch_7x from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c6f26e2 ] SOLR-11490: Add missing @since tags To all descendants of UpdateRequestProcessorFactory (cherry picked from commit 17d340055f7a799a0a686ea6d578fdd325625aaf) > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[ https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208724#comment-16208724 ] ASF subversion and git services commented on SOLR-11490: Commit 17d340055f7a799a0a686ea6d578fdd325625aaf in lucene-solr's branch refs/heads/master from [~arafalov] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=17d3400 ] SOLR-11490: Add missing @since tags To all descendants of UpdateRequestProcessorFactory > Add @since javadoc tags to the interesting Solr/Lucene classes > -- > > Key: SOLR-11490 > URL: https://issues.apache.org/jira/browse/SOLR-11490 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Alexandre Rafalovitch >Assignee: Alexandre Rafalovitch >Priority: Minor > > As per the discussion on the dev list, it may be useful to add Javadoc since > tags to significant (or even all) Java files. > For user-facing files (such as analyzers, URPs, stream evaluators, etc) it > would be useful when trying to identifying whether a particular class only > comes later than user's particular version. > For other classes, it may be useful for historical reasons. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11490) Add @since javadoc tags to the interesting Solr/Lucene classes
[
https://issues.apache.org/jira/browse/SOLR-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204832#comment-16204832
]
Alexandre Rafalovitch commented on SOLR-11490:
--
I started on a - very hacky so far - utility that may do something close to
required for all classes descending from one root.
Here is an output for TupleStream and its descendent. These are sorted by
lowest detected version and then by class name. No inner classes yet, I know
about 5 inner classes are missing. [~joel.bernstein] could you sanity check
that these make sense.
{panel}
CloudSolrStream.java => 5.1.0
MergeStream.java => 5.1.0
ParallelStream.java => 5.1.0
PushBackStream.java => 5.1.0
RankStream.java => 5.1.0
ReducerStream.java => 5.1.0
SolrStream.java => 5.1.0
StreamHandler.java => 5.1.0
TupleStream.java => 5.1.0
UniqueStream.java => 5.1.0
BiJoinStream.java => 6.0.0
ComplementStream.java => 6.0.0
DaemonStream.java => 6.0.0
ExceptionStream.java => 6.0.0
FacetStream.java => 6.0.0
HashJoinStream.java => 6.0.0
InnerJoinStream.java => 6.0.0
IntersectStream.java => 6.0.0
JDBCStream.java => 6.0.0
JoinStream.java => 6.0.0
LeftOuterJoinStream.java => 6.0.0
OuterHashJoinStream.java => 6.0.0
RollupStream.java => 6.0.0
SelectStream.java => 6.0.0
StatsStream.java => 6.0.0
TopicStream.java => 6.0.0
UpdateStream.java => 6.0.0
GatherNodesStream.java => 6.1.0
GraphHandler.java => 6.1.0
RandomStream.java => 6.1.0
ShortestPathStream.java => 6.1.0
SortStream.java => 6.1.0
FeaturesSelectionStream.java => 6.2.0
ScoreNodesStream.java => 6.2.0
TextLogitStream.java => 6.2.0
ClassifyStream.java => 6.3.0
CommitStream.java => 6.3.0
ExecutorStream.java => 6.3.0
FetchStream.java => 6.3.0
ModelStream.java => 6.3.0
HavingStream.java => 6.4.0
NullStream.java => 6.4.0
PriorityStream.java => 6.4.0
SignificantTermsStream.java => 6.5.0
CalculatorStream.java => 6.6.0
CartesianProductStream.java => 6.6.0
CellStream.java => 6.6.0
EchoStream.java => 6.6.0
EvalStream.java => 6.6.0
GetStream.java => 6.6.0
LetStream.java => 6.6.0
ListStream.java => 6.6.0
ShuffleStream.java => 6.6.0
TimeSeriesStream.java => 6.6.0
TupStream.java => 6.6.0
CalciteJDBCStream.java => 7.0.0
KnnStream.java => 7.0.0
SqlStream.java => 7.0.0
{panel}
> Add @since javadoc tags to the interesting Solr/Lucene classes
> --
>
> Key: SOLR-11490
> URL: https://issues.apache.org/jira/browse/SOLR-11490
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Alexandre Rafalovitch
>Assignee: Alexandre Rafalovitch
>Priority: Minor
>
> As per the discussion on the dev list, it may be useful to add Javadoc since
> tags to significant (or even all) Java files.
> For user-facing files (such as analyzers, URPs, stream evaluators, etc) it
> would be useful when trying to identifying whether a particular class only
> comes later than user's particular version.
> For other classes, it may be useful for historical reasons.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
