[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338389#comment-14338389 ] ASF subversion and git services commented on SOLR-7130: --- Commit

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338370#comment-14338370 ] ASF subversion and git services commented on SOLR-7130: --- Commit

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338743#comment-14338743 ] Mark Miller commented on SOLR-7130: --- bq. + if(col !=null) { These if's should have

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338749#comment-14338749 ] Mark Miller commented on SOLR-7130: --- bq. if(col !=null) { This one in particular needs a

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339028#comment-14339028 ] ASF subversion and git services commented on SOLR-7130: --- Commit

Re: [jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread Noble Paul
IIRC if I do cmd-alt-L it reformats the whole file. So I usually select the modified text and then use cmd-alt-L which limits the changes to the lines I have modified On Fri, Feb 27, 2015 at 12:15 AM, Erick Erickson erickerick...@gmail.com wrote: FWIW, in IntelliJ the auto-format stuff has an

Re: [jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread Noble Paul
oh , I see a check box now that limits the scope to only lines I have changed Thanks Erick On Fri, Feb 27, 2015 at 1:27 AM, Noble Paul noble.p...@gmail.com wrote: IIRC if I do cmd-alt-L it reformats the whole file. So I usually select the modified text and then use cmd-alt-L which limits

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339043#comment-14339043 ] ASF subversion and git services commented on SOLR-7130: --- Commit

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339048#comment-14339048 ] ASF subversion and git services commented on SOLR-7130: --- Commit

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338979#comment-14338979 ] Noble Paul commented on SOLR-7130: -- sure mark Make stale state notification work

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338981#comment-14338981 ] Noble Paul commented on SOLR-7130: -- tests failing {noformat} Build:

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339000#comment-14339000 ] Noble Paul commented on SOLR-7130: -- If I reformat the entire file I end up making the

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339021#comment-14339021 ] ASF subversion and git services commented on SOLR-7130: --- Commit

Re: [jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-26 Thread Erick Erickson
FWIW, in IntelliJ the auto-format stuff has an only vcs changed text option that I find quite useful, cmd-alt-L on a file-by-file basis and I'm done. There's also an officially approved style file that _might_ installed when you execute the 'ant idea' task, but I'm not certain whether that's

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-23 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1479#comment-1479 ] Shalin Shekhar Mangar commented on SOLR-7130: - Thanks Noble. Some comments: #

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-23 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333469#comment-14333469 ] Shalin Shekhar Mangar commented on SOLR-7130: - bq. I don't think it is a good

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-23 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333450#comment-14333450 ] Noble Paul commented on SOLR-7130: -- bq.Maybe we should use the responseHeader to send this

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-23 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333521#comment-14333521 ] Noble Paul commented on SOLR-7130: -- bq.I am referring to the response header which is part

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-23 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333131#comment-14333131 ] Noble Paul commented on SOLR-7130: -- The response NamedList contains information about the

[jira] [Commented] (SOLR-7130) Make stale state notification work without failing the requests

2015-02-22 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333036#comment-14333036 ] Noble Paul commented on SOLR-7130: -- When the node is capable of serving the requests