Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r64469213
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,664 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r64467707
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,664 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/171#issuecomment-220534914
Looks great, thanks for amazing work here.
I left a few more minor comments, other than that LGTM and I'll merge soon
---
If your project is set up for
Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63614991
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,667 @@
+using System;
+using System.Collections.Generic;
+using
Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63613952
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530865
--- Diff: src/Lucene.Net.Tests/core/Index/TestIndexWriterConfig.cs ---
@@ -307,7 +315,11 @@ public virtual void TestInvalidValues()
}
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530524
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r63530104
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,667 @@
+using System;
+using System.Collections.Generic;
+using
Github user conniey commented on the pull request:
https://github.com/apache/lucenenet/pull/171#issuecomment-219559139
Hey, we're about to finish the migration to .NET Core and I was hoping
someone could take a look at this PR. :) We are blocked on getting this in so
we can run the
Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451804
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451412
--- Diff: src/Lucene.Net.Tests/core/TestMergeSchedulerExternal.cs ---
@@ -76,7 +76,9 @@ protected override MergeThread GetMergeThread(IndexWriter
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451390
--- Diff: src/Lucene.Net.Tests/core/Index/TestTransactions.cs ---
@@ -128,13 +134,21 @@ public IndexerThread(TestTransactions outerInstance,
object
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451346
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62451281
--- Diff: src/Lucene.Net.Core/Index/IConcurrentMergeScheduler.cs ---
@@ -0,0 +1,15 @@
+namespace Lucene.Net.Index
+{
+public
Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62450955
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62450979
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62450921
--- Diff: src/Lucene.Net.Core/Index/IConcurrentMergeScheduler.cs ---
@@ -0,0 +1,15 @@
+namespace Lucene.Net.Index
+{
+public interface
Github user conniey commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62450886
--- Diff: src/Lucene.Net.Tests/core/TestMergeSchedulerExternal.cs ---
@@ -76,7 +76,9 @@ protected override MergeThread GetMergeThread(IndexWriter
writer,
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423674
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423632
--- Diff: src/Lucene.Net.Core/Index/IConcurrentMergeScheduler.cs ---
@@ -0,0 +1,15 @@
+namespace Lucene.Net.Index
+{
+public
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423611
--- Diff: src/Lucene.Net.Tests/core/TestMergeSchedulerExternal.cs ---
@@ -76,7 +76,9 @@ protected override MergeThread GetMergeThread(IndexWriter
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423483
--- Diff: src/Lucene.Net.Core/Index/TaskMergeScheduler.cs ---
@@ -0,0 +1,665 @@
+using System;
+using System.Collections.Generic;
+using
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/171#discussion_r62423417
--- Diff: src/Lucene.Net.Core/Index/LiveIndexWriterConfig.cs ---
@@ -149,7 +149,11 @@ internal LiveIndexWriterConfig(Analyzer analyzer,
LuceneVersion
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/171#issuecomment-216681382
Thanks! give me a day or two to review this properly :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
24 matches
Mail list logo