Github user njayaram2 commented on the issue:
https://github.com/apache/incubator-madlib/pull/163
Jenkins ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user njayaram2 commented on the issue:
https://github.com/apache/incubator-madlib/pull/163
@iyerr3 Not sure why they are commented out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user edespino commented on the issue:
https://github.com/apache/incubator-madlib/pull/163
@iyerr3 - Thanks for the review. Very much appreciated. Additionally, I
should have reviewed the `install-check` options. Thanks for the info.
---
If your project is set up for it, you
Github user iyerr3 commented on the issue:
https://github.com/apache/incubator-madlib/pull/163
The change looks good.
Few comments:
- An alternative to changing the threshold is to reduce the max number of
iterations. Even with the lower threshold, we're not necessarily
Github user njayaram2 commented on the issue:
https://github.com/apache/incubator-madlib/pull/163
LGTM, since we anyway don't assert on `relative_error` on `log_likelihood`
in elastic_net.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user edespino commented on the issue:
https://github.com/apache/incubator-madlib/pull/163
For future reference, this is how I reviewed the elastic_net install-check
execution:
* Update the following
